Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(aio): open review queue traces in the trace drawer (#128927)

Carlos Marchal182c7e2d74c0
diff --git a/products/ai_observability/frontend/redesign/trace/traceDrawerLists.ts b/products/ai_observability/frontend/redesign/trace/traceDrawerLists.ts
index 920aa6bf3316..012b31274e58 100644
--- a/products/ai_observability/frontend/redesign/trace/traceDrawerLists.ts
+++ b/products/ai_observability/frontend/redesign/trace/traceDrawerLists.ts
@@ -6,6 +6,7 @@ export type TraceDrawerListId =
| 'generations'
| 'prompt-traces'
| 'reviews'
+ | 'review-queue'
| 'evaluation-runs'
| 'dataset-items'
| 'cluster-traces'
@@ -46,6 +47,14 @@ export const TRACE_DRAWER_LISTS: Record<TraceDrawerListId, TraceDrawerListConfig
backLabel: 'Back to reviews',
rowClick: true,
},
+ // Shares its path with reviews: the two are tabs of one scene, and only the open tab mounts its list. It also
+ // shares the back target, because the legacy trace page only keeps queue context for `back_to=reviews`.
+ 'review-queue': {
+ pathMatcher: /^\/ai-observability\/reviews$/,
+ backTo: 'reviews',
+ backLabel: 'Back to reviews',
+ rowClick: true,
+ },
'evaluation-runs': {
pathMatcher: /^\/ai-evals\/evaluations\/(?!(?:templates|offline|scorers)$)[^/]+$/,
backTo: 'evaluation',
diff --git a/products/ai_observability/frontend/redesign/trace/traceDrawerLogic.test.ts b/products/ai_observability/frontend/redesign/trace/traceDrawerLogic.test.ts
index 56a255408f96..4bcfab16a861 100644
--- a/products/ai_observability/frontend/redesign/trace/traceDrawerLogic.test.ts
+++ b/products/ai_observability/frontend/redesign/trace/traceDrawerLogic.test.ts
@@ -437,6 +437,7 @@ describe('traceDrawerLogic', () => {
['generations', urls.aiObservabilityGenerations()],
['prompt-traces', urls.aiObservabilityPrompt('p1')],
['reviews', urls.aiObservabilityReviews()],
+ ['review-queue', urls.aiObservabilityReviews()],
['evaluation-runs', urls.aiObservabilityEvaluation('e1')],
['evaluation-runs', `/project/1${urls.aiObservabilityEvaluation('e1')}`],
['dataset-items', urls.aiObservabilityDataset('d1')],
@@ -600,6 +601,15 @@ describe('traceDrawerLogic', () => {
})
})
+ it('links a queue trace to the full page with the back target and queue the legacy page understands', () => {
+ setUp({ url: `${urls.aiObservabilityReviews()}?queue_id=q1&trace=a`, listId: 'review-queue' })
+
+ expect(combineUrl(logic.values.fullPageHref ?? '').searchParams).toMatchObject({
+ back_to: 'reviews',
+ queue_id: 'q1',
+ })
+ })
+
it('has no full page link while closed', () => {
setUp()
diff --git a/products/ai_observability/frontend/reviewQueues/AIObservabilityReviewQueues.test.tsx b/products/ai_observability/frontend/reviewQueues/AIObservabilityReviewQueues.test.tsx
new file mode 100644
index 000000000000..3ebb19f3d99a
--- /dev/null
+++ b/products/ai_observability/frontend/reviewQueues/AIObservabilityReviewQueues.test.tsx
@@ -0,0 +1,85 @@
+import { MOCK_DEFAULT_TEAM } from '~/lib/api.mock'
+
+import { cleanup, fireEvent, render } from '@testing-library/react'
+import { router } from 'kea-router'
+
+import { FEATURE_FLAGS } from 'lib/constants'
+import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
+import { urls } from 'scenes/urls'
+
+import { initKeaTests } from '~/test/init'
+
+import { traceDrawerLogic } from '../redesign/trace/traceDrawerLogic'
+import { AIObservabilityReviewQueues } from './AIObservabilityReviewQueues'
+import { reviewQueuesApi } from './reviewQueuesApi'
+
+jest.mock('./reviewQueuesApi', () => ({
+ reviewQueuesApi: {
+ listQueues: jest.fn(),
+ getQueue: jest.fn(),
+ listQueueItems: jest.fn(),
+ },
+}))
+
+const mockReviewQueuesApi = reviewQueuesApi as jest.Mocked<typeof reviewQueuesApi>
+
+const CREATED_BY = {
+ id: 1,
+ uuid: 'user-1',
+ distinct_id: 'user-1',
+ first_name: 'Test',
+ last_name: 'User',
+ email: '[email protected]',
+ hedgehog_config: null,
+}
+const QUEUE = {
+ id: 'queue_1',
+ name: 'Support',
+ pending_item_count: 2,
+ created_at: '2026-03-13T12:00:00Z',
+ updated_at: '2026-03-13T12:00:00Z',
+ created_by: CREATED_BY,
+ team: MOCK_DEFAULT_TEAM.id,
+}
+const items = ['trace_1', 'trace_2'].map((traceId, index) => ({
+ id: `item_${index}`,
+ queue_id: 'queue_1',
+ queue_name: 'Support',
+ trace_id: traceId,
+ created_at: '2026-03-13T12:00:00Z',
+ updated_at: '2026-03-13T12:00:00Z',
+ created_by: CREATED_BY,
+ team: MOCK_DEFAULT_TEAM.id,
+}))
+
+describe('AIObservabilityReviewQueues', () => {
+ beforeEach(() => {
+ initKeaTests()
+ jest.clearAllMocks()
+ mockReviewQueuesApi.listQueues.mockResolvedValue({ count: 1, next: null, previous: null, results: [QUEUE] })
+ mockReviewQueuesApi.getQueue.mockResolvedValue(QUEUE)
+ mockReviewQueuesApi.listQueueItems.mockResolvedValue({ count: 2, next: null, previous: null, results: items })
+ localStorage.clear()
+ featureFlagLogic.mount()
+ const flag = FEATURE_FLAGS.AI_OBSERVABILITY_TRACE_REDESIGN
+ featureFlagLogic.actions.setFeatureFlags([flag], { [flag]: true })
+ router.actions.push(urls.aiObservabilityReviews(), { queue_id: 'queue_1' })
+ })
+
+ afterEach(() => {
+ cleanup()
+ })
+
+ it('opens a queued trace in the drawer from its link, with the queue rows to step through', async () => {
+ const { findByText } = render(<AIObservabilityReviewQueues />)
+
+ fireEvent.click(await findByText('trace_1'))
+
+ expect(router.values.location.pathname).toContain(urls.aiObservabilityReviews())
+ expect(router.values.searchParams).toEqual({ queue_id: 'queue_1', trace: 'trace_1' })
+ expect(traceDrawerLogic({ listId: 'review-queue' }).values.rows).toEqual([
+ { traceId: 'trace_1', timestamp: null, stepId: null },
+ { traceId: 'trace_2', timestamp: null, stepId: null },
+ ])
+ })
+})
diff --git a/products/ai_observability/frontend/reviewQueues/AIObservabilityReviewQueues.tsx b/products/ai_observability/frontend/reviewQueues/AIObservabilityReviewQueues.tsx
index 0e6bf5fb4cf3..bb91265e67f4 100644
--- a/products/ai_observability/frontend/reviewQueues/AIObservabilityReviewQueues.tsx
+++ b/products/ai_observability/frontend/reviewQueues/AIObservabilityReviewQueues.tsx
@@ -23,12 +23,23 @@ import { urls } from '~/scenes/urls'
import { AccessControlLevel, AccessControlResourceType } from '~/types'
import type { ReviewQueueApi, ReviewQueueItemApi } from '../generated/api.schemas'
+import { TraceDrawerHost } from '../redesign/trace/TraceDrawerHost'
+import { useTraceDrawerTable } from '../redesign/trace/TraceDrawerRowsHost'
+import { TraceListRow } from '../redesign/trace/traceListRows'
import {
aiObservabilityReviewQueuesLogic,
REVIEW_QUEUE_ITEMS_PER_PAGE,
REVIEW_QUEUES_PER_PAGE,
} from './aiObservabilityReviewQueuesLogic'
+const TRACE_DRAWER_LIST_ID = 'review-queue'
+const TRACE_LINK = '[data-attr="llma-review-queue-trace-link"]'
+
+// `created_at` is when the trace was queued, which says nothing about when the trace happened, so no timestamp.
+function toTraceDrawerRow(item: ReviewQueueItemApi): TraceListRow | null {
+ return item.trace_id ? { traceId: item.trace_id, timestamp: null, stepId: null } : null
+}
+
export function AIObservabilityReviewQueues(): JSX.Element {
const logic = useMountedLogic(aiObservabilityReviewQueuesLogic())
const {
@@ -65,6 +76,7 @@ export function AIObservabilityReviewQueues(): JSX.Element {
hasLoadedQueuesOnce,
} = useValues(logic)
const { searchParams } = useValues(router)
+ const drawerTableProps = useTraceDrawerTable(TRACE_DRAWER_LIST_ID, TRACE_LINK, toTraceDrawerRow)
const queueColumns: LemonTableColumns<ReviewQueueApi> = [
{
@@ -349,6 +361,7 @@ export function AIObservabilityReviewQueues(): JSX.Element {
rowKey="id"
loadingSkeletonRows={REVIEW_QUEUE_ITEMS_PER_PAGE}
nouns={['pending trace', 'pending traces']}
+ {...drawerTableProps}
emptyState={
<div className="py-6">
<InsightEmptyState
@@ -411,6 +424,7 @@ export function AIObservabilityReviewQueues(): JSX.Element {
</LemonModalFooter>
</LemonModal>
) : null}
+ <TraceDrawerHost listId={TRACE_DRAWER_LIST_ID} />
</div>
)
}
diff --git a/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.test.ts b/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.test.ts
index 00a6254dbaab..d3110cdd2a0e 100644
--- a/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.test.ts
+++ b/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.test.ts
@@ -191,4 +191,31 @@ describe('aiObservabilityReviewQueuesLogic', () => {
limit: REVIEW_QUEUE_ITEMS_PER_PAGE,
})
})
+
+ it.each(['trace_1', '0'])(
+ 'keeps the queue while only the drawer params change, and reloads it when the drawer on %s closes',
+ async (traceId) => {
+ const reviewsUrl = combineUrl(urls.aiObservabilityReviews(), { queue_id: 'queue_1' }).url
+ router.actions.push(addProjectIdIfMissing(reviewsUrl, MOCK_TEAM_ID))
+ const logic = aiObservabilityReviewQueuesLogic()
+ logic.mount()
+ await expectLogic(logic).toFinishAllListeners()
+ mockReviewQueuesApi.listQueues.mockClear()
+ mockReviewQueuesApi.listQueueItems.mockClear()
+
+ router.actions.push(addProjectIdIfMissing(combineUrl(reviewsUrl, { trace: traceId }).url, MOCK_TEAM_ID))
+ router.actions.push(
+ addProjectIdIfMissing(combineUrl(reviewsUrl, { trace: traceId, step: 'gen-1' }).url, MOCK_TEAM_ID)
+ )
+ await expectLogic(logic).toFinishAllListeners()
+ expect(mockReviewQueuesApi.listQueueItems).not.toHaveBeenCalled()
+
+ router.actions.push(addProjectIdIfMissing(reviewsUrl, MOCK_TEAM_ID))
+ await expectLogic(logic).toFinishAllListeners()
+ expect(mockReviewQueuesApi.listQueues).toHaveBeenCalled()
+ expect(mockReviewQueuesApi.listQueueItems).toHaveBeenCalledWith(
+ expect.objectContaining({ queue_id: 'queue_1' })
+ )
+ }
+ )
})
diff --git a/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.ts b/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.ts
index 7183f4a6beb0..a58b117297e7 100644
--- a/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.ts
+++ b/products/ai_observability/frontend/reviewQueues/aiObservabilityReviewQueuesLogic.ts
@@ -19,6 +19,7 @@ import type {
ReviewQueueApi,
ReviewQueueItemApi,
} from '../generated/api.schemas'
+import { changedOnlyTraceDrawerParams } from '../redesign/trace/traceDrawerRows'
import { reviewQueuesApi } from './reviewQueuesApi'
import { getApiErrorDetail } from './reviewQueueUtils'
@@ -837,11 +838,23 @@ export const aiObservabilityReviewQueuesLogic = kea<aiObservabilityReviewQueuesL
})),
urlToAction(({ actions, values }) => ({
- [urls.aiObservabilityReviews()]: (_, searchParams, __, { method }) => {
+ [urls.aiObservabilityReviews()]: (_, searchParams, __, { method, pathname }, previousLocation) => {
if (searchParams.human_reviews_tab === 'reviews' || searchParams.human_reviews_tab === 'scorers') {
return
}
+ // Stepping through the drawer keeps the rows it started with. Reviewed traces leave the queue on the
+ // server, so the list catches up once the drawer closes.
+ if (changedOnlyTraceDrawerParams(previousLocation, { pathname, searchParams })) {
+ if ('trace' in previousLocation.searchParams && !('trace' in searchParams)) {
+ actions.loadQueues(false)
+ if (values.selectedQueueId) {
+ actions.loadQueueItems(false)
+ }
+ }
+ return
+ }
+
const newQueueFilters = queueFiltersFromUrl(searchParams)
const newQueueItemFilters = queueItemFiltersFromUrl(searchParams)
const newSelectedQueueId = cleanSelectedQueueId(searchParams)