Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(web-analytics): show live recording button (#122442)

Paul D'Ambra1a1f553709df
diff --git a/frontend/src/scenes/activity/live/LiveEventsFeed.test.tsx b/frontend/src/scenes/activity/live/LiveEventsFeed.test.tsx
new file mode 100644
index 000000000000..28243c8ecdfa
--- /dev/null
+++ b/frontend/src/scenes/activity/live/LiveEventsFeed.test.tsx
@@ -0,0 +1,16 @@
+import { render } from '@testing-library/react'
+
+import { LiveEventsFeed, getWebAnalyticsLiveFeedColumns } from './LiveEventsFeed'
+
+describe('LiveEventsFeed', () => {
+ it('puts the recordings action after the time column and gives it room', () => {
+ const { container } = render(<LiveEventsFeed events={[]} columns={getWebAnalyticsLiveFeedColumns(true)} />)
+
+ expect(
+ Array.from(container.querySelectorAll('thead tr:not(.LemonTable__row--grouping) th'))
+ .map((header) => header.textContent)
+ .filter(Boolean)
+ ).toEqual(['Event', 'Person distinct ID', 'URL / Screen', 'Time'])
+ expect(container.querySelector('colgroup col:last-child')?.getAttribute('style')).toContain('56px')
+ })
+})
diff --git a/frontend/src/scenes/activity/live/LiveEventsFeed.tsx b/frontend/src/scenes/activity/live/LiveEventsFeed.tsx
index 78e6883934c4..6ccc96ad7061 100644
--- a/frontend/src/scenes/activity/live/LiveEventsFeed.tsx
+++ b/frontend/src/scenes/activity/live/LiveEventsFeed.tsx
@@ -22,6 +22,12 @@ export type LiveEventsFeedColumn = 'event' | 'person' | 'url' | 'recording' | 't
const ALL_COLUMNS: LiveEventsFeedColumn[] = ['event', 'person', 'url', 'recording', 'timestamp', 'more']
+export function getWebAnalyticsLiveFeedColumns(sessionRecordingOptIn: boolean): LiveEventsFeedColumn[] {
+ return sessionRecordingOptIn
+ ? ['event', 'person', 'url', 'timestamp', 'recording']
+ : ['event', 'person', 'url', 'timestamp']
+}
+
const COLUMN_DEFINITIONS: Record<LiveEventsFeedColumn, LemonTableColumn<LiveEvent, keyof LiveEvent | undefined>> = {
event: {
title: 'Event',
@@ -58,7 +64,7 @@ const COLUMN_DEFINITIONS: Record<LiveEventsFeedColumn, LemonTableColumn<LiveEven
recording: {
title: '',
key: 'recording' as any,
- width: 0,
+ width: 56,
render: function Render(_, event: LiveEvent) {
const sessionId = event.properties.$session_id
if (typeof sessionId !== 'string' || !sessionId) {
diff --git a/frontend/src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx b/frontend/src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx
index 0d337b87e3ef..931aae4ca343 100644
--- a/frontend/src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx
+++ b/frontend/src/scenes/web-analytics/LiveMetricsDashboard/LiveWebAnalyticsMetrics.tsx
@@ -27,7 +27,7 @@ import { IconWithCount } from 'lib/lemon-ui/icons/icons'
import { LemonSnack } from 'lib/lemon-ui/LemonSnack'
import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { COUNTRY_CODE_TO_LONG_NAME, countryCodeToFlag } from 'lib/utils/country'
-import { LiveEventsFeed, LiveEventsFeedColumn } from 'scenes/activity/live/LiveEventsFeed'
+import { getWebAnalyticsLiveFeedColumns, LiveEventsFeed } from 'scenes/activity/live/LiveEventsFeed'
import { teamLogic } from 'scenes/teamLogic'
import { PathCleaningToggle } from '../PathCleaningToggle'
@@ -49,8 +49,6 @@ import { liveWebAnalyticsMetricsLogic } from './liveWebAnalyticsMetricsLogic'
import { BrowserBreakdownItem, CountryBreakdownItem, DeviceBreakdownItem } from './LiveWebAnalyticsMetricsTypes'
import { LiveWorldMap } from './LiveWorldMap'
-const LIVE_FEED_COLUMNS_WITH_RECORDINGS: LiveEventsFeedColumn[] = ['event', 'person', 'url', 'recording', 'timestamp']
-const LIVE_FEED_COLUMNS_WITHOUT_RECORDINGS: LiveEventsFeedColumn[] = ['event', 'person', 'url', 'timestamp']
const STATS_POLL_INTERVAL_MS = 1000
const renderBrowserIcon = (d: BrowserBreakdownItem): JSX.Element => {
@@ -312,9 +310,7 @@ export const LiveWebAnalyticsMetrics = (): JSX.Element => {
const { featureFlags } = useValues(featureFlagLogic)
const { currentTeam } = useValues(teamLogic)
- const liveFeedColumns = currentTeam?.session_recording_opt_in
- ? LIVE_FEED_COLUMNS_WITH_RECORDINGS
- : LIVE_FEED_COLUMNS_WITHOUT_RECORDINGS
+ const liveFeedColumns = getWebAnalyticsLiveFeedColumns(!!currentTeam?.session_recording_opt_in)
const { isVisible } = usePageVisibility()
useEffect(() => {
if (isVisible) {