:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(auth): add a flag to always send the login email code (#126354)
Yasen1d94bac38b0f
diff --git a/posthog/helpers/tests/test_two_factor_session.py b/posthog/helpers/tests/test_two_factor_session.pyindex 551fbe3696d3..19f2a350ed1d 100644--- a/posthog/helpers/tests/test_two_factor_session.py+++ b/posthog/helpers/tests/test_two_factor_session.py@@ -5,6 +5,8 @@ from unittest.mock import MagicMock, patchfrom django.test import SimpleTestCase+from parameterized import parameterized+from posthog.helpers.email_utils import ESPSuppressionReason, ESPSuppressionResultfrom posthog.helpers.two_factor_session import CodeBasedVerificationCheckResult, CodeBasedVerifier@@ -30,7 +32,7 @@ class TestCodeBasedVerifierSuppressionIntegration(SimpleTestCase):mock_dev_mode.return_value = Falsemock_email_available.return_value = Truemock_http_available.return_value = True- mock_feature_enabled.return_value = True+ mock_feature_enabled.return_value = Falsemock_check_suppression.return_value = ESPSuppressionResult(is_suppressed=True, from_cache=False, reason=ESPSuppressionReason.SUPPRESSED)@@ -53,7 +55,7 @@ class TestCodeBasedVerifierSuppressionIntegration(SimpleTestCase):mock_dev_mode.return_value = Falsemock_email_available.return_value = Truemock_http_available.return_value = True- mock_feature_enabled.return_value = True+ mock_feature_enabled.return_value = Falsemock_check_suppression.return_value = ESPSuppressionResult(is_suppressed=False, from_cache=False, reason=None)verifier = CodeBasedVerifier()@@ -80,7 +82,7 @@ class TestCodeBasedVerifierSuppressionIntegration(SimpleTestCase):mock_dev_mode.return_value = Falsemock_email_available.return_value = Truemock_http_available.return_value = True- mock_feature_enabled.return_value = True+ mock_feature_enabled.return_value = Falsemock_check_suppression.return_value = ESPSuppressionResult(is_suppressed=True, from_cache=False, reason=ESPSuppressionReason.SUPPRESSED)@@ -111,7 +113,7 @@ class TestCodeBasedVerifierSuppressionIntegration(SimpleTestCase):mock_dev_mode.return_value = Falsemock_email_available.return_value = Truemock_http_available.return_value = True- mock_feature_enabled.return_value = True+ mock_feature_enabled.return_value = Falsemock_check_suppression.return_value = ESPSuppressionResult(is_suppressed=True, from_cache=True, reason=ESPSuppressionReason.SUPPRESSED)@@ -141,7 +143,7 @@ class TestCodeBasedVerifierSuppressionIntegration(SimpleTestCase):mock_dev_mode.return_value = Falsemock_email_available.return_value = Truemock_http_available.return_value = True- mock_feature_enabled.return_value = True+ mock_feature_enabled.return_value = Falsemock_check_suppression.return_value = ESPSuppressionResult(is_suppressed=True, from_cache=False, reason=ESPSuppressionReason.API_FAILURE_FALLBACK)@@ -168,7 +170,7 @@ class TestCodeBasedVerifierSuppressionIntegration(SimpleTestCase):mock_dev_mode.return_value = Falsemock_email_available.return_value = Truemock_http_available.return_value = True- mock_feature_enabled.return_value = True+ mock_feature_enabled.return_value = Falsemock_check_suppression.return_value = ESPSuppressionResult(is_suppressed=True, from_cache=False, reason=ESPSuppressionReason.SUPPRESSED)@@ -179,6 +181,48 @@ class TestCodeBasedVerifierSuppressionIntegration(SimpleTestCase):self.assertIsInstance(result, CodeBasedVerificationCheckResult)self.assertFalse(result.should_send)+ @parameterized.expand([(ESPSuppressionReason.SUPPRESSED,), (ESPSuppressionReason.API_FAILURE_FALLBACK,)])+ @patch("posthog.helpers.two_factor_session.is_dev_mode", return_value=False)+ @patch("posthog.helpers.two_factor_session.is_email_available", return_value=True)+ @patch("posthog.helpers.two_factor_session.is_http_email_service_available", return_value=True)+ @patch("posthog.helpers.two_factor_session.posthoganalytics.feature_flag_definitions", return_value=[{}])+ @patch("posthog.helpers.two_factor_session.posthoganalytics.feature_enabled", return_value=True)+ @patch("posthog.helpers.two_factor_session.check_esp_suppression")+ def test_flag_on_sends_code_whatever_the_suppression_result(self, reason, mock_check_suppression, *_mocks):+ mock_check_suppression.return_value = ESPSuppressionResult(is_suppressed=True, from_cache=False, reason=reason)++ result = CodeBasedVerifier().should_send_code_based_verification(self.mock_user)++ self.assertTrue(result.should_send)+ self.assertFalse(result.suppression_bypassed)++ @parameterized.expand(+ [+ ("missing_definitions", None, {"return_value": True}),+ ("error", [{}], {"side_effect": RuntimeError}),+ ]+ )+ @patch("posthog.helpers.two_factor_session.is_dev_mode", return_value=False)+ @patch("posthog.helpers.two_factor_session.is_email_available", return_value=True)+ @patch("posthog.helpers.two_factor_session.is_http_email_service_available", return_value=True)+ @patch("posthog.helpers.two_factor_session.posthoganalytics.capture")+ @patch("posthog.helpers.two_factor_session.posthoganalytics.feature_flag_definitions")+ @patch("posthog.helpers.two_factor_session.posthoganalytics.feature_enabled")+ @patch("posthog.helpers.two_factor_session.check_esp_suppression")+ def test_unreadable_flag_keeps_the_suppression_check(+ self, _name, definitions, flag_behavior, mock_check_suppression, mock_feature_enabled, mock_definitions, *_mocks+ ):+ mock_definitions.return_value = definitions+ mock_feature_enabled.configure_mock(**flag_behavior)+ mock_check_suppression.return_value = ESPSuppressionResult(+ is_suppressed=True, from_cache=False, reason=ESPSuppressionReason.SUPPRESSED+ )++ result = CodeBasedVerifier().should_send_code_based_verification(self.mock_user)++ self.assertFalse(result.should_send)+ self.assertTrue(result.suppression_bypassed)+@patch("posthog.helpers.two_factor_session.is_dev_mode")@patch("posthog.helpers.two_factor_session.is_email_available")@patch("posthog.helpers.two_factor_session.is_http_email_service_available")diff --git a/posthog/helpers/two_factor_session.py b/posthog/helpers/two_factor_session.pyindex 969505087fab..964f88dbf1ee 100644--- a/posthog/helpers/two_factor_session.py+++ b/posthog/helpers/two_factor_session.py@@ -313,6 +313,9 @@ class CodeBasedVerificationTokenGenerator(PasswordResetTokenGenerator):code_based_verification_token_generator = CodeBasedVerificationTokenGenerator()+EMAIL_CODE_IGNORES_ESP_SUPPRESSION_FLAG = "email-code-ignore-esp-suppression"++@dataclassclass CodeBasedVerificationCheckResult:should_send: bool@@ -322,6 +325,25 @@ class CodeBasedVerificationCheckResult:class CodeBasedVerifier:+ def _ignores_esp_suppression(self, user: User) -> bool:+ # The SDK fetches definitions over HTTP when none are loaded, even with only_evaluate_locally,+ # so login must not evaluate the flag until they load. Missing definitions or an error keep+ # the suppression check.+ try:+ if posthoganalytics.feature_flag_definitions() is None:+ return False+ return bool(+ posthoganalytics.feature_enabled(+ EMAIL_CODE_IGNORES_ESP_SUPPRESSION_FLAG,+ str(user.distinct_id),+ only_evaluate_locally=True,+ send_feature_flag_events=False,+ )+ )+ except Exception:+ mfa_logger.warning("email_code_esp_suppression_flag_unreadable", user_id=user.pk, exc_info=True)+ return False+def _capture_suppression_bypass_event(self, user: User, reason: str, cached: bool) -> None:try:posthoganalytics.capture(@@ -364,6 +386,10 @@ class CodeBasedVerifier:mfa_logger.info("Code-based verification bypassed via access rule", user_id=user.pk)return CodeBasedVerificationCheckResult(should_send=False)+ # Skips the lookup and does not only ignore its result, because a failed lookup also counts as suppressed.+ if self._ignores_esp_suppression(user):+ return CodeBasedVerificationCheckResult(should_send=True)+suppression_result = check_esp_suppression(user.email)if suppression_result.is_suppressed:reason = suppression_result.reason or ""