:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
chore(ci): skip unused rust selection in node.js checks (#128472)
posthog[bot]1f4b6deefdbf
diff --git a/.github/workflows/ci-nodejs.yml b/.github/workflows/ci-nodejs.ymlindex 303745314648..3dbee6f305af 100644--- a/.github/workflows/ci-nodejs.yml+++ b/.github/workflows/ci-nodejs.yml@@ -189,11 +189,12 @@ jobs:- '.github/actions/setup-uv/**'# Affected-crate detection is the only step below that reads the tree, and only a- # rust/ or proto/ change reaches it. The resolver supplies the merge base and+ # rust/ or proto/ change that does not already require Node.js checks reaches it.+ # The resolver supplies the merge base and# complete change set, so this checkout needs no history.# The cone is a superset of the tree ci-rust.yml's affected job gives the same binary.- name: Check out the Rust tree for affected-crate detection- if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true'+ if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true' && steps.filter.outputs.nodejs != 'true'uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2with:clean: false@@ -207,7 +208,7 @@ jobs:- name: Resolve the Rust changed filesid: rust-changed-files- if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true'+ if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true' && steps.filter.outputs.nodejs != 'true'continue-on-error: trueenv:GH_TOKEN: ${{ steps.app-token.outputs.token || github.token }}@@ -223,7 +224,7 @@ jobs:- name: Install rust for affected-crate detection# Not needed on schedule either: the decision step below already returns# nodejs=true there without consulting the affected-crate set.- if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true'+ if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true' && steps.filter.outputs.nodejs != 'true'uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9with:toolchain: 1.91.1@@ -232,7 +233,7 @@ jobs:id: rust-affected# Not needed on schedule either: the decision step below already returns# nodejs=true there without consulting the affected-crate set.- if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true'+ if: github.event_name != 'push' && github.event_name != 'schedule' && steps.filter.outputs.rust == 'true' && steps.filter.outputs.nodejs != 'true'uses: ./.github/actions/rust-compute-affectedwith:event-name: ${{ github.event_name }}diff --git a/tools/workflow-plan/tests/workflows.test.ts b/tools/workflow-plan/tests/workflows.test.tsindex c90794307833..1b71fae63c14 100644--- a/tools/workflow-plan/tests/workflows.test.ts+++ b/tools/workflow-plan/tests/workflows.test.ts@@ -1088,22 +1088,118 @@ describe('CI workflow run plans', () => {})it.each([- ['PR', pullRequest(), true, true],- ['fork', pullRequest({ fork: true }), true, true],- ['merge queue', mergeQueue(), true, true],- ['unrelated PR', pullRequest(), false, false],- ['push', push(), true, false],- ['schedule', schedule(), true, false],- ] as const)('Node Rust resolver on %s', (name, github, rustChanged, runs) => {+ ['Rust-only PR', pullRequest(), 'true', 'false', true],+ ['missing Node filter', pullRequest(), 'true', '', true],+ ['fork', pullRequest({ fork: true }), 'true', 'false', true],+ ['Rust-only merge queue', mergeQueue(), 'true', 'false', true],+ ['mixed Node/Rust PR', pullRequest(), 'true', 'true', false],+ ['mixed Node/Rust fork', pullRequest({ fork: true }), 'true', 'true', false],+ ['mixed Node/Rust merge queue', mergeQueue(), 'true', 'true', false],+ ['Node-only PR', pullRequest(), 'false', 'true', false],+ ['unrelated PR', pullRequest(), 'false', 'false', false],+ ['push', push(), 'true', 'false', false],+ ['schedule', schedule(), 'true', 'false', false],+ ] as const)('Node Rust preparation on %s', (name, github, rust, nodejs, runs) => {const plan = planWorkflow(workflow('ci-nodejs.yml'), {name,github,- steps: { changes: { filter: pathsFilter({ rust: rustChanged }) } },+ steps: { changes: { filter: { outputs: { rust, nodejs } } } },})expect(plan.errors).toEqual([])- expect(plan.jobs.changes?.steps.find((step) => step.id === 'rust-changed-files')?.runs).toBe(runs)+ for (const name of [+ 'Check out the Rust tree for affected-crate detection',+ 'Resolve the Rust changed files',+ 'Install rust for affected-crate detection',+ 'Compute affected Rust crates',+ ]) {+ expect(plan.jobs.changes?.steps.find((step) => step.name === name)?.runs, name).toBe(runs)+ }})+ it.each([+ ['Node-only', pullRequest(), 'true', 'false', '[]', 'false', 'nodejs=true'],+ ['native addon', pullRequest(), 'true', 'true', '["replay-anonymizer"]', 'false', 'nodejs=true'],+ ['mixed Node/ingestion', pullRequest(), 'true', 'true', '["ingestion-consumer"]', 'false', 'nodejs=true'],+ ['mixed Node/personhog', pullRequest(), 'true', 'true', '["personhog-identity"]', 'false', 'nodejs=true'],+ ['Rust ingestion', pullRequest(), 'false', 'true', '["ingestion-consumer"]', 'false', 'nodejs=true'],+ [+ 'Rust personhog',+ pullRequest(),+ 'false',+ 'true',+ '["personhog-identity"]',+ 'false',+ 'personhog_e2e=true\nnodejs=false',+ ],+ ['proto full rebuild', pullRequest(), 'false', 'true', '[]', 'true', 'nodejs=true'],+ ['unrelated Rust', pullRequest(), 'false', 'true', '["common-types"]', 'false', 'nodejs=false'],+ ['lockfile', pullRequest(), 'true', 'false', '[]', 'false', 'nodejs=true'],+ ['unrelated', pullRequest(), 'false', 'false', '[]', 'false', 'nodejs=false'],+ ['push', push(), '', '', '[]', 'false', 'nodejs=true'],+ ['schedule', schedule(), '', '', '[]', 'false', 'nodejs=true'],+ ] as const)(+ 'Node decision preserves coverage for %s',+ (_name, github, nodejs, rust, crates, rebuildAll, expected) => {+ const wf = workflow('ci-nodejs.yml')+ const functions = planFunctions({+ dependenciesSucceeded: true,+ dependenciesFailed: false,+ cancelled: false,+ })+ const step = wf.jobs.changes?.steps?.find((step) => step.id === 'nodejs-changes')+ const context = {+ github,+ steps: {+ filter: { outputs: { nodejs, rust } },+ 'rust-affected': { outputs: { crates: String(crates), 'rebuild-all': String(rebuildAll) } },+ },+ }+ const runDecision = (): string => {+ const env = Object.fromEntries(+ Object.entries(step!.env!).map(([key, value]) => [+ key,+ String(evaluateValue(value, context, functions)),+ ])+ )+ const script = evaluateValue(step!.run, context, functions)+ const result = spawnSync(+ 'bash',+ [+ '-eu',+ '-o',+ 'pipefail',+ '-c',+ `+ export GITHUB_OUTPUT=$(mktemp)+ trap 'rm -f "$GITHUB_OUTPUT"' EXIT+ (+${script}+)+ cat "$GITHUB_OUTPUT"+ `,+ ],+ {+ encoding: 'utf8',+ env: { ...process.env, ...env },+ }+ )+ expect(result.error).toBeUndefined()+ expect(result.status, result.stderr).toBe(0)+ return result.stdout.trim()+ }+ expect(runDecision()).toBe(expected)+ const plan = planWorkflow(wf, {+ name: _name,+ github,+ steps: { changes: { filter: { outputs: { nodejs, rust } } } },+ })+ if (!plan.jobs.changes?.steps.find((step) => step.id === 'rust-affected')?.runs) {+ context.steps['rust-affected'].outputs = { crates: '', 'rebuild-all': '' }+ expect(runDecision()).toBe(expected)+ }+ }+ )+it.each([['success', 'true', 'false'],['success', 'false', 'true'],