Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(exports): stop capturing creator resource access denials in image exports (#119497)

posthog[bot]20648ad5dc3d
diff --git a/posthog/query_creator_access.py b/posthog/query_creator_access.py
index aae8ac9face9..1315d2e52d81 100644
--- a/posthog/query_creator_access.py
+++ b/posthog/query_creator_access.py
@@ -24,12 +24,15 @@ def report_creator_access_revoked(
source: str,
error: BaseException,
properties: Optional[dict[str, Any]] = None,
+ reason: Optional[str] = None,
) -> None:
"""Record an analytics event for a background query that failed because its creator lost access
(see `creator_access_revoked`). Attributed to the team — the creator may be gone or anonymous.
- `source` names the caller ("export", "alert", "cache_warming").
+ `source` names the caller ("export", "alert", "cache_warming"). Pass `reason` when the creator is
+ still a member but has no access to a resource the query needs.
"""
- reason = "deleted" if user is None else "deactivated" if not user.is_active else "left_org"
+ if reason is None:
+ reason = "deleted" if user is None else "deactivated" if not user.is_active else "left_org"
# Attributed to the team — the creator may be deleted or anonymous.
with ph_scoped_capture() as capture:
capture(
diff --git a/products/exports/backend/tasks/failure_handler.py b/products/exports/backend/tasks/failure_handler.py
index d1c558fea1dd..6906aa100b34 100644
--- a/products/exports/backend/tasks/failure_handler.py
+++ b/products/exports/backend/tasks/failure_handler.py
@@ -41,6 +41,8 @@ from posthog.exceptions import (
)
from posthog.storage.object_storage import ObjectStorageError
+from products.access_control.backend.facade.user_access_control import UserAccessControlError
+
# =============================================================================
# Export Failure Classification
# =============================================================================
@@ -231,6 +233,7 @@ USER_QUERY_ERRORS = (
CHQueryErrorUnknownTable,
ExcelColumnLimitExceeded,
InvalidExportContext,
+ UserAccessControlError, # The export creator has no access to a resource the query needs
)
TIMEOUT_ERRORS = (
diff --git a/products/exports/backend/tasks/image_exporter.py b/products/exports/backend/tasks/image_exporter.py
index 1fdba81f37a5..9b131aefe5f2 100644
--- a/products/exports/backend/tasks/image_exporter.py
+++ b/products/exports/backend/tasks/image_exporter.py
@@ -33,6 +33,7 @@ from posthog.schema_migrations.upgrade_manager import upgrade_insight
from posthog.tasks.exporter import EXPORT_TIMER
from posthog.utils import absolute_uri
+from products.access_control.backend.facade.user_access_control import UserAccessControlError
from products.dashboards.backend.models.dashboard_tile import DashboardTile
from products.exports.backend.facade.api import export_limit_context
from products.exports.backend.models.exported_asset import ExportedAsset, get_render_access_token, save_content
@@ -709,6 +710,22 @@ def export_image(
"dashboard_id": exported_asset.dashboard_id,
},
)
+ # The creator is still a member but has no access to a resource the query needs (e.g. web analytics).
+ elif isinstance(e, UserAccessControlError):
+ report_creator_access_revoked(
+ user=exported_asset.created_by,
+ team=exported_asset.team,
+ source="export",
+ error=e,
+ reason="missing_resource_access",
+ properties={
+ "exported_asset_id": exported_asset.id,
+ "insight_id": exported_asset.insight_id,
+ "dashboard_id": exported_asset.dashboard_id,
+ "resource": e.resource,
+ "required_level": e.required_level,
+ },
+ )
# A broken saved query is the user's to fix, and the asset already records it.
elif is_reportable_export_failure(e):
capture_exception(e, additional_properties={"task": "image_export", "team_id": team_id})
diff --git a/products/exports/backend/tasks/test/test_failure_handler.py b/products/exports/backend/tasks/test/test_failure_handler.py
index a66069109927..69a78ee052ce 100644
--- a/products/exports/backend/tasks/test/test_failure_handler.py
+++ b/products/exports/backend/tasks/test/test_failure_handler.py
@@ -45,6 +45,7 @@ class TestIsUserQueryErrorType(TestCase):
("ExcelColumnLimitExceeded", True),
("InvalidExportContext", True),
("ValidationError", True), # DRF validation of the user's query (e.g. one-step funnel export)
+ ("UserAccessControlError", True),
# Non-user errors - should return False
("TimeoutError", False),
("ValueError", False),
@@ -77,6 +78,7 @@ class TestClassifyFailureType(TestCase):
("ExcelColumnLimitExceeded", FAILURE_TYPE_USER),
("InvalidExportContext", FAILURE_TYPE_USER),
("ValidationError", FAILURE_TYPE_USER),
+ ("UserAccessControlError", FAILURE_TYPE_USER),
# System errors (from EXCEPTIONS_TO_RETRY)
("CHQueryErrorS3Error", FAILURE_TYPE_SYSTEM),
("OperationalError", FAILURE_TYPE_SYSTEM),
diff --git a/products/exports/backend/tasks/test/test_image_exporter.py b/products/exports/backend/tasks/test/test_image_exporter.py
index a41d231c6210..416c940a7e5e 100644
--- a/products/exports/backend/tasks/test/test_image_exporter.py
+++ b/products/exports/backend/tasks/test/test_image_exporter.py
@@ -30,6 +30,7 @@ from posthog.settings import (
from posthog.storage import object_storage
from posthog.storage.object_storage import ObjectStorageError
+from products.access_control.backend.facade.user_access_control import UserAccessControlError
from products.dashboards.backend.models.dashboard import Dashboard
from products.dashboards.backend.models.dashboard_tile import DashboardTile
from products.exports.backend.models.exported_asset import ExportedAsset
@@ -152,6 +153,29 @@ class TestImageExporter(APIBaseTest):
# The browser must never be reached — the point is failing before the render.
mock_screenshot_asset.assert_not_called()
+ @patch("products.exports.backend.tasks.image_exporter.report_creator_access_revoked")
+ @patch("products.exports.backend.tasks.image_exporter.capture_exception")
+ @patch("products.exports.backend.tasks.image_exporter.calculate_for_query_based_insight")
+ def test_creator_without_resource_access_is_reported_as_event_not_exception(
+ self,
+ mock_calculate: Any,
+ mock_capture: Any,
+ mock_report: Any,
+ mock_remove: Any,
+ mock_open_file: Any,
+ mock_screenshot_asset: Any,
+ ) -> None:
+ mock_calculate.side_effect = UserAccessControlError("web_analytics", "viewer")
+ self.exported_asset.created_by = self.user
+ self.exported_asset.save()
+
+ with self.assertRaises(UserAccessControlError):
+ image_exporter.export_image(self.exported_asset)
+
+ mock_capture.assert_not_called()
+ assert mock_report.call_args.kwargs["reason"] == "missing_resource_access"
+ assert mock_report.call_args.kwargs["properties"]["resource"] == "web_analytics"
+
@parameterized.expand(
[
("user_query_error", QueryError("Unknown table"), False),