:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(aio): keep the model picker menu open during model reloads (#128099)
Bernat Torres219cc1549e56
diff --git a/products/ai_observability/frontend/ModelPicker.test.tsx b/products/ai_observability/frontend/ModelPicker.test.tsxindex b793ce164671..46d62feb46ac 100644--- a/products/ai_observability/frontend/ModelPicker.test.tsx+++ b/products/ai_observability/frontend/ModelPicker.test.tsx@@ -16,6 +16,18 @@ describe('ModelPicker', () => {expect(await screen.findByText('No models available.')).toBeInTheDocument()})+ it('keeps the open menu when models start reloading', async () => {+ const props = { model: '', selectedProviderKeyId: null, onSelect: jest.fn(), groups: [] }+ const { rerender } = render(<ModelPicker {...props} />)++ await userEvent.click(screen.getByText('Select model'))+ expect(await screen.findByText('No models available.')).toBeInTheDocument()++ rerender(<ModelPicker {...props} loading />)++ expect(await screen.findByText('Loading models...')).toBeInTheDocument()+ })+it('selects a typed Azure deployment name that the provider did not list', async () => {const onSelect = jest.fn()render(diff --git a/products/ai_observability/frontend/ModelPicker.tsx b/products/ai_observability/frontend/ModelPicker.tsxindex 66f152f2748d..8db09bf48d8b 100644--- a/products/ai_observability/frontend/ModelPicker.tsx+++ b/products/ai_observability/frontend/ModelPicker.tsx@@ -1,7 +1,7 @@import { useMemo, useState } from 'react'import { IconChevronDown, IconChevronRight, IconGear, IconPlus } from '@posthog/icons'-import { LemonButton, LemonInput, LemonSkeleton } from '@posthog/lemon-ui'+import { LemonButton, LemonInput, Spinner } from '@posthog/lemon-ui'import { LemonMenu, LemonMenuItem, LemonMenuItems } from 'lib/lemon-ui/LemonMenu'@@ -39,6 +39,7 @@ export interface ModelPickerProps {onSelect: (modelId: string, providerKeyId: string) => voidgroups: ProviderModelGroup[]loading?: boolean+ onOpen?: () => voidfooterActions?: LemonMenuItem[]placeholder?: stringselectedModelName?: string@@ -114,6 +115,7 @@ export function ModelPicker({onSelect,groups,loading = false,+ onOpen,footerActions,placeholder = 'Select model',selectedModelName,@@ -133,15 +135,13 @@ export function ModelPicker({}const handleVisibilityChange = (visible: boolean): void => {- if (!visible) {+ if (visible) {+ onOpen?.()+ } else {setSearch('')}}- if (loading) {- return <LemonSkeleton className="h-10" />- }-const isSearching = search.length > 0const menuItems: LemonMenuItems = [@@ -169,7 +169,11 @@ export function ModelPicker({{label: () => (<div className="px-2 py-1.5 text-xs text-secondary">- {isSearching ? 'No models match your search.' : 'No models available.'}+ {loading+ ? 'Loading models...'+ : isSearching+ ? 'No models match your search.'+ : 'No models available.'}</div>),},@@ -262,6 +266,7 @@ export function ModelPicker({className="justify-between"data-attr={dataAttr}icon={selectedProvider ? <LLMProviderIcon provider={selectedProvider} /> : undefined}+ sideIcon={loading ? <Spinner textColored /> : undefined}>{selectedModelName ?? (model || placeholder)}</LemonButton>diff --git a/products/ai_observability/frontend/playground/AIObservabilityPlaygroundScene.tsx b/products/ai_observability/frontend/playground/AIObservabilityPlaygroundScene.tsxindex 3afe1d2241ff..d88214122d25 100644--- a/products/ai_observability/frontend/playground/AIObservabilityPlaygroundScene.tsx+++ b/products/ai_observability/frontend/playground/AIObservabilityPlaygroundScene.tsx@@ -573,6 +573,7 @@ function PlaygroundModelPicker({ promptId }: { promptId: string }): JSX.Element}}groups={groups}loading={loading}+ onOpen={() => posthog.capture('llma playground model picker opened', { is_byok: hasByokKeys, loading })}footerActions={getModelPickerFooterActions(hasByokKeys, () => setNewKeyModalOpen(true))}selectedModelName={selectedModel?.name}data-attr={`llma-playground-model-selector-${promptId}`}