Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(skills): log skill creates and edits to the activity log (#121402)

posthog[bot]220026fda4bc
diff --git a/frontend/src/lib/components/ActivityLog/describers.tsx b/frontend/src/lib/components/ActivityLog/describers.tsx
index a774994a5b38..2be8a99cfcc9 100644
--- a/frontend/src/lib/components/ActivityLog/describers.tsx
+++ b/frontend/src/lib/components/ActivityLog/describers.tsx
@@ -47,6 +47,7 @@ import { groupActivityDescriber } from 'products/groups/frontend/activityDescrip
import { personActivityDescriber } from 'products/persons/frontend/activityDescriptions'
import { insightActivityDescriber } from 'products/product_analytics/frontend/insights/activityDescriptions'
import { signalScoutConfigActivityDescriber } from 'products/signals/frontend/activityDescriber'
+import { skillActivityDescriber } from 'products/skills/frontend/activityDescriber'
import { stamphogRepoConfigActivityDescriber } from 'products/stamphog/frontend/activityDescriber'
import { workflowActivityDescriber } from 'products/workflows/frontend/Workflows/misc/workflowActivityDescriber'
@@ -142,6 +143,8 @@ export const describerFor = (logItem?: ActivityLogItem): Describer | undefined =
return promptActivityDescriber
case ActivityScope.LLM_PROMPT_LABEL:
return promptLabelActivityDescriber
+ case ActivityScope.LLM_SKILL:
+ return skillActivityDescriber
case ActivityScope.STAMPHOG_REPO_CONFIG:
return stamphogRepoConfigActivityDescriber
default:
diff --git a/frontend/src/types.ts b/frontend/src/types.ts
index 4ab98f8ff54f..81bdf4fb558f 100644
--- a/frontend/src/types.ts
+++ b/frontend/src/types.ts
@@ -6187,6 +6187,7 @@ export enum ActivityScope {
USER = 'User',
LLM_PROMPT = 'LLMPrompt',
LLM_PROMPT_LABEL = 'LLMPromptLabel',
+ LLM_SKILL = 'LLMSkill',
LLM_TRACE = 'LLMTrace',
LOG = 'Log',
LOGS_ALERT_CONFIGURATION = 'LogsAlertConfiguration',
diff --git a/posthog/models/activity_logging/activity_log.py b/posthog/models/activity_logging/activity_log.py
index 98bd5ee8bf4d..1d2565ba2919 100644
--- a/posthog/models/activity_logging/activity_log.py
+++ b/posthog/models/activity_logging/activity_log.py
@@ -112,6 +112,7 @@ ActivityScope = Literal[
"EvaluationDirectory",
"LLMPrompt",
"LLMPromptLabel",
+ "LLMSkill",
"LLMTrace",
"AIGatewayCredit",
"WebAnalyticsFilterPreset",
diff --git a/products/platform_features/frontend/generated/api.schemas.ts b/products/platform_features/frontend/generated/api.schemas.ts
index c6b9d2ac6ab4..f58f809ba9e0 100644
--- a/products/platform_features/frontend/generated/api.schemas.ts
+++ b/products/platform_features/frontend/generated/api.schemas.ts
@@ -1457,6 +1457,7 @@ export type ActivityLogListParams = {
* * `EvaluationDirectory` - EvaluationDirectory
* * `LLMPrompt` - LLMPrompt
* * `LLMPromptLabel` - LLMPromptLabel
+ * * `LLMSkill` - LLMSkill
* * `LLMTrace` - LLMTrace
* * `AIGatewayCredit` - AIGatewayCredit
* * `WebAnalyticsFilterPreset` - WebAnalyticsFilterPreset
@@ -1569,6 +1570,7 @@ export const ActivityLogListScope = {
EvaluationDirectory: 'EvaluationDirectory',
LLMPrompt: 'LLMPrompt',
LLMPromptLabel: 'LLMPromptLabel',
+ LLMSkill: 'LLMSkill',
LLMTrace: 'LLMTrace',
AIGatewayCredit: 'AIGatewayCredit',
WebAnalyticsFilterPreset: 'WebAnalyticsFilterPreset',
@@ -1668,6 +1670,7 @@ export const ActivityLogListScope = {
* * `EvaluationDirectory` - EvaluationDirectory
* * `LLMPrompt` - LLMPrompt
* * `LLMPromptLabel` - LLMPromptLabel
+ * * `LLMSkill` - LLMSkill
* * `LLMTrace` - LLMTrace
* * `AIGatewayCredit` - AIGatewayCredit
* * `WebAnalyticsFilterPreset` - WebAnalyticsFilterPreset
@@ -1768,6 +1771,7 @@ export const ActivityLogListScopesItem = {
EvaluationDirectory: 'EvaluationDirectory',
LLMPrompt: 'LLMPrompt',
LLMPromptLabel: 'LLMPromptLabel',
+ LLMSkill: 'LLMSkill',
LLMTrace: 'LLMTrace',
AIGatewayCredit: 'AIGatewayCredit',
WebAnalyticsFilterPreset: 'WebAnalyticsFilterPreset',
diff --git a/products/signals/backend/test/test_reset_signals_self_driving.py b/products/signals/backend/test/test_reset_signals_self_driving.py
index 3984b3b63e5e..9436c2b94613 100644
--- a/products/signals/backend/test/test_reset_signals_self_driving.py
+++ b/products/signals/backend/test/test_reset_signals_self_driving.py
@@ -165,7 +165,7 @@ class TestResetSignalsSelfDrivingCustomScouts(BaseTest):
# let a stale owner publish it.
name = f"{SIGNALS_SCOUT_SKILL_PREFIX}custom-checkout"
create_skill(self.team, user=self.user, name=name, description="d", body="# b")
- set_skill_owners(self.team, name, [self.user])
+ set_skill_owners(self.team, name, [self.user], acting_user=None)
call_command("reset_signals_self_driving", team_id=self.team.id, yes=True, keep_findings=True, keep_log=True)
diff --git a/products/skills/backend/activity_logging.py b/products/skills/backend/activity_logging.py
new file mode 100644
index 000000000000..f47eb28ce1c1
--- /dev/null
+++ b/products/skills/backend/activity_logging.py
@@ -0,0 +1,105 @@
+from typing import TYPE_CHECKING, Any
+
+from posthog.models.activity_logging.activity_log import Change, Detail, log_activity
+from posthog.models.activity_logging.utils import activity_storage
+
+from products.skills.backend.models.skills import LLMSkill, LLMSkillFile
+
+if TYPE_CHECKING:
+ from posthog.models import Team, User
+
+SKILL_ACTIVITY_SCOPE = "LLMSkill"
+
+# Fields a publish can change on the logical skill. `body` is recorded as changed without its
+# content, because a body can be up to 1 MB and the history only needs to say that it moved.
+_PUBLISHED_FIELDS = ("description", "license", "compatibility", "allowed_tools", "metadata", "category")
+
+
+def skill_activity_item_id(team: "Team", skill_name: str) -> str | None:
+ """The id of the skill's first live version row.
+
+ Every version is its own row and a rename rewrites the name on all of them, so neither a
+ version id nor the name stays the same for the life of a skill. The first row does.
+ """
+ first_id = (
+ LLMSkill.objects.filter(team=team, name=skill_name, deleted=False)
+ .order_by("version", "created_at", "id")
+ .values_list("id", flat=True)
+ .first()
+ )
+ return str(first_id) if first_id is not None else None
+
+
+def log_skill_activity(
+ *,
+ team: "Team",
+ user: "User | None",
+ skill_name: str,
+ activity: str,
+ item_id: str | None = None,
+ changes: list[Change] | None = None,
+) -> None:
+ """Write one activity row for one change to a logical skill.
+
+ `LLMSkill` has no `ModelActivityMixin`: a publish inserts a new row and archive uses
+ `QuerySet.update()`, so the mixin would log each version as created and miss the archive.
+ The skill service functions call this instead, once per change. Without an `item_id`, the
+ skill's first live version supplies it.
+ """
+ item_id = item_id or skill_activity_item_id(team, skill_name)
+ if item_id is None:
+ return
+ log_activity(
+ organization_id=team.organization_id,
+ team_id=team.id,
+ user=user,
+ was_impersonated=activity_storage.get_was_impersonated(),
+ item_id=item_id,
+ scope=SKILL_ACTIVITY_SCOPE,
+ activity=activity,
+ detail=Detail(name=skill_name, changes=changes),
+ )
+
+
+def skill_change(field: str, *, before: Any = None, after: Any = None) -> Change:
+ return Change(type=SKILL_ACTIVITY_SCOPE, action="changed", field=field, before=before, after=after)
+
+
+def version_changes(previous: LLMSkill, published: LLMSkill) -> list[Change]:
+ """The changes between two versions of one skill, with the version note first."""
+ changes = [skill_change("version", before=previous.version, after=published.version)]
+ if published.version_description:
+ changes.append(
+ Change(
+ type=SKILL_ACTIVITY_SCOPE,
+ action="created",
+ field="version_description",
+ after=published.version_description,
+ )
+ )
+ if previous.body != published.body:
+ changes.append(skill_change("body"))
+ for field in _PUBLISHED_FIELDS:
+ before, after = getattr(previous, field), getattr(published, field)
+ if before != after:
+ changes.append(skill_change(field, before=before, after=after))
+ files_change = _files_change(previous, published)
+ if files_change is not None:
+ changes.append(files_change)
+ return changes
+
+
+def _files_change(previous: LLMSkill, published: LLMSkill) -> Change | None:
+ # Compare digests, not content: a skill can hold 200 files of up to 1 MB each.
+ digests_by_skill: dict[Any, dict[str, str | None]] = {previous.pk: {}, published.pk: {}}
+ for skill_id, path, digest in LLMSkillFile.objects.filter(skill_id__in=digests_by_skill).values_list(
+ "skill_id", "path", "content_sha256"
+ ):
+ digests_by_skill[skill_id][path] = digest
+ before, after = digests_by_skill[previous.pk], digests_by_skill[published.pk]
+ added = sorted(after.keys() - before.keys())
+ removed = sorted(before.keys() - after.keys())
+ edited = sorted(path for path in before.keys() & after.keys() if before[path] != after[path])
+ if not (added or removed or edited):
+ return None
+ return skill_change("files", after={"added": added, "removed": removed, "edited": edited})
diff --git a/products/skills/backend/api/skill_serializers.py b/products/skills/backend/api/skill_serializers.py
index db3f447bbbd7..7075b9622dd0 100644
--- a/products/skills/backend/api/skill_serializers.py
+++ b/products/skills/backend/api/skill_serializers.py
@@ -12,6 +12,7 @@ from posthog.api.shared import UserBasicSerializer
from products.ai_observability.backend.markdown_outline import get_markdown_outline
+from ..activity_logging import log_skill_activity
from ..marketplace.packaging import DEFAULT_BUNDLE_SKILLS, MAX_BUNDLE_SKILLS, SPEC_DESCRIPTION_MAX_LENGTH
from ..models.skills import MAX_SKILL_CATEGORY_LENGTH, LLMSkill, LLMSkillFile, category_for_skill_name
from .community_publish_services import (
@@ -832,6 +833,9 @@ class LLMSkillCreateSerializer(LLMSkillSerializer):
for f in files
]
)
+ log_skill_activity(
+ team=team, user=request.user, item_id=str(skill.pk), skill_name=skill.name, activity="created"
+ )
# `is not None`, not truthiness: an explicit empty list means "create with no owners"
# and must not fall through to the creator-owns default (matching the update path).
if owner_uuids is not None:
@@ -842,7 +846,7 @@ class LLMSkillCreateSerializer(LLMSkillSerializer):
{"owners": f"User '{err.user_uuid}' is not a member of this project."},
code="invalid_owner",
)
- set_skill_owners(team, skill.name, owner_users)
+ set_skill_owners(team, skill.name, owner_users, acting_user=request.user)
else:
# Creator owns by default — durable, not reconstructed from version history.
seed_skill_owner(team, skill.name, request.user)
diff --git a/products/skills/backend/api/skill_services.py b/products/skills/backend/api/skill_services.py
index 47b39a43c36d..53d44a6cf45e 100644
--- a/products/skills/backend/api/skill_services.py
+++ b/products/skills/backend/api/skill_services.py
@@ -10,6 +10,7 @@ from django.utils import timezone
from posthog.dataclasses import frozen
from posthog.models import Team, User
+from ..activity_logging import log_skill_activity, skill_activity_item_id, skill_change, version_changes
from ..bundled_skills import bundled_skill_names
from ..marketplace.packaging import CODEX_METADATA_PATH, SPEC_DESCRIPTION_MAX_LENGTH, compute_plugin_version
from ..models.skills import (
@@ -568,6 +569,14 @@ def publish_skill_version(
else:
_copy_files(current_latest, published_skill, edited_content=resolved_file_edits)
+ log_skill_activity(
+ team=team,
+ user=user,
+ skill_name=published_skill.name,
+ activity="updated",
+ changes=version_changes(current_latest, published_skill),
+ )
+
refreshed = get_active_skill_queryset(team).filter(pk=published_skill.pk).first()
return refreshed if refreshed is not None else published_skill
@@ -694,6 +703,8 @@ def create_skill(
raise LLMSkillFilePathConflictError(path="") from err
raise
+ log_skill_activity(team=team, user=user, item_id=str(new_skill.pk), skill_name=name, activity="created")
+
refreshed = get_active_skill_queryset(team).filter(pk=new_skill.pk).first()
return refreshed if refreshed is not None else new_skill
@@ -756,6 +767,15 @@ def duplicate_skill(
_copy_files(source_latest, new_skill)
+ log_skill_activity(
+ team=team,
+ user=user,
+ item_id=str(new_skill.pk),
+ skill_name=new_name,
+ activity="created",
+ changes=[skill_change("duplicated_from", after=source_name)],
+ )
+
refreshed = get_active_skill_queryset(team).filter(pk=new_skill.pk).first()
return refreshed if refreshed is not None else new_skill
@@ -816,6 +836,13 @@ def _create_next_version_with_files(
for f in next_files
]
)
+ log_skill_activity(
+ team=team,
+ user=user,
+ skill_name=next_skill.name,
+ activity="updated",
+ changes=version_changes(current_latest, next_skill),
+ )
return next_skill
@@ -917,6 +944,8 @@ def archive_skill(team: Team, skill_name: str, *, acting_user: User | None, auth
)
if not skill_versions:
raise LLMSkillNotFoundError()
+ # Read before the update below, which takes every row out of the live set.
+ item_id = skill_activity_item_id(team, skill_name)
# Bump updated_at (the .update() bypasses auto_now) so the marketplace plugin version,
# derived from max(updated_at) across all team rows, advances on archive too — otherwise
# archiving the most-recently-updated skill would regress the version.
@@ -928,6 +957,7 @@ def archive_skill(team: Team, skill_name: str, *, acting_user: User | None, auth
# Owners are keyed on the logical `(team, skill_name)`, so they'd otherwise outlive the
# archived skill and attach to a later skill that reuses the name. Retire them with it.
clear_skill_owners(team, skill_name)
+ log_skill_activity(team=team, user=acting_user, item_id=item_id, skill_name=skill_name, activity="deleted")
return skill_versions
@@ -986,6 +1016,14 @@ def rename_skill(
version.stamp_digest()
LLMSkill.objects.bulk_update(locked_versions, ["name", "updated_at", *LLMSkill.DIGEST_FIELDS])
rename_skill_owners(team, skill_name, new_name)
+ log_skill_activity(
+ team=team,
+ user=acting_user,
+ item_id=str(locked_versions[0].pk),
+ skill_name=new_name,
+ activity="updated",
+ changes=[skill_change("name", before=skill_name, after=new_name)],
+ )
return _renamed_skill_or_missing(team, new_name)
@@ -1112,7 +1150,7 @@ def seed_skill_owner(team: Team, skill_name: str, user: User) -> None:
_owner_qs(team).get_or_create(team=team, skill_name=skill_name, user=user)
-def set_skill_owners(team: Team, skill_name: str, users: list[User]) -> list[User]:
+def set_skill_owners(team: Team, skill_name: str, users: list[User], *, acting_user: User | None) -> list[User]:
"""Replace the owner set for a logical skill with `users` (deduped, order preserved).
An empty list clears all owners. This is the explicit owner-management op — it is only ever
@@ -1127,11 +1165,22 @@ def set_skill_owners(team: Team, skill_name: str, users: list[User]) -> list[Use
ordered.append(user)
with transaction.atomic():
- _owner_qs(team).filter(skill_name=skill_name).delete()
+ owners_qs = _owner_qs(team).filter(skill_name=skill_name)
+ previous_ids = sorted(owners_qs.values_list("user_id", flat=True))
+ owners_qs.delete()
for user in ordered:
# One-by-one (not bulk_create) so `save()` runs per row; `_owner_qs` scoping keeps the
# write context-independent (works outside a request too).
_owner_qs(team).create(team=team, skill_name=skill_name, user=user)
+ next_ids = sorted(seen)
+ if next_ids != previous_ids:
+ log_skill_activity(
+ team=team,
+ user=acting_user,
+ skill_name=skill_name,
+ activity="updated",
+ changes=[skill_change("owners", before=previous_ids, after=next_ids)],
+ )
return resolve_skill_owners(team, skill_name)
diff --git a/products/skills/backend/api/skill_view_versions.py b/products/skills/backend/api/skill_view_versions.py
index 5c07b8edc826..5ea2b24d1964 100644
--- a/products/skills/backend/api/skill_view_versions.py
+++ b/products/skills/backend/api/skill_view_versions.py
@@ -189,7 +189,7 @@ class SkillVersionActionsMixin(SkillAccessMixin):
return self._skill_not_found_response(skill_name)
if base_version is not None and base_version != current_latest.version:
return version_conflict_response(current_latest.version)
- set_skill_owners(self.team, skill_name, owner_users)
+ set_skill_owners(self.team, skill_name, owner_users, acting_user=cast(User, self.request.user))
# Reread outside the transaction, so an archive landing in between can leave nothing to
# serialize. Answer that the same way every other `name/<slug>` action answers it.
refreshed = get_skill_by_name_from_db(self.team, skill_name=skill_name)
@@ -231,7 +231,7 @@ class SkillVersionActionsMixin(SkillAccessMixin):
# Owners are keyed on the logical skill, so this runs only when the caller passed
# `owners` — a plain body edit never touches ownership.
if owner_users is not None:
- set_skill_owners(self.team, skill_name, owner_users)
+ set_skill_owners(self.team, skill_name, owner_users, acting_user=cast(User, self.request.user))
except IntegrityError as err:
if "unique_skill_file_path" in str(err):
raise serializers.ValidationError({"files": "Duplicate file paths are not allowed."}, code="unique")
diff --git a/products/skills/backend/api/test/test_marketplace_endpoints.py b/products/skills/backend/api/test/test_marketplace_endpoints.py
index 12a80420dfda..bc0acbd079be 100644
--- a/products/skills/backend/api/test/test_marketplace_endpoints.py
+++ b/products/skills/backend/api/test/test_marketplace_endpoints.py
@@ -290,7 +290,7 @@ class TestSkillBundle(APIBaseTest):
self._create_skill("mine")
LLMSkillFile.objects.create(skill=self._create_skill("with-file"), path="scripts/run.py", content="print(1)\n")
self._create_skill("owned", created_by=self.other_user)
- set_skill_owners(self.team, "owned", [self.user])
+ set_skill_owners(self.team, "owned", [self.user], acting_user=None)
self._create_skill("someone-elses", created_by=self.other_user)
self._create_skill("signals-scout-x", category="scout")
self._create_skill("archived", deleted=True)
@@ -487,8 +487,8 @@ class TestSkillBundle(APIBaseTest):
AccessControl.objects.create(team=self.team, resource="llm_skill", resource_id=None, access_level="none")
allowed = self._create_skill("allowed")
self._create_skill("blocked")
- set_skill_owners(self.team, "allowed", [member])
- set_skill_owners(self.team, "blocked", [member])
+ set_skill_owners(self.team, "allowed", [member], acting_user=None)
+ set_skill_owners(self.team, "blocked", [member], acting_user=None)
AccessControl.objects.create(
team=self.team,
resource="llm_skill",
diff --git a/products/skills/backend/api/test/test_skills.py b/products/skills/backend/api/test/test_skills.py
index ade12dcd1aec..f226c4bc75e0 100644
--- a/products/skills/backend/api/test/test_skills.py
+++ b/products/skills/backend/api/test/test_skills.py
@@ -17,6 +17,7 @@ from rest_framework import serializers, status
from posthog.constants import AvailableFeature
from posthog.models import Team, User
+from posthog.models.activity_logging.activity_log import ActivityLog
from posthog.models.oauth import OAuthAccessToken, OAuthApplication
from posthog.models.organization import OrganizationMembership
@@ -94,7 +95,7 @@ class TestLLMSkillAPI(APIBaseTest):
)
# The create endpoint seeds the creator as owner, so a fixture built straight from the ORM
# has to as well. Publishing to the community is owner-only.
- set_skill_owners(self.team, name, [owner])
+ set_skill_owners(self.team, name, [owner], acting_user=None)
return skill
# --- Create ---
@@ -490,7 +491,9 @@ class TestLLMSkillAPI(APIBaseTest):
# skills version alone cannot see it, and the list serializes owners.
(
"owner_change",
- lambda self: set_skill_owners(self.team, "skill-a", [self._create_user("[email protected]")]),
+ lambda self: set_skill_owners(
+ self.team, "skill-a", [self._create_user("[email protected]")], acting_user=None
+ ),
),
("category", lambda self: LLMSkill.objects.filter(team=self.team, name="skill-a").update(category="scout")),
("hard_delete", lambda self: LLMSkill.objects.filter(team=self.team, name="skill-a").delete()),
@@ -509,9 +512,9 @@ class TestLLMSkillAPI(APIBaseTest):
)
def test_list_etag_changes_after_a_store_change(self, _label, change):
self.create_skill(name="skill-a", description="Does A things.")
- set_skill_owners(self.team, "skill-a", [])
+ set_skill_owners(self.team, "skill-a", [], acting_user=None)
self.create_skill(name="skill-b", description="Does B things.")
- set_skill_owners(self.team, "skill-b", [self._create_user("[email protected]")])
+ set_skill_owners(self.team, "skill-b", [self._create_user("[email protected]")], acting_user=None)
first = self.client.get(self._url())
change(self)
@@ -1662,7 +1665,7 @@ class TestLLMSkillAPI(APIBaseTest):
v2 = self.create_skill(name="typoo", version=2)
LLMSkillFile.objects.create(skill=v2, path="scripts/run.sh", content="#!/bin/bash")
member = User.objects.create_and_join(self.organization, "[email protected]", None)
- set_skill_owners(self.team, "typoo", [member])
+ set_skill_owners(self.team, "typoo", [member], acting_user=None)
updated_at_before = v2.updated_at
response = self.client.post(
@@ -2362,7 +2365,7 @@ class TestSkillWriteAnalytics(APIBaseTest):
created_by=self.user,
)
LLMSkillFile.objects.create(skill=self.skill, path="old.md", content="hi")
- set_skill_owners(self.team, "tracked-skill", [self.user])
+ set_skill_owners(self.team, "tracked-skill", [self.user], acting_user=None)
@parameterized.expand(
[
@@ -2437,6 +2440,105 @@ class TestSkillWriteAnalytics(APIBaseTest):
assert props["edits_used"] is False
+class TestSkillActivityLog(APIBaseTest):
+ def _url(self, path: str = "") -> str:
+ return f"/api/environments/{self.team.id}/llm_skills/{path}"
+
+ def setUp(self) -> None:
+ super().setUp()
+ self.skill = LLMSkill.objects.create(
+ team=self.team,
+ name="logged-skill",
+ description="A logged skill.",
+ body="# V1",
+ version=1,
+ is_latest=True,
+ created_by=self.user,
+ )
+ LLMSkillFile.objects.create(skill=self.skill, path="old.md", content="hi")
+ set_skill_owners(self.team, "logged-skill", [self.user], acting_user=None)
+ ActivityLog.objects.filter(team_id=self.team.id).delete()
+
+ def _skill_rows(self) -> list[ActivityLog]:
+ return list(ActivityLog.objects.filter(team_id=self.team.id, scope="LLMSkill"))
+
+ @parameterized.expand(
+ [
+ ("create", "post", "", {"name": "new-skill", "description": "New.", "body": "# New"}, "created", False),
+ ("publish", "patch", "name/logged-skill", {"body": "# V2", "base_version": 1}, "updated", True),
+ ("archive", "post", "name/logged-skill/archive", None, "deleted", True),
+ ("duplicate", "post", "name/logged-skill/duplicate", {"new_name": "copied-skill"}, "created", False),
+ ("rename", "post", "name/logged-skill/rename", {"new_name": "renamed-skill"}, "updated", True),
+ ("create file", "post", "name/logged-skill/files", {"path": "notes.md", "content": "hi"}, "updated", True),
+ (
+ "rename file",
+ "post",
+ "name/logged-skill/files-rename",
+ {"old_path": "old.md", "new_path": "new.md"},
+ "updated",
+ True,
+ ),
+ ("delete file", "delete", "name/logged-skill/files/old.md", None, "updated", True),
+ ]
+ )
+ def test_each_write_logs_one_row_for_the_logical_skill(
+ self, _label, method, path, data, expected_activity, keeps_item_id
+ ) -> None:
+ response = getattr(self.client, method)(self._url(path), data=data or {}, format="json")
+
+ assert response.status_code in (status.HTTP_200_OK, status.HTTP_201_CREATED, status.HTTP_204_NO_CONTENT), (
+ response.content
+ )
+ rows = self._skill_rows()
+ assert [row.activity for row in rows] == [expected_activity]
+ assert rows[0].user == self.user
+ assert (rows[0].item_id == str(self.skill.pk)) is keeps_item_id
+
+ def test_publish_records_the_version_note_and_what_changed(self) -> None:
+ response = self.client.patch(
+ self._url("name/logged-skill"),
+ data={
+ "body": "# V2",
+ "description": "Now described.",
+ "files": [{"path": "added.md", "content": "new"}],
+ "base_version": 1,
+ "version_description": "Tighten the instructions",
+ },
+ format="json",
+ )
+
+ assert response.status_code == status.HTTP_200_OK, response.content
+ rows = self._skill_rows()
+ assert len(rows) == 1
+ assert rows[0].detail is not None
+ changes = {change["field"]: change for change in rows[0].detail["changes"]}
+ assert changes["version"]["before"] == 1
+ assert changes["version"]["after"] == 2
+ assert changes["version_description"]["after"] == "Tighten the instructions"
+ assert changes["body"]["before"] is None and changes["body"]["after"] is None
+ assert changes["description"]["after"] == "Now described."
+ assert changes["files"]["after"] == {"added": ["added.md"], "removed": ["old.md"], "edited": []}
+
+ def test_owner_change_logs_the_owner_ids_without_publishing(self) -> None:
+ member = self._create_user("[email protected]")
+
+ response = self.client.patch(self._url("name/logged-skill"), data={"owners": [str(member.uuid)]}, format="json")
+
+ assert response.status_code == status.HTTP_200_OK, response.content
+ rows = self._skill_rows()
+ assert len(rows) == 1
+ assert rows[0].detail is not None
+ assert rows[0].detail["changes"][0]["field"] == "owners"
+ assert rows[0].detail["changes"][0]["before"] == [self.user.id]
+ assert rows[0].detail["changes"][0]["after"] == [member.id]
+
+ def test_system_archive_logs_a_system_row(self) -> None:
+ archive_skill(self.team, "logged-skill", acting_user=None)
+
+ rows = self._skill_rows()
+ assert [(row.activity, row.is_system, row.item_id) for row in rows] == [("deleted", True, str(self.skill.pk))]
+
+
class TestSkillAccessControlRBAC(APIBaseTest):
def setUp(self):
super().setUp()
@@ -2641,8 +2743,8 @@ class TestSkillAccessControlRBAC(APIBaseTest):
access_level="editor",
organization_member=membership,
)
- set_skill_owners(self.team, theirs.name, [self.member])
- set_skill_owners(self.team, self.skill.name, [self.user])
+ set_skill_owners(self.team, theirs.name, [self.member], acting_user=None)
+ set_skill_owners(self.team, self.skill.name, [self.user], acting_user=None)
response = self.client.post(
self._url(f"name/{self.skill.name}/publish-community"),
@@ -2682,7 +2784,7 @@ class TestSkillAccessControlRBAC(APIBaseTest):
def test_an_owner_with_editor_access_can_publish(self, mock_publish, _mock_flag):
mock_publish.return_value = {"pr_url": "https://example.com/pull/1", "pr_number": 1, "branch": "b"}
self._grant_llm_skill_access("editor")
- set_skill_owners(self.team, self.skill.name, [self.member])
+ set_skill_owners(self.team, self.skill.name, [self.member], acting_user=None)
response = self.client.post(
self._url(f"name/{self.skill.name}/publish-community"),
@@ -3160,7 +3262,7 @@ class TestLLMSkillOwners(APIBaseTest):
member = self._member("[email protected]")
create_skill(self.team, user=self.user, name="theirs", description="d", body="# b")
create_skill(self.team, user=self.user, name="mine", description="d", body="# b")
- set_skill_owners(self.team, "theirs", [member])
+ set_skill_owners(self.team, "theirs", [member], acting_user=None)
response = self.client.get(self._url() + f"?owner_id={member.id}")
@@ -3172,7 +3274,7 @@ class TestLLMSkillOwners(APIBaseTest):
# rather than surfacing the skills through a stale row.
member = self._member("[email protected]")
create_skill(self.team, user=self.user, name="orphaned", description="d", body="# b")
- set_skill_owners(self.team, "orphaned", [member])
+ set_skill_owners(self.team, "orphaned", [member], acting_user=None)
url = self._url() + f"?owner_id={member.id}"
etag = self.client.get(url)["ETag"]
@@ -3188,7 +3290,7 @@ class TestLLMSkillOwners(APIBaseTest):
# former member's profile must not keep leaking through skill-get.
member = self._member("[email protected]")
create_skill(self.team, user=self.user, name="leaky", description="d", body="# b")
- set_skill_owners(self.team, "leaky", [self.user, member])
+ set_skill_owners(self.team, "leaky", [self.user, member], acting_user=None)
member.organization_memberships.filter(organization=self.organization).delete()
@@ -3206,8 +3308,8 @@ class TestLLMSkillOwners(APIBaseTest):
alice = self._member("[email protected]")
bob = self._member("[email protected]")
- set_skill_owners(env_a, "shared-name", [alice])
- set_skill_owners(env_b, "shared-name", [bob])
+ set_skill_owners(env_a, "shared-name", [alice], acting_user=None)
+ set_skill_owners(env_b, "shared-name", [bob], acting_user=None)
assert [o.email for o in resolve_skill_owners(env_a, "shared-name")] == [alice.email]
assert [o.email for o in resolve_skill_owners(env_b, "shared-name")] == [bob.email]
diff --git a/products/skills/frontend/activityDescriber.tsx b/products/skills/frontend/activityDescriber.tsx
new file mode 100644
index 000000000000..e8af58864ee3
--- /dev/null
+++ b/products/skills/frontend/activityDescriber.tsx
@@ -0,0 +1,124 @@
+import {
+ ActivityChange,
+ ActivityLogItem,
+ ActivityLogUserName,
+ HumanizedChange,
+ activityLogSummary,
+ defaultDescriber,
+} from 'lib/components/ActivityLog/humanizeActivity'
+
+interface SkillFilesChange {
+ added?: string[]
+ removed?: string[]
+ edited?: string[]
+}
+
+function findChange(logItem: ActivityLogItem, field: string): ActivityChange | undefined {
+ return logItem.detail?.changes?.find((change) => change.field === field)
+}
+
+function changeAfter(logItem: ActivityLogItem, field: string): string | null {
+ const after = findChange(logItem, field)?.after
+ return after != null ? String(after) : null
+}
+
+function describeFiles(logItem: ActivityLogItem): string | null {
+ const files = findChange(logItem, 'files')?.after as SkillFilesChange | undefined
+ if (!files) {
+ return null
+ }
+ const parts = [
+ files.added?.length ? `added ${files.added.join(', ')}` : null,
+ files.removed?.length ? `removed ${files.removed.join(', ')}` : null,
+ files.edited?.length ? `edited ${files.edited.join(', ')}` : null,
+ ].filter((part): part is string => part !== null)
+ return parts.length ? parts.join('; ') : null
+}
+
+function describeVersionPublished(logItem: ActivityLogItem, skillName: string): HumanizedChange {
+ const version = changeAfter(logItem, 'version')
+ const versionDescription = changeAfter(logItem, 'version_description')
+ const files = describeFiles(logItem)
+ const action = `Published version ${version ?? '?'}${files ? ` (${files})` : ''}`
+ return {
+ summary: activityLogSummary(logItem, action, skillName, versionDescription ?? undefined),
+ description: (
+ <>
+ <ActivityLogUserName logItem={logItem} /> published version <b>{version ?? '?'}</b> of skill{' '}
+ <b>{skillName}</b>
+ {files ? <> ({files})</> : null}
+ {versionDescription ? <>: "{versionDescription}"</> : null}
+ </>
+ ),
+ }
+}
+
+// Scope LLMSkill rows, written by log_skill_activity in products/skills/backend/activity_logging.py.
+// detail.name is the skill name at the time of the change.
+export function skillActivityDescriber(logItem: ActivityLogItem, asNotification?: boolean): HumanizedChange {
+ const skillName = logItem?.detail?.name ?? ''
+
+ if (logItem.activity === 'created') {
+ const duplicatedFrom = changeAfter(logItem, 'duplicated_from')
+ return {
+ summary: activityLogSummary(
+ logItem,
+ duplicatedFrom ? `Created a copy of ${duplicatedFrom}` : 'Created the skill',
+ skillName
+ ),
+ description: duplicatedFrom ? (
+ <>
+ <ActivityLogUserName logItem={logItem} /> created skill <b>{skillName}</b> as a copy of{' '}
+ <b>{duplicatedFrom}</b>
+ </>
+ ) : (
+ <>
+ <ActivityLogUserName logItem={logItem} /> created skill <b>{skillName}</b>
+ </>
+ ),
+ }
+ }
+
+ if (logItem.activity === 'deleted') {
+ return {
+ summary: activityLogSummary(logItem, 'Archived the skill', skillName),
+ description: (
+ <>
+ <ActivityLogUserName logItem={logItem} /> archived skill <b>{skillName}</b>
+ </>
+ ),
+ }
+ }
+
+ if (logItem.activity === 'updated') {
+ if (findChange(logItem, 'version')) {
+ return describeVersionPublished(logItem, skillName)
+ }
+
+ const rename = findChange(logItem, 'name')
+ if (rename) {
+ return {
+ summary: activityLogSummary(logItem, `Renamed the skill from ${String(rename.before)}`, skillName),
+ description: (
+ <>
+ <ActivityLogUserName logItem={logItem} /> renamed skill <b>{String(rename.before)}</b> to{' '}
+ <b>{skillName}</b>
+ </>
+ ),
+ }
+ }
+
+ if (findChange(logItem, 'owners')) {
+ return {
+ summary: activityLogSummary(logItem, 'Changed the owners', skillName),
+ description: (
+ <>
+ <ActivityLogUserName logItem={logItem} /> changed the owners of skill <b>{skillName}</b>
+ </>
+ ),
+ }
+ }
+ }
+
+ return defaultDescriber(logItem, asNotification, skillName)
+}
diff --git a/services/mcp/src/api/generated.ts b/services/mcp/src/api/generated.ts
index 57d732ced01d..bd0638e2367f 100644
--- a/services/mcp/src/api/generated.ts
+++ b/services/mcp/src/api/generated.ts
@@ -124284,6 +124284,7 @@ export namespace Schemas {
* * `EvaluationDirectory` - EvaluationDirectory
* * `LLMPrompt` - LLMPrompt
* * `LLMPromptLabel` - LLMPromptLabel
+ * * `LLMSkill` - LLMSkill
* * `LLMTrace` - LLMTrace
* * `AIGatewayCredit` - AIGatewayCredit
* * `WebAnalyticsFilterPreset` - WebAnalyticsFilterPreset
@@ -124397,6 +124398,7 @@ export namespace Schemas {
EvaluationDirectory: 'EvaluationDirectory',
LLMPrompt: 'LLMPrompt',
LLMPromptLabel: 'LLMPromptLabel',
+ LLMSkill: 'LLMSkill',
LLMTrace: 'LLMTrace',
AIGatewayCredit: 'AIGatewayCredit',
WebAnalyticsFilterPreset: 'WebAnalyticsFilterPreset',
@@ -124496,6 +124498,7 @@ export namespace Schemas {
* * `EvaluationDirectory` - EvaluationDirectory
* * `LLMPrompt` - LLMPrompt
* * `LLMPromptLabel` - LLMPromptLabel
+ * * `LLMSkill` - LLMSkill
* * `LLMTrace` - LLMTrace
* * `AIGatewayCredit` - AIGatewayCredit
* * `WebAnalyticsFilterPreset` - WebAnalyticsFilterPreset
@@ -124597,6 +124600,7 @@ export namespace Schemas {
EvaluationDirectory: 'EvaluationDirectory',
LLMPrompt: 'LLMPrompt',
LLMPromptLabel: 'LLMPromptLabel',
+ LLMSkill: 'LLMSkill',
LLMTrace: 'LLMTrace',
AIGatewayCredit: 'AIGatewayCredit',
WebAnalyticsFilterPreset: 'WebAnalyticsFilterPreset',