:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
perf(insights): keep insight utils off the logged-in shell (#126878)
Paul D'Ambra27b2334b0253
diff --git a/frontend/bin/layer-baseline.txt b/frontend/bin/layer-baseline.txtindex b5afe6210767..55766ef648da 100644--- a/frontend/bin/layer-baseline.txt+++ b/frontend/bin/layer-baseline.txt@@ -108,7 +108,6 @@ frontend/src/lib/api.ts -> frontend/src/queries/utils.tsfrontend/src/lib/api.ts -> frontend/src/scenes/surveys/constants.tsxfrontend/src/lib/components/Account/ProjectFreshnessIndicator.tsx -> frontend/src/scenes/onboarding/shared/utils.tsxfrontend/src/lib/components/ActivityLog/ActivityLogSubscribeMenu.tsx -> frontend/src/scenes/hog-functions/sub-templates/sub-templates.ts-frontend/src/lib/components/ActivityLog/activityDescriptions/tagActivityDescriber.tsx -> frontend/src/scenes/insights/utils.tsxfrontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts -> frontend/src/scenes/dashboard/liveDashboardIds.tsfrontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts -> frontend/src/scenes/dashboard/newDashboardLogic.tsfrontend/src/lib/components/AddToDashboard/addToDashboardModalLogic.ts -> frontend/src/scenes/insights/insightLogic.tsx@@ -197,7 +196,6 @@ frontend/src/lib/components/EntityFilterInfo.tsx -> frontend/src/scenes/data-manfrontend/src/lib/components/EntityFilterInfo.tsx -> frontend/src/scenes/feature-flags/flagEvaluationsTable.tsfrontend/src/lib/components/EntityFilterInfo.tsx -> frontend/src/scenes/insights/filters/ActionFilter/flagCallsSeries.tsfrontend/src/lib/components/EntityFilterInfo.tsx -> frontend/src/scenes/insights/filters/ActionFilter/seriesNode.ts-frontend/src/lib/components/EntityFilterInfo.tsx -> frontend/src/scenes/insights/utils.tsxfrontend/src/lib/components/Errors/Exception/CollapsibleExceptionHeader.tsx -> products/error_tracking/frontend/components/RuntimeIcon.tsxfrontend/src/lib/components/Errors/Frame/FrameVariables.tsx -> products/error_tracking/frontend/components/PropertiesTable.tsxfrontend/src/lib/components/EventPropertyTabs/EventPropertyTabs.tsx -> frontend/src/scenes/surveys/utils.ts@@ -224,7 +222,6 @@ frontend/src/lib/components/IngestionControls/triggers/FlagTrigger/flagTriggerLofrontend/src/lib/components/IngestionControls/triggers/UrlConfig.tsx -> frontend/src/scenes/session-recordings/components/AiRegexHelper/AiRegexHelper.tsxfrontend/src/lib/components/IngestionControls/triggers/triggerGroups/TriggerGroupsEditor.tsx -> frontend/src/scenes/settings/environment/ReplayTriggers.tsxfrontend/src/lib/components/IngestionControls/triggers/triggerGroups/TriggerGroupsEditor.tsx -> frontend/src/scenes/settings/environment/SessionRecordingSettings.tsx-frontend/src/lib/components/InsightLabel/index.tsx -> frontend/src/scenes/insights/utils.tsxfrontend/src/lib/components/InsightLabel/index.tsx -> frontend/src/scenes/insights/utils/resultSeries.tsfrontend/src/lib/components/InsightLabel/index.tsx -> products/product_analytics/frontend/insights/trends/mathsLogic.tsxfrontend/src/lib/components/InsightLegend/InsightLegend.tsx -> frontend/src/scenes/insights/insightLogic.tsx@@ -289,7 +286,6 @@ frontend/src/lib/components/SessionTimeline/timeline/items/page.tsx -> products/frontend/src/lib/components/Sharing/SharingModal.tsx -> frontend/src/queries/nodes/InsightQuery/defaults.tsfrontend/src/lib/components/Sharing/SharingModal.tsx -> frontend/src/queries/utils.tsfrontend/src/lib/components/Sharing/SharingModal.tsx -> frontend/src/scenes/insights/insightVizDataLogic.ts-frontend/src/lib/components/Sharing/sharingLogic.ts -> frontend/src/scenes/insights/utils.tsxfrontend/src/lib/components/SmoothingFilter/SmoothingFilter.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/lib/components/SmoothingFilter/SmoothingFilter.tsx -> frontend/src/scenes/insights/insightVizDataLogic.tsfrontend/src/lib/components/SmoothingFilter/SmoothingFilter.tsx -> products/product_analytics/frontend/insights/trends/trendsDataLogic.ts@@ -460,7 +456,6 @@ frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts -> producfrontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts -> products/business_intelligence/frontend/biMemberAliases.tsfrontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts -> products/business_intelligence/frontend/biQueryResults.tsfrontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts -> products/business_intelligence/frontend/biTableLayout.ts-frontend/src/queries/nodes/DataVisualization/eventColumnLabels.ts -> frontend/src/scenes/insights/utils.tsxfrontend/src/queries/nodes/EventsNode/EventName.tsx -> products/actions/frontend/components/EventName.tsxfrontend/src/queries/nodes/HogQLQuery/HogQLQueryEditor.tsx -> frontend/src/scenes/data-warehouse/settings/dataWarehouseSettingsSceneLogic.tsfrontend/src/queries/nodes/HogQLQuery/hogQLQueryEditorLogic.tsx -> frontend/src/scenes/data-warehouse/saved_queries/dataWarehouseViewsLogic.tsxdiff --git a/frontend/src/lib/components/ActivityLog/activityDescriptions/tagActivityDescriber.tsx b/frontend/src/lib/components/ActivityLog/activityDescriptions/tagActivityDescriber.tsxindex f6457348c1a2..af5baf1c0a7d 100644--- a/frontend/src/lib/components/ActivityLog/activityDescriptions/tagActivityDescriber.tsx+++ b/frontend/src/lib/components/ActivityLog/activityDescriptions/tagActivityDescriber.tsx@@ -6,8 +6,8 @@ import {defaultDescriber,} from 'lib/components/ActivityLog/humanizeActivity'import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'+import { getDisplayNameFromEntityFilter } from 'lib/insights/entityFilterNames'import { Link } from 'lib/lemon-ui/Link'-import { getDisplayNameFromEntityFilter } from 'scenes/insights/utils'import { urls } from 'scenes/urls'import { getFilterLabel } from '~/taxonomy/helpers'diff --git a/frontend/src/lib/components/EntityFilterInfo.tsx b/frontend/src/lib/components/EntityFilterInfo.tsxindex 456a4664980e..9ea38ebed697 100644--- a/frontend/src/lib/components/EntityFilterInfo.tsx+++ b/frontend/src/lib/components/EntityFilterInfo.tsx@@ -1,5 +1,10 @@import clsx from 'clsx'+import {+ formatEventName,+ getDisplayNameFromEntityFilter,+ isAllEventsEntityFilter,+} from 'lib/insights/entityFilterNames'import { Tooltip } from 'lib/lemon-ui/Tooltip'import { ensureStringIsNotBlank } from 'lib/utils/strings'import { getEventDefinitionIcon } from 'scenes/data-management/events/DefinitionHeader'@@ -12,7 +17,6 @@ import {isGroupSeriesNode,isWarehouseSeriesNode,} from 'scenes/insights/filters/ActionFilter/seriesNode'-import { formatEventName, getDisplayNameFromEntityFilter, isAllEventsEntityFilter } from 'scenes/insights/utils'import { getCoreFilterDefinition } from '~/taxonomy/helpers'import { ActionFilter, EntityFilter, EntityTypes } from '~/types'diff --git a/frontend/src/lib/components/InsightLabel/index.tsx b/frontend/src/lib/components/InsightLabel/index.tsxindex 15fc39e98163..0781c6c12d74 100644--- a/frontend/src/lib/components/InsightLabel/index.tsx+++ b/frontend/src/lib/components/InsightLabel/index.tsx@@ -9,10 +9,10 @@ import { EntityFilterInfo } from 'lib/components/EntityFilterInfo'import { parseAliasToReadable } from 'lib/components/PathCleanFilters/PathCleanFilterItem'import { PropertyKeyInfo } from 'lib/components/PropertyKeyInfo'import { SeriesLetter } from 'lib/components/SeriesGlyph'+import { formatEventName } from 'lib/insights/entityFilterNames'import { Tooltip } from 'lib/lemon-ui/Tooltip'import { hexToRGBA } from 'lib/utils/colors'import { capitalizeFirstLetter, midEllipsis } from 'lib/utils/strings'-import { formatEventName } from 'scenes/insights/utils'import { ResultSeries, getResultSeriesCustomName } from 'scenes/insights/utils/resultSeries'import { groupsModel } from '~/models/groupsModel'diff --git a/frontend/src/lib/components/Sharing/sharingLogic.ts b/frontend/src/lib/components/Sharing/sharingLogic.tsindex 311ac6265985..0dcc7893d0bb 100644--- a/frontend/src/lib/components/Sharing/sharingLogic.ts+++ b/frontend/src/lib/components/Sharing/sharingLogic.ts@@ -5,8 +5,8 @@ import { loaders } from 'kea-loaders'import posthog from 'posthog-js'import api from 'lib/api'+import { getInsightId } from 'lib/insights/getInsightId'import { preflightLogic } from 'lib/logic/preflightLogic'-import { getInsightId } from 'scenes/insights/utils'import { organizationLogic } from 'scenes/organizationLogic'import { urls } from 'scenes/urls'import { userLogic } from 'scenes/userLogic'diff --git a/frontend/src/lib/insights/entityFilterNames.test.ts b/frontend/src/lib/insights/entityFilterNames.test.tsnew file mode 100644index 000000000000..bc188c8d7e83--- /dev/null+++ b/frontend/src/lib/insights/entityFilterNames.test.ts@@ -0,0 +1,37 @@+import { Entity, EntityFilter } from '~/types'++import { getDisplayNameFromEntityFilter } from './entityFilterNames'++const createFilter = (id?: Entity['id'], name?: string, custom_name?: string): EntityFilter => {+ return {+ custom_name,+ name: name ?? null,+ id: id ?? null,+ }+}++describe('getDisplayNameFromEntityFilter()', () => {+ const paramsToExpected: [EntityFilter, boolean, string | null][] = [+ [createFilter(3, 'name', 'custom_name'), true, 'custom_name'],+ [createFilter(3, 'name', ''), true, 'name'],+ [createFilter(3, 'name', ' '), true, 'name'],+ [createFilter(3, 'name'), true, 'name'],+ [createFilter(3, '', ''), true, '3'],+ [createFilter(3, ' ', ' '), true, '3'],+ [createFilter(3), true, '3'],+ [createFilter('hi'), true, 'hi'],+ [createFilter(), true, null],+ [createFilter(3, 'name', 'custom_name'), false, 'name'],+ [createFilter(3, ' ', 'custom_name'), false, '3'],+ ]++ paramsToExpected.forEach(([filter, isCustom, expected]) => {+ it(`expect "${expected}" for Filter<custom_name="${filter.custom_name}", name="${filter.name}", id="${filter.id}">`, () => {+ expect(getDisplayNameFromEntityFilter(filter, isCustom)).toEqual(expected)+ })+ })++ it('returns null when a result has no action', () => {+ expect(getDisplayNameFromEntityFilter(undefined)).toBeNull()+ })+})diff --git a/frontend/src/lib/insights/entityFilterNames.ts b/frontend/src/lib/insights/entityFilterNames.tsnew file mode 100644index 000000000000..f030137b2fba--- /dev/null+++ b/frontend/src/lib/insights/entityFilterNames.ts@@ -0,0 +1,50 @@+import { ensureStringIsNotBlank } from 'lib/utils/strings'++import { CORE_FILTER_DEFINITIONS_BY_GROUP } from '~/taxonomy/taxonomy'+import { ActionFilter, EntityFilter, EntityTypes } from '~/types'++export const isAllEventsEntityFilter = (filter: EntityFilter | ActionFilter | null | undefined): boolean => {+ return (+ filter != null &&+ filter.type === EntityTypes.EVENTS &&+ filter.id === null &&+ (!filter.name || filter.name === 'All events')+ )+}++export const formatEventName = (name: string | undefined | null): string | undefined => {+ if (!name) {+ return+ }++ // Handle comma-separated event keys (e.g., "$pageview, $exception" from GroupNode)+ if (name.includes(',')) {+ return name+ .split(',')+ .map((eventName) => {+ const trimmed = eventName.trim()+ return CORE_FILTER_DEFINITIONS_BY_GROUP.events?.[trimmed]?.label || trimmed+ })+ .join(', ')+ }++ return CORE_FILTER_DEFINITIONS_BY_GROUP.events?.[name]?.label || name+}++export const getDisplayNameFromEntityFilter = (+ filter: EntityFilter | ActionFilter | null | undefined,+ isCustom = true+): string | null => {+ // Make sure names aren't blank strings+ const customName = ensureStringIsNotBlank(filter?.custom_name)++ let name = ensureStringIsNotBlank(filter?.name)+ name = formatEventName(name) ?? name++ if (isAllEventsEntityFilter(filter)) {+ name = 'All events'+ }++ // Return custom name. If that doesn't exist then the name, then the id, then just null.+ return (isCustom ? customName : null) ?? name ?? (filter?.id ? `${filter?.id}` : null)+}diff --git a/frontend/src/lib/insights/getInsightId.ts b/frontend/src/lib/insights/getInsightId.tsnew file mode 100644index 000000000000..483cd1754565--- /dev/null+++ b/frontend/src/lib/insights/getInsightId.ts@@ -0,0 +1,16 @@+import { getCurrentTeamId } from 'lib/utils/getAppContext'+import { retryImport } from 'lib/utils/retryImport'++import { InsightShortId } from '~/types'++import { insightsList } from 'products/product_analytics/frontend/generated/api'++export async function getInsightId(shortId: InsightShortId): Promise<number | undefined> {+ // A static import would put insightLogic and everything it imports on the eager path of every page.+ const { insightLogic } = await retryImport(() => import('scenes/insights/insightLogic'))+ const insightId = insightLogic.findMounted({ dashboardItemId: shortId })?.values?.insight?.id++ return insightId+ ? insightId+ : (await insightsList(String(getCurrentTeamId()), { short_id: shortId })).results[0]?.id+}diff --git a/frontend/src/queries/nodes/DataVisualization/eventColumnLabels.ts b/frontend/src/queries/nodes/DataVisualization/eventColumnLabels.tsindex ac86f19af423..9ebb0e2ff788 100644--- a/frontend/src/queries/nodes/DataVisualization/eventColumnLabels.ts+++ b/frontend/src/queries/nodes/DataVisualization/eventColumnLabels.ts@@ -1,4 +1,4 @@-import { formatEventName } from 'scenes/insights/utils'+import { formatEventName } from 'lib/insights/entityFilterNames'// Matches the events table: only a column literally named `event` is known to hold event names.const EVENT_COLUMN_NAME = 'event'diff --git a/frontend/src/scenes/insights/insightLogic.tsx b/frontend/src/scenes/insights/insightLogic.tsxindex 189c923e6665..44f5f9e748fa 100644--- a/frontend/src/scenes/insights/insightLogic.tsx+++ b/frontend/src/scenes/insights/insightLogic.tsx@@ -22,6 +22,7 @@ import { ApiError } from 'lib/api'import { isTransientServerError, shouldReportApiFailure } from 'lib/api-error'import { tryShowMCPHint } from 'lib/components/MCPHint/mcpHintLogic'import { SetupTaskId, globalSetupLogic } from 'lib/components/ProductSetup'+import { getInsightId } from 'lib/insights/getInsightId'import { LemonField } from 'lib/lemon-ui/LemonField'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'@@ -95,7 +96,6 @@ import type { AccessControlFilterWarning, DataWarehouseSyncWarning } from '../..import type { CohortType, DashboardTileBasicType, TeamPublicType, TeamType, UserBasicType, UserType } from '../../types'import { teamLogic } from '../teamLogic'import { insightDataLogic, isInsightSceneInstance } from './insightDataLogic'-import { getInsightId } from './utils'import { insightsApi } from './utils/api'function reportInsightSaved(diff --git a/frontend/src/scenes/insights/summarizeInsight.ts b/frontend/src/scenes/insights/summarizeInsight.tsindex 071e56608768..3e064a892886 100644--- a/frontend/src/scenes/insights/summarizeInsight.ts+++ b/frontend/src/scenes/insights/summarizeInsight.ts@@ -2,12 +2,9 @@ import { useValues } from 'kea'import { PROPERTY_FILTER_TYPE_TO_TAXONOMIC_FILTER_GROUP_TYPE } from 'lib/components/PropertyFilters/utils'import { RETENTION_FIRST_OCCURRENCE_MATCHING_FILTERS } from 'lib/constants'+import { getDisplayNameFromEntityFilter } from 'lib/insights/entityFilterNames'import { alphabet, capitalizeFirstLetter } from 'lib/utils/strings'-import {- getDisplayNameFromEntityFilter,- getDisplayNameFromEntityNode,- humanizePathsEventTypes,-} from 'scenes/insights/utils'+import { getDisplayNameFromEntityNode, humanizePathsEventTypes } from 'scenes/insights/utils'import { cohortsModel } from '~/models/cohortsModel'import type { cohortsModelType } from '~/models/cohortsModel'diff --git a/frontend/src/scenes/insights/utils.test.ts b/frontend/src/scenes/insights/utils.test.tsindex 93206f6b074d..e6d6bda998dd 100644--- a/frontend/src/scenes/insights/utils.test.ts+++ b/frontend/src/scenes/insights/utils.test.ts@@ -5,7 +5,6 @@ import {formatAggregationValue,formatBreakdownLabel,formatBreakdownType,- getDisplayNameFromEntityFilter,getDisplayNameFromEntityNode,getTrendDatasetKey,NOT_IN_COHORT_ID,@@ -23,44 +22,10 @@ import {} from '~/queries/schema/schema-general'import { isEventsNode } from '~/queries/utils'import { initKeaTests } from '~/test/init'-import { BaseMathType, CompareLabelType, Entity, EntityFilter, FilterType, InsightType, TeamType } from '~/types'+import { BaseMathType, CompareLabelType, Entity, FilterType, InsightType, TeamType } from '~/types'import { IndexedTrendResult } from 'products/product_analytics/frontend/insights/trends/types'-const createFilter = (id?: Entity['id'], name?: string, custom_name?: string): EntityFilter => {- return {- custom_name,- name: name ?? null,- id: id ?? null,- }-}--describe('getDisplayNameFromEntityFilter()', () => {- const paramsToExpected: [EntityFilter, boolean, string | null][] = [- [createFilter(3, 'name', 'custom_name'), true, 'custom_name'],- [createFilter(3, 'name', ''), true, 'name'],- [createFilter(3, 'name', ' '), true, 'name'],- [createFilter(3, 'name'), true, 'name'],- [createFilter(3, '', ''), true, '3'],- [createFilter(3, ' ', ' '), true, '3'],- [createFilter(3), true, '3'],- [createFilter('hi'), true, 'hi'],- [createFilter(), true, null],- [createFilter(3, 'name', 'custom_name'), false, 'name'],- [createFilter(3, ' ', 'custom_name'), false, '3'],- ]-- paramsToExpected.forEach(([filter, isCustom, expected]) => {- it(`expect "${expected}" for Filter<custom_name="${filter.custom_name}", name="${filter.name}", id="${filter.id}">`, () => {- expect(getDisplayNameFromEntityFilter(filter, isCustom)).toEqual(expected)- })- })-- it('returns null when a result has no action', () => {- expect(getDisplayNameFromEntityFilter(undefined)).toBeNull()- })-})-const createEventsNode = (id?: Entity['id'], name?: string, custom_name?: string): EventsNode => {return {kind: NodeKind.EventsNode,diff --git a/frontend/src/scenes/insights/utils.tsx b/frontend/src/scenes/insights/utils.tsxindex fc3ea440a535..cf2bd38f3f30 100644--- a/frontend/src/scenes/insights/utils.tsx+++ b/frontend/src/scenes/insights/utils.tsx@@ -4,15 +4,12 @@ import { ReactNode } from 'react'import { IconWarning } from '@posthog/icons'import { LemonButtonProps } from '@posthog/lemon-ui'-import api from 'lib/api'import { DataColorTheme, DataColorToken } from 'lib/colors'import { dayjs } from 'lib/dayjs'-import { getCurrentTeamId } from 'lib/utils/getAppContext'import { isEmptyObject, isObject } from 'lib/utils/guards'import { humanFriendlyNumber } from 'lib/utils/numbers'import { objectsEqual } from 'lib/utils/objects'import { removeUndefinedAndNull } from 'lib/utils/objects'-import { retryImport } from 'lib/utils/retryImport'import { ensureStringIsNotBlank } from 'lib/utils/strings'import { queryUsesFiltersPlaceholder } from 'scenes/data-warehouse/editor/sql-utils'import { isWarehouseSeriesNode } from 'scenes/insights/filters/ActionFilter/seriesNode'@@ -58,18 +55,14 @@ import { cleanInsightQuery } from '~/scenes/insights/utils/queryUtils'import { getResultSeriesIndex } from '~/scenes/insights/utils/resultSeries'import { CORE_FILTER_DEFINITIONS_BY_GROUP } from '~/taxonomy/taxonomy'import {- ActionFilter,AnyPartialFilterType,BreakdownKeyType,ChartDisplayType,CohortType,- EntityFilter,- EntityTypes,EventType,FlattenedFunnelStepByBreakdown,FunnelStepWithConversionMetrics,GroupTypeIndex,- InsightShortId,InsightType,PathType,PropertyFilterType,@@ -78,52 +71,6 @@ import {import { IndexedTrendResult } from 'products/product_analytics/frontend/insights/trends/types'-export const isAllEventsEntityFilter = (filter: EntityFilter | ActionFilter | null | undefined): boolean => {- return (- filter != null &&- filter.type === EntityTypes.EVENTS &&- filter.id === null &&- (!filter.name || filter.name === 'All events')- )-}--export const formatEventName = (name: string | undefined | null): string | undefined => {- if (!name) {- return- }-- // Handle comma-separated event keys (e.g., "$pageview, $exception" from GroupNode)- if (name.includes(',')) {- return name- .split(',')- .map((eventName) => {- const trimmed = eventName.trim()- return CORE_FILTER_DEFINITIONS_BY_GROUP.events?.[trimmed]?.label || trimmed- })- .join(', ')- }-- return CORE_FILTER_DEFINITIONS_BY_GROUP.events?.[name]?.label || name-}--export const getDisplayNameFromEntityFilter = (- filter: EntityFilter | ActionFilter | null | undefined,- isCustom = true-): string | null => {- // Make sure names aren't blank strings- const customName = ensureStringIsNotBlank(filter?.custom_name)-- let name = ensureStringIsNotBlank(filter?.name)- name = formatEventName(name) ?? name-- if (isAllEventsEntityFilter(filter)) {- name = 'All events'- }-- // Return custom name. If that doesn't exist then the name, then the id, then just null.- return (isCustom ? customName : null) ?? name ?? (filter?.id ? `${filter?.id}` : null)-}-export const getDisplayNameFromEntityNode = (node: AnyEntityNode<AnyDataWarehouseNode | ExperimentDataWarehouseNode> | GroupNode,isCustom = true@@ -200,18 +147,6 @@ export function extractObjectDiffKeys(return changedKeys}-export async function getInsightId(shortId: InsightShortId): Promise<number | undefined> {- // A static import would put insightLogic and everything it imports on the eager path of every page.- const { insightLogic } = await retryImport(() => import('./insightLogic'))- const insightId = insightLogic.findMounted({ dashboardItemId: shortId })?.values?.insight?.id-- return insightId- ? insightId- : // nosemgrep: prefer-codegen-api -- Legacy raw API call with a hand-written URL and an unchecked response type. Use insightsList() from 'products/product_analytics/frontend/generated/api' instead.- (await api.get(`api/projects/${getCurrentTeamId()}/insights/?short_id=${encodeURIComponent(shortId)}`))- .results[0]?.id-}-export function humanizePathsEventTypes(includeEventTypes: PathsFilter['includeEventTypes']): string[] {let humanEventTypes: string[] = []if (includeEventTypes) {diff --git a/frontend/src/scenes/session-recordings/playlist/playlistUtils.ts b/frontend/src/scenes/session-recordings/playlist/playlistUtils.tsindex 0446649d8737..8e1c30e5730f 100644--- a/frontend/src/scenes/session-recordings/playlist/playlistUtils.ts+++ b/frontend/src/scenes/session-recordings/playlist/playlistUtils.ts@@ -5,11 +5,11 @@ import { SetupTaskId, globalSetupLogic } from 'lib/components/ProductSetup'import { convertPropertyGroupToProperties, isValidPropertyFilter } from 'lib/components/PropertyFilters/utils'import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'import { isActionFilter, isEventFilter } from 'lib/components/UniversalFilters/utils'+import { getDisplayNameFromEntityFilter } from 'lib/insights/entityFilterNames'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { deleteWithUndo } from 'lib/utils/deleteWithUndo'import { genericOperatorMap } from 'lib/utils/operators'import { toLocalFilters } from 'scenes/insights/filters/ActionFilter/legacyFilters'-import { getDisplayNameFromEntityFilter } from 'scenes/insights/utils'import { DEFAULT_RECORDING_FILTERS } from 'scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic'import { teamLogic } from 'scenes/teamLogic'import { urls } from 'scenes/urls'diff --git a/products/posthog_ai/frontend/utils/acceptSuggestion.ts b/products/posthog_ai/frontend/utils/acceptSuggestion.tsindex a0917190abdc..6e593abaa288 100644--- a/products/posthog_ai/frontend/utils/acceptSuggestion.ts+++ b/products/posthog_ai/frontend/utils/acceptSuggestion.ts@@ -1,4 +1,4 @@-import { getInsightId } from 'scenes/insights/utils'+import { getInsightId } from 'lib/insights/getInsightId'import { urls } from 'scenes/urls'import type { CyclotronJobInputSchemaType, InsightShortId } from '~/types'diff --git a/products/product_analytics/frontend/insights/editor/editorFilterUtils.ts b/products/product_analytics/frontend/insights/editor/editorFilterUtils.tsindex f0726f823077..370715f11655 100644--- a/products/product_analytics/frontend/insights/editor/editorFilterUtils.ts+++ b/products/product_analytics/frontend/insights/editor/editorFilterUtils.ts@@ -1,5 +1,5 @@+import { formatEventName } from 'lib/insights/entityFilterNames'import { pluralize } from 'lib/utils/strings'-import { formatEventName } from 'scenes/insights/utils'import { BreakdownFilter } from '~/queries/schema/schema-general'import { CORE_FILTER_DEFINITIONS_BY_GROUP } from '~/taxonomy/taxonomy'diff --git a/products/product_analytics/frontend/insights/funnels/funnelDataLogic.ts b/products/product_analytics/frontend/insights/funnels/funnelDataLogic.tsindex 7e0c5bbf0318..aa5bee068042 100644--- a/products/product_analytics/frontend/insights/funnels/funnelDataLogic.ts+++ b/products/product_analytics/frontend/insights/funnels/funnelDataLogic.ts@@ -3,6 +3,7 @@ import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reduimport { DataColorTheme, DataColorToken } from 'lib/colors'import { BIN_COUNT_AUTO } from 'lib/constants'import { dayjs } from 'lib/dayjs'+import { formatEventName } from 'lib/insights/entityFilterNames'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import type { FeatureFlagsSet } from 'lib/logic/featureFlagLogic'import { average, percentage, sum } from 'lib/utils/numbers'@@ -23,7 +24,6 @@ import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import {- formatEventName,getFunnelDatasetKey,getFunnelDatasetPosition,getFunnelResultCustomization,diff --git a/products/product_analytics/frontend/insights/funnels/shared/FunnelStepTooltip.tsx b/products/product_analytics/frontend/insights/funnels/shared/FunnelStepTooltip.tsxindex 845bc3acfc47..9e80943a247d 100644--- a/products/product_analytics/frontend/insights/funnels/shared/FunnelStepTooltip.tsx+++ b/products/product_analytics/frontend/insights/funnels/shared/FunnelStepTooltip.tsx@@ -2,9 +2,10 @@ import { useValues } from 'kea'import { TooltipSurface, TooltipSwatch } from '@posthog/quill-charts'+import { getDisplayNameFromEntityFilter } from 'lib/insights/entityFilterNames'import { humanFriendlyDuration } from 'lib/utils/durations'import { humanFriendlyNumber, percentage } from 'lib/utils/numbers'-import { formatBreakdownLabel, getDisplayNameFromEntityFilter } from 'scenes/insights/utils'+import { formatBreakdownLabel } from 'scenes/insights/utils'import { cohortsModel } from '~/models/cohortsModel'import { propertyDefinitionsModel } from '~/models/propertyDefinitionsModel'diff --git a/products/product_analytics/frontend/insights/shared/resultSeriesName.ts b/products/product_analytics/frontend/insights/shared/resultSeriesName.tsindex 6f2a679df611..34170e09990c 100644--- a/products/product_analytics/frontend/insights/shared/resultSeriesName.ts+++ b/products/product_analytics/frontend/insights/shared/resultSeriesName.ts@@ -1,5 +1,5 @@import { toDisplayEntityFilter } from 'lib/components/EntityFilterInfo'-import { getDisplayNameFromEntityFilter } from 'scenes/insights/utils'+import { getDisplayNameFromEntityFilter } from 'lib/insights/entityFilterNames'import type { ResultSeries } from 'scenes/insights/utils/resultSeries'/**diff --git a/products/subscriptions/frontend/components/Subscriptions/subscriptionLogic.ts b/products/subscriptions/frontend/components/Subscriptions/subscriptionLogic.tsindex 1768fcf622b1..a89828655139 100644--- a/products/subscriptions/frontend/components/Subscriptions/subscriptionLogic.ts+++ b/products/subscriptions/frontend/components/Subscriptions/subscriptionLogic.ts@@ -21,6 +21,7 @@ import { z } from 'zod'import api, { ApiError } from 'lib/api'import { dayjs } from 'lib/dayjs'+import { getInsightId } from 'lib/insights/getInsightId'import { integrationsLogic } from 'lib/integrations/integrationsLogic'import { recordRecentSlackChannel, slackChannelId } from 'lib/integrations/slackChannel'import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'@@ -28,7 +29,6 @@ import { getCurrentTeamId } from 'lib/utils/getAppContext'import { removeProjectIdIfPresent } from 'lib/utils/kea-router'import { objectsEqual } from 'lib/utils/objects'import { isEmail } from 'lib/utils/url'-import { getInsightId } from 'scenes/insights/utils'import { organizationLogic } from 'scenes/organizationLogic'import { userLogic } from 'scenes/userLogic'diff --git a/products/subscriptions/frontend/components/Subscriptions/subscriptionQueries.ts b/products/subscriptions/frontend/components/Subscriptions/subscriptionQueries.tsindex 5be777d366e0..b1da2a34dc0e 100644--- a/products/subscriptions/frontend/components/Subscriptions/subscriptionQueries.ts+++ b/products/subscriptions/frontend/components/Subscriptions/subscriptionQueries.ts@@ -1,7 +1,7 @@import { BreakPointFunction } from 'kea'+import { getInsightId } from 'lib/insights/getInsightId'import { getCurrentTeamId } from 'lib/utils/getAppContext'-import { getInsightId } from 'scenes/insights/utils'import { InsightShortId } from '~/types'diff --git a/products/subscriptions/frontend/components/Subscriptions/subscriptionsLogic.ts b/products/subscriptions/frontend/components/Subscriptions/subscriptionsLogic.tsindex 71d9c93d2e62..13e457fe02ff 100644--- a/products/subscriptions/frontend/components/Subscriptions/subscriptionsLogic.ts+++ b/products/subscriptions/frontend/components/Subscriptions/subscriptionsLogic.ts@@ -2,8 +2,8 @@ import { MakeLogicType, BreakPointFunction, actions, afterMount, kea, key, listeimport { loaders } from 'kea-loaders'import api from 'lib/api'+import { getInsightId } from 'lib/insights/getInsightId'import { deleteWithUndo } from 'lib/utils/deleteWithUndo'-import { getInsightId } from 'scenes/insights/utils'import { SubscriptionType } from '~/types'