:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(error-tracking): hide stored summaries without ai approval (#128976)
James Gill2caebf2b4493
diff --git a/products/error_tracking/backend/logic/issue_summaries.py b/products/error_tracking/backend/logic/issue_summaries.pyindex fbe86076bef3..b3db1ca6b6a8 100644--- a/products/error_tracking/backend/logic/issue_summaries.py+++ b/products/error_tracking/backend/logic/issue_summaries.py@@ -240,18 +240,16 @@ def get_issue_summary(team_id: int, issue_id: UUID | str) -> ErrorTrackingIssueSdef read_issue_summary(team_id: int, issue_id: UUID | str, user: User) -> IssueSummaryState:"""The stored summary, or the reason none is shown. Never starts generation."""if not issue_summaries_enabled(team_id):- # Turning the flag off also hides stored summaries.return IssueSummaryState(status=IssueSummaryStatus.UNAVAILABLE, reason=IssueSummaryUnavailableReason.DISABLED)if not summary_sources_readable(team_id, user):return IssueSummaryState(status=IssueSummaryStatus.UNAVAILABLE, reason=IssueSummaryUnavailableReason.RESTRICTED)- stored = get_issue_summary(team_id, issue_id)- if stored is not None:- return IssueSummaryState(status=IssueSummaryStatus.READY, summary=stored)- # Checked only when nothing is stored, because a summary written before the approval was withdrawn stays readable.if not is_ai_data_processing_approved(team_id):return IssueSummaryState(status=IssueSummaryStatus.UNAVAILABLE, reason=IssueSummaryUnavailableReason.AI_NOT_APPROVED)+ stored = get_issue_summary(team_id, issue_id)+ if stored is not None:+ return IssueSummaryState(status=IssueSummaryStatus.READY, summary=stored)return IssueSummaryState(status=IssueSummaryStatus.NOT_GENERATED)diff --git a/products/error_tracking/backend/tests/api/issue_summary_states.py b/products/error_tracking/backend/tests/api/issue_summary_states.pyindex ba31c63067c5..46491d3b5d46 100644--- a/products/error_tracking/backend/tests/api/issue_summary_states.py+++ b/products/error_tracking/backend/tests/api/issue_summary_states.py@@ -24,10 +24,10 @@ STORED_CONTENT = {# name, flag on, sources readable, AI approved, summary stored, expected status, expected reasonSUMMARY_STATES: list[tuple[str, bool, bool, bool, bool, str, str | None]] = [("ready", True, True, True, True, "ready", None),- ("ready_after_ai_approval_withdrawn", True, True, False, True, "ready", None),("not_generated", True, True, True, False, "not_generated", None),("disabled_hides_stored", False, True, True, True, "unavailable", "disabled"),("restricted_hides_stored", True, False, True, True, "unavailable", "restricted"),+ ("ai_not_approved_hides_stored", True, True, False, True, "unavailable", "ai_not_approved"),("ai_not_approved", True, True, False, False, "unavailable", "ai_not_approved"),]