Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(error-tracking): open the classic taxonomic filter from add filter (#124260)

Paul D'Ambra2dcf637a36b5
diff --git a/products/error_tracking/frontend/components/IssueFilters/FilterGroup.test.tsx b/products/error_tracking/frontend/components/IssueFilters/FilterGroup.test.tsx
index ba0d4f7a11ad..1ce678ac69b8 100644
--- a/products/error_tracking/frontend/components/IssueFilters/FilterGroup.test.tsx
+++ b/products/error_tracking/frontend/components/IssueFilters/FilterGroup.test.tsx
@@ -24,6 +24,11 @@ jest.mock('lib/components/PropertyFilters/components/PropertyFilterIcon', () =>
PropertyFilterIcon: (): JSX.Element => <span />,
}))
+jest.mock('lib/components/AutoSizer', () => ({
+ AutoSizer: ({ renderProp }: { renderProp: (size: { height: number; width: number }) => React.ReactNode }) =>
+ renderProp({ height: 400, width: 400 }),
+}))
+
const LOGIC_KEY = 'test'
const firefoxFilter: EventPropertyFilter = {
@@ -155,7 +160,7 @@ describe('FilterGroup', () => {
logic.unmount()
})
- it('opens the filter picker directly to the main category', async () => {
+ it('opens the classic filter picker', async () => {
const logic = issueFiltersLogic({ logicKey: LOGIC_KEY })
logic.mount()
@@ -169,8 +174,35 @@ describe('FilterGroup', () => {
await userEvent.click(screen.getByText('Add filter'))
- expect(await screen.findByText('Choose filter')).toBeInTheDocument()
- expect(screen.queryByText('New filter…')).not.toBeInTheDocument()
+ expect(await screen.findByTestId('taxonomic-filter-searchfield')).toBeInTheDocument()
+
+ logic.unmount()
+ })
+
+ it('opens a menu with the extra rows and an entry into the classic filter picker', async () => {
+ const logic = issueFiltersLogic({ logicKey: LOGIC_KEY })
+ logic.mount()
+
+ render(
+ <Provider>
+ <BindLogic logic={issueFiltersLogic} props={{ logicKey: LOGIC_KEY }}>
+ <FilterGroup
+ menuItems={<span>Extra menu row</span>}
+ renderControls={({ filterPicker }) => filterPicker}
+ />
+ </BindLogic>
+ </Provider>
+ )
+
+ await userEvent.click(screen.getByText('Add filter'))
+
+ expect(await screen.findByText('Extra menu row')).toBeInTheDocument()
+ expect(screen.queryByTestId('taxonomic-filter-searchfield')).not.toBeInTheDocument()
+
+ const addFilterEntries = screen.getAllByText('Add filter')
+ await userEvent.click(addFilterEntries[addFilterEntries.length - 1])
+
+ expect(await screen.findByTestId('taxonomic-filter-searchfield')).toBeInTheDocument()
logic.unmount()
})
@@ -200,6 +232,7 @@ describe('FilterGroup', () => {
const valueEditor = (await screen.findByText('Enter value...')).closest('.Popover')
await waitFor(() => expect(valueEditor).toHaveClass('Popover--enter-active'))
expect(screen.getByTestId('error-tracking-active-filters')).toHaveTextContent('Issue severity')
+ await waitFor(() => expect(screen.queryByTestId('taxonomic-filter-searchfield')).not.toBeInTheDocument())
const inner = logic.values.filterGroup.values[0] as UniversalFiltersGroup
expect(inner.values).toContainEqual(
@@ -239,11 +272,9 @@ describe('FilterGroup', () => {
)
await userEvent.click(screen.getByText('Add filter'))
- const recentIssueRow = Array.from(
- document.querySelectorAll<HTMLElement>('[data-slot="taxonomic-filter-menu-row"]')
- ).find((row) => row.textContent?.includes('Issue severity') && row.textContent.includes('Recent'))
- expect(recentIssueRow).toBeInTheDocument()
- await userEvent.click(recentIssueRow as HTMLElement)
+ const recentIssueRow = await screen.findByTestId('prop-filter-recent_filters-0')
+ expect(recentIssueRow).toHaveTextContent('Issue severity')
+ await userEvent.click(recentIssueRow)
const valueEditor = (await screen.findByText('Enter value...')).closest('.Popover')
await waitFor(() => expect(valueEditor).toHaveClass('Popover--enter-active'))
diff --git a/products/error_tracking/frontend/components/IssueFilters/FilterGroup.tsx b/products/error_tracking/frontend/components/IssueFilters/FilterGroup.tsx
index e2beebe16557..263d42d774ea 100644
--- a/products/error_tracking/frontend/components/IssueFilters/FilterGroup.tsx
+++ b/products/error_tracking/frontend/components/IssueFilters/FilterGroup.tsx
@@ -3,15 +3,24 @@ import { useState } from 'react'
import type { ReactNode } from 'react'
import { IconFilter } from '@posthog/icons'
+import { Popover } from '@posthog/lemon-ui'
-import { TaxonomicFilterHeadless } from 'lib/components/TaxonomicFilter/headless'
-import { TaxonomicFilterMenu } from 'lib/components/TaxonomicFilter/menu/TaxonomicFilterMenu'
+import { TaxonomicFilter } from 'lib/components/TaxonomicFilter/TaxonomicFilter'
import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'
import UniversalFilters from 'lib/components/UniversalFilters/UniversalFilters'
import { universalFiltersLogic } from 'lib/components/UniversalFilters/universalFiltersLogic'
import { isUniversalGroupFilterLike } from 'lib/components/UniversalFilters/utils'
import { useOnMountEffect } from 'lib/hooks/useOnMountEffect'
-import { Button, ToggleGroup, ToggleGroupItem } from 'lib/ui/quill'
+import {
+ Button,
+ DropdownMenu,
+ DropdownMenuContent,
+ DropdownMenuItem,
+ DropdownMenuSeparator,
+ DropdownMenuTrigger,
+ ToggleGroup,
+ ToggleGroupItem,
+} from 'lib/ui/quill'
import { FilterLogicalOperator, PropertyFilterType, UniversalFiltersGroup, UniversalFiltersGroupValue } from '~/types'
@@ -172,41 +181,57 @@ const FilterPicker = ({
menuItems?: ReactNode
}): JSX.Element => {
const { addGroupFilter } = useActions(universalFiltersLogic)
- const [openRequest, setOpenRequest] = useState(0)
+ const [pickerOpen, setPickerOpen] = useState(false)
+ const [pickerAnchor, setPickerAnchor] = useState<HTMLSpanElement | null>(null)
+
+ const buttonProps = {
+ variant: iconOnly ? 'default' : 'outline',
+ size: iconOnly ? 'icon-sm' : 'default',
+ 'aria-label': iconOnly ? 'Add filter' : undefined,
+ title: iconOnly ? 'Add filter' : undefined,
+ children: (
+ <>
+ <IconFilter />
+ {!iconOnly && 'Add filter'}
+ </>
+ ),
+ } as const
return (
- <TaxonomicFilterHeadless.Root
- className="contents"
- bindRootProps={false}
- groupType={taxonomicGroupTypes[0] ?? TaxonomicFilterGroupType.ErrorTrackingProperties}
- taxonomicGroupTypes={taxonomicGroupTypes}
- eventNames={ERROR_TRACKING_EVENT_NAMES}
- onChange={(group, value, item) => addGroupFilter(group, value, item)}
- >
- <TaxonomicFilterMenu
- key={openRequest}
- defaultOpen={openRequest > 0}
- defaultOpenState="combobox"
- menuItems={menuItems}
- trigger={({ open }) => (
- <Button
- variant={iconOnly ? 'default' : 'outline'}
- size={iconOnly ? 'icon-sm' : 'default'}
- aria-label={iconOnly ? 'Add filter' : undefined}
- title={iconOnly ? 'Add filter' : undefined}
- aria-expanded={open}
- onClick={() => {
- if (!open && !menuItems) {
- setOpenRequest((request) => request + 1)
- }
- }}
- >
- <IconFilter />
- {!iconOnly && 'Add filter'}
- </Button>
+ <>
+ <span ref={setPickerAnchor} className="inline-flex">
+ {menuItems ? (
+ <DropdownMenu>
+ <DropdownMenuTrigger render={<Button {...buttonProps} />} />
+ <DropdownMenuContent align="end">
+ <DropdownMenuItem onClick={() => setPickerOpen(true)}>Add filter</DropdownMenuItem>
+ <DropdownMenuSeparator />
+ {menuItems}
+ </DropdownMenuContent>
+ </DropdownMenu>
+ ) : (
+ <Button {...buttonProps} aria-expanded={pickerOpen} onClick={() => setPickerOpen(!pickerOpen)} />
)}
+ </span>
+ {/* Beside the trigger, not around it: a LemonDropdown around a quill menu stops the menu opening. */}
+ <Popover
+ referenceElement={pickerAnchor}
+ visible={pickerOpen}
+ onClickOutside={() => setPickerOpen(false)}
+ overlay={
+ <TaxonomicFilter
+ groupType={taxonomicGroupTypes[0] ?? TaxonomicFilterGroupType.ErrorTrackingProperties}
+ taxonomicGroupTypes={taxonomicGroupTypes}
+ eventNames={ERROR_TRACKING_EVENT_NAMES}
+ onChange={(group, value, item) => {
+ addGroupFilter(group, value, item)
+ setPickerOpen(false)
+ }}
+ enableKeywordShortcuts
+ />
+ }
/>
- </TaxonomicFilterHeadless.Root>
+ </>
)
}