:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(tasks): treat an unresolvable desktop access override flag as no override (#122606)
Alessandro Pogliaghi311981318d7e
diff --git a/products/tasks/backend/access.py b/products/tasks/backend/access.pyindex 566ccdf50fdf..48d184f2a424 100644--- a/products/tasks/backend/access.py+++ b/products/tasks/backend/access.py@@ -12,7 +12,11 @@ from posthog.models.user import Userfrom posthog.ph_client import feature_enabled_or_false, get_feature_flag_or_nonefrom products.tasks.backend.facade.contracts import DesktopAccessReason-from products.tasks.backend.metrics import DesktopAccessOutcome, observe_desktop_access_decision+from products.tasks.backend.metrics import (+ DesktopAccessOutcome,+ observe_desktop_access_decision,+ observe_desktop_access_flag_unresolved,+)from ee.billing.billing_manager import (BillingManager,@@ -89,7 +93,7 @@ def _signed_up_after_cutoff(user: User) -> bool:return cutoff is not None and user.date_joined >= cutoff-def _flag_enabled(flag_key: str, user: User, organization: "Organization") -> bool:+def _resolve_flag(flag_key: str, user: User, organization: "Organization") -> bool | None:organization_id = str(organization.id)enabled = get_feature_flag_or_none(flag_key,@@ -99,11 +103,29 @@ def _flag_enabled(flag_key: str, user: User, organization: "Organization") -> boonly_evaluate_locally=False,send_feature_flag_events=False,)- if not isinstance(enabled, bool):+ return enabled if isinstance(enabled, bool) else None+++def _flag_enabled(flag_key: str, user: User, organization: "Organization") -> bool:+ enabled = _resolve_flag(flag_key, user, organization)+ if enabled is None:raise DesktopAccessResolutionError(f"Could not evaluate the {flag_key} flag")return enabled+def _override_enabled(user: User, organization: "Organization") -> bool:+ enabled = _resolve_flag(DESKTOP_ACCESS_OVERRIDE_FLAG, user, organization)+ if enabled is None:+ logger.warning(+ "desktop_access_override_unresolved",+ flag_key=DESKTOP_ACCESS_OVERRIDE_FLAG,+ organization_id=str(organization.id),+ )+ observe_desktop_access_flag_unresolved(flag=DESKTOP_ACCESS_OVERRIDE_FLAG)+ return False+ return enabled++def _funding_decision(user: User, organization: "Organization") -> DesktopAccessDecision:funding_status = _get_funding_status(user, organization)if funding_status.startup_program_label is not None:@@ -144,7 +166,7 @@ def get_desktop_access_decision(return DesktopAccessDecision.ALLOWEDtry:- if _flag_enabled(DESKTOP_ACCESS_OVERRIDE_FLAG, user, organization):+ if _override_enabled(user, organization):observe_desktop_access_decision(outcome="override")return DesktopAccessDecision.ALLOWED# The gate flag is evaluated only for users past the cutoff, so existing users pay no extra flag call.diff --git a/products/tasks/backend/metrics.py b/products/tasks/backend/metrics.pyindex 8e586a22ec5f..38fce6fe0775 100644--- a/products/tasks/backend/metrics.py+++ b/products/tasks/backend/metrics.py@@ -449,6 +449,12 @@ DESKTOP_ACCESS_DECISIONS_TOTAL = Counter(labelnames=["outcome"],)+DESKTOP_ACCESS_FLAG_UNRESOLVED_TOTAL = Counter(+ "posthog_tasks_desktop_access_flag_unresolved_total",+ "PostHog Desktop access flag evaluations that returned no boolean value",+ labelnames=["flag"],+)+def observe_compute_quota_check(outcome: ComputeQuotaOutcome) -> None:COMPUTE_QUOTA_CHECK_TOTAL.labels(outcome=outcome).inc()@@ -802,3 +808,7 @@ def observe_code_usage_gate_check(*, outcome: CodeUsageGateOutcome) -> None:def observe_desktop_access_decision(*, outcome: DesktopAccessOutcome) -> None:DESKTOP_ACCESS_DECISIONS_TOTAL.labels(outcome=outcome).inc()+++def observe_desktop_access_flag_unresolved(*, flag: str) -> None:+ DESKTOP_ACCESS_FLAG_UNRESOLVED_TOTAL.labels(flag=flag).inc()diff --git a/products/tasks/backend/tests/test_desktop_access.py b/products/tasks/backend/tests/test_desktop_access.pyindex e5cf28567853..703122611109 100644--- a/products/tasks/backend/tests/test_desktop_access.py+++ b/products/tasks/backend/tests/test_desktop_access.py@@ -221,13 +221,43 @@ class TestDesktopAccessPolicy(APIBaseTest):self.assertEqual(response.status_code, status.HTTP_503_SERVICE_UNAVAILABLE)self.assertEqual(response.data["code"], "desktop_access_unavailable")- @parameterized.expand([(None,), ("control",), ("false",)])- @override_settings(DESKTOP_SIGNUP_CUTOFF="2000-01-01T00:00:00+00:00")- def test_indeterminate_flags_fail_closed(self, flag_value) -> None:- for flag_values in ([flag_value], [False, flag_value]):- self.mock_feature_flag.side_effect = flag_values- with self.assertRaises(DesktopAccessResolutionError):- get_desktop_access_decision(self.user, self.organization)+ @parameterized.expand(+ [+ ("override_none", None, False, None, False),+ ("override_control", "control", False, None, False),+ ("override_false_string", "false", False, None, False),+ ("override_none_funding_fails", None, False, DesktopAccessResolutionError("unavailable"), True),+ ("gate_none_after_cutoff", False, True, None, True),+ ]+ )+ @patch("products.tasks.backend.access._get_funding_status")+ def test_indeterminate_flags(+ self,+ _name: str,+ override_value: object,+ signed_up_after_cutoff: bool,+ funding_error: DesktopAccessResolutionError | None,+ expected_raise: bool,+ mock_funding,+ ) -> None:+ if funding_error is not None:+ mock_funding.side_effect = funding_error+ else:+ mock_funding.return_value = OrganizationFundingStatus(+ startup_program_label=None, prepaid_credit_state=PrepaidCreditState.NONE+ )+ self.mock_feature_flag.side_effect = [override_value, None]+ cutoff = "2000-01-01T00:00:00+00:00" if signed_up_after_cutoff else ""++ with override_settings(DESKTOP_SIGNUP_CUTOFF=cutoff):+ if expected_raise:+ with self.assertRaises(DesktopAccessResolutionError):+ get_desktop_access_decision(self.user, self.organization)+ return+ decision = get_desktop_access_decision(self.user, self.organization)++ self.assertTrue(decision.allowed)+ mock_funding.assert_called_once()@patch("products.tasks.backend.access._get_funding_status",