Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(homepage): defer conversation UI until after home renders (#121198)

Paul D'Ambra32864e4b0133
diff --git a/frontend/src/scenes/project-homepage/ai-first/AiFirstHomepage.test.tsx b/frontend/src/scenes/project-homepage/ai-first/AiFirstHomepage.test.tsx
new file mode 100644
index 000000000000..afdbd283f05c
--- /dev/null
+++ b/frontend/src/scenes/project-homepage/ai-first/AiFirstHomepage.test.tsx
@@ -0,0 +1,89 @@
+import '@testing-library/jest-dom'
+
+import { act, cleanup, render, screen } from '@testing-library/react'
+import { ReactNode, Suspense } from 'react'
+
+import { SceneRenderedMarkContext } from 'scenes/SceneContentFallback'
+
+import { AiFirstHomepage } from './AiFirstHomepage'
+
+let mockContentReady: boolean
+let mockPendingContent: Promise<void>
+let releaseContent: () => void
+let pendingContentHolds: number
+
+jest.mock('kea', () => ({
+ BindLogic: ({ children }: { children: ReactNode }) => children,
+ useValues: () => ({
+ mode: 'ai',
+ animationPhase: 'content',
+ query: '',
+ threadStarted: true,
+ conversationId: 'example-conversation',
+ }),
+}))
+
+jest.mock('./aiFirstHomepageLogic', () => ({ aiFirstHomepageLogic: {} }))
+jest.mock('scenes/max/maxLogic', () => ({ maxLogic: () => ({}) }))
+jest.mock('lib/components/Search/Search', () => ({
+ Search: { Root: ({ children }: { children: ReactNode }) => <div>{children}</div> },
+}))
+jest.mock('~/layout/scenes/components/SceneBreadcrumbs', () => ({ SceneBreadcrumbBackButton: () => null }))
+jest.mock('./HomepageInput', () => ({ HomepageInput: () => <input data-attr="home-input" /> }))
+jest.mock('scenes/max/components/AiFirstMaxInstance', () => ({
+ ChatHeader: () => {
+ if (!mockContentReady) {
+ throw mockPendingContent
+ }
+ return <div data-attr="header" />
+ },
+}))
+jest.mock('./HomepageThread', () => ({
+ HomepageThread: () => <div data-attr="thread" />,
+}))
+
+describe('AiFirstHomepage', () => {
+ beforeEach(() => {
+ mockContentReady = false
+ pendingContentHolds = 0
+ mockPendingContent = new Promise<void>((resolve) => {
+ releaseContent = resolve
+ })
+ })
+
+ afterEach(cleanup)
+
+ it('keeps the input visible while the header loads', async () => {
+ render(
+ <SceneRenderedMarkContext.Provider
+ value={{
+ holdUntilContent: () => {
+ pendingContentHolds++
+ return () => {
+ pendingContentHolds--
+ }
+ },
+ sceneCommitted: jest.fn(),
+ sceneUncommitted: jest.fn(),
+ }}
+ >
+ <Suspense fallback={<div data-attr="home-loading" />}>
+ <AiFirstHomepage />
+ </Suspense>
+ </SceneRenderedMarkContext.Provider>
+ )
+
+ expect(screen.getByTestId('home-input')).toBeVisible()
+ expect(screen.queryByTestId('home-loading')).not.toBeInTheDocument()
+ expect(screen.queryByTestId('header')).not.toBeInTheDocument()
+ expect(pendingContentHolds).toBeGreaterThan(0)
+
+ await act(async () => {
+ mockContentReady = true
+ releaseContent()
+ })
+
+ expect(await screen.findByTestId('header')).toBeVisible()
+ expect(pendingContentHolds).toBe(0)
+ })
+})
diff --git a/frontend/src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx b/frontend/src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
index 5d07bc050b91..aa85419e3c92 100644
--- a/frontend/src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
+++ b/frontend/src/scenes/project-homepage/ai-first/AiFirstHomepage.tsx
@@ -1,9 +1,13 @@
import { BindLogic, useValues } from 'kea'
+import { Suspense, useEffect } from 'react'
import { Search } from 'lib/components/Search/Search'
+import { LemonSkeleton } from 'lib/lemon-ui/LemonSkeleton'
+import { runWhenIdle } from 'lib/utils/async'
import { cn } from 'lib/utils/css-classes'
-import { ChatHeader } from 'scenes/max/components/AiFirstMaxInstance'
+import { lazyWithRetry } from 'lib/utils/retryImport'
import { maxLogic } from 'scenes/max/maxLogic'
+import { SceneContentFallback } from 'scenes/SceneContentFallback'
import { urls } from 'scenes/urls'
import { SceneBreadcrumbBackButton } from '~/layout/scenes/components/SceneBreadcrumbs'
@@ -14,6 +18,10 @@ import { HomepageInput } from './HomepageInput'
import { HomepageSearchResults } from './HomepageSearchResults'
import { HomepageThread } from './HomepageThread'
+const ChatHeader = lazyWithRetry(() =>
+ import('scenes/max/components/AiFirstMaxInstance').then((m) => ({ default: m.ChatHeader }))
+)
+
const PHASE_ORDER = ['idle', 'moving', 'separator', 'content'] as const
function phaseAtLeast(current: string, target: string): boolean {
@@ -24,6 +32,14 @@ export function AiFirstHomepage(): JSX.Element {
const { mode, animationPhase, query, threadStarted } = useValues(aiFirstHomepageLogic)
const { conversationId } = useValues(maxLogic({ panelId: HOMEPAGE_TAB_ID }))
+ useEffect(
+ () =>
+ runWhenIdle(() => {
+ void import('scenes/max/components/AiFirstMaxInstance').catch(() => {})
+ }),
+ []
+ )
+
const isIdle = mode === 'idle'
const isAi = mode === 'ai'
const isSearch = mode === 'search'
@@ -50,16 +66,24 @@ export function AiFirstHomepage(): JSX.Element {
)}
>
{isAi && (
- <ChatHeader conversationId={conversationId} hideBorder>
- <SceneBreadcrumbBackButton
- forceBackTo={{
- name: 'Project homepage',
- path: urls.projectHomepage(),
- type: 'projectTree',
- key: 'projectHomepage',
- }}
- />
- </ChatHeader>
+ <Suspense
+ fallback={
+ <SceneContentFallback>
+ <LemonSkeleton className="h-10 w-full" />
+ </SceneContentFallback>
+ }
+ >
+ <ChatHeader conversationId={conversationId} hideBorder>
+ <SceneBreadcrumbBackButton
+ forceBackTo={{
+ name: 'Project homepage',
+ path: urls.projectHomepage(),
+ type: 'projectTree',
+ key: 'projectHomepage',
+ }}
+ />
+ </ChatHeader>
+ </Suspense>
)}
</div>
diff --git a/frontend/src/scenes/project-homepage/ai-first/HomepageThread.test.tsx b/frontend/src/scenes/project-homepage/ai-first/HomepageThread.test.tsx
index ad6aca09cd13..de5a1b522345 100644
--- a/frontend/src/scenes/project-homepage/ai-first/HomepageThread.test.tsx
+++ b/frontend/src/scenes/project-homepage/ai-first/HomepageThread.test.tsx
@@ -1,8 +1,9 @@
import { act, cleanup, render } from '@testing-library/react'
import { Provider } from 'kea'
+import { Suspense } from 'react'
import { maxLogic } from 'scenes/max/maxLogic'
-import { maxMocks } from 'scenes/max/testUtils'
+import { MOCK_CONVERSATION, maxMocks } from 'scenes/max/testUtils'
import { useMocks } from '~/mocks/jest'
import { initKeaTests } from '~/test/init'
@@ -11,8 +12,17 @@ import { aiFirstHomepageLogic } from './aiFirstHomepageLogic'
import { HOMEPAGE_TAB_ID } from './constants'
import { HomepageThread } from './HomepageThread'
+let mockThreadLoading = false
+let mockPendingThread: Promise<void>
+let resolveThread: () => void
+
jest.mock('scenes/max/Thread', () => ({
- Thread: () => <div data-attr="mock-thread" />,
+ Thread: () => {
+ if (mockThreadLoading) {
+ throw mockPendingThread
+ }
+ return <div data-attr="mock-thread" />
+ },
}))
describe('HomepageThread', () => {
@@ -22,6 +32,10 @@ describe('HomepageThread', () => {
let maxLogicInstance: ReturnType<typeof maxLogic.build>
beforeEach(() => {
+ mockThreadLoading = false
+ mockPendingThread = new Promise<void>((resolve) => {
+ resolveThread = resolve
+ })
useMocks({
...maxMocks,
get: {
@@ -52,16 +66,21 @@ describe('HomepageThread', () => {
// The send waits 100 ms so the thread logic is mounted first. Without cleanup on the effect, a
// navigation away inside that window still starts a conversation the user has already left.
it.each([
- ['sends the initial query once the delay passes', false, 1],
- ['drops the send when the thread unmounts first', true, 0],
- ])('%s', (_case, unmountBeforeSend, expectedCalls) => {
+ ['sends the initial query once the delay passes', false, false, 1],
+ ['drops the send when the thread unmounts first', false, true, 0],
+ ['sends while the thread UI loads', true, false, 1],
+ ['drops the pending send when the loading thread unmounts', true, true, 0],
+ ])('%s', (_case, threadLoading, unmountBeforeSend, expectedCalls) => {
+ mockThreadLoading = threadLoading
const askMax = jest
.spyOn(maxLogicInstance.actions, 'askMax')
.mockImplementation((prompt) => ({ prompt, addToThread: true, uiContext: undefined }))
const { unmount } = render(
<Provider>
- <HomepageThread />
+ <Suspense fallback={null}>
+ <HomepageThread />
+ </Suspense>
</Provider>
)
if (unmountBeforeSend) {
@@ -73,4 +92,35 @@ describe('HomepageThread', () => {
expect(askMax).toHaveBeenCalledTimes(expectedCalls)
})
+
+ it.each([0, 200])('scrolls a restored conversation after the thread UI loads in %i ms', async (loadDelay) => {
+ mockThreadLoading = true
+ homepageLogic.actions.setQuery('')
+ maxLogicInstance.actions.prependOrReplaceConversation({ ...MOCK_CONVERSATION, messages: [] })
+ maxLogicInstance.actions.setConversationId(MOCK_CONVERSATION.id)
+
+ const { container } = render(
+ <Provider>
+ <HomepageThread />
+ </Provider>
+ )
+ const scrollable = container.querySelector<HTMLElement>('[data-attr="max-scrollable"]')!
+ const scrollTo = jest.fn()
+ scrollable.scrollTo = scrollTo
+ Object.defineProperty(scrollable, 'scrollHeight', { get: () => (mockThreadLoading ? 0 : 1000) })
+
+ act(() => {
+ jest.advanceTimersByTime(loadDelay)
+ })
+ scrollTo.mockClear()
+ await act(async () => {
+ mockThreadLoading = false
+ resolveThread()
+ })
+ act(() => {
+ jest.advanceTimersByTime(100)
+ })
+
+ expect(scrollTo).toHaveBeenCalledWith({ top: 1000 })
+ })
})
diff --git a/frontend/src/scenes/project-homepage/ai-first/HomepageThread.tsx b/frontend/src/scenes/project-homepage/ai-first/HomepageThread.tsx
index 07def89730f3..178fa5b78851 100644
--- a/frontend/src/scenes/project-homepage/ai-first/HomepageThread.tsx
+++ b/frontend/src/scenes/project-homepage/ai-first/HomepageThread.tsx
@@ -1,16 +1,20 @@
import { BindLogic, useActions, useValues } from 'kea'
-import { useEffect, useRef } from 'react'
+import { Suspense, useEffect, useRef } from 'react'
import { ScrollableShadows } from 'lib/components/ScrollableShadows/ScrollableShadows'
+import { LemonSkeleton } from 'lib/lemon-ui/LemonSkeleton'
import { uuid } from 'lib/utils/dom'
+import { lazyWithRetry } from 'lib/utils/retryImport'
import { ThreadAutoScroller } from 'scenes/max/components/ThreadAutoScroller'
import { maxLogic } from 'scenes/max/maxLogic'
import { MaxThreadLogicProps, maxThreadLogic } from 'scenes/max/maxThreadLogic'
-import { Thread } from 'scenes/max/Thread'
+import { SceneContentFallback } from 'scenes/SceneContentFallback'
import { aiFirstHomepageLogic } from './aiFirstHomepageLogic'
import { HOMEPAGE_TAB_ID } from './constants'
+const Thread = lazyWithRetry(() => import('scenes/max/Thread').then((m) => ({ default: m.Thread })))
+
export function HomepageThread(): JSX.Element {
const { query } = useValues(aiFirstHomepageLogic)
const { threadLogicKey, conversation } = useValues(maxLogic({ panelId: HOMEPAGE_TAB_ID }))
@@ -52,9 +56,17 @@ export function HomepageThread(): JSX.Element {
<BindLogic logic={maxLogic} props={{ panelId: HOMEPAGE_TAB_ID }}>
<BindLogic logic={maxThreadLogic} props={threadProps}>
<ScrollableShadows direction="vertical" styledScrollbars className="grow min-h-0" scrollRef={scrollRef}>
- <ThreadAutoScroller>
- <Thread className="p-3" />
- </ThreadAutoScroller>
+ <Suspense
+ fallback={
+ <SceneContentFallback>
+ <LemonSkeleton className="h-24 w-full" />
+ </SceneContentFallback>
+ }
+ >
+ <ThreadAutoScroller>
+ <Thread className="p-3" />
+ </ThreadAutoScroller>
+ </Suspense>
</ScrollableShadows>
</BindLogic>
</BindLogic>