:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(data-modeling): check view edit access on node write actions (#123506)
Daniel RC35eaa578d351
diff --git a/products/data_modeling/backend/presentation/views/edge.py b/products/data_modeling/backend/presentation/views/edge.pyindex 4b2ef1b49a26..669a0e191e6d 100644--- a/products/data_modeling/backend/presentation/views/edge.py+++ b/products/data_modeling/backend/presentation/views/edge.py@@ -1,4 +1,4 @@-from typing import Any+from typing import Any, castfrom rest_framework import mixins, serializers, viewsets@@ -7,7 +7,11 @@ from posthog.api.routing import TeamAndOrgViewSetMixinfrom products.data_modeling.backend.facade.api import delete_orphaned_table_nodesfrom products.data_modeling.backend.facade.models import Edge, NodeType-from products.data_modeling.backend.presentation.views.metric_visibility import DELETE_DENIED, MetricNodeVisibilityMixin+from products.data_modeling.backend.presentation.views.metric_visibility import (+ DELETE_DENIED,+ EDIT_DENIED,+ MetricNodeVisibilityMixin,+)_METRIC_EDGE_REFUSAL = "Edges that connect a metric are maintained by the data catalog."@@ -71,7 +75,7 @@ class EdgeViewSet(viewsets.GenericViewSet,):scope_object = "INTERNAL"- queryset = Edge.objects.select_related("dag", "target__saved_query").all()+ queryset = Edge.objects.select_related("dag", "source__saved_query", "target__saved_query").all()serializer_class = EdgeSerializerpagination_class = EdgePaginationordering = "-created_at"@@ -82,8 +86,15 @@ class EdgeViewSet(def get_serializer_class(self) -> type[serializers.Serializer]:return EdgeSummarySerializer if self.action == "list" else EdgeSerializer+ def perform_update(self, serializer: serializers.BaseSerializer) -> None:+ self._require_warehouse_access(level="editor", message=EDIT_DENIED)+ edge = cast(Edge, serializer.instance)+ self._require_view_edit_access(edge.source.saved_query, edge.target.saved_query)+ serializer.save()+def perform_destroy(self, instance: Edge) -> None:self._require_warehouse_access(level="editor", message=DELETE_DENIED)+ self._require_view_edit_access(instance.source.saved_query, instance.target.saved_query)if instance.target.belongs_to_managed_viewset:raise serializers.ValidationError("Edges into views PostHog manages cannot be deleted.")if _connects_a_metric(instance):diff --git a/products/data_modeling/backend/presentation/views/metric_visibility.py b/products/data_modeling/backend/presentation/views/metric_visibility.pyindex 313c2bbb4d98..7cd00a8d8988 100644--- a/products/data_modeling/backend/presentation/views/metric_visibility.py+++ b/products/data_modeling/backend/presentation/views/metric_visibility.py@@ -11,8 +11,11 @@ if TYPE_CHECKING:from posthog.models.team import Teamfrom products.access_control.backend.facade.user_access_control import AccessControlLevel, UserAccessControl+ from products.data_modeling.backend.facade.models import DataWarehouseSavedQueryDELETE_DENIED = "Deleting data models requires data warehouse write access."+EDIT_DENIED = "Editing data models requires data warehouse write access."+VIEW_EDIT_DENIED = "You need edit access to this view."class MetricNodeVisibilityMixin:@@ -25,6 +28,15 @@ class MetricNodeVisibilityMixin:if not self.user_access_control.check_access_level_for_resource("warehouse_view", required_level=level):raise PermissionDenied(message)+ def _require_view_edit_access(self, *saved_queries: "DataWarehouseSavedQuery | None") -> None:+ """The resource check above passes a member who holds a deny rule on one view, so a write to a+ node or edge of that view also checks the view itself."""+ for saved_query in saved_queries:+ if saved_query is not None and not self.user_access_control.check_access_level_for_object(+ saved_query, "editor"+ ):+ raise PermissionDenied(VIEW_EDIT_DENIED)+def _metric_nodes_hidden(self) -> bool:return not self.user_access_control.check_access_level_for_resource("data_catalog", required_level="viewer")diff --git a/products/data_modeling/backend/presentation/views/node.py b/products/data_modeling/backend/presentation/views/node.pyindex d21040dc707c..62b3e95f3cf7 100644--- a/products/data_modeling/backend/presentation/views/node.py+++ b/products/data_modeling/backend/presentation/views/node.py@@ -35,7 +35,11 @@ from products.data_modeling.backend.facade.models import (NodeType,)from products.data_modeling.backend.presentation.views.edge import EdgeSerializer-from products.data_modeling.backend.presentation.views.metric_visibility import DELETE_DENIED, MetricNodeVisibilityMixin+from products.data_modeling.backend.presentation.views.metric_visibility import (+ DELETE_DENIED,+ EDIT_DENIED,+ MetricNodeVisibilityMixin,+)from products.warehouse_sources.backend.facade.models import sync_frequency_interval_to_sync_frequency@@ -366,8 +370,14 @@ class NodeViewSet(def get_serializer_context(self) -> dict[str, Any]:return {**super().get_serializer_context(), "hidden_node_types": self._hidden_node_types()}+ def perform_update(self, serializer: serializers.BaseSerializer) -> None:+ self._require_warehouse_access(level="editor", message=EDIT_DENIED)+ self._require_view_edit_access(cast(Node, serializer.instance).saved_query)+ serializer.save()+def perform_destroy(self, instance: Node) -> None:self._require_warehouse_access(level="editor", message=DELETE_DENIED)+ self._require_view_edit_access(instance.saved_query)if instance.belongs_to_managed_viewset:raise serializers.ValidationError("Nodes of views PostHog manages cannot be deleted.")if _feeds_a_managed_view(instance):@@ -564,9 +574,10 @@ class NodeViewSet(status=status.HTTP_400_BAD_REQUEST,)- # Publishes the same rows as a DAG run of this node, so it needs the same check as `run`.+ # Publishes the same rows as a DAG run of this node, so it needs the same checks as `run`.# A DB constraint guarantees non-table nodes have a saved query, so the None branch never# skips the check for a real node; it exists because the FK is typed as nullable.+ self._require_view_edit_access(node.saved_query)if node.saved_query is not None:assert_user_can_read_query(node.saved_query.query, self.team_id, cast(User, req.user))@@ -586,6 +597,9 @@ class NodeViewSet(# Resuming puts a model back on the materialization schedule, so it needs write access.self._require_warehouse_access(level="editor", message="Resuming a node requires data warehouse write access.")- resumed = unsuspend_nodes([self.get_object()], by="api")+ node = self.get_object()+ self._require_view_edit_access(node.saved_query)++ resumed = unsuspend_nodes([node], by="api")return response.Response({"resumed": bool(resumed)}, status=status.HTTP_200_OK)diff --git a/products/data_modeling/backend/tests/api/test_node_api.py b/products/data_modeling/backend/tests/api/test_node_api.pyindex cddcf65a4783..7251e6e67c14 100644--- a/products/data_modeling/backend/tests/api/test_node_api.py+++ b/products/data_modeling/backend/tests/api/test_node_api.py@@ -1047,6 +1047,40 @@ class TestNodeAccessControl(WarehouseAccessControlTestMixin):type(target).objects.filter(pk=target.pk).exists(), expected_status == status.HTTP_403_FORBIDDEN)+ @parameterized.expand(+ [("update_node",), ("update_edge",), ("delete_node",), ("delete_edge",), ("resume",), ("materialize",)]+ )+ @patch("products.data_modeling.backend.logic.node_materialization.sync_connect")+ def test_write_actions_refuse_a_member_denied_the_view(self, action, mock_sync_connect):+ source = Node.objects.create(team=self.team, dag=self.dag, name="events", type=NodeType.TABLE)+ edge = Edge.objects.create(team=self.team, dag=self.dag, source=source, target=self.node)+ self._create_access_control(self.editor_user, access_level="editor")+ self._create_access_control(+ self.editor_user, resource="warehouse_view", resource_id=str(self.node.saved_query_id), access_level="none"+ )+ self.client.force_login(self.editor_user)+ node_url = f"{self._list_url()}{self.node.id}/"+ edge_url = f"/api/environments/{self.team.id}/data_modeling_edges/{edge.id}/"++ if action == "update_node":+ response = self.client.patch(node_url, {"description": "changed"}, format="json")+ elif action == "update_edge":+ response = self.client.patch(edge_url, {"properties": {"changed": True}}, format="json")+ elif action == "delete_node":+ response = self.client.delete(node_url)+ elif action == "delete_edge":+ response = self.client.delete(edge_url)+ else:+ response = self.client.post(f"{node_url}{action}/")++ self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)+ edge.refresh_from_db()+ self.assertEqual(edge.properties, {})+ self.node.refresh_from_db()+ self.assertNotEqual(self.node.description, "changed")+ self.assertNotEqual(suspension_state(self.node), {})+ mock_sync_connect.assert_not_called()+@parameterized.expand([("list_granted", False, "viewer", status.HTTP_200_OK),