Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(tasks): use bounded workflow labels for sandbox tags (#120380)

Alessandro Pogliaghi3c352f321168
diff --git a/docs/internal/sandboxes-setup-guide.md b/docs/internal/sandboxes-setup-guide.md
index a4ac2b76e4a5..04e3a1718a13 100644
--- a/docs/internal/sandboxes-setup-guide.md
+++ b/docs/internal/sandboxes-setup-guide.md
@@ -469,6 +469,10 @@ Each name above is a class attribute on `ModalSandbox`, and the `MODAL_DOCKER` a
override all four (`posthog-sandbox-modal-docker-*`, `posthog-sandbox-evals`), so local and eval runs never land
in a production app. A new app name has to be a class attribute for that to keep holding.
+Task sandboxes carry `task_id` and `task_run_id` tags for exact lookup, plus a readable `workflow_label`.
+The label keeps the workflow prefix, replaces characters outside `A-Z`, `a-z`, `0-9`, `_`, `.`, and `-` with dashes, and caps the result at 63 characters.
+Use `TaskRun.workflow_id` to recover the full Temporal workflow ID from the run.
+
### Sandbox templates
Staff can inspect the agent release pipeline at `/admin/tasks/task/infrastructure/` in each region.
diff --git a/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py b/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py
index 20f879fe16ea..560d096baa23 100644
--- a/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py
+++ b/products/tasks/backend/temporal/process_task/activities/provision_sandbox.py
@@ -1,3 +1,4 @@
+import re
import json
import shlex
import asyncio
@@ -669,13 +670,13 @@ def _build_sandbox_tags(
Tag values must be strings; None values are dropped so we don't emit empty tags.
Hogland also caps each tag at 64 characters and truncates on its side.
"""
+ workflow_prefix = (activity.info().workflow_id or "").removesuffix(f"-{ctx.task_id}-{ctx.run_id}")
tags: dict[str, str | int | None] = {
"task_id": ctx.task_id,
"task_run_id": ctx.run_id,
"origin_product": ctx.origin_product,
"team_id": ctx.team_id,
- # The running workflow's real id — a re-derived default would mislabel prefixed dispatches.
- "workflow_id": activity.info().workflow_id,
+ "workflow_label": re.sub(r"[^A-Za-z0-9_.-]", "-", workflow_prefix)[:63] if workflow_prefix else None,
"image_source": prepared.image_source,
"sandbox_runtime": "vm" if use_vm_sandbox else "gvisor",
}
diff --git a/products/tasks/backend/temporal/process_task/tests/test_provision_sandbox.py b/products/tasks/backend/temporal/process_task/tests/test_provision_sandbox.py
index fa20bdbaa823..848725898ad3 100644
--- a/products/tasks/backend/temporal/process_task/tests/test_provision_sandbox.py
+++ b/products/tasks/backend/temporal/process_task/tests/test_provision_sandbox.py
@@ -81,21 +81,43 @@ def _prepared(**overrides) -> PrepareSandboxForRepositoryOutput:
_WORKFLOW_ID = "review-pr:42:posthog/posthog:7-sandbox"
-def _build_tags(*args, **kwargs):
+def _build_tags(
+ ctx: TaskProcessingContext,
+ prepared: PrepareSandboxForRepositoryOutput,
+ use_vm_sandbox: bool,
+ *,
+ workflow_id: str | None = _WORKFLOW_ID,
+) -> dict[str, str]:
with patch(f"{_PROVISION}.activity") as mock_activity:
- mock_activity.info.return_value = MagicMock(workflow_id=_WORKFLOW_ID)
- return _build_sandbox_tags(*args, **kwargs)
+ mock_activity.info.return_value = MagicMock(workflow_id=workflow_id)
+ return _build_sandbox_tags(ctx, prepared, use_vm_sandbox)
-def test_build_sandbox_tags_includes_all_identifiers():
- tags = _build_tags(_context(), _prepared(), use_vm_sandbox=False)
+ ("workflow_prefix", "expected_label"),
+ [
+ ("task-processing", "task-processing"),
+ ("review-pr:42:example/demo:7:validation-c3", "review-pr-42-example-demo-7-validation-c3"),
+ ("scheduled.daily_report", "scheduled.daily_report"),
+ ("review-pr:42:example/" + "r" * 80 + ":7:validation", "review-pr-42-example-" + "r" * 42),
+ ],
+)
+def test_build_sandbox_tags_includes_all_identifiers(workflow_prefix: str, expected_label: str) -> None:
+ task_id = "00000000-0000-4000-8000-000000000001"
+ run_id = "00000000-0000-4000-8000-000000000002"
+ tags = _build_tags(
+ _context(task_id=task_id, run_id=run_id),
+ _prepared(),
+ use_vm_sandbox=False,
+ workflow_id=f"{workflow_prefix}-{task_id}-{run_id}",
+ )
assert tags == {
- "task_id": "task-123",
- "task_run_id": "run-456",
+ "task_id": task_id,
+ "task_run_id": run_id,
"origin_product": "error_tracking",
"team_id": "42",
- "workflow_id": _WORKFLOW_ID,
+ "workflow_label": expected_label,
"image_source": "base_image",
"sandbox_runtime": "gvisor",
}
@@ -116,9 +138,10 @@ def test_build_sandbox_tags_reflects_image_source(image_source):
def test_build_sandbox_tags_drops_none_values():
- tags = _build_tags(_context(origin_product=None), _prepared(), use_vm_sandbox=False)
+ tags = _build_tags(_context(origin_product=None), _prepared(), use_vm_sandbox=False, workflow_id=None)
assert "origin_product" not in tags
+ assert "workflow_label" not in tags
assert all(isinstance(value, str) for value in tags.values())