:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
chore(insights): move the insight editor into product analytics (#122555)
Thomas Obermüller3d5dbf31a96f
diff --git a/frontend/src/lib/components/Cards/InsightCard/DashboardInsightDisplayOptions.tsx b/frontend/src/lib/components/Cards/InsightCard/DashboardInsightDisplayOptions.tsxindex 4b6d7769cb2d..47d8c3525f2e 100644--- a/frontend/src/lib/components/Cards/InsightCard/DashboardInsightDisplayOptions.tsx+++ b/frontend/src/lib/components/Cards/InsightCard/DashboardInsightDisplayOptions.tsx@@ -5,8 +5,8 @@ import { LemonDivider } from 'lib/lemon-ui/LemonDivider'import { LemonDropdown } from 'lib/lemon-ui/LemonDropdown'import { LemonMenuItems, LemonMenuOverlay } from 'lib/lemon-ui/LemonMenu'-import { DisplayOptionTab } from '~/queries/nodes/InsightViz/insightDisplayOptions'-import { InsightDisplayOptionsPanel } from '~/queries/nodes/InsightViz/InsightDisplayOptionsPanel'+import { DisplayOptionTab } from 'products/product_analytics/frontend/insights/editor/insightDisplayOptions'+import { InsightDisplayOptionsPanel } from 'products/product_analytics/frontend/insights/editor/InsightDisplayOptionsPanel'// Items are computed in InsightMeta (always mounted) and passed down to avoid mounting// useInsightDisplayOptions lazily inside the More popover overlay, which triggers kea logicdiff --git a/frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsx b/frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsxindex 98f9370559f6..197e6eeaac18 100644--- a/frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsx+++ b/frontend/src/lib/components/Cards/InsightCard/InsightMeta.tsx@@ -59,7 +59,6 @@ import { QueryScanTileTooltip } from '~/queries/nodes/DataNode/QueryScanTileToolimport { WarehouseSyncWarningList } from '~/queries/nodes/DataNode/WarehouseSyncWarningList'import { outOfDateSyncWarnings } from '~/queries/nodes/DataNode/warehouseSyncWarnings'import { copyTableData, getInsightExportAdapter } from '~/queries/nodes/InsightViz/exportAdapters'-import { useInsightDisplayOptions } from '~/queries/nodes/InsightViz/insightDisplayOptions'import { Node, NodeKind, ProductKey } from '~/queries/schema/schema-general'import {isDataVisualizationNode,@@ -86,6 +85,7 @@ import {} from 'products/alerts/frontend/logic/insightAlertsLogic'import type { AlertType } from 'products/alerts/frontend/types'import { ManageAlertsModal } from 'products/alerts/frontend/views/ManageAlertsModal'+import { useInsightDisplayOptions } from 'products/product_analytics/frontend/insights/editor/insightDisplayOptions'import { DashboardInsightDisplayOptions } from './DashboardInsightDisplayOptions'import { useDashboardVisualizationOptions } from './dashboardVisualizationOptions'diff --git a/frontend/src/queries/nodes/InsightViz/InsightViz.tsx b/frontend/src/queries/nodes/InsightViz/InsightViz.tsxindex 5bf48e41cd9a..66d98db8fe80 100644--- a/frontend/src/queries/nodes/InsightViz/InsightViz.tsx+++ b/frontend/src/queries/nodes/InsightViz/InsightViz.tsx@@ -18,8 +18,9 @@ import { AnyResponseType, DashboardFilter, HogQLVariable, InsightVizNode } fromimport { QueryContext } from '~/queries/types'import { InsightLogicProps } from '~/types'+import { EditorFilters } from 'products/product_analytics/frontend/insights/editor/EditorFilters'+import { DataNodeLogicProps, dataNodeLogic } from '../DataNode/dataNodeLogic'-import { EditorFilters } from './EditorFilters'import { InsightVizDisplay } from './InsightVizDisplay'import { insightVizDataCollectionId, insightVizDataNodeKey } from './insightVizKeys'import { getCachedResults } from './utils'diff --git a/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx b/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsxindex 44fc749bf1db..cd3da4d2f730 100644--- a/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx+++ b/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx@@ -49,6 +49,7 @@ import {import { ChartAlternatives } from 'products/product_analytics/frontend/insights/chartAlternatives/ChartAlternatives'import { InsightDataChecks } from 'products/product_analytics/frontend/insights/dataChecks/InsightDataChecks'+import { InsightDisplayConfig } from 'products/product_analytics/frontend/insights/editor/InsightDisplayConfig'import { Funnel } from 'products/product_analytics/frontend/insights/funnels/Funnel'import { FunnelCanvasLabel } from 'products/product_analytics/frontend/insights/funnels/FunnelCanvasLabel'import { funnelDataLogic } from 'products/product_analytics/frontend/insights/funnels/funnelDataLogic'@@ -65,7 +66,6 @@ import { BoxPlotResultsTable } from 'products/product_analytics/frontend/insightimport { TrendInsight } from 'products/product_analytics/frontend/insights/trends/Trends'import { FlagCallsRetentionNotice } from './FlagCallsRetentionNotice'-import { InsightDisplayConfig } from './InsightDisplayConfig'import { InsightResultMetadata } from './InsightResultMetadata'import { ResultCustomizationsModal } from './ResultCustomizationsModal'diff --git a/frontend/src/scenes/insights/filters/InsightDateFilter/index.ts b/frontend/src/scenes/insights/filters/InsightDateFilter/index.tsdeleted file mode 100644index 64227d89d647..000000000000--- a/frontend/src/scenes/insights/filters/InsightDateFilter/index.ts+++ /dev/null@@ -1 +0,0 @@-export * from './InsightDateFilter'diff --git a/products/product_analytics/AGENTS.md b/products/product_analytics/AGENTS.mdindex 94eb1c43ed7d..66950094d95e 100644--- a/products/product_analytics/AGENTS.md+++ b/products/product_analytics/AGENTS.md@@ -70,14 +70,17 @@ When adding another related resource, define its deletion and restore behavior eThese rules apply when you add or move a frontend file for this product.-New frontend code that only this product imports goes in `products/product_analytics/frontend/`.+Frontend code that belongs to this product goes in `products/product_analytics/frontend/`, also when core imports it.Do not put it in `frontend/src/scenes/insights/` or in another scene tree that the placement report maps to this product.`resultSeriesName` landed in `scenes/insights/utils/` although only product files import it, so the default still points at core.-A file in those scene trees stays in core while core or another product imports it.-Moving it would make core import the product.-Merge-queue lanes come from paths only, so the moved file would report only this product's lane while core still uses it.-The lazy scene loaders in `frontend/src/scenes/appScenes.ts` do not count: repoint the loader when its scene moves.+A file that another product also imports stays in core, for example `scenes/insights/filters/ActionFilter/`.+Products never import from each other, so a move would make that product import this one.++Core imports from this product are accepted.+The insight charts and the insight editor (`frontend/insights/editor/`) live here, and core's `InsightViz` and insight cards import them.+Merge-queue lanes come from paths only, so a change to such a file reports only this product's lane.+Master's post-merge run is the check for a conflict that this lets through.Read [the placement skill](../../.agents/skills/placing-product-frontend-code/SKILL.md) when you decide where a file goes.Its `scripts/scene_product_split.py` is the placement report: it maps each scene tree to its product and shows how far the tree has moved.diff --git a/frontend/src/queries/nodes/InsightViz/Breakdown.tsx b/products/product_analytics/frontend/insights/editor/Breakdown.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/Breakdown.tsxrename to products/product_analytics/frontend/insights/editor/Breakdown.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/DisplayOptions.tsx b/products/product_analytics/frontend/insights/editor/DisplayOptions.tsxsimilarity index 81%rename from frontend/src/queries/nodes/InsightViz/DisplayOptions.tsxrename to products/product_analytics/frontend/insights/editor/DisplayOptions.tsxindex 013efbbb4026..14e76100fa30 100644--- a/frontend/src/queries/nodes/InsightViz/DisplayOptions.tsx+++ b/products/product_analytics/frontend/insights/editor/DisplayOptions.tsx@@ -9,35 +9,35 @@ import { LemonCheckbox, LemonInput, Tooltip } from '@posthog/lemon-ui'import { SmoothingFilter } from 'lib/components/SmoothingFilter/SmoothingFilter'import { UnitPicker } from 'lib/components/UnitPicker/UnitPicker'import { DEFAULT_DECIMAL_PLACES } from 'lib/utils/numbers'-import { AnnotationsPicker } from 'scenes/insights/EditorFilters/AnnotationsPicker'-import { AxisLabelFilter } from 'scenes/insights/EditorFilters/AxisLabelFilter'-import { HideIncompleteConversionWindowPeriodsFilter } from 'scenes/insights/EditorFilters/HideIncompleteConversionWindowPeriodsFilter'-import { LegendOptionsFilter } from 'scenes/insights/EditorFilters/LegendOptionsFilter'-import { LineStylePicker } from 'scenes/insights/EditorFilters/LineStylePicker'-import {- MetricColorFilter,- MetricShowChangeFilter,- MetricSummaryFilter,-} from 'scenes/insights/EditorFilters/MetricFilters'-import { PercentStackViewFilter } from 'scenes/insights/EditorFilters/PercentStackViewFilter'-import { ResultCustomizationByPicker } from 'scenes/insights/EditorFilters/ResultCustomizationByPicker'-import { ScalePicker } from 'scenes/insights/EditorFilters/ScalePicker'-import { ShowAlertAnomalyPointsFilter } from 'scenes/insights/EditorFilters/ShowAlertAnomalyPointsFilter'-import { ShowAlertThresholdLinesFilter } from 'scenes/insights/EditorFilters/ShowAlertThresholdLinesFilter'-import { ShowLegendFilter } from 'scenes/insights/EditorFilters/ShowLegendFilter'-import { ShowMultipleYAxesFilter } from 'scenes/insights/EditorFilters/ShowMultipleYAxesFilter'-import { ShowPieTotalFilter } from 'scenes/insights/EditorFilters/ShowPieTotalFilter'-import { ShowTrendLinesFilter } from 'scenes/insights/EditorFilters/ShowTrendLinesFilter'-import { SliceNamesFilter } from 'scenes/insights/EditorFilters/SliceNamesFilter'-import { StackBreakdownFilter } from 'scenes/insights/EditorFilters/StackBreakdownFilter'-import { ValueOnSeriesFilter } from 'scenes/insights/EditorFilters/ValueOnSeriesFilter'-import { YAxisRangeFilter } from 'scenes/insights/EditorFilters/YAxisRangeFilter'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { isTrendsQuery } from '~/queries/utils'import { ChartDisplayType } from '~/types'+import { AnnotationsPicker } from 'products/product_analytics/frontend/insights/editor/filters/AnnotationsPicker'+import { AxisLabelFilter } from 'products/product_analytics/frontend/insights/editor/filters/AxisLabelFilter'+import { HideIncompleteConversionWindowPeriodsFilter } from 'products/product_analytics/frontend/insights/editor/filters/HideIncompleteConversionWindowPeriodsFilter'+import { LegendOptionsFilter } from 'products/product_analytics/frontend/insights/editor/filters/LegendOptionsFilter'+import { LineStylePicker } from 'products/product_analytics/frontend/insights/editor/filters/LineStylePicker'+import {+ MetricColorFilter,+ MetricShowChangeFilter,+ MetricSummaryFilter,+} from 'products/product_analytics/frontend/insights/editor/filters/MetricFilters'+import { PercentStackViewFilter } from 'products/product_analytics/frontend/insights/editor/filters/PercentStackViewFilter'+import { ResultCustomizationByPicker } from 'products/product_analytics/frontend/insights/editor/filters/ResultCustomizationByPicker'+import { ScalePicker } from 'products/product_analytics/frontend/insights/editor/filters/ScalePicker'+import { ShowAlertAnomalyPointsFilter } from 'products/product_analytics/frontend/insights/editor/filters/ShowAlertAnomalyPointsFilter'+import { ShowAlertThresholdLinesFilter } from 'products/product_analytics/frontend/insights/editor/filters/ShowAlertThresholdLinesFilter'+import { ShowLegendFilter } from 'products/product_analytics/frontend/insights/editor/filters/ShowLegendFilter'+import { ShowMultipleYAxesFilter } from 'products/product_analytics/frontend/insights/editor/filters/ShowMultipleYAxesFilter'+import { ShowPieTotalFilter } from 'products/product_analytics/frontend/insights/editor/filters/ShowPieTotalFilter'+import { ShowTrendLinesFilter } from 'products/product_analytics/frontend/insights/editor/filters/ShowTrendLinesFilter'+import { SliceNamesFilter } from 'products/product_analytics/frontend/insights/editor/filters/SliceNamesFilter'+import { StackBreakdownFilter } from 'products/product_analytics/frontend/insights/editor/filters/StackBreakdownFilter'+import { ValueOnSeriesFilter } from 'products/product_analytics/frontend/insights/editor/filters/ValueOnSeriesFilter'+import { YAxisRangeFilter } from 'products/product_analytics/frontend/insights/editor/filters/YAxisRangeFilter'import { LifecyclePercentagesFilter } from 'products/product_analytics/frontend/insights/lifecycle/filters/LifecyclePercentagesFilter'import { LifecycleStackingFilter } from 'products/product_analytics/frontend/insights/lifecycle/filters/LifecycleStackingFilter'import { RetentionCohortLabelStartIndexPicker } from 'products/product_analytics/frontend/insights/retention/filters/RetentionCohortLabelStartIndexPicker'diff --git a/frontend/src/queries/nodes/InsightViz/EditorFilterGroup.tsx b/products/product_analytics/frontend/insights/editor/EditorFilterGroup.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/EditorFilterGroup.tsxrename to products/product_analytics/frontend/insights/editor/EditorFilterGroup.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/EditorFilterGroupTile.tsx b/products/product_analytics/frontend/insights/editor/EditorFilterGroupTile.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/EditorFilterGroupTile.tsxrename to products/product_analytics/frontend/insights/editor/EditorFilterGroupTile.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/EditorFilterItems.tsx b/products/product_analytics/frontend/insights/editor/EditorFilterItems.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/EditorFilterItems.tsxrename to products/product_analytics/frontend/insights/editor/EditorFilterItems.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/EditorFilters.stories.tsx b/products/product_analytics/frontend/insights/editor/EditorFilters.stories.tsxsimilarity index 92%rename from frontend/src/queries/nodes/InsightViz/EditorFilters.stories.tsxrename to products/product_analytics/frontend/insights/editor/EditorFilters.stories.tsxindex 02cc03ea1311..b578b6d5f334 100644--- a/frontend/src/queries/nodes/InsightViz/EditorFilters.stories.tsx+++ b/products/product_analytics/frontend/insights/editor/EditorFilters.stories.tsx@@ -5,8 +5,7 @@ import { Meta, StoryObj } from '@storybook/react'import { createInsightStory } from 'scenes/insights/__mocks__/createInsightScene'import { mswDecorator } from '~/mocks/browser'--import __editorFiltersLongValue from '../../../mocks/fixtures/api/projects/team_id/insights/editorFiltersLongValue.json'+import __editorFiltersLongValue from '~/mocks/fixtures/api/projects/team_id/insights/editorFiltersLongValue.json'type Story = StoryObj<{}>const meta: Meta = {diff --git a/frontend/src/queries/nodes/InsightViz/EditorFilters.test.tsx b/products/product_analytics/frontend/insights/editor/EditorFilters.test.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/EditorFilters.test.tsxrename to products/product_analytics/frontend/insights/editor/EditorFilters.test.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/EditorFilters.tsx b/products/product_analytics/frontend/insights/editor/EditorFilters.tsxsimilarity index 97%rename from frontend/src/queries/nodes/InsightViz/EditorFilters.tsxrename to products/product_analytics/frontend/insights/editor/EditorFilters.tsxindex 5985e6789260..1c9f3801d69d 100644--- a/frontend/src/queries/nodes/InsightViz/EditorFilters.tsx+++ b/products/product_analytics/frontend/insights/editor/EditorFilters.tsx@@ -8,9 +8,6 @@ import { NON_BREAKDOWN_DISPLAY_TYPES } from 'lib/constants'import { retryImport } from 'lib/utils/retryImport'import { pluralize } from 'lib/utils/strings'import { ChunkLoadErrorBoundary } from 'scenes/ChunkLoadErrorBoundary'-import { GoalLines } from 'scenes/insights/EditorFilters/GoalLines'-import { PoeFilter } from 'scenes/insights/EditorFilters/PoeFilter'-import { SamplingDeprecationNotice } from 'scenes/insights/EditorFilters/SamplingDeprecationNotice'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { userLogic } from 'scenes/userLogic'@@ -26,6 +23,9 @@ import {PathType,} from '~/types'+import { GoalLines } from 'products/product_analytics/frontend/insights/editor/filters/GoalLines'+import { PoeFilter } from 'products/product_analytics/frontend/insights/editor/filters/PoeFilter'+import { SamplingDeprecationNotice } from 'products/product_analytics/frontend/insights/editor/filters/SamplingDeprecationNotice'import { FunnelAttribution } from 'products/product_analytics/frontend/insights/funnels/editor/FunnelAttributionFilter'import { FunnelsAdvanced } from 'products/product_analytics/frontend/insights/funnels/editor/FunnelsAdvanced'import { FunnelsQuerySteps } from 'products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps'@@ -57,7 +57,7 @@ import { TrendsSeries } from './TrendsSeries'// Only web analytics insights use these filters, and they pull in the web analytics logic and its schema validators.const WebAnalyticsEditorFilters = lazy(() =>retryImport(() =>- import('scenes/insights/EditorFilters/WebAnalyticsEditorFilters').then((m) => ({+ import('products/product_analytics/frontend/insights/editor/filters/WebAnalyticsEditorFilters').then((m) => ({default: m.WebAnalyticsEditorFilters,})))diff --git a/frontend/src/queries/nodes/InsightViz/EditorFiltersShell.test.ts b/products/product_analytics/frontend/insights/editor/EditorFiltersShell.test.tssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/EditorFiltersShell.test.tsrename to products/product_analytics/frontend/insights/editor/EditorFiltersShell.test.tsdiff --git a/frontend/src/queries/nodes/InsightViz/EditorFiltersShell.tsx b/products/product_analytics/frontend/insights/editor/EditorFiltersShell.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/EditorFiltersShell.tsxrename to products/product_analytics/frontend/insights/editor/EditorFiltersShell.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/GlobalAndOrFilters.tsx b/products/product_analytics/frontend/insights/editor/GlobalAndOrFilters.tsxsimilarity index 90%rename from frontend/src/queries/nodes/InsightViz/GlobalAndOrFilters.tsxrename to products/product_analytics/frontend/insights/editor/GlobalAndOrFilters.tsxindex fd5623fbc4c3..d10362e07ce9 100644--- a/frontend/src/queries/nodes/InsightViz/GlobalAndOrFilters.tsx+++ b/products/product_analytics/frontend/insights/editor/GlobalAndOrFilters.tsx@@ -3,16 +3,17 @@ import { useActions, useValues } from 'kea'import { getProjectEventExistence } from 'lib/utils/getAppContext'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'-import { getInsightPropertyFilterGroupTypes } from 'scenes/insights/utils/propertyTaxonomicGroupTypes'import { actionsModel } from '~/models/actionsModel'import { groupsModel } from '~/models/groupsModel'+import { getAllEventNames } from '~/queries/nodes/InsightViz/utils'import { ProductAnalyticsInsightQueryNode } from '~/queries/schema/schema-general'import { isActionsNode, isInsightQueryWithSeries } from '~/queries/utils'import { EditorFilterProps } from '~/types'+import { getInsightPropertyFilterGroupTypes } from 'products/product_analytics/frontend/insights/editor/propertyTaxonomicGroupTypes'+import { PropertyGroupFilters } from './PropertyGroupFilters/PropertyGroupFilters'-import { getAllEventNames } from './utils'export function GlobalAndOrFilters({ insightProps }: EditorFilterProps): JSX.Element {const { groupsTaxonomicTypes } = useValues(groupsModel)diff --git a/frontend/src/queries/nodes/InsightViz/InsightDisplayConfig.test.tsx b/products/product_analytics/frontend/insights/editor/InsightDisplayConfig.test.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/InsightDisplayConfig.test.tsxrename to products/product_analytics/frontend/insights/editor/InsightDisplayConfig.test.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/InsightDisplayConfig.tsx b/products/product_analytics/frontend/insights/editor/InsightDisplayConfig.tsxsimilarity index 98%rename from frontend/src/queries/nodes/InsightViz/InsightDisplayConfig.tsxrename to products/product_analytics/frontend/insights/editor/InsightDisplayConfig.tsxindex 405ad90c5530..6023cc7def1d 100644--- a/frontend/src/queries/nodes/InsightViz/InsightDisplayConfig.tsx+++ b/products/product_analytics/frontend/insights/editor/InsightDisplayConfig.tsx@@ -10,13 +10,13 @@ import { IntervalFilter } from 'lib/components/IntervalFilter'import { NON_TIME_SERIES_DISPLAY_TYPES } from 'lib/constants'import { LemonDropdown } from 'lib/lemon-ui/LemonDropdown'import { alignResolvedDateRangeToInterval, formatResolvedDateRange } from 'lib/utils/datetime'-import { InsightDateFilter } from 'scenes/insights/filters/InsightDateFilter'import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { hasBreakdownFilter, isWebAnalyticsInsightQuery } from '~/queries/utils'import { ChartDisplayType } from '~/types'+import { InsightDateFilter } from 'products/product_analytics/frontend/insights/editor/filters/InsightDateFilter'import { FunnelBinsPicker } from 'products/product_analytics/frontend/insights/funnels/filters/FunnelBinsPicker'import { FunnelDisplayLayoutPicker } from 'products/product_analytics/frontend/insights/funnels/filters/FunnelDisplayLayoutPicker'import { funnelDataLogic } from 'products/product_analytics/frontend/insights/funnels/funnelDataLogic'diff --git a/frontend/src/queries/nodes/InsightViz/InsightDisplayOptionsPanel.tsx b/products/product_analytics/frontend/insights/editor/InsightDisplayOptionsPanel.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/InsightDisplayOptionsPanel.tsxrename to products/product_analytics/frontend/insights/editor/InsightDisplayOptionsPanel.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/PropertyGroupFilters.scss b/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.scsssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/PropertyGroupFilters.scssrename to products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.scssdiff --git a/frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/PropertyGroupFilters.tsx b/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.tsxsimilarity index 99%rename from frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/PropertyGroupFilters.tsxrename to products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.tsxindex 124974945b66..c5796e0ae81b 100644--- a/frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/PropertyGroupFilters.tsx+++ b/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/PropertyGroupFilters.tsx@@ -15,11 +15,11 @@ import { FEATURE_FLAGS } from 'lib/constants'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'+import { AndOrFilterSelect } from '~/queries/nodes/InsightViz/PropertyGroupFilters/AndOrFilterSelect'import { InsightQueryNode, ProductAnalyticsInsightQueryNode } from '~/queries/schema/schema-general'import { InsightLogicProps, PropertyGroupFilterValue } from '~/types'import { InsightTestAccountFilter } from '../filters/InsightTestAccountFilter'-import { AndOrFilterSelect } from './AndOrFilterSelect'import { propertyGroupFilterLogic } from './propertyGroupFilterLogic'type PropertyGroupFiltersProps = {diff --git a/frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/propertyGroupFilterLogic.test.ts b/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/propertyGroupFilterLogic.test.tssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/propertyGroupFilterLogic.test.tsrename to products/product_analytics/frontend/insights/editor/PropertyGroupFilters/propertyGroupFilterLogic.test.tsdiff --git a/frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/propertyGroupFilterLogic.ts b/products/product_analytics/frontend/insights/editor/PropertyGroupFilters/propertyGroupFilterLogic.tssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/PropertyGroupFilters/propertyGroupFilterLogic.tsrename to products/product_analytics/frontend/insights/editor/PropertyGroupFilters/propertyGroupFilterLogic.tsdiff --git a/frontend/src/queries/nodes/InsightViz/SessionAnalysisWarning.tsx b/products/product_analytics/frontend/insights/editor/SessionAnalysisWarning.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/SessionAnalysisWarning.tsxrename to products/product_analytics/frontend/insights/editor/SessionAnalysisWarning.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/SuggestionBanner.stories.tsx b/products/product_analytics/frontend/insights/editor/SuggestionBanner.stories.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/SuggestionBanner.stories.tsxrename to products/product_analytics/frontend/insights/editor/SuggestionBanner.stories.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/SuggestionBanner.tsx b/products/product_analytics/frontend/insights/editor/SuggestionBanner.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/SuggestionBanner.tsxrename to products/product_analytics/frontend/insights/editor/SuggestionBanner.tsxdiff --git a/frontend/src/queries/nodes/InsightViz/TrendsSeries.tsx b/products/product_analytics/frontend/insights/editor/TrendsSeries.tsxsimilarity index 97%rename from frontend/src/queries/nodes/InsightViz/TrendsSeries.tsxrename to products/product_analytics/frontend/insights/editor/TrendsSeries.tsxindex c0e8fde27a46..3e6170f0ca0f 100644--- a/frontend/src/queries/nodes/InsightViz/TrendsSeries.tsx+++ b/products/product_analytics/frontend/insights/editor/TrendsSeries.tsx@@ -10,13 +10,13 @@ import { SeriesActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFimport { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'-import { getInsightPropertyFilterGroupTypes } from 'scenes/insights/utils/propertyTaxonomicGroupTypes'import { groupsModel } from '~/models/groupsModel'import { NodeKind } from '~/queries/schema/schema-general'import { isInsightQueryNode } from '~/queries/utils'import { ChartDisplayType, InsightType } from '~/types'+import { getInsightPropertyFilterGroupTypes } from 'products/product_analytics/frontend/insights/editor/propertyTaxonomicGroupTypes'import { LifecycleSeriesHeader } from 'products/product_analytics/frontend/insights/lifecycle/LifecycleSeriesHeader'import { TrendsFormula } from 'products/product_analytics/frontend/insights/trends/filters/TrendsFormula'diff --git a/frontend/src/queries/nodes/InsightViz/displayTypes.ts b/products/product_analytics/frontend/insights/editor/displayTypes.tssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/displayTypes.tsrename to products/product_analytics/frontend/insights/editor/displayTypes.tsdiff --git a/frontend/src/queries/nodes/InsightViz/editorFilterUtils.test.ts b/products/product_analytics/frontend/insights/editor/editorFilterUtils.test.tssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/editorFilterUtils.test.tsrename to products/product_analytics/frontend/insights/editor/editorFilterUtils.test.tsdiff --git a/frontend/src/queries/nodes/InsightViz/editorFilterUtils.ts b/products/product_analytics/frontend/insights/editor/editorFilterUtils.tssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/editorFilterUtils.tsrename to products/product_analytics/frontend/insights/editor/editorFilterUtils.tsdiff --git a/frontend/src/scenes/insights/EditorFilters/AnnotationsPicker.tsx b/products/product_analytics/frontend/insights/editor/filters/AnnotationsPicker.tsxsimilarity index 95%rename from frontend/src/scenes/insights/EditorFilters/AnnotationsPicker.tsxrename to products/product_analytics/frontend/insights/editor/filters/AnnotationsPicker.tsxindex 0f0dbdd35524..8013e471c9d3 100644--- a/frontend/src/scenes/insights/EditorFilters/AnnotationsPicker.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/AnnotationsPicker.tsx@@ -3,13 +3,12 @@ import { useActions, useValues } from 'kea'import { LemonSelect, LemonSelectOptions } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { AnnotationScope } from '~/types'import { annotationScopeToName } from 'products/annotations/frontend/logics/annotationModalLogic'-import { insightVizDataLogic } from '../insightVizDataLogic'-type AnnotationsSelection = AnnotationScope | 'all' | 'none'const OPTIONS: LemonSelectOptions<AnnotationsSelection> = [diff --git a/frontend/src/scenes/insights/EditorFilters/AxisLabelFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/AxisLabelFilter.tsxsimilarity index 100%rename from frontend/src/scenes/insights/EditorFilters/AxisLabelFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/AxisLabelFilter.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/GoalLines.tsx b/products/product_analytics/frontend/insights/editor/filters/GoalLines.tsxsimilarity index 100%rename from frontend/src/scenes/insights/EditorFilters/GoalLines.tsxrename to products/product_analytics/frontend/insights/editor/filters/GoalLines.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/HideIncompleteConversionWindowPeriodsFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/HideIncompleteConversionWindowPeriodsFilter.tsxsimilarity index 95%rename from frontend/src/scenes/insights/EditorFilters/HideIncompleteConversionWindowPeriodsFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/HideIncompleteConversionWindowPeriodsFilter.tsxindex c4dd57b56a9c..c9ac11ea8c5f 100644--- a/frontend/src/scenes/insights/EditorFilters/HideIncompleteConversionWindowPeriodsFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/HideIncompleteConversionWindowPeriodsFilter.tsx@@ -4,11 +4,10 @@ import { IconInfo } from '@posthog/icons'import { LemonCheckbox, Tooltip } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { isFunnelsQuery } from '~/queries/utils'-import { insightVizDataLogic } from '../insightVizDataLogic'-export function HideIncompleteConversionWindowPeriodsFilter(): JSX.Element | null {const { insightProps } = useValues(insightLogic)const { querySource } = useValues(insightVizDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/filters/InsightDateFilter/InsightDateFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/InsightDateFilter.tsxsimilarity index 98%rename from frontend/src/scenes/insights/filters/InsightDateFilter/InsightDateFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/InsightDateFilter.tsxindex e5e97f5ca76b..f93bc4f0706e 100644--- a/frontend/src/scenes/insights/filters/InsightDateFilter/InsightDateFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/InsightDateFilter.tsx@@ -8,16 +8,15 @@ import { type DateFilterExclusions } from 'lib/components/DateFilter/DateFilterEimport { dateMapping } from 'lib/utils/dateFilters'import { alignResolvedDateRangeToInterval } from 'lib/utils/datetime'import { eventUsageLogic } from 'lib/utils/eventUsageLogic'-import { insightLogic } from 'scenes/insights/insightLogic'-import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import {computeDaysOfWeekUpdate,daysOfWeekSetsEqual,getExcludedDaysOfWeek,parseIsoDaysOfWeek,querySupportsDaysOfWeek,-} from './daysOfWeekFilterUtils'+} from 'scenes/insights/filters/InsightDateFilter/daysOfWeekFilterUtils'+import { insightLogic } from 'scenes/insights/insightLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'type InsightDateFilterProps = {disabled: booleandiff --git a/frontend/src/queries/nodes/InsightViz/filters/InsightTestAccountFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/InsightTestAccountFilter.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/filters/InsightTestAccountFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/InsightTestAccountFilter.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/LegendOptionsFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/LegendOptionsFilter.tsxsimilarity index 96%rename from frontend/src/scenes/insights/EditorFilters/LegendOptionsFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/LegendOptionsFilter.tsxindex a689ff2c70aa..c45c5fc0b885 100644--- a/frontend/src/scenes/insights/EditorFilters/LegendOptionsFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/LegendOptionsFilter.tsx@@ -3,11 +3,10 @@ import { useActions, useValues } from 'kea'import { LemonCheckbox, LemonSelect } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { TrendsFilter } from '~/queries/schema/schema-general'-import { insightVizDataLogic } from '../insightVizDataLogic'-type LegendPosition = NonNullable<TrendsFilter['legendPosition']>const POSITION_OPTIONS: { value: LegendPosition; label: string }[] = [diff --git a/frontend/src/scenes/insights/EditorFilters/LineStylePicker.tsx b/products/product_analytics/frontend/insights/editor/filters/LineStylePicker.tsxsimilarity index 94%rename from frontend/src/scenes/insights/EditorFilters/LineStylePicker.tsxrename to products/product_analytics/frontend/insights/editor/filters/LineStylePicker.tsxindex 04c69a1c75e7..0d52497175be 100644--- a/frontend/src/scenes/insights/EditorFilters/LineStylePicker.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/LineStylePicker.tsx@@ -3,11 +3,10 @@ import { useActions, useValues } from 'kea'import { LemonSegmentedButton } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import type { TrendsFilter } from '~/queries/schema/schema-general'-import { insightVizDataLogic } from '../insightVizDataLogic'-export function LineStylePicker(): JSX.Element {const { insightProps } = useValues(insightLogic)const { insightFilter } = useValues(insightVizDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/MetricFilters.tsx b/products/product_analytics/frontend/insights/editor/filters/MetricFilters.tsxsimilarity index 98%rename from frontend/src/scenes/insights/EditorFilters/MetricFilters.tsxrename to products/product_analytics/frontend/insights/editor/filters/MetricFilters.tsxindex 16ebd8669e76..c231e0270dcb 100644--- a/frontend/src/scenes/insights/EditorFilters/MetricFilters.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/MetricFilters.tsx@@ -4,6 +4,7 @@ import { LemonSelect } from '@posthog/lemon-ui'import { MetricDirectionColorPickers } from 'lib/components/Metric/MetricDirectionColorPickers'import { LemonCheckbox } from 'lib/lemon-ui/LemonCheckbox'+import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import {@@ -15,8 +16,6 @@ import {type MetricSummary,} from 'products/product_analytics/frontend/insights/trends/Metric/Metric.utils'-import { insightLogic } from '../insightLogic'-export function MetricSummaryFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)const { trendsFilter } = useValues(insightVizDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/PercentStackViewFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/PercentStackViewFilter.tsxsimilarity index 93%rename from frontend/src/scenes/insights/EditorFilters/PercentStackViewFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/PercentStackViewFilter.tsxindex 6781148a4244..91da1b22221a 100644--- a/frontend/src/scenes/insights/EditorFilters/PercentStackViewFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/PercentStackViewFilter.tsx@@ -1,11 +1,10 @@import { useActions, useValues } from 'kea'import { LemonCheckbox } from 'lib/lemon-ui/LemonCheckbox'+import { insightLogic } from 'scenes/insights/insightLogic'import { trendsDataLogic } from 'products/product_analytics/frontend/insights/trends/trendsDataLogic'-import { insightLogic } from '../insightLogic'-export function PercentStackViewFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)const { showPercentStackView } = useValues(trendsDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/PoeFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/PoeFilter.tsxsimilarity index 95%rename from frontend/src/scenes/insights/EditorFilters/PoeFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/PoeFilter.tsxindex 55066d4e8988..b78b343887c8 100644--- a/frontend/src/scenes/insights/EditorFilters/PoeFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/PoeFilter.tsx@@ -2,9 +2,10 @@ import { useActions, useValues } from 'kea'import { LemonDisabledArea, LemonLabel, LemonSwitch } from '@posthog/lemon-ui'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'+import { InsightLogicProps } from '~/types'-import { insightVizDataLogic } from '../insightVizDataLogic'import { poeFilterLogic } from './poeFilterLogic'interface PoeFilterProps {diff --git a/frontend/src/scenes/insights/EditorFilters/ResultCustomizationByPicker.tsx b/products/product_analytics/frontend/insights/editor/filters/ResultCustomizationByPicker.tsxsimilarity index 100%rename from frontend/src/scenes/insights/EditorFilters/ResultCustomizationByPicker.tsxrename to products/product_analytics/frontend/insights/editor/filters/ResultCustomizationByPicker.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/SamplingDeprecationNotice.tsx b/products/product_analytics/frontend/insights/editor/filters/SamplingDeprecationNotice.tsxsimilarity index 100%rename from frontend/src/scenes/insights/EditorFilters/SamplingDeprecationNotice.tsxrename to products/product_analytics/frontend/insights/editor/filters/SamplingDeprecationNotice.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/ScalePicker.tsx b/products/product_analytics/frontend/insights/editor/filters/ScalePicker.tsxsimilarity index 92%rename from frontend/src/scenes/insights/EditorFilters/ScalePicker.tsxrename to products/product_analytics/frontend/insights/editor/filters/ScalePicker.tsxindex 4b002a687dc9..5ec6ef173c24 100644--- a/frontend/src/scenes/insights/EditorFilters/ScalePicker.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/ScalePicker.tsx@@ -3,8 +3,7 @@ import { useActions, useValues } from 'kea'import { LemonSegmentedButton } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'--import { insightVizDataLogic } from '../insightVizDataLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'export function ScalePicker(): JSX.Element | null {const { insightProps } = useValues(insightLogic)diff --git a/frontend/src/scenes/insights/EditorFilters/ShowAlertAnomalyPointsFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/ShowAlertAnomalyPointsFilter.tsxsimilarity index 100%rename from frontend/src/scenes/insights/EditorFilters/ShowAlertAnomalyPointsFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/ShowAlertAnomalyPointsFilter.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/ShowAlertThresholdLinesFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/ShowAlertThresholdLinesFilter.tsxsimilarity index 92%rename from frontend/src/scenes/insights/EditorFilters/ShowAlertThresholdLinesFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/ShowAlertThresholdLinesFilter.tsxindex a6fda8aa4501..0ca62f7b099e 100644--- a/frontend/src/scenes/insights/EditorFilters/ShowAlertThresholdLinesFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/ShowAlertThresholdLinesFilter.tsx@@ -3,8 +3,7 @@ import { useActions, useValues } from 'kea'import { LemonCheckbox } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'--import { insightVizDataLogic } from '../insightVizDataLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'export function ShowAlertThresholdLinesFilter(): JSX.Element | null {const { insightProps } = useValues(insightLogic)diff --git a/frontend/src/scenes/insights/EditorFilters/ShowLegendFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/ShowLegendFilter.tsxsimilarity index 91%rename from frontend/src/scenes/insights/EditorFilters/ShowLegendFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/ShowLegendFilter.tsxindex b5655c6e0745..6bf11e214e3b 100644--- a/frontend/src/scenes/insights/EditorFilters/ShowLegendFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/ShowLegendFilter.tsx@@ -3,8 +3,7 @@ import { useActions, useValues } from 'kea'import { LemonCheckbox } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'--import { insightVizDataLogic } from '../insightVizDataLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'export function ShowLegendFilter(): JSX.Element | null {const { insightProps } = useValues(insightLogic)diff --git a/frontend/src/scenes/insights/EditorFilters/ShowMultipleYAxesFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/ShowMultipleYAxesFilter.tsxsimilarity index 91%rename from frontend/src/scenes/insights/EditorFilters/ShowMultipleYAxesFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/ShowMultipleYAxesFilter.tsxindex 4d62933b8aa4..cbda10823d5c 100644--- a/frontend/src/scenes/insights/EditorFilters/ShowMultipleYAxesFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/ShowMultipleYAxesFilter.tsx@@ -3,8 +3,7 @@ import { useActions, useValues } from 'kea'import { LemonCheckbox } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'--import { insightVizDataLogic } from '../insightVizDataLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'export function ShowMultipleYAxesFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)diff --git a/frontend/src/scenes/insights/EditorFilters/ShowPieTotalFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/ShowPieTotalFilter.tsxsimilarity index 94%rename from frontend/src/scenes/insights/EditorFilters/ShowPieTotalFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/ShowPieTotalFilter.tsxindex 405ec2ce8884..66b67f9d6d42 100644--- a/frontend/src/scenes/insights/EditorFilters/ShowPieTotalFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/ShowPieTotalFilter.tsx@@ -3,13 +3,12 @@ import { useActions, useValues } from 'kea'import { LemonCheckbox } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { ChartDisplayType } from '~/types'import { trendsDataLogic } from 'products/product_analytics/frontend/insights/trends/trendsDataLogic'-import { insightVizDataLogic } from '../insightVizDataLogic'-export function ShowPieTotalFilter(): JSX.Element | null {const { insightProps } = useValues(insightLogic)const { display, pieChartVizOptions } = useValues(trendsDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/ShowTrendLinesFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/ShowTrendLinesFilter.tsxsimilarity index 97%rename from frontend/src/scenes/insights/EditorFilters/ShowTrendLinesFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/ShowTrendLinesFilter.tsxindex 969353de7f0d..17f169411488 100644--- a/frontend/src/scenes/insights/EditorFilters/ShowTrendLinesFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/ShowTrendLinesFilter.tsx@@ -3,14 +3,13 @@ import { useActions, useValues } from 'kea'import { LemonCheckbox } from '@posthog/lemon-ui'import { insightLogic } from 'scenes/insights/insightLogic'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { isFunnelsQuery, isRetentionQuery, isTrendsQuery } from '~/queries/utils'import { ChartDisplayType } from '~/types'import { funnelDataLogic } from 'products/product_analytics/frontend/insights/funnels/funnelDataLogic'-import { insightVizDataLogic } from '../insightVizDataLogic'-export function ShowTrendLinesFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)const { querySource, trendsFilter, yAxisScaleType } = useValues(insightVizDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/SliceNamesFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/SliceNamesFilter.tsxsimilarity index 93%rename from frontend/src/scenes/insights/EditorFilters/SliceNamesFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/SliceNamesFilter.tsxindex de83df474aad..f59197572242 100644--- a/frontend/src/scenes/insights/EditorFilters/SliceNamesFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/SliceNamesFilter.tsx@@ -1,10 +1,9 @@import { useActions, useValues } from 'kea'import { LemonCheckbox } from 'lib/lemon-ui/LemonCheckbox'+import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { insightLogic } from '../insightLogic'-// Pie only — it's the one display that draws the series label on the chart itself.export function SliceNamesFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)diff --git a/frontend/src/scenes/insights/EditorFilters/StackBreakdownFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/StackBreakdownFilter.tsxsimilarity index 93%rename from frontend/src/scenes/insights/EditorFilters/StackBreakdownFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/StackBreakdownFilter.tsxindex 53e428bc1235..417c264e0068 100644--- a/frontend/src/scenes/insights/EditorFilters/StackBreakdownFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/StackBreakdownFilter.tsx@@ -1,11 +1,10 @@import { useActions, useValues } from 'kea'import { LemonCheckbox } from 'lib/lemon-ui/LemonCheckbox'+import { insightLogic } from 'scenes/insights/insightLogic'import { trendsDataLogic } from 'products/product_analytics/frontend/insights/trends/trendsDataLogic'-import { insightLogic } from '../insightLogic'-export function StackBreakdownFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)const { trendsFilter } = useValues(trendsDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/ValueOnSeriesFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/ValueOnSeriesFilter.tsxsimilarity index 93%rename from frontend/src/scenes/insights/EditorFilters/ValueOnSeriesFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/ValueOnSeriesFilter.tsxindex 690d91419d8d..1db991877dfa 100644--- a/frontend/src/scenes/insights/EditorFilters/ValueOnSeriesFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/ValueOnSeriesFilter.tsx@@ -1,10 +1,9 @@import { useActions, useValues } from 'kea'import { LemonCheckbox } from 'lib/lemon-ui/LemonCheckbox'+import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { insightLogic } from '../insightLogic'-export function ValueOnSeriesFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)const { updateInsightFilter } = useActions(insightVizDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/WebAnalyticsEditorFilters.tsx b/products/product_analytics/frontend/insights/editor/filters/WebAnalyticsEditorFilters.tsxsimilarity index 100%rename from frontend/src/scenes/insights/EditorFilters/WebAnalyticsEditorFilters.tsxrename to products/product_analytics/frontend/insights/editor/filters/WebAnalyticsEditorFilters.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/YAxisRangeFilter.test.tsx b/products/product_analytics/frontend/insights/editor/filters/YAxisRangeFilter.test.tsxsimilarity index 100%rename from frontend/src/scenes/insights/EditorFilters/YAxisRangeFilter.test.tsxrename to products/product_analytics/frontend/insights/editor/filters/YAxisRangeFilter.test.tsxdiff --git a/frontend/src/scenes/insights/EditorFilters/YAxisRangeFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/YAxisRangeFilter.tsxsimilarity index 98%rename from frontend/src/scenes/insights/EditorFilters/YAxisRangeFilter.tsxrename to products/product_analytics/frontend/insights/editor/filters/YAxisRangeFilter.tsxindex 02bd5ac8523d..8780b02f1dc6 100644--- a/frontend/src/scenes/insights/EditorFilters/YAxisRangeFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/YAxisRangeFilter.tsx@@ -3,10 +3,9 @@ import { useEffect, useState } from 'react'import { LemonInput, LemonSwitch } from '@posthog/lemon-ui'+import { insightLogic } from 'scenes/insights/insightLogic'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'-import { insightLogic } from '../insightLogic'-export function YAxisRangeFilter(): JSX.Element {const { insightProps } = useValues(insightLogic)const { trendsFilter, yAxisScaleType, showPercentStackView } = useValues(insightVizDataLogic(insightProps))diff --git a/frontend/src/scenes/insights/EditorFilters/goalLinesLogic.ts b/products/product_analytics/frontend/insights/editor/filters/goalLinesLogic.tssimilarity index 95%rename from frontend/src/scenes/insights/EditorFilters/goalLinesLogic.tsrename to products/product_analytics/frontend/insights/editor/filters/goalLinesLogic.tsindex 3ae3556d5ef7..7d327a085b5e 100644--- a/frontend/src/scenes/insights/EditorFilters/goalLinesLogic.ts+++ b/products/product_analytics/frontend/insights/editor/filters/goalLinesLogic.ts@@ -1,6 +1,8 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers } from 'kea'import { subscriptions } from 'kea-subscriptions'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'+import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import {@@ -10,19 +12,16 @@ import {RetentionQuery,TrendsQuery,} from '~/queries/schema/schema-general'-import { isFunnelsQuery, isRetentionQuery, isTrendsQuery } from '~/queries/utils'-import { InsightLogicProps } from '~/types'-import type {LifecycleQuery,PathsQuery,StickinessQuery,WebOverviewQuery,WebStatsTableQuery,-} from '../../../queries/schema/schema-general'-import type { PathsV2Query } from '../../../queries/schema/schema-general'-import { insightVizDataLogic } from '../insightVizDataLogic'-import type { QuerySourceUpdate } from '../insightVizDataLogic'+} from '~/queries/schema/schema-general'+import type { PathsV2Query } from '~/queries/schema/schema-general'+import { isFunnelsQuery, isRetentionQuery, isTrendsQuery } from '~/queries/utils'+import { InsightLogicProps } from '~/types'export type PoeModeTypes = HogQLQueryModifiers['personsOnEventsMode'] | nulldiff --git a/frontend/src/scenes/insights/EditorFilters/poeFilterLogic.ts b/products/product_analytics/frontend/insights/editor/filters/poeFilterLogic.tssimilarity index 91%rename from frontend/src/scenes/insights/EditorFilters/poeFilterLogic.tsrename to products/product_analytics/frontend/insights/editor/filters/poeFilterLogic.tsindex 43de09a73e03..b7cf317c1a6f 100644--- a/frontend/src/scenes/insights/EditorFilters/poeFilterLogic.ts+++ b/products/product_analytics/frontend/insights/editor/filters/poeFilterLogic.ts@@ -1,11 +1,11 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers } from 'kea'import { subscriptions } from 'kea-subscriptions'+import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'+import type { QuerySourceUpdate } from 'scenes/insights/insightVizDataLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { HogQLQueryModifiers } from '~/queries/schema/schema-general'-import { InsightLogicProps } from '~/types'-import type {FunnelsQuery,LifecycleQuery,@@ -15,10 +15,9 @@ import type {TrendsQuery,WebOverviewQuery,WebStatsTableQuery,-} from '../../../queries/schema/schema-general'-import type { PathsV2Query } from '../../../queries/schema/schema-general'-import { insightVizDataLogic } from '../insightVizDataLogic'-import type { QuerySourceUpdate } from '../insightVizDataLogic'+} from '~/queries/schema/schema-general'+import type { PathsV2Query } from '~/queries/schema/schema-general'+import { InsightLogicProps } from '~/types'export type PoeModeTypes = HogQLQueryModifiers['personsOnEventsMode'] | nulldiff --git a/frontend/src/queries/nodes/InsightViz/insightDisplayOptions.tsx b/products/product_analytics/frontend/insights/editor/insightDisplayOptions.tsxsimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/insightDisplayOptions.tsxrename to products/product_analytics/frontend/insights/editor/insightDisplayOptions.tsxdiff --git a/frontend/src/scenes/insights/utils/propertyTaxonomicGroupTypes.ts b/products/product_analytics/frontend/insights/editor/propertyTaxonomicGroupTypes.tssimilarity index 100%rename from frontend/src/scenes/insights/utils/propertyTaxonomicGroupTypes.tsrename to products/product_analytics/frontend/insights/editor/propertyTaxonomicGroupTypes.tsdiff --git a/frontend/src/queries/nodes/InsightViz/useEditorGroupExpansion.ts b/products/product_analytics/frontend/insights/editor/useEditorGroupExpansion.tssimilarity index 100%rename from frontend/src/queries/nodes/InsightViz/useEditorGroupExpansion.tsrename to products/product_analytics/frontend/insights/editor/useEditorGroupExpansion.tsdiff --git a/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsx b/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsxindex 0f50d2b55ec7..9058ada23e1b 100644--- a/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsx+++ b/products/product_analytics/frontend/insights/funnels/editor/FunnelsQuerySteps.tsx@@ -7,13 +7,14 @@ import { getProjectEventExistence } from 'lib/utils/getAppContext'import { SeriesActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFilter'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'-import { getInsightPropertyFilterGroupTypes } from 'scenes/insights/utils/propertyTaxonomicGroupTypes'import { groupsModel } from '~/models/groupsModel'import { NodeKind } from '~/queries/schema/schema-general'import { isInsightQueryNode } from '~/queries/utils'import { EditorFilterProps, InsightType } from '~/types'+import { getInsightPropertyFilterGroupTypes } from 'products/product_analytics/frontend/insights/editor/propertyTaxonomicGroupTypes'+import { FunnelDataWarehouseStepDefinitionPopover } from './FunnelDataWarehouseStepDefinitionPopover'export const FUNNEL_STEP_COUNT_LIMIT = 30diff --git a/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsx b/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsxindex f8bfd4d899a0..fc6fc1246b1e 100644--- a/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsx+++ b/products/product_analytics/frontend/insights/retention/editor/RetentionCondition.tsx@@ -11,11 +11,11 @@ import { getOrdinalSuffix } from 'lib/utils/strings'import { ActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFilter'import { MathAvailability } from 'scenes/insights/filters/ActionFilter/ActionFilterRow/types'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'-import { getRetentionPropertyFilterGroupTypes } from 'scenes/insights/utils/propertyTaxonomicGroupTypes'import { groupsModel } from '~/models/groupsModel'import { EditorFilterProps, EntityTypes, FilterType, RetentionPeriod, RetentionType } from '~/types'+import { getRetentionPropertyFilterGroupTypes } from 'products/product_analytics/frontend/insights/editor/propertyTaxonomicGroupTypes'import { AggregationSelect } from 'products/product_analytics/frontend/insights/shared/AggregationSelect'import { dateOptionPlurals, dateOptions, retentionOptionDescriptions, retentionOptions } from '../constants'