:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(error-tracking): move the email entry points from the side panel into the issue header (#118448)
Daniel Marchuk40406009f1b1
diff --git a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ErrorTrackingIssueScene.tsx b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ErrorTrackingIssueScene.tsxindex 4f772e48bd00..ef0952f431fa 100644--- a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ErrorTrackingIssueScene.tsx+++ b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ErrorTrackingIssueScene.tsx@@ -4,7 +4,7 @@ import clsx from 'clsx'import { BindLogic, useActions, useValues } from 'kea'import { router } from 'kea-router'import posthog from 'posthog-js'-import { useCallback, useEffect, useRef } from 'react'+import { useCallback, useEffect, useRef, useState } from 'react'import { IconChevronDown, IconRewindPlay, IconSparkles, IconX } from '@posthog/icons'import { LemonButton } from '@posthog/lemon-ui'@@ -20,6 +20,7 @@ import {DropdownMenu,DropdownMenuContent,DropdownMenuItem,+ DropdownMenuSeparator,DropdownMenuTrigger,} from 'lib/ui/quill'import { newInternalTab } from 'lib/utils/newInternalTab'@@ -33,6 +34,7 @@ import { ReplayTabs } from '~/types'import { useAttachedContext } from 'products/posthog_ai/frontend/api/logics'import { markScannerHandoffIntent } from 'products/replay_vision/frontend/replay_scanners/scannerHandoffIntent'+import { messageAudienceAccessDisabledReason } from 'products/workflows/frontend/MessageAudience/messageAudience'import { PostHogSDKIssueBanner } from '../../components/Banners/PostHogSDKIssueBanner'import { miniBreakdownsLogic } from '../../components/Breakdowns/miniBreakdownsLogic'@@ -53,6 +55,8 @@ import { StyleVariables } from '../../components/StyleVariables'import { useErrorTagRenderer } from '../../hooks/use-error-tag-renderer'import { getIssueReplayDateRange, getIssueReplayFilterGroup, issueVisionScannerHandoff } from '../../utils'import { ErrorTrackingIssueSceneLogicProps, errorTrackingIssueSceneLogic } from './errorTrackingIssueSceneLogic'+import { IssueEmailMenu } from './IssueEmailMenu'+import { IssueEmailMenuItems } from './IssueEmailMenuItems'import { IssueEventsPanel } from './IssueEventsPanel'import { LinkedReports } from './LinkedReports'import { ErrorTrackingIssueScenePanel } from './ScenePanel'@@ -64,6 +68,10 @@ export const scene: SceneExport<ErrorTrackingIssueSceneLogicProps> = {paramsToProps: ({ params: { id }, searchParams: { fingerprint, timestamp } }) => ({ id, fingerprint, timestamp }),}+function isDisplayed(element: HTMLElement | null): boolean {+ return !!element && getComputedStyle(element).display !== 'none'+}+export function ErrorTrackingIssueScene(): JSX.Element {const { issue, issueId, issueIdValid, lastSeen, initialEventTimestamp, selectedEvent, mobileDetailOpen } =useValues(errorTrackingIssueSceneLogic)@@ -73,6 +81,9 @@ export function ErrorTrackingIssueScene(): JSX.Element {const { isWindowLessThan } = useWindowSize()const isMobile = isWindowLessThan('md')const hasIssueSplitting = useFeatureFlag('ERROR_TRACKING_ISSUE_SPLITTING')+ const inlineEmailMenuRef = useRef<HTMLDivElement>(null)+ // The overflow menu portals out of the scene container, so a container query cannot hide its email items.+ const [emailInOverflow, setEmailInOverflow] = useState(true)// Jump to the session replay list filtered to this issue. Captured so we can measure how often// people watch recordings themselves, the baseline the Replay vision cross-sell is weighed against.@@ -184,13 +195,21 @@ export function ErrorTrackingIssueScene(): JSX.Element {View recordings<IconRewindPlay /></Button>- <DropdownMenu>+ <DropdownMenu+ onOpenChange={(open) => {+ if (open) {+ setEmailInOverflow(+ !isDisplayed(inlineEmailMenuRef.current)+ )+ }+ }}+ ><DropdownMenuTriggerrender={<Buttonvariant="outline"size="icon"- aria-label="More recording options"+ aria-label="More options"/>}>@@ -207,6 +226,16 @@ export function ErrorTrackingIssueScene(): JSX.Element {<IconSparkles className="text-ai" />Set up a scanner to watch these</DropdownMenuItem>+ {emailInOverflow &&+ !messageAudienceAccessDisabledReason() && (+ <>+ <DropdownMenuSeparator />+ <IssueEmailMenuItems+ issueId={issue.id}+ issueName={issue.name}+ />+ </>+ )}</DropdownMenuContent></DropdownMenu></ButtonGroup>@@ -220,6 +249,12 @@ export function ErrorTrackingIssueScene(): JSX.Element {<IconRewindPlay /></Button>)}+ <IssueEmailMenu+ issueId={issue.id}+ issueName={issue.name}+ collapseWhenNarrow={!!issue.name}+ wrapperRef={inlineEmailMenuRef}+ /><IssueStatusButton status={issue.status} onChange={updateStatus} /></div>)@@ -246,6 +281,7 @@ export function ErrorTrackingIssueScene(): JSX.Element {disabled={issue.status != 'active'}/></ButtonGroup>+ <IssueEmailMenu issueId={issue.id} issueName={issue.name} /><IssueStatusButton status={issue.status} onChange={updateStatus} />{!mobileDetailOpen && (<LemonButtondiff --git a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/IssueEmailMenu.tsx b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/IssueEmailMenu.tsxnew file mode 100644index 000000000000..60a704810f83--- /dev/null+++ b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/IssueEmailMenu.tsx@@ -0,0 +1,60 @@+import clsx from 'clsx'+import { RefObject } from 'react'++import { IconChevronDown, IconSend } from '@posthog/icons'++import {+ Button,+ DropdownMenu,+ DropdownMenuContent,+ DropdownMenuTrigger,+ Tooltip,+ TooltipContent,+ TooltipTrigger,+} from 'lib/ui/quill'++import { messageAudienceAccessDisabledReason } from 'products/workflows/frontend/MessageAudience/messageAudience'++import { IssueEmailMenuItems } from './IssueEmailMenuItems'+import { IssueAffectedBroadcastLogicProps } from './ScenePanel/issueAffectedBroadcastLogic'+import { IssueAffectedBroadcastModal } from './ScenePanel/IssueAffectedBroadcastModal'++export interface IssueEmailMenuProps extends IssueAffectedBroadcastLogicProps {+ /** Hides the button on a narrow scene, where the header menu next to it carries the same items. */+ collapseWhenNarrow?: boolean+ wrapperRef?: RefObject<HTMLDivElement>+}++export function IssueEmailMenu({ collapseWhenNarrow, wrapperRef, ...props }: IssueEmailMenuProps): JSX.Element {+ const accessDisabledReason = messageAudienceAccessDisabledReason()++ return (+ <>+ <div ref={wrapperRef} className={clsx(collapseWhenNarrow ? 'hidden @6xl/main-content:flex' : 'flex')}>+ {accessDisabledReason ? (+ <Tooltip>+ <TooltipTrigger render={<Button variant="outline" disabled />}>+ <IconSend />+ Email users+ </TooltipTrigger>+ <TooltipContent>{accessDisabledReason}</TooltipContent>+ </Tooltip>+ ) : (+ <DropdownMenu>+ <DropdownMenuTrigger+ render={<Button variant="outline" data-attr="error-tracking-issue-email-menu" />}+ >+ <IconSend />+ Email users+ <IconChevronDown />+ </DropdownMenuTrigger>+ <DropdownMenuContent align="end" className="w-auto min-w-56">+ <IssueEmailMenuItems {...props} />+ </DropdownMenuContent>+ </DropdownMenu>+ )}+ </div>+ <IssueAffectedBroadcastModal {...props} />+ </>+ )+}diff --git a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/IssueEmailMenuItems.tsx b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/IssueEmailMenuItems.tsxnew file mode 100644index 000000000000..fd5c75bd05f5--- /dev/null+++ b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/IssueEmailMenuItems.tsx@@ -0,0 +1,28 @@+import { useActions } from 'kea'++import { IconSend } from '@posthog/icons'++import { DropdownMenuItem } from 'lib/ui/quill'++import { openIssueWorkflow } from './issueWorkflow'+import { IssueAffectedBroadcastLogicProps, issueAffectedBroadcastLogic } from './ScenePanel/issueAffectedBroadcastLogic'++export function IssueEmailMenuItems(props: IssueAffectedBroadcastLogicProps): JSX.Element {+ const { openModal } = useActions(issueAffectedBroadcastLogic(props))++ return (+ <>+ <DropdownMenuItem onClick={openModal} data-attr="error-tracking-issue-email-affected">+ <IconSend />+ Email people affected+ </DropdownMenuItem>+ <DropdownMenuItem+ onClick={() => openIssueWorkflow(props.issueId)}+ data-attr="error-tracking-issue-start-workflow"+ >+ <IconSend />+ Email anyone who hits this+ </DropdownMenuItem>+ </>+ )+}diff --git a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/ErrorTrackingIssueScenePanel.tsx b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/ErrorTrackingIssueScenePanel.tsxindex c75728af5f40..ec6f7a4b89be 100644--- a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/ErrorTrackingIssueScenePanel.tsx+++ b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/ErrorTrackingIssueScenePanel.tsx@@ -25,8 +25,6 @@ import { ErrorTrackingRelationalIssue, ProductIntentContext, ProductKey } from 'import { ExternalReferences } from '../../../components/ExternalReferences'import { manageFingerprintsLogic } from '../../../components/FingerprintPreview/manageFingerprintsLogic'import { errorTrackingIssueSceneLogic } from '../errorTrackingIssueSceneLogic'-import { IssueAffectedBroadcastButton } from './IssueAffectedBroadcastButton'-import { IssueWorkflowButton } from './IssueWorkflowButton'export const ErrorTrackingIssueScenePanel = ({issue,@@ -44,8 +42,6 @@ export const ErrorTrackingIssueScenePanel = ({<ScenePanelDivider /><ScenePanelActionsSection><CreateSurveyButton />- <IssueAffectedBroadcastButton issueId={issue.id} issueName={issue.name} />- <IssueWorkflowButton issueId={issue.id} /><SceneComment dataAttrKey="issue" /><SceneShareButtondataAttrKey="issue"diff --git a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/IssueAffectedBroadcastButton.tsx b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/IssueAffectedBroadcastButton.tsxdeleted file mode 100644index 0edc4189f7f5..000000000000--- a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/IssueAffectedBroadcastButton.tsx+++ /dev/null@@ -1,29 +0,0 @@-import { useActions } from 'kea'--import { IconSend } from '@posthog/icons'--import { ButtonPrimitive } from 'lib/ui/Button/ButtonPrimitives'--import { messageAudienceAccessDisabledReason } from 'products/workflows/frontend/MessageAudience/messageAudience'--import { IssueAffectedBroadcastLogicProps, issueAffectedBroadcastLogic } from './issueAffectedBroadcastLogic'-import { IssueAffectedBroadcastModal } from './IssueAffectedBroadcastModal'--export function IssueAffectedBroadcastButton(props: IssueAffectedBroadcastLogicProps): JSX.Element {- const { openModal } = useActions(issueAffectedBroadcastLogic(props))- const accessDisabledReason = messageAudienceAccessDisabledReason()- return (- <>- <ButtonPrimitive- fullWidth- onClick={openModal}- disabledReasons={accessDisabledReason ? { [accessDisabledReason]: true } : {}}- data-attr="issue-panel-email-affected"- >- <IconSend />- Email people affected- </ButtonPrimitive>- <IssueAffectedBroadcastModal {...props} />- </>- )-}diff --git a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/IssueWorkflowButton.tsx b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/IssueWorkflowButton.tsxdeleted file mode 100644index 6798831b37e9..000000000000--- a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/ScenePanel/IssueWorkflowButton.tsx+++ /dev/null@@ -1,54 +0,0 @@-import { router } from 'kea-router'--import { IconSend } from '@posthog/icons'--import { ButtonPrimitive } from 'lib/ui/Button/ButtonPrimitives'--import {- captureMessageAudienceClicked,- messageAudienceAccessDisabledReason,-} from 'products/workflows/frontend/MessageAudience/messageAudience'-import { draftMessage } from 'products/workflows/frontend/MessageAudience/messageDrafts'-import {- type WorkflowTriggerConfig,- urlForNewWorkflowWithTrigger,-} from 'products/workflows/frontend/Workflows/workflowTriggerPrefill'--// pinned: reported as the click event's source, so renaming it splits the entry point's history-const SOURCE = 'error_tracking'--function issueWorkflowTrigger(issueId: string): WorkflowTriggerConfig {- return {- type: 'event',- filters: {- events: [{ id: '$exception', name: '$exception', type: 'events' }],- properties: [{ key: '$exception_issue_id', value: issueId, operator: 'exact', type: 'event' }],- },- }-}--export function IssueWorkflowButton({ issueId }: { issueId: string }): JSX.Element {- const accessDisabledReason = messageAudienceAccessDisabledReason()- return (- <ButtonPrimitive- fullWidth- tooltip="Open a workflow that emails people each time they hit this issue"- onClick={() => {- captureMessageAudienceClicked(SOURCE, 'workflow')- router.actions.push(- urlForNewWorkflowWithTrigger(- issueWorkflowTrigger(issueId),- SOURCE,- draftMessage({ kind: 'issue_hit' }),- { source: 'error_tracking', source_id: issueId }- )- )- }}- disabledReasons={accessDisabledReason ? { [accessDisabledReason]: true } : {}}- data-attr="issue-panel-start-workflow"- >- <IconSend />- Email anyone who hits this- </ButtonPrimitive>- )-}diff --git a/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/issueWorkflow.ts b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/issueWorkflow.tsnew file mode 100644index 000000000000..1eba40771f97--- /dev/null+++ b/products/error_tracking/frontend/scenes/ErrorTrackingIssueScene/issueWorkflow.ts@@ -0,0 +1,32 @@+import { router } from 'kea-router'++import { captureMessageAudienceClicked } from 'products/workflows/frontend/MessageAudience/messageAudience'+import { draftMessage } from 'products/workflows/frontend/MessageAudience/messageDrafts'+import {+ type WorkflowTriggerConfig,+ urlForNewWorkflowWithTrigger,+} from 'products/workflows/frontend/Workflows/workflowTriggerPrefill'++// pinned: reported as the click event's source, so renaming it splits the entry point's history+const SOURCE = 'error_tracking'++function issueWorkflowTrigger(issueId: string): WorkflowTriggerConfig {+ return {+ type: 'event',+ filters: {+ events: [{ id: '$exception', name: '$exception', type: 'events' }],+ properties: [{ key: '$exception_issue_id', value: issueId, operator: 'exact', type: 'event' }],+ },+ }+}++/** Opens a new workflow that emails people each time they hit this issue. */+export function openIssueWorkflow(issueId: string): void {+ captureMessageAudienceClicked(SOURCE, 'workflow')+ router.actions.push(+ urlForNewWorkflowWithTrigger(issueWorkflowTrigger(issueId), SOURCE, draftMessage({ kind: 'issue_hit' }), {+ source: 'error_tracking',+ source_id: issueId,+ })+ )+}