:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(replay): prefilter distinct ids for in-cohort replay filters (#124978)
Kim Svatos Dugan4363d39593c5
diff --git a/posthog/session_recordings/queries/sub_queries/cohort_subquery.py b/posthog/session_recordings/queries/sub_queries/cohort_subquery.pyindex 658a7f653a81..15dc85427d41 100644--- a/posthog/session_recordings/queries/sub_queries/cohort_subquery.py+++ b/posthog/session_recordings/queries/sub_queries/cohort_subquery.py@@ -81,6 +81,7 @@ class CohortPropertyGroupsSubQuery(SessionRecordingsListingBaseQuery):"""join_clauses: list[str] = []where_conditions: list[str] = []+ member_conditions: list[str] = []placeholders: dict[str, ast.Expr] = {"team_id": ast.Constant(value=self._team.pk),}@@ -95,10 +96,16 @@ class CohortPropertyGroupsSubQuery(SessionRecordingsListingBaseQuery):# DISTINCT because `person_static_cohort` can hold repeated rows for the same member# (its sort key includes a per-row UUID), which would fan out through the LEFT JOIN.subquery = f"(SELECT DISTINCT person_id, 1 AS matched FROM static_cohort_people WHERE cohort_id = {{{cohort_id_placeholder}}})"+ member_conditions.append(+ f"person_id IN (SELECT person_id FROM static_cohort_people WHERE cohort_id = {{{cohort_id_placeholder}}})"+ )else:version_placeholder = f"version_{idx}"placeholders[version_placeholder] = ast.Constant(value=version)subquery = f"(SELECT person_id, 1 AS matched FROM raw_cohort_people WHERE cohort_id = {{{cohort_id_placeholder}}} AND version = {{{version_placeholder}}})"+ member_conditions.append(+ f"person_id IN (SELECT person_id FROM raw_cohort_people WHERE cohort_id = {{{cohort_id_placeholder}}} AND version = {{{version_placeholder}}})"+ )join_clauses.append(f"LEFT JOIN {subquery} AS {alias} ON {alias}.person_id = pdi.person_id")@@ -112,6 +119,15 @@ class CohortPropertyGroupsSubQuery(SessionRecordingsListingBaseQuery):else:combined_where = " OR ".join(f"({cond})" for cond in where_conditions)+ # Without a prefilter, the argMax aggregation below holds every distinct_id of the team in memory.+ # When all filters are IN, a distinct_id can only match if one of its rows points at a cohort member,+ # so the aggregation can skip the other distinct_ids. The aggregation still reads all rows of the kept+ # distinct_ids, so a distinct_id that moved out of the cohort resolves to its current person.+ # NOT IN must keep every distinct_id, because a person outside the cohort matches it.+ distinct_id_prefilter = ""+ if not any(is_negated for _, is_negated, _, _ in cohort_filters):+ distinct_id_prefilter = f"AND distinct_id IN (SELECT distinct_id FROM raw_person_distinct_ids WHERE {' OR '.join(member_conditions)})"+query_template = f"""SELECT pdi.distinct_id AS distinct_idFROM (@@ -121,6 +137,7 @@ class CohortPropertyGroupsSubQuery(SessionRecordingsListingBaseQuery):argMax(is_deleted, version) AS is_deletedFROM raw_person_distinct_idsWHERE team_id = {{team_id}}+ {distinct_id_prefilter}GROUP BY distinct_idHAVING is_deleted = 0) AS pdidiff --git a/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.ambr b/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.ambrindex 5b121997ebc1..61a8e056eba0 100644--- a/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.ambr+++ b/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.ambr@@ -48,7 +48,16 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), or(in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0)))), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0)))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -176,7 +185,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -351,7 +366,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -422,7 +443,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -483,7 +510,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -558,7 +591,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT person_static_cohort.person_id AS person_id+ FROM person_static_cohort+ WHERE and(equals(person_static_cohort.team_id, 99999), equals(person_static_cohort.cohort_id, 99999))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -668,7 +707,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -1252,7 +1297,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -1372,7 +1423,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOINdiff --git a/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.new_events_schema.ambr b/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.new_events_schema.ambrindex c2a1f3ed5093..1937712f7ca6 100644--- a/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.new_events_schema.ambr+++ b/posthog/session_recordings/queries/test/listing_recordings/__snapshots__/test_session_recordings_list_by_cohort.new_events_schema.ambr@@ -34,7 +34,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN@@ -97,7 +103,13 @@FROM(SELECT person_distinct_id2.distinct_id AS distinct_id, argMax(person_distinct_id2.person_id, person_distinct_id2.version) AS person_id, argMax(person_distinct_id2.is_deleted, person_distinct_id2.version) AS is_deletedFROM person_distinct_id2- WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999))+ WHERE and(equals(person_distinct_id2.team_id, 99999), equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.distinct_id,+ (SELECT person_distinct_id2.distinct_id AS distinct_id+ FROM person_distinct_id2+ WHERE and(equals(person_distinct_id2.team_id, 99999), in(person_distinct_id2.person_id,+ (SELECT cohortpeople.person_id AS person_id+ FROM cohortpeople+ WHERE and(equals(cohortpeople.team_id, 99999), equals(cohortpeople.cohort_id, 99999), equals(cohortpeople.version, 0))))))))GROUP BY person_distinct_id2.distinct_idHAVING equals(is_deleted, 0)) AS pdiLEFT JOIN