:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(subscriptions): treat 404 from summaries endpoint as no summaries (#118107)
posthog[bot]476b9c2bbe76
diff --git a/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.test.ts b/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.test.tsindex 7b064badf672..2a63047d1929 100644--- a/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.test.ts+++ b/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.test.ts@@ -1,5 +1,6 @@import { expectLogic } from 'kea-test-utils'+import { ApiError } from 'lib/api-error'import { FEATURE_FLAGS } from 'lib/constants'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'@@ -62,6 +63,24 @@ describe('subscriptionSummariesLogic', () => {})+ it.each([+ { status: 404, expectedSummaries: [] },+ { status: 500, expectedSummaries: null },+ ])(+ 'treats only a 404 from the summaries endpoint as no summaries ($status)',+ async ({ status, expectedSummaries }) => {+ featureFlagLogic.actions.setFeatureFlags([], { [FEATURE_FLAGS.SUBSCRIPTION_SOURCE_SUMMARIES]: true })+ mockSummariesList.mockRejectedValue(new ApiError('Request failed', status))+ logic = subscriptionSummariesLogic({ insightId: 3 })+ logic.mount()++ await expectLogic(logic)+ .toFinishAllListeners()+ .toMatchValues({ summaries: expectedSummaries, latestSummary: null })+ expect(mockSummariesList).toHaveBeenCalledTimes(1)+ }+ )+it('loads summaries when the flag turns on after the component is already mounted', async () => {featureFlagLogic.actions.setFeatureFlags([], { [FEATURE_FLAGS.SUBSCRIPTION_SOURCE_SUMMARIES]: false })logic = subscriptionSummariesLogic({ dashboardId: 7 })diff --git a/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.ts b/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.tsindex 5899edae816c..8320ae1d665b 100644--- a/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.ts+++ b/products/subscriptions/frontend/components/SubscriptionSummaries/subscriptionSummariesLogic.ts@@ -2,6 +2,7 @@ import { MakeLogicType, afterMount, connect, kea, key, listeners, path, props, simport { loaders } from 'kea-loaders'import posthog from 'posthog-js'+import { ApiError } from 'lib/api-error'import { FEATURE_FLAGS } from 'lib/constants'import { featureFlagLogic, type FeatureFlagsSet } from 'lib/logic/featureFlagLogic'import { getCurrentTeamId } from 'lib/utils/getAppContext'@@ -84,8 +85,16 @@ export const subscriptionSummariesLogic = kea<subscriptionSummariesLogicType>([{loadSummaries: async (): Promise<SubscriptionSummaryApi[] | null> => {const params = props.dashboardId ? { dashboard: props.dashboardId } : { insight: props.insightId }- const response = await subscriptionsSummariesList(String(getCurrentTeamId()), params)- return response.results+ try {+ const response = await subscriptionsSummariesList(String(getCurrentTeamId()), params)+ return response.results+ } catch (error) {+ // A deleted source or one from another team returns 404, which means there is nothing to show.+ if (error instanceof ApiError && error.status === 404) {+ return []+ }+ throw error+ }},},],