:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(data-modeling): skip non-uuid view ids in stale view column refresh (#130030)
Thiago Salvatore48d2e1d59838
diff --git a/products/data_modeling/backend/logic/view_column_refresh.py b/products/data_modeling/backend/logic/view_column_refresh.pyindex 245a259dcaf4..5ff9ef94aff4 100644--- a/products/data_modeling/backend/logic/view_column_refresh.py+++ b/products/data_modeling/backend/logic/view_column_refresh.py@@ -9,6 +9,7 @@ from django.utils import timezoneimport structlogfrom posthog.clickhouse.client.limit import ConcurrencyLimitExceeded+from posthog.uuidt import UUIDTfrom products.access_control.backend.facade.api import get_restricted_properties_with_group_type_index_for_teamfrom products.access_control.backend.facade.user_access_control import UserAccessControl@@ -38,7 +39,7 @@ def refresh_view_columns(team: "Team", saved_query_ids: Collection[UUID | str],views = {view.id: viewfor view in DataWarehouseSavedQuery.objects.select_related("team")- .filter(team_id=team.pk, id__in=list(saved_query_ids), managed_viewset__isnull=True)+ .filter(team_id=team.pk, id__in=_saved_query_uuids(saved_query_ids), managed_viewset__isnull=True).exclude(deleted=True)}return {view_id for view_id in _upstream_first(team.pk, set(views)) if _refresh_columns(views[view_id], user)}@@ -47,7 +48,7 @@ def refresh_view_columns(team: "Team", saved_query_ids: Collection[UUID | str],def views_updated_since(team: "Team", saved_query_ids: Collection[UUID | str], since: datetime) -> bool:"""Whether any of these views was written after ``since``, for example by another request's refresh."""return DataWarehouseSavedQuery.objects.filter(- team_id=team.pk, id__in=list(saved_query_ids), updated_at__gt=since+ team_id=team.pk, id__in=_saved_query_uuids(saved_query_ids), updated_at__gt=since).exists()@@ -66,6 +67,10 @@ def _readable_by(team: "Team", user: "User | None", view_ids: list[UUID]) -> Colreturn allowed_saved_query_ids(team.pk, UserAccessControl(user=user, team=team), ids=view_ids)+def _saved_query_uuids(saved_query_ids: Collection[UUID | str]) -> list[UUID]:+ return [UUID(str(value)) for value in saved_query_ids if UUIDT.is_valid_uuid(str(value))]++def _infers_masked_columns(team: "Team", user: "User | None") -> bool:return bool(get_restricted_properties_with_group_type_index_for_team(user=user, team_id=team.pk))diff --git a/products/data_modeling/backend/test/test_view_column_refresh.py b/products/data_modeling/backend/test/test_view_column_refresh.pyindex 80b199d5d278..d59ccdeb7e37 100644--- a/products/data_modeling/backend/test/test_view_column_refresh.py+++ b/products/data_modeling/backend/test/test_view_column_refresh.py@@ -6,6 +6,8 @@ from unittest.mock import patchfrom parameterized import parameterized+from posthog.schema import RevenueAnalyticsEventItem+from posthog.hogql.errors import QueryErrorfrom posthog.hogql.property_access_types import RestrictedPropertyfrom posthog.hogql.query import execute_hogql_query@@ -70,6 +72,26 @@ class TestViewColumnRefresh(ClickhouseTestMixin, BaseTest):downstream.refresh_from_db()assert downstream.column_order == ["new_id"]+ def test_query_that_also_reads_an_event_revenue_view_refreshes_the_user_view(self) -> None:+ self.team.revenue_analytics_config.events = [+ RevenueAnalyticsEventItem(eventName="purchase", revenueProperty="amount")+ ]+ self.team.revenue_analytics_config.save()+ upstream = self._create_view("upstream_view", "SELECT 1 AS old_id")+ downstream = self._create_view("downstream_view", "SELECT * FROM upstream_view")+ self._edit_view(upstream, "SELECT 1 AS new_id")++ response = execute_hogql_query(+ "SELECT new_id, (SELECT count() FROM revenue_analytics.events.purchase.charge_events_revenue_view) "+ "FROM downstream_view",+ team=self.team,+ user=self.user,+ )++ assert response.results == [(1, 0)]+ downstream.refresh_from_db()+ assert downstream.column_order == ["new_id"]+def test_query_by_a_property_restricted_reader_leaves_stale_columns_untouched(self) -> None:upstream = self._create_view("upstream_view", "SELECT 1 AS old_id")downstream = self._create_view("downstream_view", "SELECT * FROM upstream_view")