:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(firebase): retry transient errors on read-only firestore posts (#126127)
Tom Owers4a9d01e5902e
diff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/firebase.py b/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/firebase.pyindex ceedc2d31ee9..fd92d3a7fdf5 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/firebase.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/firebase.py@@ -17,7 +17,10 @@ from posthog.dataclasses import frozenfrom products.warehouse_sources.backend.temporal.data_imports.naming_convention import NamingConventionfrom products.warehouse_sources.backend.temporal.data_imports.pipelines.helpers import incremental_type_to_initial_value-from products.warehouse_sources.backend.temporal.data_imports.sources.common.http import make_tracked_session+from products.warehouse_sources.backend.temporal.data_imports.sources.common.http import (+ DEFAULT_RETRY,+ make_tracked_session,+)from products.warehouse_sources.backend.temporal.data_imports.sources.common.resumable import ResumableSourceManagerfrom products.warehouse_sources.backend.temporal.data_imports.sources.common.schema import (incremental_field,@@ -158,11 +161,17 @@ def _auth_session(credentials: FirebaseCredentials) -> requests.Session:return make_tracked_session(redact_values=credentials.secret_values, capture=False)+# Firestore's `listCollectionIds` and `runQuery` are read-only POSTs, so the GET retry policy is safe+# for them. Without it, one transient 503 from Google fails schema discovery in the source wizard.+_API_RETRY = DEFAULT_RETRY.new(allowed_methods=frozenset(DEFAULT_RETRY.allowed_methods or ()) | {"POST"})++def _api_session(credentials: FirebaseCredentials, *, capture: bool = True) -> requests.Session:return make_tracked_session(headers={"Accept": "application/json"},redact_values=credentials.secret_values,capture=capture,+ retry=_API_RETRY,)diff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/tests/test_firebase.py b/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/tests/test_firebase.pyindex fd1a2ec0dadd..2637a8886f31 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/tests/test_firebase.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/firebase/tests/test_firebase.py@@ -20,6 +20,7 @@ from products.warehouse_sources.backend.temporal.data_imports.sources.firebase.fFirebaseResponseTooLargeError,FirebaseResumeConfig,FirestoreIncrementalCursor,+ _api_session,build_jwt_assertion,decode_firestore_value,firebase_source,@@ -199,6 +200,23 @@ class TestAccessTokens:assert mint_access_token(session.as_session(), credentials()) == ("tok-1", expected_lifetime)+class TestApiSessionRetries:+ @pytest.mark.parametrize(+ "method,status_code,expected_retry",+ [+ ("POST", 503, True),+ ("POST", 429, True),+ ("GET", 503, True),+ ("POST", 403, False),+ ],+ )+ def test_read_only_posts_retry_transient_errors(self, method: str, status_code: int, expected_retry: bool) -> None:+ adapter = _api_session(credentials()).get_adapter("https://firestore.googleapis.com")++ assert isinstance(adapter, requests.adapters.HTTPAdapter)+ assert adapter.max_retries.is_retry(method, status_code) is expected_retry++class TestFirestorePagination:def test_pages_and_checkpoints_after_each_yield(self, logger: FilteringBoundLogger) -> None:session = FakeSession(