:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(notebooks): restore the copy action on markdown notebook blocks (#120513)
Tyler Crandall4aff8e257013
diff --git a/frontend/src/lib/components/MarkdownNotebook/MarkdownNotebook.tsx b/frontend/src/lib/components/MarkdownNotebook/MarkdownNotebook.tsxindex d94d33c6ffae..a2d81b9a39b5 100644--- a/frontend/src/lib/components/MarkdownNotebook/MarkdownNotebook.tsx+++ b/frontend/src/lib/components/MarkdownNotebook/MarkdownNotebook.tsx@@ -27,6 +27,7 @@ import { LemonButton, Tooltip } from '@posthog/lemon-ui'import { Spinner } from 'lib/lemon-ui/Spinner'import { findMountedCodeEditorWithin } from 'lib/monaco/mountedCodeEditors'+import { copyToClipboard } from 'lib/utils/copyToClipboard'import { downloadFile, isMac, uuid } from 'lib/utils/dom'import { lazyWithRetry } from 'lib/utils/retryImport'@@ -3520,6 +3521,12 @@ function MarkdownNotebookEditor({writeSystemClipboardText(markdown)}+ const copyComponentNode = (componentNode: NotebookComponentBlockNode): void => {+ const markdown = serializeNotebookNodes([componentNode])+ notebookClipboardMarkdownRef.current = markdown+ void copyToClipboard(markdown, 'block')+ }+const pasteNotebookClipboardAfterNode = (nodeId: string): void => {const fallbackMarkdown = notebookClipboardMarkdownRef.currentconst pasteMarkdown = (markdown: string | null): void => {@@ -7034,6 +7041,8 @@ function MarkdownNotebookEditor({? () => openBtw(serializeMarkdownNotebook({ ...documentRef.current, nodes: [node] })): undefined,askAIDisabledReason,+ // Shared renders have no editor to paste into, matching the legacy notebook's `!isShared` gate.+ copyNode: hideResourceLinks ? undefined : copyComponentNode,deleteNode: () => deleteNodeWithRefCleanup(node.id),deleteNodeAndFocusAdjacent: () => {requestFocusAfterRemovingNode(node.id)diff --git a/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.test.tsx b/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.test.tsxindex 7d8731701516..657273c76d76 100644--- a/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.test.tsx+++ b/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.test.tsx@@ -484,6 +484,45 @@ describe('NotebookComponentShell', () => {expect(menuItems[1].closest('a')?.getAttribute('target')).toBe('_blank')})+ it('copies the block from the overflow menu', async () => {+ const registry = createMarkdownNotebookRegistry([+ { tagName: 'Probe', label: 'Insight', category: 'Test', ViewComponent: () => <div>Results</div> },+ ])+ const node: NotebookComponentBlockNode = {+ id: 'probe-node',+ type: 'component',+ tagName: 'Probe',+ props: { title: 'Weekly activity' },+ }+ const copyNode = jest.fn()++ render(+ <NotebookComponentShell+ node={node}+ mode="view"+ componentPanels={{ filters: false, results: true }}+ persistComponentPanelVisibility={false}+ isSelected={false}+ registry={registry}+ toggleComponentPanel={jest.fn()}+ setLocalComponentPanels={jest.fn()}+ rememberComponentPanels={jest.fn()}+ setBlockRef={jest.fn()}+ updateNode={jest.fn()}+ copyNode={copyNode}+ deleteNode={jest.fn()}+ deleteSelectedNotebookBlocks={jest.fn(() => false)}+ insertParagraphAfterNode={jest.fn()}+ moveFocusToAdjacentNode={jest.fn(() => false)}+ />+ )++ await userEvent.click(screen.getByLabelText('More actions'))+ await userEvent.click(screen.getByText('Copy'))++ expect(copyNode).toHaveBeenCalledWith(node)+ })+it('renders a published fixed title and status without offering title editing', () => {const toggleStatus = jest.fn()diff --git a/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.tsx b/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.tsxindex 0153622eeebf..25d6dc47eed6 100644--- a/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.tsx+++ b/frontend/src/lib/components/MarkdownNotebook/NotebookComponentShell.tsx@@ -95,6 +95,7 @@ export type NotebookComponentShellProps = {updateNode: (nodeId: string, updater: (node: NotebookBlockNode) => NotebookBlockNode | null) => voidonBtw?: () => voidaskAIDisabledReason?: string+ copyNode?: (node: NotebookComponentBlockNode) => voiddeleteNode: () => voiddeleteSelectedNotebookBlocks: () => booleaninsertParagraphAfterNode: () => void@@ -118,6 +119,7 @@ export function NotebookComponentShell({updateNode,onBtw,askAIDisabledReason,+ copyNode,deleteNode,deleteSelectedNotebookBlocks,insertParagraphAfterNode,@@ -192,6 +194,7 @@ export function NotebookComponentShell({targetBlank: true,}: null,+ copyNode ? { label: 'Copy', onClick: () => copyNode(node) } : null,mode === 'edit' && isTitleEditable ? { label: 'Edit title', onClick: () => setIsEditingTitle(true) } : null,...(mode === 'edit'? (toolbarExtras?.actions.map((action) => ({diff --git a/frontend/src/lib/components/MarkdownNotebook/renderNode.tsx b/frontend/src/lib/components/MarkdownNotebook/renderNode.tsxindex 36cb1bab61a8..346a783b0ed5 100644--- a/frontend/src/lib/components/MarkdownNotebook/renderNode.tsx+++ b/frontend/src/lib/components/MarkdownNotebook/renderNode.tsx@@ -24,7 +24,7 @@ import {} from './editorTypes'import { MemoizedNotebookComponentShell } from './NotebookComponentShell'import { NotebookMermaidBlock } from './NotebookMermaidBlock'-import { NotebookBlockNode, NotebookComponentRegistry, NotebookMode } from './types'+import { NotebookBlockNode, NotebookComponentBlockNode, NotebookComponentRegistry, NotebookMode } from './types'export function renderNode({node,@@ -47,6 +47,7 @@ export function renderNode({updateNode,onBtw,askAIDisabledReason,+ copyNode,replaceNodeWithNodes,deleteNode,deleteNodeAndFocusAdjacent,@@ -99,6 +100,7 @@ export function renderNode({updateNode: (nodeId: string, updater: (node: NotebookBlockNode) => NotebookBlockNode | null) => voidonBtw?: () => voidaskAIDisabledReason?: string+ copyNode?: (node: NotebookComponentBlockNode) => voidreplaceNodeWithNodes: (nodeId: string, replacementNodes: NotebookBlockNode[]) => voiddeleteNode: () => voiddeleteNodeAndFocusAdjacent: () => void@@ -201,6 +203,7 @@ export function renderNode({updateNode={updateNode}onBtw={onBtw}askAIDisabledReason={askAIDisabledReason}+ copyNode={copyNode}deleteNode={deleteNode}deleteSelectedNotebookBlocks={deleteSelectedNotebookBlocks}insertParagraphAfterNode={insertParagraphAfterNode}