Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(logs): make time range changes work in full screen (#130044)

Jon McCallum4b2895064cf5
diff --git a/frontend/src/lib/components/DateFilter/DateRangePicker/DateRangePicker.tsx b/frontend/src/lib/components/DateFilter/DateRangePicker/DateRangePicker.tsx
index a43c3e531819..aaac9a75fdb6 100644
--- a/frontend/src/lib/components/DateFilter/DateRangePicker/DateRangePicker.tsx
+++ b/frontend/src/lib/components/DateFilter/DateRangePicker/DateRangePicker.tsx
@@ -100,8 +100,10 @@ export const DateRangePicker = ({
onTimezoneChange,
}: DateRangePickerProps): JSX.Element => {
const logic = dateRangePickerLogic({ key: logicKey })
- const { popoverOpen, customFrom, customTo, history } = useValues(logic)
- const { setPopoverOpen, setCustomFrom, setCustomTo, addToHistory } = useActions(logic)
+ const { customFrom, customTo, history } = useValues(logic)
+ const { setCustomFrom, setCustomTo, addToHistory } = useActions(logic)
+ // Per instance, not in the keyed logic: pickers sharing a logicKey must not open together.
+ const [popoverOpen, setPopoverOpen] = useState(false)
const effectiveTimezone = timezone ?? 'UTC'
const showTimezone = timezone !== undefined && onTimezoneChange !== undefined
diff --git a/frontend/src/lib/components/DateFilter/DateRangePicker/dateRangePickerLogic.ts b/frontend/src/lib/components/DateFilter/DateRangePicker/dateRangePickerLogic.ts
index 6254d4347131..7fa6a55ab555 100644
--- a/frontend/src/lib/components/DateFilter/DateRangePicker/dateRangePickerLogic.ts
+++ b/frontend/src/lib/components/DateFilter/DateRangePicker/dateRangePickerLogic.ts
@@ -7,7 +7,7 @@ const MAX_HISTORY_ITEMS = 5
const dateRangesEqual = (a: DateRange, b: DateRange): boolean => a.date_from === b.date_from && a.date_to === b.date_to
export interface DateRangePickerLogicProps {
- /** Unique per consumer surface ('logs' | 'tracing'); keys popover/custom-input/history state. */
+ /** Unique per consumer surface ('logs' | 'tracing'); keys custom-input/history state. */
key: string
}
@@ -16,7 +16,6 @@ export interface dateRangePickerLogicValues {
customFrom: string
customTo: string
history: DateRange[]
- popoverOpen: boolean
}
// Generated by kea-typegen. Update if you're an agent, ignore if you're human.
@@ -30,9 +29,6 @@ export interface dateRangePickerLogicActions {
setCustomTo: (value: string) => {
value: string
}
- setPopoverOpen: (open: boolean) => {
- open: boolean
- }
}
// Generated by kea-typegen. Update if you're an agent, ignore if you're human.
@@ -52,18 +48,11 @@ export const dateRangePickerLogic = kea<dateRangePickerLogicType>([
key((props) => props.key),
path((key) => ['lib', 'components', 'DateFilter', 'DateRangePicker', 'dateRangePickerLogic', key]),
actions({
- setPopoverOpen: (open: boolean) => ({ open }),
setCustomFrom: (value: string) => ({ value }),
setCustomTo: (value: string) => ({ value }),
addToHistory: (dateRange: DateRange) => ({ dateRange }),
}),
reducers({
- popoverOpen: [
- false,
- {
- setPopoverOpen: (_, { open }) => open,
- },
- ],
customFrom: [
'',
{