:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(warehouse_sources): support OwnerRez API version v2 (#119186)
Tom Owers4d786f9d3fe6
diff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/ownerrez.py b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/ownerrez.pyindex ae40b3bbe354..0a0ba2312feb 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/ownerrez.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/ownerrez.py@@ -27,6 +27,11 @@ OWNERREZ_API_HOST = "api.ownerrez.com"# Required per the vendor's auth guide: "Use a user-agent header to identify yourself on all calls."USER_AGENT = "PostHog Data Warehouse (+https://posthog.com)"+# OwnerRez versions by URL path only. "v1" is the framework's legacy unversioned label, not the+# vendor's v1.1 API: this client has always called /v2 paths, so both labels send identical requests.+OWNERREZ_API_VERSION_V1 = "v1"+OWNERREZ_API_VERSION_V2 = "v2"+@frozenclass OwnerRezResumeConfig:diff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/source.py b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/source.pyindex 0a00cbefd499..a43c943276d0 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/source.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/source.py@@ -23,6 +23,8 @@ from products.warehouse_sources.backend.temporal.data_imports.sources.generated_OwnerrezSourceConfig,)from products.warehouse_sources.backend.temporal.data_imports.sources.ownerrez.ownerrez import (+ OWNERREZ_API_VERSION_V1,+ OWNERREZ_API_VERSION_V2,OwnerRezResumeConfig,ownerrez_source,validate_credentials as validate_ownerrez_credentials,@@ -40,8 +42,8 @@ class OwnerrezSource(ResumableSource[OwnerrezSourceConfig, OwnerRezResumeConfig]lists_tables_without_credentials = True # static endpoint catalog — safe for public docs- # OwnerRez's API is unversioned in practice: paths are pinned under /v2 with no dated- # version header, param, or named release to declare.+ supported_versions = (OWNERREZ_API_VERSION_V1, OWNERREZ_API_VERSION_V2)+ default_version = OWNERREZ_API_VERSION_V2api_docs_url = "https://api.ownerreservations.com/help/v2"@propertydiff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez.py b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez.pyindex fcc11c790340..aa3882fd5de6 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez.py@@ -68,6 +68,13 @@ def _page(items: list[dict[str, Any]], *, next_page_url: str | None = None) -> Sclass TestOwnerrezSourceTransport:+ @parameterized.expand([("unpinned", None), ("v1", "v1"), ("v2", "v2")])+ def test_every_version_calls_v2_paths(self, _name: str, api_version: str | None) -> None:+ result = _driver().run("Properties", [_page([{"id": 1}])], api_version=api_version)++ assert result.raised is None+ assert result.paths == ["/v2/properties"]+def test_follows_next_page_url_until_null(self) -> None:result = _driver().run("Properties",diff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez_source.py b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez_source.pyindex 546ee2b80bf5..00484c799a86 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez_source.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/ownerrez/tests/test_ownerrez_source.py@@ -19,6 +19,10 @@ class TestOwnerrezSource:self.team_id = 123self.config = OwnerrezSourceConfig(email="[email protected]", api_key="pt_key")+ def test_new_sources_default_to_v2(self) -> None:+ assert self.source.supported_versions == ("v1", "v2")+ assert self.source.default_version == "v2"+@pytest.mark.parametrize("status_code, expected_valid, expected_message",[