:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(workflows): drop models outside the workflows gateway pin (#125731)
Jonathan Mieloo50ef6898936d
diff --git a/products/tasks/backend/logic/services/workflow_tasks.py b/products/tasks/backend/logic/services/workflow_tasks.pyindex 8a78fa158767..7c8879aa73e1 100644--- a/products/tasks/backend/logic/services/workflow_tasks.py+++ b/products/tasks/backend/logic/services/workflow_tasks.py@@ -29,7 +29,9 @@ from products.slack_app.backend.facade.api import slack_artifact_delivery_state_from products.slack_app.backend.models import SlackThreadTaskMappingfrom products.slack_app.backend.slack_thread import SlackThreadContextfrom products.tasks.backend.facade import contracts+from products.tasks.backend.logic.services.ai_run_defaults import resolve_ai_run_selectionfrom products.tasks.backend.logic.services.code_usage_gate import usage_limit_response+from products.tasks.backend.logic.services.gateway_model_pin import model_allowed_by_product_pinfrom products.tasks.backend.logic.services.model_catalogue import runtime_adapter_forfrom products.tasks.backend.logic.services.run_actor import (loop_owner_eligible_for_credentials,@@ -42,6 +44,7 @@ from products.tasks.backend.logic.services.workflow_task_skills import (resolve_attached_skills,)from products.tasks.backend.metrics import observe_workflow_task_create+from products.tasks.backend.model_catalog import CLAUDEfrom products.tasks.backend.models import Channel, Task, TaskRunfrom products.tasks.backend.temporal.constants import WORKFLOW_RUN_IDLE_TIMEOUT_SECONDS@@ -221,6 +224,7 @@ def create_workflow_task()gateway_server_ids = resolve_connectors(team.id, connector_ids)+ run_selection = _workflow_run_selection(team.id, owner_id, model)gate_owner = User.objects.filter(id=owner_id).first()if gate_owner is None:@@ -387,8 +391,8 @@ def create_workflow_task(origin_key=origin_key,output_schema=output_schema,extra_run_state=extra_run_state,- runtime_adapter=runtime_adapter_for(model),- model=model,+ runtime_adapter=run_selection.runtime_adapter,+ model=run_selection.model,reasoning_effort=reasoning_effort,slack_thread_context=thread_context,interaction_origin=interaction_origin,@@ -471,6 +475,21 @@ def _task_dto(task: Task, *, created: bool) -> contracts.WorkflowTaskDTO:return contracts.WorkflowTaskDTO(task_id=task.id, run_id=run.id if run is not None else None, created=created)+@frozen+class _WorkflowRunSelection:+ runtime_adapter: str | None+ model: str | None+++def _workflow_run_selection(team_id: int, owner_id: int, model: str | None) -> _WorkflowRunSelection:+ if model and model_allowed_by_product_pin("workflows", model):+ return _WorkflowRunSelection(runtime_adapter=runtime_adapter_for(model), model=model)+ default = resolve_ai_run_selection(team_id, owner_id)+ if model_allowed_by_product_pin("workflows", default.model):+ return _WorkflowRunSelection(runtime_adapter=None, model=None)+ return _WorkflowRunSelection(runtime_adapter=CLAUDE, model=None)++def _find_replayed_task(team_id: int, hog_flow_id: uuid.UUID, origin_key: str | None) -> contracts.WorkflowTaskDTO | None:diff --git a/products/tasks/backend/tests/test_workflow_tasks_api.py b/products/tasks/backend/tests/test_workflow_tasks_api.pyindex c2f99dec7272..76de7a22698e 100644--- a/products/tasks/backend/tests/test_workflow_tasks_api.py+++ b/products/tasks/backend/tests/test_workflow_tasks_api.py@@ -31,7 +31,7 @@ from products.tasks.backend.logic.services.workflow_tasks import (WORKFLOW_TASK_RATE_CAP_PER_DAY,WORKFLOW_TASK_TEAM_RATE_CAP_PER_DAY,)-from products.tasks.backend.models import Channel, Task, TaskRun+from products.tasks.backend.models import Channel, Task, TaskRun, TeamTasksConfigfrom products.tasks.backend.visibility import task_control_q, task_visibility_qfrom products.workflows.backend.facade.team_extension import TeamWorkflowsConfigfrom products.workflows.backend.facade.testing import create_workflow_for_test@@ -176,6 +176,34 @@ class TestWorkflowTasksAPI(APIBaseTest):assert run.state["model"] == modelassert run.state["reasoning_effort"] == "high"+ @parameterized.expand([("zai-org/glm-5.3-flash",), ("deepseek-ai/deepseek-v4-flash-0731",)])+ def test_drops_a_model_outside_the_workflows_gateway_pin(self, model: str) -> None:+ response = self._post({"model": model})++ assert response.status_code == status.HTTP_201_CREATED, response.json()+ run = TaskRun.objects.get(id=response.json()["run_id"])+ assert run.state.get("model") is None+ assert run.state.get("runtime_adapter") is None++ @parameterized.expand([("dropped_model", {"model": "zai-org/glm-5.3-flash"}), ("no_model", {})])+ def test_skips_a_project_default_model_outside_the_workflows_gateway_pin(self, _name: str, body: dict) -> None:+ TeamTasksConfig.objects.update_or_create(+ team=self.team,+ defaults={+ "ai_run_preferences": {+ "runtime_adapter": "claude",+ "model": "zai-org/glm-5.3-flash",+ "reasoning_effort": None,+ }+ },+ )++ response = self._post(body)++ assert response.status_code == status.HTTP_201_CREATED, response.json()+ run = TaskRun.objects.get(id=response.json()["run_id"])+ assert run.state.get("model") is None+def test_dispatches_the_agent_run_after_the_task_commits(self) -> None:with (patch("products.tasks.backend.temporal.client.execute_task_processing_workflow") as dispatch,