:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(slack-app): track failed steps on the workspace setup page (#130764)
Vojta Bartoš53d34dabf560
diff --git a/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.test.ts b/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.test.tsindex c25f80402fd8..0e1f46da9ecc 100644--- a/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.test.ts+++ b/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.test.ts@@ -118,6 +118,45 @@ describe('slackAppWorkspaceSetupLogic', () => {post_welcome: true,})expect(warning).toHaveBeenCalledWith(expect.stringContaining('#growth'))+ expect(capture).toHaveBeenCalledWith('slack app workspace setup step failed', {+ integration_id: 7,+ entry: 'slack_page',+ return_to: 'settings',+ step: 'channels',+ error: 'is_archived',+ })await expectLogic(logic).toMatchValues({ currentStep: null })})++ it.each([+ {+ step: 'default_project',+ fail: () => mockSaveDefaultProject.mockRejectedValue(new Error('Only the installer can do this.')),+ run: (logic: ReturnType<typeof slackAppWorkspaceSetupLogic>) => logic.actions.saveDefaultProject(),+ },+ {+ step: 'channels',+ fail: () => mockJoinChannels.mockRejectedValue(new Error('Only the installer can do this.')),+ run: (logic: ReturnType<typeof slackAppWorkspaceSetupLogic>) => logic.actions.joinChannels(),+ },+ ])('reports a failed $step step and keeps the person on it', async ({ step, fail, run }) => {+ mockRetrieve.mockResolvedValue({ ...BASE, steps: [step] })+ mockChannels.mockResolvedValue({ channels: [] })+ fail()+ const capture = jest.spyOn(posthog, 'capture')++ const logic = slackAppWorkspaceSetupLogic({ integrationId: 7, entry: 'slack_page' })+ logic.mount()+ await expectLogic(logic).toFinishAllListeners()+ await expectLogic(logic, () => run(logic)).toFinishAllListeners()++ expect(capture).toHaveBeenCalledWith('slack app workspace setup step failed', {+ integration_id: 7,+ entry: 'slack_page',+ return_to: null,+ step,+ error: 'Only the installer can do this.',+ })+ await expectLogic(logic).toMatchValues({ currentStep: step })+ })})diff --git a/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.ts b/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.tsindex 2169df340909..731d1a603f45 100644--- a/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.ts+++ b/products/slack_app/frontend/workspace-setup/slackAppWorkspaceSetupLogic.ts@@ -141,6 +141,13 @@ export interface slackAppWorkspaceSetupLogicActions {skipStep: (step: WorkspaceSetupStepKey) => {step: SlackSetupStepKeyEnumApi}+ stepFailed: (+ step: WorkspaceSetupStepKey,+ error: string+ ) => {+ error: string+ step: SlackSetupStepKeyEnumApi+ }}// Generated by kea-typegen. Update if you're an agent, ignore if you're human.@@ -176,6 +183,7 @@ export const slackAppWorkspaceSetupLogic = kea<slackAppWorkspaceSetupLogicType>(actions({completeStep: (step: WorkspaceSetupStepKey) => ({ step }),skipStep: (step: WorkspaceSetupStepKey) => ({ step }),+ stepFailed: (step: WorkspaceSetupStepKey, error: string) => ({ step, error }),selectProject: (integrationId: number) => ({ integrationId }),setSelectedChannelIds: (channelIds: string[]) => ({ channelIds }),setPostWelcome: (postWelcome: boolean) => ({ postWelcome }),@@ -321,6 +329,15 @@ export const slackAppWorkspaceSetupLogic = kea<slackAppWorkspaceSetupLogicType>(saveDefaultProjectSuccess: () => {actions.completeStep('default_project')},+ saveDefaultProjectFailure: ({ error }) => {+ actions.stepFailed('default_project', error)+ },+ loadChannelOptionsFailure: ({ error }) => {+ actions.stepFailed('channels', error)+ },+ joinChannelsFailure: ({ error }) => {+ actions.stepFailed('channels', error)+ },joinChannelsSuccess: ({ joinResults }) => {const failed = (joinResults ?? []).filter((result) => result.error)const names = new Map((values.channelOptions ?? []).map((channel) => [channel.id, channel.name]))@@ -329,6 +346,8 @@ export const slackAppWorkspaceSetupLogic = kea<slackAppWorkspaceSetupLogicType>(lemonToast.warning(`PostHog couldn't join ${failedNames.join(', ')}. Invite it with /invite @PostHog in those channels.`)+ // Slack's refusals arrive in a successful response, so the loader's failure listener never sees them.+ actions.stepFailed('channels', [...new Set(failed.map((result) => result.error))].join(', '))}actions.completeStep('channels')},@@ -338,6 +357,9 @@ export const slackAppWorkspaceSetupLogic = kea<slackAppWorkspaceSetupLogicType>(skipStep: ({ step }) => {posthog.capture('slack app workspace setup step skipped', { ...setupEventProperties(props), step })},+ stepFailed: ({ step, error }) => {+ posthog.capture('slack app workspace setup step failed', { ...setupEventProperties(props), step, error })+ },openSlackClicked: () => {posthog.capture('slack app workspace setup open slack clicked', {...setupEventProperties(props),diff --git a/products/slack_app/frontend/workspace-setup/steps/AIConsentStep.tsx b/products/slack_app/frontend/workspace-setup/steps/AIConsentStep.tsxindex be67254f6c48..0624e45f709e 100644--- a/products/slack_app/frontend/workspace-setup/steps/AIConsentStep.tsx+++ b/products/slack_app/frontend/workspace-setup/steps/AIConsentStep.tsx@@ -17,7 +17,7 @@ export function AIConsentStep(): JSX.Element {const { dataProcessingApprovalDisabledReason } = useValues(aiConsentLogic)const { setPendingApprovalRedirect } = useActions(aiConsentLogic)const { acceptDataProcessing } = useAsyncActions(aiConsentLogic)- const { completeStep, skipStep } = useActions(slackAppWorkspaceSetupLogic)+ const { completeStep, skipStep, stepFailed } = useActions(slackAppWorkspaceSetupLogic)const { location } = useValues(router)const [approving, setApproving] = useState(false)@@ -34,6 +34,9 @@ export function AIConsentStep(): JSX.Element {try {await acceptDataProcessing()completeStep('ai_consent')+ } catch (error) {+ stepFailed('ai_consent', error instanceof Error ? error.message : String(error))+ throw error} finally {setApproving(false)}