:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(replay): skip the logs query when the user has no logs access (#125527)
Jon McCallum549c8afb6026
diff --git a/frontend/src/scenes/session-recordings/player/inspector/PlayerInspectorControls.tsx b/frontend/src/scenes/session-recordings/player/inspector/PlayerInspectorControls.tsxindex 59206732ad4e..4fcaa9a37a01 100644--- a/frontend/src/scenes/session-recordings/player/inspector/PlayerInspectorControls.tsx+++ b/frontend/src/scenes/session-recordings/player/inspector/PlayerInspectorControls.tsx@@ -285,7 +285,7 @@ function CommentsFilterSettingsButton(): JSX.Element {function LogsFilterSettingsButton(): JSX.Element {const { logicProps } = useValues(sessionRecordingPlayerLogic)- const { allItemsByItemType, logsLoading, logsLoadError, logsInitialLoadRequested } = useValues(+ const { allItemsByItemType, logsLoading, logsLoadError, logsInitialLoadRequested, logsAccessDenied } = useValues(playerInspectorLogic(logicProps))@@ -319,13 +319,15 @@ function LogsFilterSettingsButton(): JSX.Element {)}- const disabledReason = logsLoading- ? 'Loading logs...'- : !logsInitialLoadRequested- ? "Logs load after the recording's events load"- : logsLoadError- ? 'Failed to load logs for this session'- : undefined+ const disabledReason = logsAccessDenied+ ? "You don't have access to logs in this project"+ : logsLoading+ ? 'Loading logs...'+ : !logsInitialLoadRequested+ ? "Logs load after the recording's events load"+ : logsLoadError+ ? 'Failed to load logs for this session'+ : undefinedreturn (<FilterSettingsButtondiff --git a/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.test.ts b/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.test.tsindex 0bf6ff4489a7..6f101308e3d7 100644--- a/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.test.ts+++ b/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.test.ts@@ -4,7 +4,10 @@ import posthog from 'posthog-js'import { RecordingSnapshot } from '@posthog/replay-shared'+import api from 'lib/api'+import { FEATURE_FLAGS } from 'lib/constants'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'+import * as appContext from 'lib/utils/getAppContext'import {PlayerInspectorLogicProps,playerInspectorLogic,@@ -16,7 +19,13 @@ import { snapshotDataLogic } from 'scenes/session-recordings/player/snapshotDataimport { DEFAULT_RECORDING_FILTERS } from 'scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic'import { useMocks } from '~/mocks/jest'-import { RecordingEventType, RRWebRecordingConsoleLogPayload, SessionRecordingType } from '~/types'+import {+ AccessControlLevel,+ AccessControlResourceType,+ RecordingEventType,+ RRWebRecordingConsoleLogPayload,+ SessionRecordingType,+} from '~/types'import { makeExperimentSessionContextItem } from '../../__mocks__/experiment_session_context'import { BLOB_SOURCE_V2, overrideSessionRecordingMocks, setupSessionRecordingTest } from '../__mocks__/test-setup'@@ -725,6 +734,38 @@ describe('playerInspectorLogic', () => {})})+ describe('backend logs', () => {+ afterEach(() => {+ jest.restoreAllMocks()+ })++ it.each([+ ['sends the logs query when the user can read logs', AccessControlLevel.Viewer, 1],+ ['skips the logs query when logs access is none', AccessControlLevel.None, 0],+ ])('%s', (_name, logsAccess, expectedCalls) => {+ jest.spyOn(appContext, 'getAppContext').mockReturnValue({+ effective_resource_access_control: { [AccessControlResourceType.Logs]: logsAccess },+ } as ReturnType<typeof appContext.getAppContext>)+ const querySpy = jest+ .spyOn(api.logs, 'query')+ .mockResolvedValue({ results: [], hasMore: false, nextCursor: 'cursor', maxExportableLogs: 0 })+ featureFlagLogic.actions.setFeatureFlags([FEATURE_FLAGS.SESSION_REPLAY_BACKEND_LOGS], {+ [FEATURE_FLAGS.SESSION_REPLAY_BACKEND_LOGS]: true,+ })++ dataLogic.actions.loadRecordingMetaSuccess({+ id: '1',+ start_time: '2025-01-01T00:00:00.000Z',+ end_time: '2025-01-01T00:01:00.000Z',+ recording_duration: 60,+ } as SessionRecordingType)+ dataLogic.actions.loadEventsSuccess([])++ expect(querySpy).toHaveBeenCalledTimes(expectedCalls)+ expect(logic.values.logsAccessDenied).toBe(logsAccess === AccessControlLevel.None)+ })+ })+describe('console log snapshots', () => {const consoleSnapshot = (timestamp: number,diff --git a/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.ts b/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.tsindex b4b46deef460..7304fa9fbb4c 100644--- a/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.ts+++ b/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogic.ts@@ -410,6 +410,7 @@ export interface playerInspectorLogicValues {showOnlyMatching: boolean // miniFiltersLogicallPerformanceEvents: PerformanceEvent[] // performanceEventDataLogiclogs: LogMessage[] // playerInspectorLogsLogic+ logsAccessDenied: boolean // playerInspectorLogsLogiclogsHasMore: boolean // playerInspectorLogsLogiclogsInitialLoadRequested: boolean // playerInspectorLogsLogiclogsLoadError: boolean // playerInspectorLogsLogic@@ -905,6 +906,7 @@ export const playerInspectorLogic = kea<playerInspectorLogicType>(['logsNextCursor','logsLoadError','logsInitialLoadRequested',+ 'logsAccessDenied','readyToLoadLogs',],],diff --git a/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogsLogic.ts b/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogsLogic.tsindex 76f57469f9af..474442195ab7 100644--- a/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogsLogic.ts+++ b/frontend/src/scenes/session-recordings/player/inspector/playerInspectorLogsLogic.ts@@ -5,9 +5,10 @@ import api from 'lib/api'import { FEATURE_FLAGS } from 'lib/constants'import { Dayjs } from 'lib/dayjs'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'+import { productHasEffectiveNoneAccess } from 'lib/utils/accessControlUtils'import { LogMessage, LogsQuery } from '~/queries/schema/schema-general'-import { FilterLogicalOperator } from '~/types'+import { AccessControlResourceType, FilterLogicalOperator } from '~/types'import type { FeatureFlagsSet } from '../../../../lib/logic/featureFlagLogic'import { sessionRecordingDataCoordinatorLogic } from '../sessionRecordingDataCoordinatorLogic'@@ -42,6 +43,7 @@ export interface playerInspectorLogsLogicValues {end: Dayjs | null // sessionRecordingDataCoordinatorLogicstart: Dayjs | null // sessionRecordingDataCoordinatorLogiclogs: LogMessage[]+ logsAccessDenied: booleanlogsHasMore: booleanlogsInitialLoadRequested: booleanlogsLoadError: boolean@@ -97,7 +99,13 @@ export interface playerInspectorLogsLogicActions {export interface playerInspectorLogsLogicMeta {key: string__keaTypeGenInternalSelectorTypes: {- readyToLoadLogs: (featureFlags: FeatureFlagsSet, start: Dayjs | null, end: Dayjs | null, arg: any) => boolean+ readyToLoadLogs: (+ featureFlags: FeatureFlagsSet,+ logsAccessDenied: boolean,+ start: Dayjs | null,+ end: Dayjs | null,+ arg: any+ ) => boolean}}@@ -205,15 +213,22 @@ export const playerInspectorLogsLogic = kea<playerInspectorLogsLogicType>([],})),selectors(() => ({+ // Users with no logs access get a 403 from the logs API, so readyToLoadLogs stays false for them.+ logsAccessDenied: [() => [], (): boolean => productHasEffectiveNoneAccess(AccessControlResourceType.Logs)],readyToLoadLogs: [- (s) => [s.featureFlags, s.start, s.end, (_, props) => props.sessionRecordingId],+ (s) => [s.featureFlags, s.logsAccessDenied, s.start, s.end, (_, props) => props.sessionRecordingId],(featureFlags: import('lib/logic/featureFlagLogic').FeatureFlagsSet,+ logsAccessDenied: boolean,start: Dayjs | null,end: Dayjs | null,sessionRecordingId): boolean =>- !!featureFlags[FEATURE_FLAGS.SESSION_REPLAY_BACKEND_LOGS] && !!start && !!end && !!sessionRecordingId,+ !!featureFlags[FEATURE_FLAGS.SESSION_REPLAY_BACKEND_LOGS] &&+ !logsAccessDenied &&+ !!start &&+ !!end &&+ !!sessionRecordingId,],})),])