Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(funnels): remove funnel-steps-bar-labels flag (#116848)

Sam Pennington5699117bfcf8
diff --git a/frontend/snapshots.yml b/frontend/snapshots.yml
index d46815801d0b..4bad9e9a8dbd 100644
--- a/frontend/snapshots.yml
+++ b/frontend/snapshots.yml
@@ -505,9 +505,9 @@ snapshots:
components-cards-insight-card--access-control-manager-access--light:
hash: v1.k794b7964.0431bdfb0012bc06a0c27570a66b6639b9fcab5c6d2c871893adbf2fc996d325.N4VtYwiHepp7lYjreIZcUjItBZwyQ1ctUjD-NJU7fRo
components-cards-insight-card--access-control-mixed-permissions--dark:
- hash: v1.k794b7964.4d59a5a59dede8fb691ca62e8426dc8a0a0577988081c019767a05f9cee8bfd9.mcDb3gqkMG06AiA5hTbI3lAr7P0GQiWHtD_QIHhgrAA
+ hash: v1.k794b7964.9d5066f60a94602a4f31bc7960465e0c0a84a619702bbe85f9bf58a31dfe61c4.pTg9ylnH4yACMIOEbZU7AJ5ECaPzXljJvUc2J-cCZOw
components-cards-insight-card--access-control-mixed-permissions--light:
- hash: v1.k794b7964.eeea1313835a64f1693ce963a1ce95806745c5f6d908ffd06f41e0b83aec968e.Q7qCtJE-fYzohNXcpgXsnExB5FJ9UdkUY1MRWyLcR_M
+ hash: v1.k794b7964.a63b7608f3a9a19b71b81f3ee51b9344917a731da69ad2e2f43fc646dc4ecd24.pudWVLHfFTxHUHaiGW7j-CLqEGoBDSXUd9INH4L2cCc
components-cards-insight-card--access-control-no-access--dark:
hash: v1.k794b7964.fb149599ab5c3584c0979d57bc6cc38c695388fa8fe4e48a2f69ef0a1fbb58ec.8s4BbLU8yRqY3xI7Suo6Pk8DFPtVo7QGRBohDWojYs0
components-cards-insight-card--access-control-no-access--light:
@@ -529,9 +529,9 @@ snapshots:
components-cards-insight-card--error-states--light:
hash: v1.k794b7964.4d8783224442312d41b2a287eadb0fffa7922c3308be4cbed5588dd0c5ac56aa.5ZmPvR8Y-7ANS-18aHI1NqbOuLRYUbr278Fv133lAec
components-cards-insight-card--insight-card--dark:
- hash: v1.k794b7964.202e31ff4f195a15a226fc65795830fabaca4d0f9775a1b62f44baed548c3036.5KvC-4R69dy1qPw3WAFh5palZD8tXmWhQQNhaQK2xV4
+ hash: v1.k794b7964.5d1f26eec5f4d3be14859072647dd74e08497620da1bc718990be951279dfc77.UlGuWII_GYd3amdM91aSG06oER8Gqc3shFktqotRgtM
components-cards-insight-card--insight-card--light:
- hash: v1.k794b7964.2b9d9122b7a8949469daef5432df4c590c1f5cffeaef6929c644d5a2101c82b6.0wC_Z5xp9Hx18a_z7R4FK1Jj47_sJMJQcd-AKTAp6bw
+ hash: v1.k794b7964.39871a6e8998cfefdf2d99fb9aea164b286177406faf2a4175d47a4062e52bef.5zVfKttePa7VlApk6M75eHR7vBLIVOlAC1NID2ii2kI
components-cards-insight-card--warehouse-sync-warning--dark:
hash: v1.k794b7964.a2bf1677c0ca6c9d9ea5c52776a00006a9e84c4c35e0a0c7dfeb70ad7eac767c.8r2jeOLV3BYUDiOz2eary3Jf-XbUPY3v9q8bOP4khGQ
components-cards-insight-card--warehouse-sync-warning--light:
@@ -3937,57 +3937,49 @@ snapshots:
insights-funnellinechart--with-legend--light:
hash: v1.k794b7964.d3d505f78dc4785055c98a602b0edd9c39549001dab1a3f1c3bf753f1cff60be.Lu6z04Zq2foZ5axwQK8Hg4ys33BYX2OIMjQkpYBycKM
insights-funnelstepsbarchart--alert-thresholds--dark:
- hash: v1.k794b7964.f07a01625198eb67f2bf3709a2b562abf1e5c9fb6e0ad50d32bc3c0455810e4c.kcHPaKTNWm1MsjfK7ZXC-YOSHARImNlxhU63hmrI9zk
+ hash: v1.k794b7964.f5d5e505d99571ec39404621acb2a3bbfcf6a61e5f3569cbc4b81249b646418c.2Ba0lEZr4VcVG6g60MtLt15ZzFdXcOrmu4MQdGOe6ck
insights-funnelstepsbarchart--alert-thresholds--light:
- hash: v1.k794b7964.1615420c253f38e627b2d08757e17d1bd748369b520353077fb7cb69b60ce73d.fckv-4nelywj6ArxmnSQa8Xt5h6ZySRMvXTpCuoTF-A
- insights-funnelstepsbarchart--bar-labels--dark:
- hash: v1.k794b7964.5de2ee4fdd7ba021e1af1363b1e7977b10a245ce3ae6486008b83552cc41296d.tMGnyCUxbncHrGz42VrPrOAdXqsv6oqpZP2N6hjMW48
- insights-funnelstepsbarchart--bar-labels--light:
- hash: v1.k794b7964.92a4ba706ab7e815129fda18a18edf460100e74bb965dadcd5f9523c40215479.YIUpY2DlL_TDsfoZsTO_95xWdZ7YmrcCoHbEJomgdFU
- insights-funnelstepsbarchart--bar-labels-breakdown--dark:
- hash: v1.k794b7964.d3675eb469f32b3a3767a993ebae285cf78dadaeece9b92bd9fc5e91080b6068.Lsx3bzPCJAlujEQn8J9l7O77jhh10eNRXSiDPoVe7r4
- insights-funnelstepsbarchart--bar-labels-breakdown--light:
- hash: v1.k794b7964.2c3c0f0066ab4d0d241134e6de2ddd48c34ec5996e06067e8097a20a62922cf8.K2qM77LHmP27bs4qp40o8hdxMSEsznlBDv8V2F_BMR4
- insights-funnelstepsbarchart--bar-labels-many-steps--dark:
- hash: v1.k794b7964.d8c49417def3a54db958e7bbf990e0d3b4b43e7203761d24c226b37b0cefd380.mVnR4EgzRXJHZUt-g7PmieIOc6z5lJkrQfsMjmPzzE0
- insights-funnelstepsbarchart--bar-labels-many-steps--light:
- hash: v1.k794b7964.d2e4b9ce0b7c4d694825ad4faf79fc57dec0b8ec49f2d01e9ddfd105f634188d.x3V1W4dTNNFPUo2wjZO5y9O1vnIsFGfaWbfQCm9nZMQ
+ hash: v1.k794b7964.23f7a72873beda0cc8bdfbd9f9e6e06a329ace0037b418779c54163532e2c44a.mrtL58e9KZRBJ8R4rfm444m_LpkevD-Fd4sPNTSoTSg
insights-funnelstepsbarchart--breakdown--dark:
- hash: v1.k794b7964.790ff5760fabe3a875385fc7f09cd89d8096abf331d4b36a59abee7f0a35bc23.3uG4AjVvDhojZ8UlnAa4vzwgAdjl3zsbKVnN6ysAHls
+ hash: v1.k794b7964.c2d92698867480a543c6eb6169fc4036f4835b492b41c08a8fa26f408788fd3e.z8RRXnyR_lm8QnwMAm67PMkIhJsiUzeIWn8iKs10fm4
insights-funnelstepsbarchart--breakdown--light:
- hash: v1.k794b7964.5377c4cbd353925545d9a4cf58c42631fd5447b412f9f3aab9fb12ee13f99878.bySipaP4HU1OJt8OJU5gt5gVrEASKJrpkjQvrMoAbEY
+ hash: v1.k794b7964.7aab3a665d4b41136170ab92ee2b0e064a7863cca8ae4a7d4995565b197b5ed7.gTeYEv2NOKLyETrIK5Fr1j_Fsyd1xJFrQ6ir80E2FxM
insights-funnelstepsbarchart--breakdown-and-compare--dark:
- hash: v1.k794b7964.0918b80c0a0cb8241156b91c339804a51e41fc83df7b23073630209646ccbece.rLJeJH6rThJOaS74eCwaT58KsCrhtNRybXjZykbmO8I
+ hash: v1.k794b7964.e20cc018206fa15f6766f29dbdce5e2c0c39b99f9fbc18849825ea5380e45847.46rxhGsVTIfKfbmuLelK8N-QZ4mGTBamGIwvgiouihE
insights-funnelstepsbarchart--breakdown-and-compare--light:
- hash: v1.k794b7964.2931f5bf248bb5f5e86f6885783a33ff11e211284425e0ca814cff84e9aa9402.vXewdVSTepVqG5y3T1CurANseNbfvO3kX-CSSS_Fj20
+ hash: v1.k794b7964.efef122126f1e5ef29512640f6c61e7cd1d9381e7083f552c0770117bc5d1e3e.EihU8COwmUNJDKrlIUY4bZ2VIoSPhTDUMcWIBA3U-kA
insights-funnelstepsbarchart--compare--dark:
- hash: v1.k794b7964.da944d4a39e08bbe27ff8f6b9125a611dd29b665a57b6636d45aa9a264eacd1b.3tKSb1UqOCSIz7mGfUO70c2lIP9JC3T1Yi1MNFq7TLM
+ hash: v1.k794b7964.7f64c36d9f1ae10b28f7585efc12ea6f73196234f63efe1811f1907ef78214ed.VuHv9LtRTjx2OkDb1wpf87bwYdoLHQeNViomW6R4Puk
insights-funnelstepsbarchart--compare--light:
- hash: v1.k794b7964.be4f02e7675f9fc885e953f17f5534172a72def39a78f087412fc34d1b497fc0.gh4HHfpYGNEIw4eUUwQXsbAueFoJcoFVrJs_NjT1kPg
+ hash: v1.k794b7964.700e58c684da97d4bf6d70220500a753f2ff436b6cfc24fd96713de5b72d5699.wGjG7Qx1ZDGtV4vgi8_mqi1MLfrg8gwQ9cfzMtgHblQ
insights-funnelstepsbarchart--default--dark:
- hash: v1.k794b7964.3d957ad368bb0bd0ba618546b72d5de93e475b4bee4b5ffe03422b99db209d75.TjTXVw0jOcpzA78SFxwyisVFQ9XOZRB4uayDo29eRWo
+ hash: v1.k794b7964.2abe07b2842219c5c9eca1de6cfb49c80bb6edb888a1f7f93697812fe26d4d24.yunreV45IfOrt0P4s0vlxnANtQO93aIB-rXEOb0I_uQ
insights-funnelstepsbarchart--default--light:
- hash: v1.k794b7964.8a0522ec815ea8cc16cf80d267e59d19f1e252cb224046f990aac1813ede5471.OoVj4JjpY5y8uKoARS5NKsrL35_8Isiaz368TQrdH88
+ hash: v1.k794b7964.5d929eb0ffb601e274b9d9421eac5ef0ac6904a96019aef0564fbe60aae54f7b.ARsZBqiIEHpxi_ALbgR5Bodsw97BpnsTCWv-GLDdGDA
insights-funnelstepsbarchart--edit-scene--dark:
- hash: v1.k794b7964.7a808ef6465b805e0b3d60b9a3c42a9c564d58db9dd810fa6b22b65a1109c9cd.55RXNeqQzrRDEFDfZf6Qgf3Jy_7z1lQcDOXdT5nM7VY
+ hash: v1.k794b7964.077b08443b4c222196af8c7ec15402af0695206c407a04417492136f4c60135c.NbT9gRjVRodiV8DPmqC23QyroY7MtFOfl4GUv42qnOw
insights-funnelstepsbarchart--edit-scene--light:
- hash: v1.k794b7964.944c542e36c004a661a16fb182d29822efd68050bca1a6ba3476de9ea2e9330f.7siA4PBt54AuV-AhfV-jFM7Ek_oSpv6AaIvbaF8wEr4
+ hash: v1.k794b7964.f5ff377b6354c9297ff5400ca90a9e1c7825accdffbaf9bd10486e7cec1659b4.aKhUrtFxg29XLWeKs2gNmar_om31xO2mp8Mv71RV7eQ
insights-funnelstepsbarchart--edit-scene-viewports--medium--dark:
- hash: v1.k794b7964.0f3f42b9162817e6584c3073bdbc42054a4f12a78b576d60d03dd34c1565b0d4.5rsWaIpEA5z8PtTRn7A6A9RaUouNgij5y9-nNG-gtLw
+ hash: v1.k794b7964.1a363428ae3a81cfd2dc0240e9bfab8f6424919d4608e96652c93c9e793ba6c3.JWisF7b03uqLIo3e5FvsV7newRK6iW4hKruNs8rxp9o
insights-funnelstepsbarchart--edit-scene-viewports--medium--light:
- hash: v1.k794b7964.f0dd5bc79f26b8d58bcb2bb3908db17048f49f22ef6e5fe8261a65a0297757f6.ZGr7l_lzhXvDbwIXbaa9-8RmLIDeGgyaUjuFclE2IIQ
+ hash: v1.k794b7964.04e52f036fe1629c030b37e24c3828afe77f30e5058eb973795fab5d72299c35.QEVRlBr_cF8nFuQqgVMlMfvGXKgNGFTXSUThNpq4s2U
insights-funnelstepsbarchart--edit-scene-viewports--superwide--dark:
- hash: v1.k794b7964.7b0b6d35173a9ba24003f86ca529a8eca60668a4afa76b115d773faefc45c74d.ketbuWMrAkdk5J529QPwPiuKRo3KtCieBIm_wMvYi1M
+ hash: v1.k794b7964.2734141eea2a648641af1a7bc40cc909aafa8da96bf82afe6bbb2cffc35f5386.4pOkxU_IIY9p2C1sZ50qDpj7vudqmGObiYUiKK0Ilgk
insights-funnelstepsbarchart--edit-scene-viewports--superwide--light:
- hash: v1.k794b7964.d149e93eea28903df05aa3c6e0d8a5bc19f06529b27780eb93a3c1f96c57e8ce.a7L85prxcatYb6IuMhfX9wgzSU2vogW6I6xCt7JH4nw
+ hash: v1.k794b7964.d557120fdbfe9e4b8a7ae56c9ab2e498b8655473794703d94c98dcfa3a652d36.8JK8ksPqHOyI6tjUYQZzc1LSg3x1HzI96njY5uwncyo
insights-funnelstepsbarchart--edit-scene-viewports--wide--dark:
- hash: v1.k794b7964.7a808ef6465b805e0b3d60b9a3c42a9c564d58db9dd810fa6b22b65a1109c9cd.Wu7bXuAuqgNT6sxiZ2JOfJ5cNPDOdgsEWH8n_jntIcA
+ hash: v1.k794b7964.077b08443b4c222196af8c7ec15402af0695206c407a04417492136f4c60135c.B_SUWCEdZHU41X_wsBH94I75HadiyFPP6oHjpb3p2qc
insights-funnelstepsbarchart--edit-scene-viewports--wide--light:
- hash: v1.k794b7964.944c542e36c004a661a16fb182d29822efd68050bca1a6ba3476de9ea2e9330f.ovOYU-ey09DfEXCbU3kUYN469O5NRbsGHIf7Z__qFrk
+ hash: v1.k794b7964.f5ff377b6354c9297ff5400ca90a9e1c7825accdffbaf9bd10486e7cec1659b4.8-0toy5KD5C40Fp2n8OsgN89h3kzFU5q4pG7hAjlF0w
insights-funnelstepsbarchart--edit-scene-with-inline-events--dark:
- hash: v1.k794b7964.2be8a4664b003638e0cebb9289412a8f6407c8d6cea8c88f50e8c7b164ef214d.o20jpTyQ8Vk7kUSSKon4exHjEldB4mW3blQt4YwsRdA
+ hash: v1.k794b7964.24ce4c432f150ec6914e8323f3b2aead0a9c3fd133ccde9f62515a98778c60af.Jm_MfoCaI7elrpZqa3cF1TOyWF9U60y07ErkL1AI8WE
insights-funnelstepsbarchart--edit-scene-with-inline-events--light:
- hash: v1.k794b7964.fb44bae35519b5972ccc7fda97e803dd0f617d31877f6474bdf345b0249babd0.IeucwBZomVxB6_0114pIyap889C-8toZSXeA_D8seiE
+ hash: v1.k794b7964.62398020a9f02be9249df81d93daec24d16e7089040f6b17c0a3d77632696454.4Mwu5zbhI4cP_IFVw1E5wtCMlp4riOB_s1ZRrVfKwe4
+ insights-funnelstepsbarchart--many-steps--dark:
+ hash: v1.k794b7964.d8c49417def3a54db958e7bbf990e0d3b4b43e7203761d24c226b37b0cefd380.r9Am9aFzlywAm7aCjhIxuq8-y0j4Fe9oM0I4D36Wvnc
+ insights-funnelstepsbarchart--many-steps--light:
+ hash: v1.k794b7964.d2e4b9ce0b7c4d694825ad4faf79fc57dec0b8ec49f2d01e9ddfd105f634188d.ix5ZKs_6HmA-2eGa7f-KaueZZvnIpKPdNIJgs--WeLM
insights-funneltimetoconverttable--default--dark:
hash: v1.k794b7964.39fad6f5fd14cdf0e6d9e538cdc8eea2d6b0dbfc9f215c6226ae1b014b8b0c61.FEIbcPsm2lRRriC_2UPs1yryWU9SP5QiilC5IxwanY4
insights-funneltimetoconverttable--default--light:
@@ -7153,9 +7145,9 @@ snapshots:
products-dashboards-tiles-image-tile-modal--existing-image--light:
hash: v1.k794b7964.a6f0232a7044b1a581e4beb9105ee9c00bbed9748fdfcd1c3c1a232acfa0333c.D40_QysPPcg1v2fjLF3-6qPyFXkBZ9rrdYat6l6djGU
products-dashboards-tiles-tile-decorations--cheeky-hog-on-hover--dark:
- hash: v1.k794b7964.8c27598f3437c8b7dd91c39d66ad86b5aeb31cae24ab3194540c28acc625324f.vnJKNEFZpfk6LtCs-t4iEC_nVByvZ3xL8RTsHphOv9Y
+ hash: v1.k794b7964.5c7969e266c49a47d8e89006ab3edb1a345d5c1a9b11a4ca16c4152f7c0a3310.UGi0v6vEqRLgIF7A1CWhVMQhGoJJkAoX-xG7hCjCEcs
products-dashboards-tiles-tile-decorations--cheeky-hog-on-hover--light:
- hash: v1.k794b7964.471204110598501753a3589b034f63b02e11a97f8d3130eb0186672d451111b0.fV4BoD_yh9_fSqt48a5YzHveQXR1UzM57a5UAQ3DDsU
+ hash: v1.k794b7964.a452a2108b65bb8bb362f5af78b7573f147667a66cc03c80fa6683e25fdad978.KG9g3eA5O4OYBgH0bbGIyDb9Yob_hIIsjAi08humM3Y
products-dashboards-tiles-tile-decorations--winner-with-group-title--dark:
hash: v1.k794b7964.762601bb7a59d6ca5aaad78a8f470aebfb3907f4714d2d534bf7353a54525c6d.iojbhy_Og8NozcL_fVG45sNdo7zUx4nAPUZVa80uFyI
products-dashboards-tiles-tile-decorations--winner-with-group-title--light:
diff --git a/frontend/src/lib/constants.tsx b/frontend/src/lib/constants.tsx
index 578481ea3b19..22bb3453884d 100644
--- a/frontend/src/lib/constants.tsx
+++ b/frontend/src/lib/constants.tsx
@@ -186,7 +186,6 @@ export const FEATURE_FLAGS = {
EXPERIMENT_ACTIVATION_EVENT: 'experiment-activation-event', // owner: #team-experiments, offers an activation event on top of the default exposure instead of legacy custom exposure events
EXPERIMENT_EXPOSURE_EVENT: 'experiment-exposure-event', // owner: #team-experiments, switches new experiments to the dedicated exposure event
FUNNEL_BAR_LIST: 'funnel-bar-list', // owner: @sampennington #team-product-analytics, top-to-bottom funnel as a bar list
- FUNNEL_STEPS_BAR_LABELS: 'funnel-steps-bar-labels', // owner: @sampennington #team-product-analytics, left-to-right funnel with value labels on the bars, a name-only step legend and steps that shrink to fit
GAME_CENTER: 'game-center', // owner: everybody, this is just internal for now
HEDGEHOG_SKIN_SPIDERHOG: 'hedgehog-skin-spiderhog', // owner: #team-web-analytics, used to reward beta users for web analytics
HIGH_FREQUENCY_BATCH_EXPORTS: 'high-frequency-batch-exports', // owner: #team-batch-exports, allow batch exports to be run every 5min/15min
diff --git a/playwright/e2e/product-analytics/insights/funnels.spec.ts b/playwright/e2e/product-analytics/insights/funnels.spec.ts
index 9f6eb433ef51..9ad4df42b6e0 100644
--- a/playwright/e2e/product-analytics/insights/funnels.spec.ts
+++ b/playwright/e2e/product-analytics/insights/funnels.spec.ts
@@ -141,12 +141,12 @@ test.describe('Funnel insights', () => {
const step2 = insight.funnels.stepLegend(1)
await expect(step2).toContainText('10')
await expect(step2).toContainText(STEP_2)
- await expect(step2).toContainText('50')
+ await expect(insight.funnels.stepValueLabel(1)).toContainText('50')
const step3 = insight.funnels.stepLegend(2)
await expect(step3).toContainText('5')
await expect(step3).toContainText(STEP_3)
- await expect(step3).toContainText('25')
+ await expect(insight.funnels.stepValueLabel(2)).toContainText('25')
})
await test.step('hover funnel bar to show tooltip', async () => {
@@ -254,9 +254,7 @@ test.describe('Funnel insights', () => {
}
await insight.funnels.waitForChart()
- const step2 = insight.funnels.stepLegend(1)
- const droppedOffButton = step2.getByTestId('funnel-inspect-dropped-off')
- await droppedOffButton.click()
+ await insight.funnels.clickStepDropOff(1)
const modal = page.getByTestId('persons-modal')
await expect(modal).toBeVisible({ timeout: 10000 })
@@ -284,10 +282,8 @@ test.describe('Funnel insights', () => {
await expect(step2).toBeVisible()
await expect(step2.getByTestId('funnel-inspect-converted')).toHaveCount(1)
- await expect(step2.getByTestId('funnel-inspect-dropped-off')).toHaveCount(1)
- const droppedOffButton = step2.getByTestId('funnel-inspect-dropped-off')
- await droppedOffButton.click()
+ await insight.funnels.clickStepDropOff(1)
const modal = page.getByTestId('persons-modal')
await expect(modal).toBeVisible({ timeout: 10000 })
diff --git a/playwright/e2e/product-analytics/notebooks.spec.ts b/playwright/e2e/product-analytics/notebooks.spec.ts
index 10b3d2582b61..534b18e047b8 100644
--- a/playwright/e2e/product-analytics/notebooks.spec.ts
+++ b/playwright/e2e/product-analytics/notebooks.spec.ts
@@ -111,11 +111,11 @@ test.describe('Notebooks', () => {
const step2 = insight.funnels.stepLegend(1)
await expect(step2).toContainText('10')
- await expect(step2).toContainText('50')
+ await expect(insight.funnels.stepValueLabel(1)).toContainText('50')
const step3 = insight.funnels.stepLegend(2)
await expect(step3).toContainText('5')
- await expect(step3).toContainText('25')
+ await expect(insight.funnels.stepValueLabel(2)).toContainText('25')
})
})
diff --git a/playwright/page-models/insights/funnelsInsight.ts b/playwright/page-models/insights/funnelsInsight.ts
index 7628bd6d7bcb..59c19b02c205 100644
--- a/playwright/page-models/insights/funnelsInsight.ts
+++ b/playwright/page-models/insights/funnelsInsight.ts
@@ -9,6 +9,7 @@ export class FunnelsInsight {
readonly histogram: Locator
readonly trendsLineGraph: Locator
readonly stepLegends: Locator
+ readonly stepValueLabels: Locator
readonly layoutSelector: Locator
readonly stepOrderFilter: Locator
readonly tooltip: Locator
@@ -23,6 +24,7 @@ export class FunnelsInsight {
this.histogram = page.getByTestId('funnel-histogram')
this.trendsLineGraph = page.getByTestId('trend-line-graph-funnel')
this.stepLegends = this.verticalChart.getByTestId('funnel-step-legend')
+ this.stepValueLabels = this.verticalChart.getByTestId('hog-chart-value-label')
this.layoutSelector = page.getByTestId('funnel-bar-layout-selector')
this.stepOrderFilter = page.getByTestId('funnel-step-order-filter')
this.tooltip = page.locator('[data-hog-charts-tooltip]')
@@ -139,6 +141,28 @@ export class FunnelsInsight {
return this.stepLegends.nth(index)
}
+ /** Conversion from the first step, drawn above each bar. */
+ stepValueLabel(index: number): Locator {
+ return this.stepValueLabels.nth(index)
+ }
+
+ // The drop-off is the hatched track above a bar on the canvas, so click just above the bar's value label.
+ async clickStepDropOff(index: number): Promise<void> {
+ const label = this.stepValueLabel(index)
+ await expect(label).toBeVisible()
+ const box = (await label.boundingBox())!
+ const x = box.x + box.width / 2
+ const y = box.y - 20
+ // The chart resolves a click from its hover state, so wait for the hover to register
+ // (the tooltip shows) before clicking, or the click can land before the chart knows the step.
+ await expect(async () => {
+ await this.page.mouse.move(x - 5, y - 5)
+ await this.page.mouse.move(x, y)
+ await expect(this.tooltip.first()).toBeVisible({ timeout: 1000 })
+ }).toPass({ timeout: 15000 })
+ await this.page.mouse.click(x, y)
+ }
+
// The steps chart renders its bars onto a canvas, so the tooltip is driven by
// hovering the canvas rather than a per-bar DOM element. Retry the move until
// the tooltip shows, mirroring ChartInsightBase.hoverChartAt.
diff --git a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelBarVertical.scss b/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelBarVertical.scss
index cd4f9f5035f3..e0d6e7ae2c2e 100644
--- a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelBarVertical.scss
+++ b/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelBarVertical.scss
@@ -172,47 +172,6 @@
transform: translateY(-50%);
}
-.StepLegend {
- height: 100%;
- white-space: nowrap;
- border-left: 1px solid var(--color-border-primary);
-
- > .LemonRow {
- min-height: 1.5rem;
- padding: 0 0.5rem;
- margin-top: 0.25rem;
- font-weight: 500;
-
- &:first-child {
- width: fit-content;
- max-width: 100%;
- margin-top: 0;
- font-weight: 600;
- white-space: normal;
-
- .EntityFilterInfo {
- display: -webkit-box;
- -webkit-line-clamp: 5;
- -webkit-box-orient: vertical;
- overflow: hidden;
-
- // `anywhere` (unlike `break-word`) shrinks the intrinsic min-content width, so an
- // unbroken event name wraps instead of blowing the row past its step column.
- overflow-wrap: anywhere;
- }
- }
-
- .LemonRow__main-area {
- align-items: flex-start;
- }
- }
-
- .funnel-inspect-button {
- font-weight: inherit;
- line-height: 1.5rem;
- }
-}
-
.StepNameLabel {
container-type: inline-size;
height: 100%;
diff --git a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.stories.tsx b/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.stories.tsx
index a9e575bf92da..68ee61c93077 100644
--- a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.stories.tsx
+++ b/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.stories.tsx
@@ -2,7 +2,6 @@ import { Meta, StoryObj } from '@storybook/react'
import { BindLogic } from 'kea'
import { useState } from 'react'
-import { FEATURE_FLAGS } from 'lib/constants'
import {
createInsightStory,
expandFirstPropertyFilter,
@@ -98,21 +97,9 @@ const manyStepsFixture = {
},
}
-// One bar per step, so the step to step conversion chips sit in the gaps between steps.
-export const BarLabels: Story = {
- render: () => <StoryRender insightFixture={funnelTopToBottomFixture} />,
- parameters: { featureFlags: [FEATURE_FLAGS.FUNNEL_STEPS_BAR_LABELS] },
-}
-
// Steps shrink to fit the width instead of scrolling, with the rate on each bar.
-export const BarLabelsManySteps: Story = {
+export const ManySteps: Story = {
render: () => <StoryRender insightFixture={manyStepsFixture} width={1520} />,
- parameters: { featureFlags: [FEATURE_FLAGS.FUNNEL_STEPS_BAR_LABELS] },
-}
-
-export const BarLabelsBreakdown: Story = {
- render: () => <StoryRender insightFixture={funnelTopToBottomBreakdownFixture} />,
- parameters: { featureFlags: [FEATURE_FLAGS.FUNNEL_STEPS_BAR_LABELS] },
}
export const Breakdown: Story = {
diff --git a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.tsx b/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.tsx
index ea8f9c15585d..701b7c47fd6b 100644
--- a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.tsx
+++ b/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/FunnelStepsBarChart.tsx
@@ -1,4 +1,3 @@
-import clsx from 'clsx'
import { useActions, useValues } from 'kea'
import posthog from 'posthog-js'
import { useCallback, useMemo, type ErrorInfo } from 'react'
@@ -8,8 +7,6 @@ import type { FunnelChartConfig, FunnelStepClickData, TooltipContext } from '@po
import { useChartTheme } from 'lib/charts/hooks'
import { ScrollableShadows } from 'lib/components/ScrollableShadows/ScrollableShadows'
-import { FEATURE_FLAGS } from 'lib/constants'
-import { featureFlagLogic } from 'lib/logic/featureFlagLogic'
import { insightLogic } from 'scenes/insights/insightLogic'
import { groupsModel } from '~/models/groupsModel'
@@ -28,23 +25,21 @@ import {
type FunnelStepsBarSeriesMeta,
} from './funnelStepsBarTransforms'
import { StepConversionChips } from './StepConversionChips'
-import { StepLegend } from './StepLegend'
import { StepNameLabel } from './StepNameLabel'
const MIN_STEP_WIDTH_PX = 144
const MAX_STEP_WIDTH_PX = 240
const PER_BAR_WIDTH_PX = 20
-const LEGACY_CHART_CONFIG: FunnelChartConfig = {
+const CHART_CONFIG: FunnelChartConfig = {
animateHover: true,
- // Keep the chart from collapsing under a tall StepLegend footer.
+ // Keep the chart from collapsing under a tall step footer.
chartMinHeight: 150,
margins: { left: DEFAULT_MARGINS.left },
tooltip: FUNNEL_STEPS_BAR_TOOLTIP_CONFIG,
+ stepFooterAlign: 'center',
}
-const CHART_CONFIG: FunnelChartConfig = { ...LEGACY_CHART_CONFIG, stepFooterAlign: 'center' }
-
const handleChartError = (error: Error, info: ErrorInfo): void => {
posthog.captureException(error, {
feature: 'funnels-steps-bar-chart',
@@ -54,11 +49,8 @@ const handleChartError = (error: Error, info: ErrorInfo): void => {
export function FunnelStepsBarChart({
showPersonsModal: showPersonsModalProp = true,
- inCardView,
}: ChartParams): JSX.Element | null {
const theme = useChartTheme()
- const { featureFlags } = useValues(featureFlagLogic)
- const hasBarLabels = !!featureFlags[FEATURE_FLAGS.FUNNEL_STEPS_BAR_LABELS]
const { insightProps } = useValues(insightLogic)
const {
stepsWithConversionMetrics,
@@ -87,24 +79,21 @@ export function FunnelStepsBarChart({
[steps, getFunnelsColor]
)
- // Feeds the tooltip header only; the visible labels come from the StepLegend footer.
+ // Feeds the tooltip header only; the visible labels come from the StepNameLabel footer.
const stepLabels = useMemo(() => steps.map((step) => String(step.custom_name ?? step.name ?? '')), [steps])
const groupTypeLabel = aggregationLabel(querySource?.aggregation_group_type_index).plural
- const showTime = steps.some((step) => step.average_conversion_time != null)
const breakdownCount = series.length
const conversionChipStepIndexes = useMemo(
() =>
- hasBarLabels
- ? getConversionChipStepIndexes(steps, {
- // The visible steps always carry nested_breakdown, so check the steps before hidden values are filtered out.
- hasBreakdownOrCompare: stepsWithConversionMetrics[0]?.nested_breakdown != null,
- stepReference: funnelsFilter?.funnelStepReference ?? FunnelStepReference.total,
- isStepOptional,
- })
- : [],
- [hasBarLabels, steps, stepsWithConversionMetrics, funnelsFilter?.funnelStepReference, isStepOptional]
+ getConversionChipStepIndexes(steps, {
+ // The visible steps always carry nested_breakdown, so check the steps before hidden values are filtered out.
+ hasBreakdownOrCompare: stepsWithConversionMetrics[0]?.nested_breakdown != null,
+ stepReference: funnelsFilter?.funnelStepReference ?? FunnelStepReference.total,
+ isStepOptional,
+ }),
+ [steps, stepsWithConversionMetrics, funnelsFilter?.funnelStepReference, isStepOptional]
)
const chartWidth = (stepWidthPx: number): number =>
DEFAULT_MARGINS.left +
@@ -152,19 +141,9 @@ export function FunnelStepsBarChart({
if (!step) {
return null
}
- return hasBarLabels ? (
- <StepNameLabel step={step} stepIndex={stepIndex} showPersonsModal={showPersonsModal} />
- ) : (
- <StepLegend
- step={step}
- stepIndex={stepIndex}
- showTime={showTime}
- showPersonsModal={showPersonsModal}
- inCardView={inCardView}
- />
- )
+ return <StepNameLabel step={step} stepIndex={stepIndex} showPersonsModal={showPersonsModal} />
},
- [steps, hasBarLabels, showTime, showPersonsModal, inCardView]
+ [steps, showPersonsModal]
)
if (steps.length === 0) {
@@ -175,19 +154,15 @@ export function FunnelStepsBarChart({
<ScrollableShadows direction="horizontal" className="flex-1" contentClassName="flex h-full flex-col">
{/* eslint-disable-next-line react/forbid-dom-props */}
<div
- className={clsx('flex flex-1 flex-col', hasBarLabels && 'w-full')}
- style={
- hasBarLabels
- ? { minWidth: chartWidth(MIN_STEP_WIDTH_PX), maxWidth: chartWidth(MAX_STEP_WIDTH_PX) }
- : { width: chartWidth(MAX_STEP_WIDTH_PX) }
- }
+ className="flex w-full flex-1 flex-col"
+ style={{ minWidth: chartWidth(MIN_STEP_WIDTH_PX), maxWidth: chartWidth(MAX_STEP_WIDTH_PX) }}
data-attr="funnel-steps-bar-chart"
>
<FunnelChart<FunnelStepsBarSeriesMeta>
steps={stepLabels}
series={series}
theme={theme}
- config={hasBarLabels ? CHART_CONFIG : LEGACY_CHART_CONFIG}
+ config={CHART_CONFIG}
tooltip={renderTooltip}
onStepClick={showPersonsModal ? onStepClick : undefined}
stepFooter={renderStepFooter}
@@ -195,7 +170,7 @@ export function FunnelStepsBarChart({
onError={handleChartError}
>
<FunnelGoalLines />
- {hasBarLabels && <ValueLabels valueFormatter={formatFunnelStepBarLabel} offset={4} />}
+ <ValueLabels valueFormatter={formatFunnelStepBarLabel} offset={4} />
{conversionChipStepIndexes.length > 0 && (
<StepConversionChips steps={steps} stepIndexes={conversionChipStepIndexes} />
)}
diff --git a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/StepLegend.tsx b/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/StepLegend.tsx
deleted file mode 100644
index 582933610b94..000000000000
--- a/products/product_analytics/frontend/insights/funnels/FunnelStepsBarChart/StepLegend.tsx
+++ /dev/null
@@ -1,143 +0,0 @@
-// .StepLegend styles live in FunnelBarVertical.scss; import here so they load on the quill funnel
-// charts that reuse this component (the old FunnelBarVertical that used to pull them in is gone).
-import './FunnelBarVertical.scss'
-
-import { useActions, useValues } from 'kea'
-
-import { IconClock } from '@posthog/icons'
-
-import { EntityFilterInfo } from 'lib/components/EntityFilterInfo'
-import { IconTrendingFlat, IconTrendingFlatDown } from 'lib/lemon-ui/icons'
-import { LemonRow } from 'lib/lemon-ui/LemonRow'
-import { Lettermark, LettermarkColor } from 'lib/lemon-ui/Lettermark'
-import { Tooltip } from 'lib/lemon-ui/Tooltip'
-import { insightLogic } from 'scenes/insights/insightLogic'
-import { userLogic } from 'scenes/userLogic'
-
-import { AvailableFeature, ChartParams, FunnelStepWithConversionMetrics } from '~/types'
-
-import { funnelDataLogic } from '../funnelDataLogic'
-import { funnelPersonsModalLogic } from '../funnelPersonsModalLogic'
-import {
- formatConvertedCount,
- formatConvertedPercentage,
- formatDroppedOffCount,
- formatDroppedOffPercentage,
- formatMedianConversionTime,
- getTooltipTitleForConverted,
- getTooltipTitleForDroppedOff,
-} from '../funnelUtils'
-import { FunnelStepMore } from '../shared/FunnelStepMore'
-import { getActionFilterFromFunnelStep } from '../shared/funnelStepTableUtils'
-import { ValueInspectorButton } from '../shared/ValueInspectorButton'
-
-type StepLegendProps = {
- step: FunnelStepWithConversionMetrics
- stepIndex: number
- showTime: boolean
-} & ChartParams
-
-export function StepLegend({ step, stepIndex, showTime, showPersonsModal, inCardView }: StepLegendProps): JSX.Element {
- const { insightProps } = useValues(insightLogic)
- const { aggregationTargetLabel, funnelsFilter, isStepOptional } = useValues(funnelDataLogic(insightProps))
- const { canOpenPersonModal, isInExperimentContext } = useValues(funnelPersonsModalLogic(insightProps))
- const { openPersonsModalForStep } = useActions(funnelPersonsModalLogic(insightProps))
- const { hasAvailableFeature } = useValues(userLogic)
-
- const isOptionalStep = isStepOptional(stepIndex + 1)
- const isFirstStep = stepIndex === 0
- const isBreakdown =
- Array.isArray(step.nested_breakdown) &&
- step.nested_breakdown?.length !== undefined &&
- !(step.nested_breakdown.length === 1)
-
- const convertedCountPresentationWithPercentage = (
- <>
- {formatConvertedCount(step, aggregationTargetLabel)}
- {!isFirstStep && (
- <>
- {' '}
- <span className="text-secondary">({formatConvertedPercentage(step)})</span>
- </>
- )}
- {/* Spacer used in the card view because the first step has no conversion percentage. */}
- {isFirstStep && inCardView && <span className="inline-block w-[55px]" />}
- </>
- )
- const droppedOffCountPresentationWithPercentage = (
- <>
- {formatDroppedOffCount(step, aggregationTargetLabel)}{' '}
- <span className="text-secondary">({formatDroppedOffPercentage(step)})</span>
- </>
- )
-
- return (
- <div className="StepLegend" data-attr="funnel-step-legend" style={{ opacity: isOptionalStep ? 0.6 : 1 }}>
- {/* Step */}
- <LemonRow
- icon={<Lettermark name={stepIndex + 1} color={LettermarkColor.Gray} />}
- sideIcon={
- hasAvailableFeature(AvailableFeature.PATHS_ADVANCED) && <FunnelStepMore stepIndex={stepIndex} />
- }
- >
- <EntityFilterInfo filter={getActionFilterFromFunnelStep(step)} allowWrap />
- {isOptionalStep ? <div className="ml-1 text-xs font-normal">(optional)</div> : null}
- </LemonRow>
-
- {/* Conversions */}
- <LemonRow
- icon={<IconTrendingFlat />}
- status="success"
- style={{ color: 'unset' }} // Prevent status color from affecting text
- >
- <Tooltip
- title={getTooltipTitleForConverted(funnelsFilter, aggregationTargetLabel, stepIndex)}
- placement="right"
- >
- {!!showPersonsModal && canOpenPersonModal && !isInExperimentContext ? (
- <ValueInspectorButton
- onClick={() => openPersonsModalForStep({ step, stepIndex, converted: true })}
- data-attr="funnel-inspect-converted"
- >
- {convertedCountPresentationWithPercentage}
- </ValueInspectorButton>
- ) : (
- <span>{convertedCountPresentationWithPercentage}</span>
- )}
- </Tooltip>
- </LemonRow>
-
- {/* Drop-offs */}
- {!isFirstStep && (
- <LemonRow
- icon={<IconTrendingFlatDown />}
- status="danger"
- style={{ color: 'unset' }} // Prevent status color from affecting text
- >
- <Tooltip
- title={getTooltipTitleForDroppedOff(funnelsFilter, aggregationTargetLabel)}
- placement="right"
- >
- {showPersonsModal && stepIndex && !isInExperimentContext ? (
- <ValueInspectorButton
- onClick={() => openPersonsModalForStep({ step, stepIndex, converted: false })}
- data-attr="funnel-inspect-dropped-off"
- >
- {droppedOffCountPresentationWithPercentage}
- </ValueInspectorButton>
- ) : (
- <span>{droppedOffCountPresentationWithPercentage}</span>
- )}
- </Tooltip>
- </LemonRow>
- )}
-
- {/* Median conversion time */}
- {!isFirstStep && !isBreakdown && showTime && (
- <LemonRow icon={<IconClock />} title="Median time of conversion from previous step">
- {formatMedianConversionTime(step)}
- </LemonRow>
- )}
- </div>
- )
-}
diff --git a/products/product_analytics/frontend/insights/funnels/shared/funnelStepsBarShared.ts b/products/product_analytics/frontend/insights/funnels/shared/funnelStepsBarShared.ts
index d33635cd1db8..73d2d5a053a0 100644
--- a/products/product_analytics/frontend/insights/funnels/shared/funnelStepsBarShared.ts
+++ b/products/product_analytics/frontend/insights/funnels/shared/funnelStepsBarShared.ts
@@ -13,7 +13,7 @@ export const FUNNEL_STEPS_BAR_SERIES_KEY = 'funnel-steps-bar-series'
export const FUNNEL_STEPS_BAND_PADDING = 0.1
export interface FunnelStepsBarConfigOptions {
- /** Hide x-axis category labels — the web container renders its own StepLegend row instead. */
+ /** Hide x-axis category labels — the web container renders its own StepNameLabel row instead. */
hideXAxis?: boolean
/** Truncate long category (step-name) labels to this px width; omit to render untruncated. */
maxCategoryLabelWidth?: number
@@ -77,7 +77,7 @@ export interface FunnelStepsBarsModel<TMeta = unknown> {
series: Series<TMeta>[]
/** X-axis band labels — 1-based step indices as strings. Always unique, so steps that share an event
* name (e.g. two `$pageview` steps) don't collapse onto one band slot; surfaces map the index back to
- * the step name for display (web's StepLegend row, the MCP app's `xTickFormatter`). */
+ * the step name for display (web's StepNameLabel row, the MCP app's `xTickFormatter`). */
labels: string[]
rows: FunnelStepsBarRow[]
overall: { rate: number; firstCount: number; lastCount: number }
diff --git a/services/mcp/src/ui-apps/components/FunnelVisualizer.tsx b/services/mcp/src/ui-apps/components/FunnelVisualizer.tsx
index 42bfca51557f..01c3a37afe1d 100644
--- a/services/mcp/src/ui-apps/components/FunnelVisualizer.tsx
+++ b/services/mcp/src/ui-apps/components/FunnelVisualizer.tsx
@@ -19,7 +19,7 @@ const TITLE = 'Funnel'
const NOOP = (): void => {}
-// The web container hides the x-axis and renders its own StepLegend row; this compact UI app instead
+// The web container hides the x-axis and renders its own StepNameLabel row; this compact UI app instead
// shows the step names on the axis (truncated) and tracks the cursor with the tooltip.
const CHART_CONFIG = buildFunnelStepsBarConfig({ maxCategoryLabelWidth: 120, tooltipPlacement: 'cursor' })