Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

refactor(experiments): register the experiment file-system type from the product (#125876)

Anders5a808bb267c0
diff --git a/posthog/api/file_system/registrations.py b/posthog/api/file_system/registrations.py
index 371a86b7624a..3d6d8c813e84 100644
--- a/posthog/api/file_system/registrations.py
+++ b/posthog/api/file_system/registrations.py
@@ -107,26 +107,6 @@ def _dashboard_post_restore(context: RestoreContext, dashboard: Any) -> None:
)
-def _experiment_post_restore(context: RestoreContext, experiment: Any) -> None:
- _log_restore_activity(
- context,
- scope="Experiment",
- item_id=experiment.id,
- name=_first_non_blank(getattr(experiment, "name", None)) or "Untitled experiment",
- object_type="experiment",
- )
-
-
-def _experiment_post_delete(context: DeletionContext, experiment: Any) -> None:
- _log_deletion_activity(
- context,
- scope="Experiment",
- item_id=experiment.id,
- name=_first_non_blank(getattr(experiment, "name", None)) or "Untitled experiment",
- object_type="experiment",
- )
-
-
def _insight_post_delete(context: DeletionContext, insight: Any) -> None:
_log_deletion_activity(
context,
@@ -361,15 +341,6 @@ def register_core_file_system_types() -> None:
register_pre_restore_hook("feature_flag", _feature_flag_pre_restore)
register_post_restore_hook("feature_flag", _feature_flag_post_restore)
- register_file_system_type(
- "experiment",
- "experiments",
- "Experiment",
- undo_message="Send PATCH /api/projects/@current/experiments/{id} with deleted=false.",
- )
- register_post_delete_hook("experiment", _experiment_post_delete)
- register_post_restore_hook("experiment", _experiment_post_restore)
-
register_file_system_type(
"insight",
"product_analytics",
diff --git a/products/experiments/backend/apps.py b/products/experiments/backend/apps.py
index 44ee53940e74..2810eec9fcd3 100644
--- a/products/experiments/backend/apps.py
+++ b/products/experiments/backend/apps.py
@@ -8,6 +8,15 @@ class ExperimentsConfig(AppConfig):
def ready(self) -> None:
# Registers the activity and change signal receivers after the app registry is ready.
+ from posthog.api.file_system.deletion import ( # noqa: PLC0415
+ DeletionContext,
+ RestoreContext,
+ register_file_system_type,
+ register_post_delete_hook,
+ register_post_restore_hook,
+ )
+ from posthog.helpers.impersonation import is_impersonated # noqa: PLC0415
+ from posthog.models.activity_logging.activity_log import Change, Detail, log_activity # noqa: PLC0415
from posthog.models.file_system.unfiled_file_saver import register_mixin_model # noqa: PLC0415
import products.experiments.backend.activity_logging # noqa: F401, PLC0415
@@ -15,3 +24,48 @@ class ExperimentsConfig(AppConfig):
from products.experiments.backend.models.experiment import Experiment # noqa: PLC0415
register_mixin_model("experiment", Experiment)
+
+ register_file_system_type(
+ "experiment",
+ "experiments",
+ "Experiment",
+ undo_message="Send PATCH /api/projects/@current/experiments/{id} with deleted=false.",
+ )
+
+ def _log_file_system_activity(
+ context: DeletionContext | RestoreContext,
+ experiment: Experiment,
+ activity: str,
+ changes: list[Change] | None = None,
+ ) -> None:
+ organization = context.organization
+ if not organization:
+ return
+ log_activity(
+ organization_id=organization.id,
+ team_id=getattr(context.team, "id", None),
+ user=context.user,
+ was_impersonated=is_impersonated(context.request),
+ item_id=str(experiment.id),
+ scope="Experiment",
+ activity=activity,
+ detail=Detail(
+ name=(experiment.name or "").strip() or "Untitled experiment",
+ type="experiment",
+ changes=changes,
+ ),
+ )
+
+ def _post_delete(context: DeletionContext, experiment: Experiment) -> None:
+ _log_file_system_activity(context, experiment, "deleted")
+
+ def _post_restore(context: RestoreContext, experiment: Experiment) -> None:
+ _log_file_system_activity(
+ context,
+ experiment,
+ "restored",
+ changes=[Change(type="Experiment", action="changed", field="deleted", before=True, after=False)],
+ )
+
+ register_post_delete_hook("experiment", _post_delete)
+ register_post_restore_hook("experiment", _post_restore)