:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
chore(slack-app): remove three fully rolled out flags and deprecate patches (#123251)
Vojta Bartoš5ca71f3fa8fa
diff --git a/products/slack_app/backend/facade/api.py b/products/slack_app/backend/facade/api.pyindex ffec8de22b22..322d201e4853 100644--- a/products/slack_app/backend/facade/api.py+++ b/products/slack_app/backend/facade/api.py@@ -26,7 +26,6 @@ import structlogfrom posthog.models.integration import Integration-from products.slack_app.backend.feature_flags import is_slack_app_chart_links_enabledfrom products.slack_app.backend.logic.feature_tips.features import SlackFeaturefrom products.slack_app.backend.logic.feature_tips.state import record_feature_usedfrom products.slack_app.backend.logic.progress_phases import (@@ -122,7 +121,7 @@ def slack_artifact_delivery_state_updates(integration: Integration) -> dict[str,return {"slack_artifact_delivery": mode,"slack_chart_delivery": True,- "slack_chart_links": is_slack_app_chart_links_enabled(integration),+ "slack_chart_links": True,}diff --git a/products/slack_app/backend/feature_flags.py b/products/slack_app/backend/feature_flags.pyindex 8bea45500f9e..4665e14b2c78 100644--- a/products/slack_app/backend/feature_flags.py+++ b/products/slack_app/backend/feature_flags.py@@ -46,10 +46,7 @@ logger = structlog.get_logger(__name__)SLACK_APP_AGENT_DESIGN_FLAG = "slack-app-agent-design"-SLACK_APP_CHART_LINKS_FLAG = "slack-app-chart-links"-SLACK_APP_FEATURE_TIPS_FLAG = "slack-app-feature-tips"SLACK_APP_FORKING_FLAG = "slack-app-forking"-SLACK_APP_MULTIPLAYER_APPROVALS_FLAG = "slack-app-multiplayer-approvals"SLACK_APP_BYOS_FLAG = "slack-app-byos"SLACK_APP_UNPROMPTED_ANSWERS_FLAG = "slack-app-unprompted-answers"SLACK_APP_INTERVIEW_RECRUITMENT_FLAG = "slack-app-interview-recruitment"@@ -131,46 +128,6 @@ def is_slack_app_agent_design_enabled(integration: Integration, distinct_id: str)-def is_slack_app_chart_links_enabled(integration: Integration) -> bool:- """Gate for charts as insight links: a Slack task run shares a PostHog insight link- instead of rendering a chart image, and the link unfurl draws the chart. Resolved once,- when the run starts, and stored on the run for the unfurl webhook to read."""- return _workspace_flag_enabled(- SLACK_APP_CHART_LINKS_FLAG,- integration,- failure_log_key="slack_app_chart_links_feature_flag_check_failed",- )---def is_slack_app_feature_tips_enabled(integration: Integration, distinct_id: str) -> bool:- """Gate for the one-line feature tip under an answer.-- ``distinct_id`` is the reader's PostHog distinct id, or their Slack-derived id when no- PostHog user is linked. A tip is a per-person decision, so a percentage rollout splits- people and a holdout group can measure what tips change.- """- return _workspace_flag_enabled(- SLACK_APP_FEATURE_TIPS_FLAG,- integration,- failure_log_key="slack_app_feature_tips_feature_flag_check_failed",- distinct_id=distinct_id,- )---def is_slack_app_multiplayer_approvals_enabled(integration: Integration, distinct_id: str | None) -> bool:- """Gate for the thread creator's choice of who may join their threads.-- ``distinct_id`` is the thread creator's PostHog user. With the gate closed, anyone with- project access can join, and the Home tab hides the setting.- """- return _workspace_flag_enabled(- SLACK_APP_MULTIPLAYER_APPROVALS_FLAG,- integration,- failure_log_key="slack_app_multiplayer_approvals_feature_flag_check_failed",- distinct_id=distinct_id,- )--def is_slack_app_byos_enabled(integration: Integration, distinct_id: str | None, *, adapter: str = "codex") -> bool:"""Gate for Slack runs that bill to the user's own plan.diff --git a/products/slack_app/backend/logic/feature_tips/offer.py b/products/slack_app/backend/logic/feature_tips/offer.pyindex cc8525c8dc4b..3da492f9234a 100644--- a/products/slack_app/backend/logic/feature_tips/offer.py+++ b/products/slack_app/backend/logic/feature_tips/offer.py@@ -25,7 +25,6 @@ from posthog.dataclasses import frozenfrom posthog.models.integration import Integration, SlackIntegrationfrom products.slack_app.backend.analytics import capture_slack_event, slack_distinct_id-from products.slack_app.backend.feature_flags import is_slack_app_feature_tips_enabledfrom products.slack_app.backend.logic.feature_tips.catalog import CATALOG, TipContext, TipFeaturefrom products.slack_app.backend.logic.feature_tips.features import SlackFeaturefrom products.slack_app.backend.logic.feature_tips.picker import choose_tip@@ -76,7 +75,7 @@ def offer_feature_tip(request: TipRequest) -> SlackFeature | None:).values_list("feature_tips", flat=True)[:1])# Most answers come from a reader who opted out or already got today's tip. They stop here,- # before the flag call and the lock. Their interaction count no longer gates anything.+ # before the lock. Their interaction count no longer gates anything.if stored and _skip_without_counting(parse_state(stored[0]), timezone.now()):return Nonedistinct_id = (@@ -84,8 +83,6 @@ def offer_feature_tip(request: TipRequest) -> SlackFeature | None:if request.posthog_user is not None and request.posthog_user.distinct_idelse slack_distinct_id(integration, request.slack_user_id))- if not is_slack_app_feature_tips_enabled(integration, distinct_id):- return Noneif not stored:SlackSettings.objects.get_or_create(slack_workspace_id=integration.integration_id, slack_user_id=request.slack_user_iddiff --git a/products/slack_app/backend/logic/thread_join.py b/products/slack_app/backend/logic/thread_join.pyindex 7b8cfc7168aa..e5571cc60944 100644--- a/products/slack_app/backend/logic/thread_join.py+++ b/products/slack_app/backend/logic/thread_join.py@@ -3,7 +3,6 @@from enum import StrEnumfrom typing import TYPE_CHECKING-from products.slack_app.backend.feature_flags import is_slack_app_multiplayer_approvals_enabledfrom products.slack_app.backend.models import SlackThreadJoin, ThreadJoinModefrom products.slack_app.backend.services.slack_settings import resolve_thread_join_mode@@ -28,7 +27,7 @@ def decide_thread_join("""The creator's join mode applied to one person, given the approvals the thread already has.A person's approval holds whatever the mode is now, because a mode change applies to new- people only. With the rollout flag off for the creator, the stored mode does not apply.+ people only."""from products.tasks.backend.facade import api as tasks_facade@@ -39,10 +38,6 @@ def decide_thread_join()if mode == ThreadJoinMode.ALLOW:return ThreadJoinDecision.ALLOW- # Checked after the mode, so a creator who lets anyone join costs no flag request.- creator = mapping.task.created_by- if not is_slack_app_multiplayer_approvals_enabled(integration, creator.distinct_id if creator else None):- return ThreadJoinDecision.ALLOWapproved = set(SlackThreadJoin.objects.for_team(mapping.team_id).filter(thread_mapping_id=mapping.id)diff --git a/products/slack_app/backend/services/slack_app_home.py b/products/slack_app/backend/services/slack_app_home.pyindex 910e94ff22b8..9b3ca32cb745 100644--- a/products/slack_app/backend/services/slack_app_home.py+++ b/products/slack_app/backend/services/slack_app_home.py@@ -35,7 +35,6 @@ from posthog.user_permissions import UserPermissionsfrom products.slack_app.backend.analytics import capture_slack_eventfrom products.slack_app.backend.feature_flags import (is_slack_app_byos_enabled,- is_slack_app_multiplayer_approvals_enabled,is_slack_app_oauth_enabled,is_slack_app_unprompted_answers_enabled,)@@ -1829,9 +1828,7 @@ def handle_ai_preferences_block_action(payload: dict, action: dict) -> HttpRespoif action_id == ACTION_SET_THREAD_JOIN_MODE:picked = (action.get("selected_option") or {}).get("value")# An unrecognised value is ignored rather than stored.- if picked in ThreadJoinMode.values and _thread_join_offered(- integration, _resolve_home_user(integration, slack_user_id)- ):+ if picked in ThreadJoinMode.values and _resolve_home_user(integration, slack_user_id) is not None:set_thread_join_mode(integration.integration_id, slack_user_id, ThreadJoinMode(picked))capture_slack_event(integration, "slack app thread join mode set", slack_user_id=slack_user_id, mode=picked)republish()@@ -2313,11 +2310,7 @@ def _build_home_view(resolve_auto_model_choice(integration.integration_id, slack_user_id) if home_user is not None else None),own_plan=own_plan,- thread_join_mode=(- resolve_thread_join_mode(integration, slack_user_id)- if _thread_join_offered(integration, home_user)- else None- ),+ thread_join_mode=(resolve_thread_join_mode(integration, slack_user_id) if home_user is not None else None),has_project_access=bool(accessible),# The same settings page the GitHub card deep-links to.account_settings_url=github_state.settings_url,@@ -2577,10 +2570,6 @@ def _resolve_run_defaults_state()-def _thread_join_offered(integration: Integration, home_user: User | None) -> bool:- return home_user is not None and is_slack_app_multiplayer_approvals_enabled(integration, home_user.distinct_id)--def _resolve_own_plan_state(integration: Integration, slack_user_id: str, home_user: User | None, *, accessible: list[Integration]) -> OwnPlanState | None:diff --git a/products/slack_app/backend/temporal/tests/activities/test_task_creation.py b/products/slack_app/backend/temporal/tests/activities/test_task_creation.pyindex 1dc8d47d073d..d20d8e86af50 100644--- a/products/slack_app/backend/temporal/tests/activities/test_task_creation.py+++ b/products/slack_app/backend/temporal/tests/activities/test_task_creation.py@@ -12,7 +12,6 @@ to wording in the wrapper text show up as a diff in"""import pytest-from unittest.mock import patchfrom posthog.models.integration import Integration@@ -96,25 +95,15 @@ def test_artifact_delivery_mode_offers_only_what_delivery_accepts(granted_scopes# missing one still gets charts while dropping to message mode.integration = Integration(kind="slack", config={"scope": granted_scopes})- with patch("products.slack_app.backend.facade.api.is_slack_app_chart_links_enabled", return_value=False):- state = slack_artifact_delivery_state_updates(integration)+ state = slack_artifact_delivery_state_updates(integration)assert state == {"slack_artifact_delivery": expected_mode,"slack_chart_delivery": True,- "slack_chart_links": False,+ "slack_chart_links": True,}-def test_chart_links_ride_on_the_flag():- integration = Integration(kind="slack", config={"scope": "chat:write"})-- with patch("products.slack_app.backend.facade.api.is_slack_app_chart_links_enabled", return_value=True):- state = slack_artifact_delivery_state_updates(integration)-- assert state["slack_chart_links"] is True--def test_build_description_renders_labeled_mention_for_each_author():# Add a follow-up message after the mentioner so the placeholder isn't the trailing# entry (the trailing-placeholder pop would otherwise drop the mentioner's row).diff --git a/products/slack_app/backend/tests/logic/test_feature_tips.py b/products/slack_app/backend/tests/logic/test_feature_tips.pyindex b4886d6cc862..403c9cfb5bad 100644--- a/products/slack_app/backend/tests/logic/test_feature_tips.py+++ b/products/slack_app/backend/tests/logic/test_feature_tips.py@@ -37,7 +37,6 @@ class TestOfferFeatureTip:team=self.team, kind="slack", integration_id=WORKSPACE, sensitive_config={"access_token": "xoxb-test"})with (- patch.object(offer, "is_slack_app_feature_tips_enabled", return_value=True) as self.flag,patch.object(offer, "post_slack_ephemeral") as self.post,patch.object(offer, "SlackIntegration"),patch.object(catalog, "is_slack_app_unprompted_answers_enabled", return_value=False),@@ -128,13 +127,6 @@ class TestOfferFeatureTip:assert self._offer() == expected- def test_flag_off_writes_nothing(self):- self._threads(3)- self.flag.return_value = False-- assert self._offer() is None- assert not SlackSettings.objects.filter(slack_workspace_id=WORKSPACE, slack_user_id=SLACK_USER).exists()-class TestCatalog(SimpleTestCase):def test_every_feature_has_a_tip_and_a_unique_rank(self):diff --git a/products/slack_app/backend/tests/services/test_slack_app_home.py b/products/slack_app/backend/tests/services/test_slack_app_home.pyindex 521e964f8919..b0c65899d371 100644--- a/products/slack_app/backend/tests/services/test_slack_app_home.py+++ b/products/slack_app/backend/tests/services/test_slack_app_home.py@@ -1279,35 +1279,28 @@ class TestHandleAppHomeOpened:assert mock_capture.call_args.args[1] == "slack app home opened"assert mock_capture.call_args.kwargs["posthog_user"] == opener- @pytest.mark.parametrize("flag_on_for_viewer", [True, False])- def test_multiplayer_section_follows_its_flag(- self, slack_integration, mock_slack_client, flag_on, admin_user, flag_on_for_viewer+ @pytest.mark.parametrize("viewer_linked", [True, False])+ def test_multiplayer_section_shows_only_to_a_linked_viewer(+ self, slack_integration, mock_slack_client, flag_on, admin_user, viewer_linked):- opener = User.objects.create_and_join(slack_integration.team.organization, "[email protected]", None)- SlackUserProfileCache.objects.create(integration=slack_integration, slack_user_id="U001", email=opener.email)+ if viewer_linked:+ opener = User.objects.create_and_join(slack_integration.team.organization, "[email protected]", None)+ SlackUserProfileCache.objects.create(+ integration=slack_integration, slack_user_id="U001", email=opener.email+ )- with patch(- "products.slack_app.backend.services.slack_app_home.is_slack_app_multiplayer_approvals_enabled",- return_value=flag_on_for_viewer,- ):- handle_app_home_opened({"user": "U001"}, SLACK_WORKSPACE_ID, integration=slack_integration)+ handle_app_home_opened({"user": "U001"}, SLACK_WORKSPACE_ID, integration=slack_integration)view = mock_slack_client.views_publish.call_args.kwargs["view"]- assert (ACTION_SET_THREAD_JOIN_MODE in _action_ids(view)) is flag_on_for_viewer- assert ("Multiplayer" in _all_text(view)) is flag_on_for_viewer+ assert (ACTION_SET_THREAD_JOIN_MODE in _action_ids(view)) is viewer_linked+ assert ("Multiplayer" in _all_text(view)) is viewer_linkeddef test_join_picker_shows_without_the_plan_card(self, slack_integration, mock_slack_client, flag_on, admin_user):# Who may join a thread is not a plan feature, so closing the BYOS gate must not hide it.opener = User.objects.create_and_join(slack_integration.team.organization, "[email protected]", None)SlackUserProfileCache.objects.create(integration=slack_integration, slack_user_id="U001", email=opener.email)- with (- patch("products.slack_app.backend.services.slack_app_home.is_slack_app_byos_enabled", return_value=False),- patch(- "products.slack_app.backend.services.slack_app_home.is_slack_app_multiplayer_approvals_enabled",- return_value=True,- ),- ):+ with patch("products.slack_app.backend.services.slack_app_home.is_slack_app_byos_enabled", return_value=False):handle_app_home_opened({"user": "U001"}, SLACK_WORKSPACE_ID, integration=slack_integration)view = mock_slack_client.views_publish.call_args.kwargs["view"]diff --git a/products/slack_app/backend/tests/test_followup_forwarding.py b/products/slack_app/backend/tests/test_followup_forwarding.pyindex baea7d3b98eb..70272ecb1b36 100644--- a/products/slack_app/backend/tests/test_followup_forwarding.py+++ b/products/slack_app/backend/tests/test_followup_forwarding.py@@ -1227,18 +1227,16 @@ class TestForwardPostHogCodeFollowupActivity(TestCase):@parameterized.expand([- ("allow", ThreadJoinMode.ALLOW, None, True, False, True),+ ("allow", ThreadJoinMode.ALLOW, None, True, False),# A creator who never picked a mode lets anyone join.- ("unset", None, None, True, False, True),- ("ask_per_person", ThreadJoinMode.ASK_PER_PERSON, None, False, True, True),- ("ask_per_person_already_joined", ThreadJoinMode.ASK_PER_PERSON, ["U_BOB"], True, False, True),- ("ask_per_person_after_someone_else_joined", ThreadJoinMode.ASK_PER_PERSON, ["U_CAROL"], False, True, True),- ("ask_per_thread", ThreadJoinMode.ASK_PER_THREAD, None, False, True, True),- ("ask_per_thread_after_someone_else_joined", ThreadJoinMode.ASK_PER_THREAD, ["U_CAROL"], True, False, True),- ("never", ThreadJoinMode.NEVER, None, False, False, True),- ("never_after_joining", ThreadJoinMode.NEVER, ["U_BOB"], True, False, True),- # Turning the rollout flag off brings back today's behavior, whatever was stored.- ("never_with_the_flag_off", ThreadJoinMode.NEVER, None, True, False, False),+ ("unset", None, None, True, False),+ ("ask_per_person", ThreadJoinMode.ASK_PER_PERSON, None, False, True),+ ("ask_per_person_already_joined", ThreadJoinMode.ASK_PER_PERSON, ["U_BOB"], True, False),+ ("ask_per_person_after_someone_else_joined", ThreadJoinMode.ASK_PER_PERSON, ["U_CAROL"], False, True),+ ("ask_per_thread", ThreadJoinMode.ASK_PER_THREAD, None, False, True),+ ("ask_per_thread_after_someone_else_joined", ThreadJoinMode.ASK_PER_THREAD, ["U_CAROL"], True, False),+ ("never", ThreadJoinMode.NEVER, None, False, False),+ ("never_after_joining", ThreadJoinMode.NEVER, ["U_BOB"], True, False),])@patch("products.slack_app.backend.api.post_thread_join_prompt")@@ -1252,7 +1250,6 @@ class TestForwardPostHogCodeFollowupActivity(TestCase):joined,delivered,prompted,- flag_on,mock_slack_cls,mock_resolve,mock_signal,@@ -1270,13 +1267,9 @@ class TestForwardPostHogCodeFollowupActivity(TestCase):mock_resolve.return_value = SlackUserContext(user=bob, slack_email="[email protected]")inputs = _make_inputs(self.integration.id, self.user.id)- with patch(- "products.slack_app.backend.logic.thread_join.is_slack_app_multiplayer_approvals_enabled",- return_value=flag_on,- ):- result = forward_posthog_code_followup_activity(- inputs, "C123", "1234.5678", "U_BOB", "<@BOT> ship it", "1234.5679"- )+ result = forward_posthog_code_followup_activity(+ inputs, "C123", "1234.5678", "U_BOB", "<@BOT> ship it", "1234.5679"+ )assert result is Trueassert mock_signal.called is delivered@@ -1372,11 +1365,7 @@ class TestForwardPostHogCodeFollowupActivity(TestCase):mock_resolve.return_value = SlackUserContext(user=bob, slack_email="[email protected]")inputs = _make_inputs(self.integration.id, self.user.id)- with patch(- "products.slack_app.backend.logic.thread_join.is_slack_app_multiplayer_approvals_enabled",- return_value=True,- ):- forward_posthog_code_followup_activity(inputs, "C123", "1234.5678", "U_BOB", "<@BOT> ship it", "1234.5679")+ forward_posthog_code_followup_activity(inputs, "C123", "1234.5678", "U_BOB", "<@BOT> ship it", "1234.5679")assert mock_signal.called is deliveredassert mock_prompt.called is prompteddiff --git a/products/tasks/backend/temporal/process_task/slack_agent_design_relay.py b/products/tasks/backend/temporal/process_task/slack_agent_design_relay.pyindex 697cc024e782..320da580063e 100644--- a/products/tasks/backend/temporal/process_task/slack_agent_design_relay.py+++ b/products/tasks/backend/temporal/process_task/slack_agent_design_relay.py@@ -362,9 +362,10 @@ class SlackAgentDesignRelayWorkflow(PostHogWorkflow):start_to_close_timeout=_ACTIVITY_TIMEOUT,retry_policy=_ACTIVITY_RETRY,)- # An older activity returns None, which means the stream is still open. The patch keeps- # histories that older workflow code wrote on their recorded command sequence.- if stream_open is False and workflow.patched(_PATCH_ID_STREAM_ENDED):+ # An older activity returns None, which means the stream is still open. Histories that+ # carry the patch marker replay with deprecate_patch; delete it once those runs drain.+ if stream_open is False:+ workflow.deprecate_patch(_PATCH_ID_STREAM_ENDED)self._stream_ended = True@workflow.rundiff --git a/products/tasks/backend/temporal/process_task/tests/test_workflow.py b/products/tasks/backend/temporal/process_task/tests/test_workflow.pyindex 189433980991..fb2300e8e0f6 100644--- a/products/tasks/backend/temporal/process_task/tests/test_workflow.py+++ b/products/tasks/backend/temporal/process_task/tests/test_workflow.py@@ -2531,6 +2531,7 @@ class TestProcessTaskWorkflowUnit:start_slack_relay_mock = AsyncMock()monkeypatch.setattr(workflow, "_start_slack_agent_design_relay", start_slack_relay_mock)monkeypatch.setattr(process_task_workflow_module.workflow, "patched", Mock(return_value=True))+ monkeypatch.setattr(process_task_workflow_module.workflow, "deprecate_patch", Mock())monkeypatch.setattr(process_task_workflow_module.workflow, "now", Mock(return_value=datetime.now(UTC)))result = await workflow.run(diff --git a/products/tasks/backend/temporal/process_task/workflow.py b/products/tasks/backend/temporal/process_task/workflow.pyindex 9780c6d1beba..a7c03ea81c31 100644--- a/products/tasks/backend/temporal/process_task/workflow.py+++ b/products/tasks/backend/temporal/process_task/workflow.py@@ -347,7 +347,8 @@ _ORIGIN_PRODUCT_SIGNAL_REPORT = "signal_report"# Gates the forward of the agent_final_text signal to the Slack relay. A worker without the# handler records that signal in history and sends nothing, so a replay that forwards it emits a-# command the history does not have (TMPRL1100).+# command the history does not have (TMPRL1100). Every worker now has the handler, so the patch is+# deprecated; delete it once histories that carry the marker drain._PATCH_ID_SLACK_AGENT_FINAL_TEXT = "tasks-slack-agent-final-text"# Progress steps of sandbox setup. The Slack plan shows them until the first turn starts.@@ -1196,7 +1197,8 @@ class ProcessTaskWorkflow(PostHogWorkflow):self._sandbox_url = sandbox_urlself._sandbox_connect_token = sandbox_connect_tokenif self._is_agent_design_enabled:- self._forwards_agent_final_text = workflow.patched(_PATCH_ID_SLACK_AGENT_FINAL_TEXT)+ workflow.deprecate_patch(_PATCH_ID_SLACK_AGENT_FINAL_TEXT)+ self._forwards_agent_final_text = Truerelay_task: asyncio.Task[None] | None = self._spawn_event_relay(sandbox_url, sandbox_connect_token, sandbox_id