Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

refactor(replay): name playlist entity filters without legacyFilters (#126242)

Thomas Obermüller5fd620780b95
diff --git a/frontend/src/scenes/insights/filters/ActionFilter/legacyFilters.ts b/frontend/src/scenes/insights/filters/ActionFilter/legacyFilters.ts
index a364f2741c74..7372d01b8285 100644
--- a/frontend/src/scenes/insights/filters/ActionFilter/legacyFilters.ts
+++ b/frontend/src/scenes/insights/filters/ActionFilter/legacyFilters.ts
@@ -1,5 +1,4 @@
import { convertPropertyGroupToProperties } from 'lib/components/PropertyFilters/utils'
-import { uuid } from 'lib/utils/dom'
import { AnyEntityNode, GroupNode, NodeKind } from '~/queries/schema/schema-general'
import { ActionFilter, EntityTypes, FilterType } from '~/types'
@@ -136,34 +135,3 @@ export function seriesToLegacyFilters(series: SeriesNode[]): FilterType {
[EntityTypes.GROUPS]: filters.filter((filter) => filter.type === EntityTypes.GROUPS),
} as FilterType
}
-
-/**
- * The legacy row shape. Replay's playlist summary (`summarizePlaylistFilters`) still builds it
- * with `toLocalFilters` to name its event and action filters.
- */
-export type LocalFilter = ActionFilter & {
- order: number
- uuid: string
- table_name?: string
- [key: string]: any
-}
-
-export function toLocalFilters(filters: Partial<FilterType>): LocalFilter[] {
- const localFilters = [
- ...(filters[EntityTypes.ACTIONS] || []),
- ...(filters[EntityTypes.EVENTS] || []),
- ...(filters[EntityTypes.DATA_WAREHOUSE] || []),
- ...(filters[EntityTypes.GROUPS] || []),
- ]
- .sort((a, b) => a.order - b.order)
- .map((filter, order) => ({ ...(filter as ActionFilter), order }))
- return localFilters.map((filter) =>
- filter.properties && Array.isArray(filter.properties)
- ? {
- ...filter,
- uuid: uuid(),
- properties: convertPropertyGroupToProperties(filter.properties),
- }
- : { ...filter, uuid: uuid() }
- )
-}
diff --git a/frontend/src/scenes/session-recordings/playlist/playlistEntitySummary.ts b/frontend/src/scenes/session-recordings/playlist/playlistEntitySummary.ts
new file mode 100644
index 000000000000..2758cb6fbddc
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/playlist/playlistEntitySummary.ts
@@ -0,0 +1,14 @@
+import { isActionFilter, isEventFilter } from 'lib/components/UniversalFilters/utils'
+import { getDisplayNameFromEntityFilter } from 'lib/insights/entityFilterNames'
+
+import { UniversalFilterValue } from '~/types'
+
+export function summarizePlaylistEntityFilters(filters: UniversalFilterValue[]): string {
+ return (
+ [...filters.filter(isActionFilter), ...filters.filter(isEventFilter)]
+ // A filter added from the replay filter bar has no `order`. Its comparison gives NaN, which sort reads as equal.
+ .sort((a, b) => Number(a.order) - Number(b.order))
+ .map((filter) => getDisplayNameFromEntityFilter(filter))
+ .join(' & ')
+ )
+}
diff --git a/frontend/src/scenes/session-recordings/playlist/playlistUtils.test.ts b/frontend/src/scenes/session-recordings/playlist/playlistUtils.test.ts
index 4f178fb99694..a2c20394cf08 100644
--- a/frontend/src/scenes/session-recordings/playlist/playlistUtils.test.ts
+++ b/frontend/src/scenes/session-recordings/playlist/playlistUtils.test.ts
@@ -65,6 +65,19 @@ describe('summarizePlaylistFilters()', () => {
).toEqual('Pageview & Rageclick & Random action & Pageview & Autocapture')
})
+ it('names events and actions by custom name and all events, in their order', () => {
+ expect(
+ summarizePlaylistFilters(
+ [
+ { type: 'events', id: 'signed_up', name: 'signed_up', custom_name: 'Sign ups', order: 2 },
+ { type: 'events', id: null, name: 'All events', order: 0 },
+ { type: 'actions', id: 7, name: 'Purchased', order: 1 },
+ ],
+ cohortIdsMapped
+ )
+ ).toEqual('All events & Purchased & Sign ups')
+ })
+
it('summarizes a playlist with one event, one PH person property and one custom property', () => {
expect(
summarizePlaylistFilters(
diff --git a/frontend/src/scenes/session-recordings/playlist/playlistUtils.ts b/frontend/src/scenes/session-recordings/playlist/playlistUtils.ts
index 8e1c30e5730f..24364015dae8 100644
--- a/frontend/src/scenes/session-recordings/playlist/playlistUtils.ts
+++ b/frontend/src/scenes/session-recordings/playlist/playlistUtils.ts
@@ -4,12 +4,9 @@ import api from 'lib/api'
import { SetupTaskId, globalSetupLogic } from 'lib/components/ProductSetup'
import { convertPropertyGroupToProperties, isValidPropertyFilter } from 'lib/components/PropertyFilters/utils'
import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'
-import { isActionFilter, isEventFilter } from 'lib/components/UniversalFilters/utils'
-import { getDisplayNameFromEntityFilter } from 'lib/insights/entityFilterNames'
import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'
import { deleteWithUndo } from 'lib/utils/deleteWithUndo'
import { genericOperatorMap } from 'lib/utils/operators'
-import { toLocalFilters } from 'scenes/insights/filters/ActionFilter/legacyFilters'
import { DEFAULT_RECORDING_FILTERS } from 'scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic'
import { teamLogic } from 'scenes/teamLogic'
import { urls } from 'scenes/urls'
@@ -24,6 +21,8 @@ import {
UniversalFilterValue,
} from '~/types'
+import { summarizePlaylistEntityFilters } from './playlistEntitySummary'
+
export function splitOngoingRecordings<T extends { ongoing?: boolean }>(
recordings: T[],
enabled: boolean
@@ -63,18 +62,9 @@ export function summarizePlaylistFilters(
filters: UniversalFilterValue[],
cohortsById: cohortsModelType['values']['cohortsById']
): string | null {
- const eventFilters = filters.filter(isEventFilter)
- const actionFilters = filters.filter(isActionFilter)
const propertyFilters = filters.filter(isValidPropertyFilter)
- let summary: string
- const localFilters = toLocalFilters({ events: eventFilters, actions: actionFilters })
-
- summary = localFilters
- .map((localFilter) => {
- return getDisplayNameFromEntityFilter(localFilter)
- })
- .join(' & ')
+ let summary = summarizePlaylistEntityFilters(filters)
const properties = convertPropertyGroupToProperties(propertyFilters)
if (properties && (properties.length ?? 0) > 0) {