:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(workflows): make big workflows easier to navigate on the tile canvas (#120966)
Daniel Marchuk61fc0679348e
diff --git a/frontend/snapshots.yml b/frontend/snapshots.ymlindex abeb02744743..3ecdd6376ae4 100644--- a/frontend/snapshots.yml+++ b/frontend/snapshots.yml@@ -8247,25 +8247,25 @@ snapshots:products-workflows-editor-graph--with-navigation--light:hash: v1.k794b7964.56d8bf045970b426f994709ddc19478d18e1968fcf3a41f8e0d28485ff338fa1.QsH5OKiKp00RMcqNzSYgsacI4_1BZ7UtU31Qt2EYzuUproducts-workflows-editor-tile-canvas--long-emails--dark:- hash: v1.k794b7964.746428991aecc1377d0eee56fb4bfa599ea2655fd0e5ea52b422d2801a35b7d3.1ymLS7jybK2AYnJEU35IFIHsVPFfXodyVK7oL-aUNB8+ hash: v1.k794b7964.fd71da5c1231d1036556e7e58e34b68a931b14812134201ce9f7fb2008d195c9.Eyw-ZqzqCvOOfKSecjq358TQw_kZtHC2hXzISMuEP9Qproducts-workflows-editor-tile-canvas--long-emails--light:- hash: v1.k794b7964.eebfc3cc0b5c90e085ba25241bcc782ecea76b1d80eddecd7395694223163f78.6yn2sx_hr50S9YDOqkZOEFUj3ksKoyDB5SOGeOwjQ6k+ hash: v1.k794b7964.f7c8b7f120b9d77bbc35e34c228c4d94875408d06b86935452594036a21bd3e4.EEU2unhqDjBNtYEvkX9wh3AgvSoqLlkNF9EPIeTxjuwproducts-workflows-editor-tile-canvas--paths-collapsed--dark:- hash: v1.k794b7964.a7d1365772454bc11513284e6b78429127fd18f9e88dc8596005089e1ec69719.W3pCWyBom6wjFqo5FoXZ1Ve1o6zhmWDzy3X0gRZHdN0+ hash: v1.k794b7964.fbc02489e48230560f38677e2c0564544ba43ba5fccb814d9c58d21141f7bd56.mSexBQ6C7P2Tfnhl5JcaUMWxhpEgUdYwGzc0bsnnEKEproducts-workflows-editor-tile-canvas--paths-collapsed--light:- hash: v1.k794b7964.e31aafe29d8cdc6afe148c7eb70c8777ccee76f57f5c84dd4dcd1f20326a18f7.snezvPc-3tVItCBGG6bYUghv_df0U3TYloGuRI1kaV8+ hash: v1.k794b7964.3d1637648ee51ef3722219862d7d1fb06bf5a6a557e717256576e7894d861fb6.jmfY3wnm_MZTY_6DZYAw1yw54aqt5k9lM6qyf2PCW-Iproducts-workflows-editor-tile-canvas--paths-open--dark:- hash: v1.k794b7964.e57ec2aab358744dd6c7ff13dace41bdc233f1176fc751366b47ba3a4d6bc712.sjRXt0A6GF7dDuoED0em4jT4CCxjoeT-8dWgvlbJkXg+ hash: v1.k794b7964.814198da2522e4b84347f93ed982501c269854725253835786e532db662a00b2.HrvlQqF-r9XB80Wk5t8Dh933q4t_scSHWTVmOfd7s6Eproducts-workflows-editor-tile-canvas--paths-open--light:- hash: v1.k794b7964.e2682899187338a05587b9c79fc6e1973445700e921c69731d74e6c822825472.kEwE5QPZ3ChJ-i8R5T7JVJPZTdWsJsG_Wgsc8bn4PPY+ hash: v1.k794b7964.cee0f349c18a1b78a05c1ab61307e904993b24d116b8c243a2ba0a0ad60f9e18.Igdbc6OD8bF9oJ_1c8lUUIVcieG4JvrXa49np3otQIUproducts-workflows-editor-tile-canvas--time-window-and-webhook--dark:- hash: v1.k794b7964.5742bd6276714aa6b25de49b7004c4e65340b7e22c31566caf465677462dcdf3.GKcg0jOBKdPEkKBmSFCzj4oDaiBohGDZXzmmHcX2Ev8+ hash: v1.k794b7964.b1a47db1602c1e0703b2f3b521ac52dcbc5a3ebba76f4e7d2d309c3b4c7c4b7a._LObcIoA9-yXUI0LuwW34VQfGxEUdGcreQQvdLF1-Awproducts-workflows-editor-tile-canvas--time-window-and-webhook--light:- hash: v1.k794b7964.bb4d20744239d7853c41634985d6c021415cf69a6c7a7affd82cc1b66629c05c.V8xSVCs8-Ryzp0TxCYhQJGUE6lIVtIJhK3_z07BoEvc+ hash: v1.k794b7964.96225fdd020c0c75c161f88680367e556a5c95ea9616dbfb4540e526038198c8.5Bl9S5lwxwuPa6gPDab0DYRVBhU9njZz8tg2puTozykproducts-workflows-editor-tile-canvas--with-step-counts--dark:- hash: v1.k794b7964.0ab0b8a7082c3361fbfe4411ced4404bb68a064b053b7f2ccf1a837eac899e16.J6jtQPYdW-CDpPpbapVHB1Ne2lsf5pfJIDUyPiAP5XM+ hash: v1.k794b7964.de5dddfb98e5dcb9ad68c0fbeb72adc735052df9f6adaa2409863b4ff49febf3.CvpVLCAl5s20yCLvaCQj7Y0yOmvGr-X9bjdS9br6m4Mproducts-workflows-editor-tile-canvas--with-step-counts--light:- hash: v1.k794b7964.b152134d4ebad3b1aad8e7daa775d1c9a8eb751a4135054d79236ed3a667ab6d.SJNeHLOjBtEOEO14ecxMYO0Bc2DHtzrAF3ddp99XzsE+ hash: v1.k794b7964.d28c0e207d14d3f1ee827602f1600c4e3eb47ec9c790e4357757388aa1172f9a.yjhNs4J_VVtzYX_ksVtLrSzDD0vw8lAknbYlYncjD9Aproducts-workflows-editor-tree--add-on-promotion-emails--dark:hash: v1.k794b7964.b57f08708c8687742a71ed295c7e0d342e11cc63c709a9b9b703385fbf4d1b31.yosoQWPjKotHOoPqaIycyvai4desJVjTgoOqJHZu1fAproducts-workflows-editor-tree--add-on-promotion-emails--light:diff --git a/products/workflows/frontend/Workflows/WorkflowStatusBar.tsx b/products/workflows/frontend/Workflows/WorkflowStatusBar.tsxindex 17cc44f8e5e8..f1b367f99a98 100644--- a/products/workflows/frontend/Workflows/WorkflowStatusBar.tsx+++ b/products/workflows/frontend/Workflows/WorkflowStatusBar.tsx@@ -48,7 +48,7 @@ export function WorkflowStatusBar({const isEditingDraftOfLive = isActive && (hasStagedDraft || hasUnsavedChanges)return (- <div className="flex items-center justify-between gap-2 px-2 py-1.5 border-b bg-surface-secondary rounded-t-md flex-wrap">+ <div className="@container/workflow-status flex items-center justify-between gap-2 px-2 py-1.5 border-b bg-surface-secondary rounded-t-md flex-wrap"><div className="flex items-center gap-3 min-w-0">{showEditorLayoutToggle && (<LemonSegmentedButtondiff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/CanvasCommandButtons.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/CanvasCommandButtons.tsxindex ab648e22c2d6..b3a635daa21b 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/CanvasCommandButtons.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/CanvasCommandButtons.tsx@@ -21,8 +21,10 @@ export function CanvasCommandButtons(): JSX.Element {active={panelMode === command.mode}onClick={() => togglePanel(command.mode)}data-attr={`workflow-tile-command-${command.id}`}+ tooltip={command.hint ? `${command.label}: ${command.hint}` : command.label}>- {command.label}+ {/* A narrow bar keeps the icons on one row, and the tooltip names each one. */}+ <span className="@max-[64rem]/workflow-status:sr-only">{command.label}</span></LemonButton>))}<LemonMenudiff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathChip.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathChip.tsxindex 0376b8517eba..b8c33763e564 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathChip.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathChip.tsx@@ -2,11 +2,11 @@ import { NodeProps } from '@xyflow/react'import { useActions } from 'kea'import { IconCollapse } from '@posthog/icons'-import { Tooltip } from '@posthog/lemon-ui'import { cn } from 'lib/utils/css-classes'import { motionProps } from './motionProps'+import { shortLabel } from './tileCanvasLayout'import { tileCanvasLogic } from './tileCanvasLogic'import { pathColor } from './tileCanvasModel'import type { PathChipNodeType } from './tileCanvasNodes'@@ -17,24 +17,26 @@ export function PathChip({ data }: NodeProps<PathChipNodeType>): JSX.Element {const motionStyle = motionProps(data.motion)return (<div className={cn('-translate-y-1/2', motionStyle.className)} style={motionStyle.style}>- <Tooltip title="Collapse this path">- <button- type="button"- className="nodrag flex w-max cursor-pointer items-center gap-1.5 whitespace-nowrap rounded-full border bg-surface-primary py-1 pl-2 pr-2.5 shadow-sm hover:bg-surface-secondary"- style={{ borderColor: color }}- data-attr="workflow-tile-collapse-path"- onClick={(event) => {- event.stopPropagation()- collapsePath(data.group.id)- }}- >- <IconCollapse className="size-3.5 shrink-0 text-secondary" />- <span className="size-2 shrink-0 rounded-full" style={{ backgroundColor: color }} />- <span className="text-[13px] font-semibold" style={{ color }}>- {data.group.label}- </span>- </button>- </Tooltip>+ <button+ type="button"+ className="nodrag group flex w-max cursor-pointer items-center gap-1.5 whitespace-nowrap rounded-full border bg-surface-primary py-1 pl-2.5 pr-1 shadow-sm"+ style={{ borderColor: color }}+ title={data.group.label === shortLabel(data.group.label) ? undefined : data.group.label}+ data-attr="workflow-tile-collapse-path"+ onClick={(event) => {+ event.stopPropagation()+ collapsePath(data.group.id)+ }}+ >+ <span className="size-2 shrink-0 rounded-full" style={{ backgroundColor: color }} />+ <span className="text-[13px] font-semibold" style={{ color }}>+ {shortLabel(data.group.label)}+ </span>+ <span className="flex items-center gap-0.5 rounded-full px-1.5 py-0.5 text-[11px] font-medium text-secondary group-hover:bg-fill-button-tertiary-hover group-hover:text-primary">+ <IconCollapse className="size-3" />+ Collapse+ </span>+ </button></div>)}diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathFrame.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathFrame.tsxindex 64b844c0c70f..9e45eff2cf86 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathFrame.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathFrame.tsx@@ -3,16 +3,18 @@ import { NodeProps } from '@xyflow/react'import { cn } from 'lib/utils/css-classes'import { motionProps } from './motionProps'-import { pathColor, tint } from './tileCanvasModel'+import { tint } from './tileCanvasModel'import type { PathFrameNodeType } from './tileCanvasNodes'export function PathFrame({ data, width, height }: NodeProps<PathFrameNodeType>): JSX.Element {- const color = pathColor(data.group.entryEdge)const motionStyle = motionProps(data.motion)+ // A path color would stack into one solid hue on a nested workflow, so every open path gets the same light gray.return (<div className={cn('relative', motionStyle.className)} style={{ width, height, ...motionStyle.style }}>- <div className="absolute inset-0 rounded-2xl" style={{ backgroundColor: tint(color, 6) }} />- <div className="absolute bottom-3 left-0 top-3 w-[3px] rounded-full" style={{ backgroundColor: color }} />+ <div+ className="absolute inset-0 rounded-2xl"+ style={{ backgroundColor: tint('var(--color-text-secondary)', 6) }}+ /></div>)}diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathTrail.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathTrail.tsxnew file mode 100644index 000000000000..5969279cf357--- /dev/null+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/PathTrail.tsx@@ -0,0 +1,188 @@+import { useReactFlow, useStore } from '@xyflow/react'+import { useActions, useValues } from 'kea'+import { useMemo } from 'react'++import { IconChevronRight, IconCollapse, IconEllipsis, IconExpand } from '@posthog/icons'+import { LemonButton, LemonMenu } from '@posthog/lemon-ui'++import { Box, PathFrameSpec, shortLabel } from './tileCanvasLayout'+import { tileCanvasLogic } from './tileCanvasLogic'+import { FIT_MARGIN, pathColor, Point } from './tileCanvasModel'++const TRAIL_ROOM = 56+const SHOWN_PATHS = 2+const PAN_MS = 300++interface TrailFrame {+ frame: PathFrameSpec+ box: Box+}++const contains = (box: Box, point: Point): boolean =>+ point.x >= box.x && point.x <= box.x + box.width && point.y >= box.y && point.y <= box.y + box.height++const framesAround = (framed: TrailFrame[], centre: Point): TrailFrame[] =>+ framed.filter(({ box }) => contains(box, centre)).sort((a, b) => a.frame.group.depth - b.frame.group.depth)++function framesOfStep(framed: TrailFrame[], stepId: string): TrailFrame[] {+ // A frame lists the steps drawn in it, so the step's own frame is the deepest that lists it, and its parents follow.+ const byId = new Map(framed.map((entry) => [entry.frame.id, entry]))+ let current = framed+ .filter(({ frame }) => frame.memberIds.includes(stepId))+ .reduce<TrailFrame | undefined>(+ (deepest, entry) => (!deepest || entry.frame.group.depth > deepest.frame.group.depth ? entry : deepest),+ undefined+ )+ const chain: TrailFrame[] = []+ while (current) {+ chain.unshift(current)+ current = current.frame.parentId ? byId.get(current.frame.parentId) : undefined+ }+ return chain+}++/** The open paths around the selected step, or around the middle of the view when no step is selected. */+function useTrail(): TrailFrame[] {+ const { frameSpecs, layout, selectedStepId } = useValues(tileCanvasLogic)+ const centreX = useStore((state) =>+ selectedStepId ? null : (state.width / 2 - state.transform[0]) / state.transform[2]+ )+ const centreY = useStore((state) =>+ selectedStepId ? null : (state.height / 2 - state.transform[1]) / state.transform[2]+ )+ const framed = useMemo(+ () =>+ frameSpecs.flatMap((frame) => {+ const box = layout?.frames[frame.id]+ return box ? [{ frame, box }] : []+ }),+ [frameSpecs, layout]+ )+ return useMemo(() => {+ if (selectedStepId) {+ return framesOfStep(framed, selectedStepId)+ }+ return centreX === null || centreY === null ? [] : framesAround(framed, { x: centreX, y: centreY })+ }, [framed, selectedStepId, centreX, centreY])+}++export function PathTrail(): JSX.Element | null {+ const { pathGroups, allPathsCollapsed, openPathIds } = useValues(tileCanvasLogic)+ const { setOpenPathIds, fitNextLayout, collapsePath, requestFit } = useActions(tileCanvasLogic)+ const { getViewport, setViewport } = useReactFlow()+ const canvasWidth = useStore((state) => state.width)+ const trail = useTrail()++ if (pathGroups.length === 0) {+ return null+ }++ const showPath = (box: Box): void => {+ const { zoom } = getViewport()+ void setViewport(+ {+ x: canvasWidth / 2 - (box.x + Math.min(box.width, canvasWidth / zoom) / 2) * zoom,+ y: FIT_MARGIN.top + TRAIL_ROOM - box.y * zoom,+ zoom,+ },+ { duration: PAN_MS }+ )+ }+ const innermost = trail[trail.length - 1]+ const hidden = trail.slice(0, Math.max(0, trail.length - SHOWN_PATHS))+ const shown = trail.slice(hidden.length)++ return (+ <div+ className="flex max-w-full flex-wrap items-center gap-2 rounded-lg border bg-surface-primary p-1 shadow-sm"+ data-attr="workflow-tile-path-trail"+ >+ <div className="flex items-center gap-1">+ <LemonButton+ size="xsmall"+ type="secondary"+ icon={<IconExpand />}+ onClick={() => {+ fitNextLayout()+ setOpenPathIds(pathGroups.map((group) => group.id))+ }}+ disabledReason={+ pathGroups.every((group) => openPathIds.includes(group.id)) ? 'Every path is open' : undefined+ }+ data-attr="workflow-tile-open-all-paths"+ >+ Open all+ </LemonButton>+ <LemonButton+ size="xsmall"+ type="secondary"+ icon={<IconCollapse />}+ onClick={() => {+ fitNextLayout()+ setOpenPathIds([])+ }}+ disabledReason={allPathsCollapsed ? 'Every path is collapsed' : undefined}+ data-attr="workflow-tile-collapse-all-paths"+ >+ Collapse all+ </LemonButton>+ </div>+ {trail.length > 0 && (+ <nav aria-label="Open paths" className="flex min-w-0 flex-wrap items-center gap-0.5 text-xs">+ <LemonButton size="xsmall" onClick={requestFit} tooltip="Back to the start of the workflow">+ Start+ </LemonButton>+ {hidden.length > 0 && (+ <span className="flex items-center gap-0.5">+ <IconChevronRight className="size-3 shrink-0 text-tertiary" />+ <LemonMenu+ items={hidden.map(({ frame, box }) => ({+ label: shortLabel(frame.group.label),+ onClick: () => showPath(box),+ }))}+ >+ <LemonButton+ size="xsmall"+ icon={<IconEllipsis />}+ tooltip={`${hidden.length} more ${hidden.length === 1 ? 'path' : 'paths'} around this one`}+ aria-label="Show the paths around this one"+ />+ </LemonMenu>+ </span>+ )}+ {shown.map(({ frame, box }) => {+ const color = pathColor(frame.group.entryEdge)+ return (+ <span key={frame.id} className="flex min-w-0 items-center gap-0.5">+ <IconChevronRight className="size-3 shrink-0 text-tertiary" />+ <LemonButton+ size="xsmall"+ onClick={() => showPath(box)}+ tooltip={frame.group.label}+ data-attr="workflow-tile-path-trail-step"+ >+ <span className="flex items-center gap-1">+ <span+ className="size-2 shrink-0 rounded-full"+ style={{ backgroundColor: color }}+ />+ <span style={{ color }}>{shortLabel(frame.group.label)}</span>+ </span>+ </LemonButton>+ </span>+ )+ })}+ {innermost && (+ <LemonButton+ size="xsmall"+ icon={<IconCollapse />}+ onClick={() => collapsePath(innermost.frame.group.id)}+ tooltip="Collapse this path"+ aria-label="Collapse this path"+ />+ )}+ </nav>+ )}+ </div>+ )+}diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/QuickAddButton.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/QuickAddButton.tsxindex 2571efa06029..1d4971d88466 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/QuickAddButton.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/QuickAddButton.tsx@@ -12,7 +12,16 @@ import { StepPalette } from './StepPalette'import { tileCanvasLogic } from './tileCanvasLogic'import { Point } from './tileCanvasModel'-export function QuickAddButton({ edge, at }: { edge: HogFlowEdge; at: Point }): JSX.Element {+export function QuickAddButton({+ edge,+ at,+ revealed = false,+}: {+ edge: HogFlowEdge+ at: Point+ /** The pointer is on the arrow, so its button shows. */+ revealed?: boolean+}): JSX.Element {const buttonRef = useRef<HTMLButtonElement>(null)const { quickAddEdgeKey, isPlacing, paletteSections } = useValues(tileCanvasLogic)const { openQuickAdd, closeQuickAdd, addStepAt, placeAt, onDrop } = useActions(tileCanvasLogic)@@ -32,6 +41,7 @@ export function QuickAddButton({ edge, at }: { edge: HogFlowEdge; at: Point }):<Popovervisible={isOpen}placement="right-start"+ fallbackPlacements={['left-start', 'left', 'left-end', 'bottom-start', 'top-start']}overlay={<StepPalettesections={paletteSections}@@ -53,7 +63,9 @@ export function QuickAddButton({ edge, at }: { edge: HogFlowEdge; at: Point }):'flex size-5 cursor-pointer items-center justify-center rounded-full border bg-surface-primary text-secondary transition-all hover:scale-125 hover:border-[var(--color-accent)] hover:text-[var(--color-accent)] motion-reduce:transition-none',isPlacing || isOpen? 'scale-125 border-[var(--color-accent)] text-[var(--color-accent)] shadow'- : 'opacity-60'+ : revealed+ ? 'opacity-100'+ : 'opacity-0 hover:opacity-100 focus-visible:opacity-100')}><IconPlus className="text-xs" />diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasContent.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasContent.tsxindex c29841a64353..b1dd2a5cbd16 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasContent.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasContent.tsx@@ -9,6 +9,7 @@ import { themeLogic } from '~/layout/navigation-3000/themeLogic'import { CommandBar } from './CommandBar'import { PathChip } from './PathChip'import { PathFrame } from './PathFrame'+import { PathTrail } from './PathTrail'import { PlacementHint } from './PlacementHint'import { TileCanvasControls } from './TileCanvasControls'import { TileCanvasLayoutError } from './TileCanvasLayoutError'@@ -123,7 +124,7 @@ export function TileCanvasContent(): JSX.Element {<divref={wrapperRef}onKeyDown={onKeyDown}- className="TileCanvas__flow @container/tile-canvas relative flex min-h-0 min-w-0 grow @max-[48rem]/workflow-editor:min-h-80 @max-[48rem]/workflow-editor:shrink-0"+ className="TileCanvas__flow @container/tile-canvas relative flex min-h-0 min-w-0 grow @max-[48rem]/workflow-editor:min-h-48"><ReactFlow<TileCanvasNode, TileEdgeType>className="grow"@@ -145,7 +146,14 @@ export function TileCanvasContent(): JSX.Element {proOptions={{ hideAttribution: true }}><Background gap={36} variant={BackgroundVariant.Dots} />- <Panel position="bottom-center" className="!mb-5">+ <Panel position="top-left" className="!m-2 max-w-[calc(100%-1rem)]">+ <PathTrail />+ </Panel>+ {/* A narrow editor stacks the panel under the canvas, which leaves no room for the bar over it. */}+ <Panel+ position="bottom-center"+ className={cn('!mb-5', isPanelOpen && '@max-[48rem]/workflow-editor:hidden')}+ ><div className="flex flex-col items-center gap-2">{commandPaletteQuery === null && <PlacementHint />}<CommandBar />diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasControls.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasControls.tsxindex 0aae7b173731..d6eacfd64d7e 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasControls.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasControls.tsx@@ -1,10 +1,14 @@import { ControlButton, Controls, useReactFlow, useStore } from '@xyflow/react'+import { useActions } from 'kea'import { IconExpand45, IconMinus, IconPlus } from '@posthog/icons'+import { tileCanvasLogic } from './tileCanvasLogic'+/** React Flow's own buttons take no data attributes, so the canvas draws its own to keep their use measurable. */export function TileCanvasControls(): JSX.Element {- const { zoomIn, zoomOut, fitView } = useReactFlow()+ const { zoomIn, zoomOut } = useReactFlow()+ const { requestFit } = useActions(tileCanvasLogic)const atMin = useStore((state) => state.transform[2] <= state.minZoom)const atMax = useStore((state) => state.transform[2] >= state.maxZoom)return (@@ -28,9 +32,9 @@ export function TileCanvasControls(): JSX.Element {<IconMinus /></ControlButton><ControlButton- onClick={() => void fitView()}- title="Fit view"- aria-label="Fit view"+ onClick={requestFit}+ title="Fit to screen"+ aria-label="Fit to screen"data-attr="workflow-tile-fit-view"><IconExpand45 />diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasPanel.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasPanel.tsxindex c3056cb0066f..1730f88d74e7 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasPanel.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCanvasPanel.tsx@@ -4,10 +4,9 @@ import { workflowLogic } from '../../../workflowLogic'import { WorkflowRevisions } from '../../../WorkflowRevisions'import { HogFlowEditorPanel } from '../../panel/HogFlowEditorPanel'import { tileCanvasLogic } from './tileCanvasLogic'-import { TileStepPanelHead } from './TileStepPanelHead'export function TileCanvasPanel(): JSX.Element {- const { isHistoryOpen, selectedNode } = useValues(tileCanvasLogic)+ const { isHistoryOpen } = useValues(tileCanvasLogic)const { closePanel } = useActions(tileCanvasLogic)const { logicProps } = useValues(workflowLogic)const historyView =@@ -21,12 +20,5 @@ export function TileCanvasPanel(): JSX.Element {),}: undefined- return (- <HogFlowEditorPanel- layout="docked"- onClose={closePanel}- view={historyView}- stepHead={selectedNode ? <TileStepPanelHead action={selectedNode.data} /> : undefined}- />- )+ return <HogFlowEditorPanel layout="docked" onClose={closePanel} view={historyView} />}diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCaption.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCaption.tsxindex c378c29141d6..8e82a03d89cb 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCaption.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileCaption.tsx@@ -8,7 +8,26 @@ export const CAPTION_WIDTH = 230/** A tile and the panel head keep the caption short, so a long email subject cannot stretch them. The hover card shows more. */const LINES = { tile: 'line-clamp-2', card: 'line-clamp-4' }-export function TileCaption({ facts, size = 'tile' }: { facts: StepFacts; size?: keyof typeof LINES }): JSX.Element {+export function TileCaption({+ facts,+ name,+ size = 'tile',+}: {+ facts: StepFacts+ /** A name the author gave the step leads, and what the step does follows it. */+ name?: string+ size?: keyof typeof LINES+}): JSX.Element {+ if (name) {+ return (+ <div className="ph-no-capture flex w-57.5 flex-col gap-0.5 pt-1 text-left">+ <div className={cn('break-words text-[13px] font-semibold leading-tight', LINES[size])}>{name}</div>+ <div className={cn('break-words text-xs leading-snug text-secondary', LINES[size])}>+ {facts.headline}+ </div>+ </div>+ )+ }return (<div className="ph-no-capture flex w-57.5 flex-col gap-0.5 pt-1 text-left"><div className={cn('break-words text-[13px] font-semibold leading-tight', LINES[size])}>diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileEdge.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileEdge.tsxindex 845d3c2ffc43..ecd56bd4c270 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileEdge.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileEdge.tsx@@ -1,13 +1,15 @@import { EdgeLabelRenderer, EdgeProps } from '@xyflow/react'+import { useState } from 'react'import { QuickAddButton } from './QuickAddButton'-import { arrowHead, EDGE_LABEL_HEIGHT, edgeLabelWidth, insertPoint, roundedPath } from './tileCanvasLayout'+import { arrowHead, EDGE_LABEL_HEIGHT, edgeLabelWidth, insertPoint, roundedPath, shortLabel } from './tileCanvasLayout'import type { TileEdgeType } from './tileCanvasNodes'const QUICK_ADD_GAP = 14export function TileEdge({ data }: EdgeProps<TileEdgeType>): JSX.Element | null {const routed = data?.routed+ const [hovered, setHovered] = useState(false)if (!data || !routed) {return null}@@ -18,6 +20,16 @@ export function TileEdge({ data }: EdgeProps<TileEdgeType>): JSX.Element | null<><path d={roundedPath(routed.points)} fill="none" stroke="var(--tile-canvas-edge)" strokeWidth={1.5} /><path d={arrowHead(routed.points)} fill="none" stroke="var(--tile-canvas-edge)" strokeWidth={1.5} />+ {/* A wide invisible stroke lets the pointer find the arrow, which shows the button that adds a step on it. */}+ <path+ d={roundedPath(routed.points)}+ fill="none"+ stroke="transparent"+ strokeWidth={24}+ style={{ pointerEvents: 'stroke' }}+ onMouseEnter={() => setHovered(true)}+ onMouseLeave={() => setHovered(false)}+ /><EdgeLabelRenderer>{label && routed.label && (<div@@ -26,14 +38,17 @@ export function TileEdge({ data }: EdgeProps<TileEdgeType>): JSX.Element | nulltransform: `translate(-50%, -50%) translate(${routed.label.x}px, ${routed.label.y}px)`,height: EDGE_LABEL_HEIGHT,minWidth: edgeLabelWidth(label),+ pointerEvents: 'all',}}+ title={label === shortLabel(label) ? undefined : label}>- {label}+ {shortLabel(label)}</div>)}{edge.insertEdge && (<QuickAddButtonedge={edge.insertEdge}+ revealed={hovered}at={{ x: at.x + (label ? edgeLabelWidth(label) / 2 + QUICK_ADD_GAP : 0), y: at.y }}/>)}diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStackNode.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStackNode.tsxindex 66ddabf901d9..172c670c9f29 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStackNode.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStackNode.tsx@@ -1,5 +1,7 @@import { useEffect, useRef, useState } from 'react'+import { IconExpand } from '@posthog/icons'+import { humanFriendlyLargeNumber } from 'lib/utils/numbers'import type { HogFlow } from '../../types'@@ -76,13 +78,23 @@ export function TileStackNode({)}</div><div className="flex w-57.5 flex-col gap-0.5 pt-1 text-left">- <div className="break-words text-[13px] font-semibold leading-tight" style={{ color }}>+ <div+ className="line-clamp-2 break-words text-[13px] font-semibold leading-tight"+ style={{ color }}+ title={group.label}+ >{group.label}</div><div className="ph-no-capture break-words text-xs leading-snug">{pathSummary(workflow, group, templateNameOf)}</div>- <div className="text-[11px] text-secondary">{members.length} steps</div>+ <div className="flex items-center gap-1.5 text-[11px] text-secondary">+ {members.length} steps+ <span className="flex items-center gap-0.5 font-medium text-primary">+ <IconExpand className="size-3" />+ Open+ </span>+ </div></div></div>)diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStepNode.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStepNode.tsxindex 9acdea62cc6f..4a8946af8f35 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStepNode.tsx+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStepNode.tsx@@ -66,7 +66,7 @@ export function TileStepNode({}>{interactive ? <TileStepMenu action={action}>{face}</TileStepMenu> : face}- <TileCaption facts={tile.facts} />+ <TileCaption facts={tile.facts} name={tile.customName} /></div>)}diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStepPanelHead.tsx b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStepPanelHead.tsxdeleted file mode 100644index b75b8cadd5fe..000000000000--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/TileStepPanelHead.tsx+++ /dev/null@@ -1,55 +0,0 @@-import { useActions, useValues } from 'kea'--import { IconTrash } from '@posthog/icons'-import { LemonButton } from '@posthog/lemon-ui'--import { HogFlowStepNameFields } from '../../panel/HogFlowStepNameFields'-import type { HogFlowAction } from '../../types'-import { tileCanvasLogic } from './tileCanvasLogic'-import { TileCaption } from './TileCaption'-import { TileFace } from './TileFace'-import { useTileStep } from './useTileStep'--const KIND_BORDER_WIDTH = 3--export function TileStepPanelHead({ action }: { action: HogFlowAction }): JSX.Element {- const { workflow, countOf, selectedNode, selectedNodeCanBeDeleted } = useValues(tileCanvasLogic)- const { onNodesDelete, closePanel } = useActions(tileCanvasLogic)- const tile = useTileStep(action, workflow)- return (- <div- className="relative z-10 flex shrink-0 flex-col gap-3 border-b bg-surface-primary px-3 pb-3 pt-3"- style={{ borderTop: `${KIND_BORDER_WIDTH}px solid ${tile.color}` }}- data-attr="workflow-tile-panel-head"- >- <div className="relative flex items-start gap-3">- <TileFace tile={tile} count={countOf(action.id)} />- <TileCaption facts={tile.facts} />- <div- className="absolute right-0 top-0 text-[10px] font-semibold uppercase tracking-wider"- style={{ color: tile.color }}- >- {tile.label}- </div>- </div>- <div className="flex items-start gap-2">- <div className="flex min-w-0 flex-1 flex-col gap-0.5">- <HogFlowStepNameFields action={action} />- </div>- {selectedNode?.deletable && (- <LemonButton- size="small"- status="danger"- icon={<IconTrash />}- tooltip="Delete this step"- onClick={() => {- onNodesDelete([selectedNode])- closePanel()- }}- disabledReason={selectedNodeCanBeDeleted ? undefined : 'Clean up branching steps first'}- />- )}- </div>- </div>- )-}diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.test.ts b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.test.tsindex 7a2202cbb700..575853f85480 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.test.ts+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.test.ts@@ -104,4 +104,11 @@ describe('layoutTileCanvas', () => {expect(tops).toEqual(tops.map(() => placeOf(outerArms[opened]).top))})++ it('gives a path no more room for a name longer than its label shows', () => {+ const named = (label: string): number =>+ pathFrameSpecs([{ ...outerArms[0], label }], [outerArms[0].id], [])[0].minWidth++ expect(named('Eligible and reachable, '.repeat(6))).toEqual(named('x'.repeat(40)))+ })})diff --git a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.ts b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.tsindex b0566b11cb74..fe23ead4feea 100644--- a/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.ts+++ b/products/workflows/frontend/Workflows/hogflows/editor/tile-canvas/tileCanvasLayout.ts@@ -46,8 +46,13 @@ export interface PathFrameSpec {minWidth: number}-export const edgeLabelWidth = (text: string): number => Math.ceil(text.length * 6.6) + 20-export const frameChipWidth = (label: string): number => Math.ceil(label.length * 7.6) + 64+const LABEL_MAX_CHARS = 40+/** A condition name can run to a sentence, and a label that long would set the width of its whole path. */+export const shortLabel = (text: string): string =>+ text.length <= LABEL_MAX_CHARS ? text : `${text.slice(0, LABEL_MAX_CHARS - 1).trimEnd()}…`+export const edgeLabelWidth = (text: string): number => Math.ceil(shortLabel(text).length * 6.6) + 20+/** The chip also holds the Collapse control after the name. */+export const frameChipWidth = (label: string): number => Math.ceil(shortLabel(label).length * 7.6) + 136export const frameId = (group: PathGroup): string => `frame:${group.id}`diff --git a/products/workflows/frontend/Workflows/hogflows/panel/HogFlowEditorPanel.tsx b/products/workflows/frontend/Workflows/hogflows/panel/HogFlowEditorPanel.tsxindex 750051185fe1..5048a4e52edf 100644--- a/products/workflows/frontend/Workflows/hogflows/panel/HogFlowEditorPanel.tsx+++ b/products/workflows/frontend/Workflows/hogflows/panel/HogFlowEditorPanel.tsx@@ -29,15 +29,12 @@ export interface HogFlowEditorPanelProps {layout?: 'floating' | 'panel' | 'docked'onClose?: () => voidview?: { title: string; content: JSX.Element }- /** Replaces the selected step's head, for a canvas that draws steps its own way. */- stepHead?: JSX.Element}export function HogFlowEditorPanel({layout = 'floating',onClose,view,- stepHead,}: HogFlowEditorPanelProps = {}): JSX.Element | null {const { panelWidth, selectedNode, mode, workflow } = useValues(hogFlowEditorLogic)const { clearPanelWidth, setMode, setPanelWidth, setSelectedNodeId } = useActions(hogFlowEditorLogic)@@ -79,12 +76,12 @@ export function HogFlowEditorPanel({ref={panelRef}data-attr="workflow-editor-panel"className={clsx(- 'flex min-h-0 max-h-full flex-col justify-end overflow-hidden @max-[48rem]/workflow-editor:!relative @max-[48rem]/workflow-editor:!h-96 @max-[48rem]/workflow-editor:!min-w-0 @max-[48rem]/workflow-editor:!w-full @max-[48rem]/workflow-editor:!max-w-full @max-[48rem]/workflow-editor:shrink-0',- layout === 'floating' && 'absolute right-0 max-w-full p-2',+ 'flex min-h-0 max-h-full flex-col justify-end overflow-hidden @max-[48rem]/workflow-editor:!relative @max-[48rem]/workflow-editor:!min-w-0 @max-[48rem]/workflow-editor:!w-full @max-[48rem]/workflow-editor:!max-w-full @max-[48rem]/workflow-editor:shrink-0',+ layout === 'floating' && 'absolute right-0 max-w-full p-2 @max-[48rem]/workflow-editor:!h-96',layout === 'panel' &&- 'relative h-full shrink-0 bg-surface-primary @max-[48rem]/workflow-editor:border-t',+ 'relative h-full shrink-0 bg-surface-primary @max-[48rem]/workflow-editor:!h-96 @max-[48rem]/workflow-editor:border-t',layout === 'docked' &&- 'relative h-full min-w-80 max-w-[calc(100%-30rem)] shrink-0 border-l bg-surface-primary @max-[48rem]/workflow-editor:border-t @max-[48rem]/workflow-editor:border-l-0'+ 'relative h-full min-w-80 max-w-[calc(100%-30rem)] shrink-0 border-l bg-surface-primary @max-[48rem]/workflow-editor:!h-1/2 @max-[48rem]/workflow-editor:border-t @max-[48rem]/workflow-editor:border-l-0')}style={layout === 'panel'@@ -153,9 +150,9 @@ export function HogFlowEditorPanel({view.content) : (<>- {selectedNode &&- ['build', 'metrics', 'test', 'logs'].includes(mode) &&- (stepHead ?? <HogFlowEditorPanelSelectedStep />)}+ {selectedNode && ['build', 'metrics', 'test', 'logs'].includes(mode) && (+ <HogFlowEditorPanelSelectedStep />+ )}{mode === 'build' && (<>{!selectedNode ? <HogFlowEditorPanelBuild /> : <HogFlowEditorPanelBuildDetail />}</>)}