Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

refactor(experiments): own the team experiments config admin inline (#125441)

Anders69365f13d004
diff --git a/posthog/admin/admins/team_admin.py b/posthog/admin/admins/team_admin.py
index 747726f94dba..f8df604126da 100644
--- a/posthog/admin/admins/team_admin.py
+++ b/posthog/admin/admins/team_admin.py
@@ -30,9 +30,9 @@ from temporalio import common
from temporalio.client import WorkflowExecutionStatus
from temporalio.common import SearchAttributePair, TypedSearchAttributes
+from posthog.admin.inline_registry import extra_inlines_for
from posthog.admin.inlines.events_retention_config_inline import TeamEventsRetentionConfigInline
from posthog.admin.inlines.organization_member_for_related_inline import OrganizationMemberForRelatedInline
-from posthog.admin.inlines.team_experiments_config_inline import TeamExperimentsConfigInline
from posthog.admin.inlines.team_marketing_analytics_config_inline import TeamMarketingAnalyticsConfigInline
from posthog.helpers.impersonation import is_impersonated
from posthog.llm.gateway_internal_client import AIGatewayInternalError, AIGatewayNotConfigured, add_credit, get_wallet
@@ -204,10 +204,14 @@ class TeamAdmin(admin.ModelAdmin):
inlines = [
OrganizationMemberForRelatedInline,
TeamMarketingAnalyticsConfigInline,
- TeamExperimentsConfigInline,
TeamEventsRetentionConfigInline,
]
+ def get_inlines(self, request, obj=None):
+ # Inlines other apps registered for Team, so a product can show a panel on
+ # this page without core importing it. See posthog.admin.inline_registry.
+ return [*super().get_inlines(request, obj), *extra_inlines_for(Team)]
+
def changeform_view(self, request, object_id=None, form_url="", extra_context=None):
self._current_request = request
return super().changeform_view(request, object_id, form_url, extra_context)
diff --git a/products/experiments/backend/admin/__init__.py b/products/experiments/backend/admin/__init__.py
index 5a3bec5aa0bc..2c2f65f35aac 100644
--- a/products/experiments/backend/admin/__init__.py
+++ b/products/experiments/backend/admin/__init__.py
@@ -1,7 +1,8 @@
-# Importing these submodules fires their `@admin.register` decorators when
-# `autodiscover_modules("admin")` imports this package.
+# Importing these submodules fires their `@admin.register` decorators and
+# `register_admin_inline` calls when `autodiscover_modules("admin")` imports this package.
from products.experiments.backend.admin import ( # noqa: F401
experiment_admin,
experiment_saved_metric_admin,
recalculation_admin,
+ team_experiments_config_inline,
)
diff --git a/posthog/admin/inlines/team_experiments_config_inline.py b/products/experiments/backend/admin/team_experiments_config_inline.py
similarity index 84%
rename from posthog/admin/inlines/team_experiments_config_inline.py
rename to products/experiments/backend/admin/team_experiments_config_inline.py
index d02e5d5e7f66..ec8c30b3d8ce 100644
--- a/posthog/admin/inlines/team_experiments_config_inline.py
+++ b/products/experiments/backend/admin/team_experiments_config_inline.py
@@ -1,6 +1,9 @@
from django import forms
from django.contrib import admin
+from posthog.admin.inline_registry import register_admin_inline
+from posthog.models import Team
+
from products.experiments.backend.models.team_experiments_config import TeamExperimentsConfig
@@ -43,3 +46,8 @@ class TeamExperimentsConfigInline(admin.StackedInline):
def has_delete_permission(self, request, obj=None):
return False
+
+
+# Surface the inline on core's Team admin page without core importing the product.
+# TeamAdmin pulls it in via get_inlines(). See posthog.admin.inline_registry.
+register_admin_inline(Team, TeamExperimentsConfigInline)
diff --git a/posthog/admin/test_team_experiments_config_inline.py b/products/experiments/backend/test/test_team_experiments_config_inline.py
similarity index 69%
rename from posthog/admin/test_team_experiments_config_inline.py
rename to products/experiments/backend/test/test_team_experiments_config_inline.py
index 4497bb0ccf59..a9c4814213a4 100644
--- a/posthog/admin/test_team_experiments_config_inline.py
+++ b/products/experiments/backend/test/test_team_experiments_config_inline.py
@@ -1,10 +1,17 @@
from posthog.test.base import BaseTest
+from django.contrib.admin import AdminSite
from django.forms import ModelForm, modelform_factory
+from django.test import RequestFactory, SimpleTestCase
-from posthog.admin.inlines.team_experiments_config_inline import TeamExperimentsConfigInlineForm
+from posthog.admin.admins.team_admin import TeamAdmin
+from posthog.models import Team
from posthog.models.team.extensions import get_or_create_team_extension
+from products.experiments.backend.admin.team_experiments_config_inline import (
+ TeamExperimentsConfigInline,
+ TeamExperimentsConfigInlineForm,
+)
from products.experiments.backend.models.team_experiments_config import TeamExperimentsConfig
@@ -29,3 +36,9 @@ class TestTeamExperimentsConfigInlineForm(BaseTest):
self.assertTrue(form.is_valid(), form.errors)
config = form.save()
self.assertEqual(config.experiment_recalculation_times, ["14:00:00", "02:00:00"])
+
+
+class TestTeamExperimentsConfigInlineRegistration(SimpleTestCase):
+ def test_inline_attaches_to_team_admin(self):
+ team_admin = TeamAdmin(Team, AdminSite())
+ self.assertIn(TeamExperimentsConfigInline, team_admin.get_inlines(RequestFactory().get("/")))