:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(signals): show per-head lift and center the lift bar on 1x (#119781)
posthog[bot]6ac2ef17ba0b
diff --git a/frontend/snapshots.yml b/frontend/snapshots.ymlindex 84cf1d44c5e9..6934d5ce7ea6 100644--- a/frontend/snapshots.yml+++ b/frontend/snapshots.yml@@ -11247,9 +11247,9 @@ snapshots:scenes-app-inbox-cards--pull-request-cards--light:hash: v1.k794b7964.19291313347041d3b8311d7a7e9b97ee8e60b7ccca476b1b3c43945a006de3fe.Lf3Mkhh7fJ5mnyomCZa2-Jcw4fOG4rgHZ5udu8CQNxgscenes-app-inbox-cards--report-card-ranking-tags--dark:- hash: v1.k794b7964.7e0ad449f0f22eb44dcd7e77ee090c579e08387ae4c34214417a345871fab2a5.f9JnoKRVlRT_kyV09RgUE5_Tz8Q2uAcun90ikzLy_Q4+ hash: v1.k794b7964.294082f823ab2ce9f78f66e8746953db61e9223adb567a0f695fcd234b92df06.GcCaDeL0q5OBdxC6X5LATc1y6EER1pRwb4jC-CCI6j8scenes-app-inbox-cards--report-card-ranking-tags--light:- hash: v1.k794b7964.6a0b9cca157bc22b01c5c0300112dc4587cf632c817750a433628da227c1580c.LTthUp2YqFYePHTgvmC43QS9YX7fdZhD-zPpHgjUjxI+ hash: v1.k794b7964.8a2bda01a1685a8d2b69aa05b2ddf6b8d9164e1dc98ead1e26dbd8fadbb5e103.GnchgJgJyVKlTAgtUTqypg49s-yl7wLPRkR9a3InLyYscenes-app-inbox-cards--report-card-states--dark:hash: v1.k794b7964.b987dc8b9a750647567259b3cfb6f65c1fc03c82294e599942d85f394182ec5f.tJh2uAs0GnyekhEbDh2gi3yZAm6ydVS4Tp8YEAowHccscenes-app-inbox-cards--report-card-states--light:@@ -14711,17 +14711,17 @@ snapshots:scenes-app-signals-artefactloglist--narrow--light:hash: v1.k794b7964.bc1bb17c0d0961d5b227fd437b445c7bd80e368d17beebe24e1c35f6ec962d18.NfYGRA8WerwD9NaJgX1I1fN3ZjRIb2fYJzJhlEiKubgscenes-app-signals-artefactloglist--ranking-score--dark:- hash: v1.k794b7964.b2f6ecde64678b491e63960e212656014e26e0611601b29f975b797bf8c82ed2.fcO6NcbOIYxiZeLjd-JdG1BP0Mrk8nfNuj6a1AOS9AU+ hash: v1.k794b7964.71e7ad1e0e29d7df3381bb65dae809f5ef4a3cc20de7738519ddc2f0323f76e1.adFYnEeyErZk-2toT-MbXv2DVVVQA3ShbLqLlnaakFYscenes-app-signals-artefactloglist--ranking-score--light:- hash: v1.k794b7964.9685c0e156d7aeb1473c4f7f77146f435ff21296909830abf39f620af9acf949.XX4CUKAxDWeV3C5vXULvpfVI1yOCd0hpi0WCT2KXAvU+ hash: v1.k794b7964.0605c0f3a7b72897c5d655de9af5f767db06a09f1b2ede04bb694deb465943f7.mV9jZbvVKoxip7Kfpcu3PtZ-zP1XUhwNnf_NYz7QG94scenes-app-signals-artefactloglist--ranking-score-all-heads--dark:- hash: v1.k794b7964.5cf2508f92e498071cf00b89916c9ceb6f1552c8b740ed63a62e185b4a8be59e.nAFTq4vg0FmgttoOvK_R1nMS4nxxl7-QfmqyA2Qnq88+ hash: v1.k794b7964.1fcb66bace69ead5a3771a3552eede0101724db7202c4b321827bb9021da9a0c.Cjl1gELgUQDE9KxyM0IG8E6FzTzVOnKXsSIRwmQc_Jcscenes-app-signals-artefactloglist--ranking-score-all-heads--light:- hash: v1.k794b7964.59e9dff519bf23a0a343e7e6dd4976985486f823a73d0dd18140ab09bd89c666.bSSYwoWPv0Mei1LH-1L1tSe1r7wtnqcUVmW0xV8XxBs+ hash: v1.k794b7964.bd48f24e9fef8696f76aa64b35d5f4e61948f1a273796afe722bdaf396ba5e12.dMjDVK1tbRdyc7HIv-5PblYSo0_LbjCifv6k8NMuoZwscenes-app-signals-artefactloglist--ranking-score-narrow--dark:- hash: v1.k794b7964.c45f6c6f88fb8ec781d72d315e0447e12819e2e582aa457f79858cbc0e079549.kD4Ij85HrhYA9pyNaOiidYDdoX3SSqdma7NexCPydjY+ hash: v1.k794b7964.d3b608e45c6ebae1e3c54ae1fdd1d310e208e5e61e206810311e7bde10bad273.VTT--LhqWbIcGhdZgM5jxOpHB0Uw70HpZSQnSdgdwvIscenes-app-signals-artefactloglist--ranking-score-narrow--light:- hash: v1.k794b7964.e6db177d796824ba271ca2a2fce62c6a637df3586753b2a5651c3c884a8feac2.hXYW48r-72Ns5eA4yz9fak_rR3IF0qbYVXlK8fhyj-w+ hash: v1.k794b7964.2b39979a0f350a3b771111bb628d4d7343631e2e13afefc3bd2a7b7b16375dfc.sozT5ARsJ4ZSZQMiqONQB-Cq6EgVyJga1F7Xq6hLCfoscenes-app-signals-artefactloglist--replacement-lifecycle--dark:hash: v1.k794b7964.f723b2160bdf85cd5a827fa3dac4c281d75950f47555cdef7fc01f2ef689dfc6.wAOg7AG2Pf4mYO8EjKdD8lFlC1Ulv4MhkXIEMkzfCrgscenes-app-signals-artefactloglist--replacement-lifecycle--light:diff --git a/products/signals/frontend/inbox/components/cards/InboxCards.stories.tsx b/products/signals/frontend/inbox/components/cards/InboxCards.stories.tsxindex c97ad4271f22..3a2660accdcd 100644--- a/products/signals/frontend/inbox/components/cards/InboxCards.stories.tsx+++ b/products/signals/frontend/inbox/components/cards/InboxCards.stories.tsx@@ -276,7 +276,7 @@ const rankedReports: SignalReport[] = [ranking: {...RANKING,scores: { open: 0.91, action: 0.78, fixed: 0.33, pr_merged: 0.52 },- lifts: { open: 1.1, action: 2.1, fixed: 2.2, pr_merged: 2.6 },+ lifts: { open: 0.6, action: 2.1, fixed: 6.0, pr_merged: 2.6 },},}),makeReport({diff --git a/products/signals/frontend/inbox/components/cards/RankingLiftBar.tsx b/products/signals/frontend/inbox/components/cards/RankingLiftBar.tsxindex abe6a25c398a..588e20b14efa 100644--- a/products/signals/frontend/inbox/components/cards/RankingLiftBar.tsx+++ b/products/signals/frontend/inbox/components/cards/RankingLiftBar.tsx@@ -1,18 +1,27 @@import clsx from 'clsx'-import { rankingLiftBarPercent } from './rankingFormat'+import { rankingLiftBarFill } from './rankingFormat'-/** A lift on a log scale with a tick at 1x. A head without a lift shows an empty track. */+/**+ * A lift on a log scale with a tick at 1x. The fill grows from the tick, right above 1x and left below 1x.+ * A head without a lift shows an empty track.+ */export function RankingLiftBar({ lift, className }: { lift: number | null; className?: string }): JSX.Element {+ const fill = lift !== null ? rankingLiftBarFill(lift) : null+ const belowAverage = lift !== null && lift < 1return (<span className="relative block h-1.5 overflow-hidden rounded-full">{/* The track and tick take the text color, so they keep contrast in a dark tooltip and on a light card. */}<span className="absolute inset-0 bg-current opacity-20" aria-hidden />- {lift !== null ? (+ {fill !== null ? (<span- className={clsx('relative block h-full rounded-full', className ?? 'bg-current')}+ className={clsx(+ 'absolute inset-y-0 rounded-full',+ className ?? 'bg-current',+ belowAverage && 'opacity-50'+ )}// oxlint-disable-next-line react/forbid-dom-props- style={{ width: `${rankingLiftBarPercent(lift)}%` }}+ style={{ left: `${fill.left}%`, width: `${fill.width}%` }}/>) : null}<span className="absolute inset-y-0 left-1/2 w-px bg-current opacity-60" aria-hidden />diff --git a/products/signals/frontend/inbox/components/cards/ReportCardRankingTag.tsx b/products/signals/frontend/inbox/components/cards/ReportCardRankingTag.tsxindex ec9e4adc30d8..d6e6603e658f 100644--- a/products/signals/frontend/inbox/components/cards/ReportCardRankingTag.tsx+++ b/products/signals/frontend/inbox/components/cards/ReportCardRankingTag.tsx@@ -45,7 +45,7 @@ function RankingHoverCard({ ranking, active }: { ranking: Ranking; active: Inbox(rankingLift(ranking, score.head) !== null || rankingProbability(ranking, score.head) !== null))return (- <div className="flex max-w-80 min-w-72 flex-col gap-2 text-xs">+ <div className="flex max-w-96 min-w-80 flex-col gap-2 text-xs"><div><div className="font-semibold"><span>{active.name}</span>:{' '}@@ -71,6 +71,9 @@ function RankingHoverCard({ ranking, active }: { ranking: Ranking; active: Inbox<span className="flex-1"><RankingLiftBar lift={scoreLift} /></span>+ <span className="w-9 shrink-0 text-right tabular-nums">+ {scoreLift !== null ? formatRankingLift(scoreLift) : null}+ </span><span className="w-24 shrink-0 text-right whitespace-nowrap">{scoreLift !== null ? RANKING_STRENGTH_LABELS[rankingStrength(scoreLift)] : null}</span>diff --git a/products/signals/frontend/inbox/components/cards/rankingFormat.test.ts b/products/signals/frontend/inbox/components/cards/rankingFormat.test.tsindex 4034fc1c00b5..e63a6d3778d8 100644--- a/products/signals/frontend/inbox/components/cards/rankingFormat.test.ts+++ b/products/signals/frontend/inbox/components/cards/rankingFormat.test.ts@@ -1,4 +1,4 @@-import { formatRankingLift, rankingLiftBarPercent, rankingStrength } from './rankingFormat'+import { formatRankingLift, rankingLiftBarFill, rankingLiftBarPercent, rankingStrength } from './rankingFormat'describe('rankingFormat', () => {test.each([@@ -23,6 +23,20 @@ describe('rankingFormat', () => {expect(rankingLiftBarPercent(lift)).toBeCloseTo(expected)})+ test.each([+ [1, 50, 0],+ [10, 50, 50],+ [40, 50, 50],+ [Math.sqrt(10), 50, 25],+ [0.1, 0, 50],+ [0.05, 0, 50],+ [1 / Math.sqrt(10), 25, 25],+ ])('fills the bar for a lift of %s from %s% with a width of %s%', (lift, left, width) => {+ const fill = rankingLiftBarFill(lift)+ expect(fill.left).toBeCloseTo(left)+ expect(fill.width).toBeCloseTo(width)+ })+test.each([[3.1, 'very_likely'],[2, 'very_likely'],diff --git a/products/signals/frontend/inbox/components/cards/rankingFormat.ts b/products/signals/frontend/inbox/components/cards/rankingFormat.tsindex 56d368e3ef8d..a2ee1890fdb5 100644--- a/products/signals/frontend/inbox/components/cards/rankingFormat.ts+++ b/products/signals/frontend/inbox/components/cards/rankingFormat.ts@@ -12,7 +12,7 @@ export function formatRankingLift(lift: number): string {}/**- * Bar width in percent for a lift on a log scale. 1x sits at 50%, and the bar clamps at 0.1x and 10x,+ * Bar position in percent for a lift on a log scale. 1x sits at 50%, and the bar clamps at 0.1x and 10x,* so a lift and its inverse sit at equal distances from the center.*/export function rankingLiftBarPercent(lift: number): number {@@ -23,6 +23,12 @@ export function rankingLiftBarPercent(lift: number): number {return Math.min(1, Math.max(0, position)) * 100}+/** The bar fill in percent. It starts at 1x in the center and grows right above 1x and left below 1x. */+export function rankingLiftBarFill(lift: number): { left: number; width: number } {+ const percent = rankingLiftBarPercent(lift)+ return { left: Math.min(50, percent), width: Math.abs(percent - 50) }+}+export type RankingStrength = 'very_likely' | 'likely' | 'average' | 'unlikely'export const RANKING_STRENGTH_LABELS: Record<RankingStrength, string> = {