Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

refactor(experiments): move experiment activity receivers and data generator into the product (#122724)

Anders6adee8f0139b
diff --git a/posthog/models/activity_logging/signal_handlers.py b/posthog/models/activity_logging/signal_handlers.py
index 490ad2390952..4e53a0a2a989 100644
--- a/posthog/models/activity_logging/signal_handlers.py
+++ b/posthog/models/activity_logging/signal_handlers.py
@@ -57,12 +57,6 @@ from posthog.session.activity import session_activity_credential
from posthog.session.models import Session
from posthog.utils import get_ip_address, get_short_user_agent
-from products.experiments.backend.models.experiment import (
- ExperimentHoldout,
- ExperimentSavedMetric,
- ExperimentToSavedMetric,
-)
-
logger = structlog.get_logger(__name__)
@@ -420,75 +414,6 @@ def handle_identity_provider_config_change(
)
-@mutable_receiver(model_activity_signal, sender=ExperimentSavedMetric)
-def handle_experiment_saved_metric_change(
- sender, scope, before_update, after_update, activity, user, was_impersonated=False, **kwargs
-):
- log_activity(
- organization_id=after_update.team.organization_id,
- team_id=after_update.team_id,
- user=user,
- was_impersonated=was_impersonated,
- item_id=after_update.id,
- scope="Experiment", # log under Experiment scope so it appears in experiment activity log
- activity=activity,
- detail=Detail(
- # need to use ExperimentSavedMetric here for field exclusions..
- changes=changes_between("ExperimentSavedMetric", previous=before_update, current=after_update),
- name=after_update.name,
- type="shared_metric",
- ),
- )
-
-
-@receiver(pre_delete, sender=ExperimentSavedMetric)
-def handle_experiment_saved_metric_delete(sender, instance, **kwargs):
- log_activity(
- organization_id=instance.team.organization_id,
- team_id=instance.team_id,
- user=activity_storage.get_user() or getattr(instance, "last_modified_by", instance.created_by),
- was_impersonated=activity_storage.get_was_impersonated(),
- item_id=instance.id,
- scope="Experiment", # log under Experiment scope so it appears in experiment activity log
- activity="deleted",
- detail=Detail(name=instance.name, type="shared_metric"),
- )
-
-
-@mutable_receiver(model_activity_signal, sender=ExperimentHoldout)
-def handle_experiment_holdout_change(
- sender, scope, before_update, after_update, activity, user=None, was_impersonated=False, **kwargs
-):
- log_activity(
- organization_id=after_update.team.organization_id,
- team_id=after_update.team_id,
- user=user or after_update.created_by,
- was_impersonated=was_impersonated,
- item_id=after_update.id,
- scope="Experiment", # log under Experiment scope so it appears in experiment activity log
- activity=activity,
- detail=Detail(
- changes=changes_between(scope, previous=before_update, current=after_update),
- name=after_update.name,
- type="holdout",
- ),
- )
-
-
-@receiver(pre_delete, sender=ExperimentHoldout)
-def handle_experiment_holdout_delete(sender, instance, **kwargs):
- log_activity(
- organization_id=instance.team.organization_id,
- team_id=instance.team_id,
- user=activity_storage.get_user() or getattr(instance, "last_modified_by", instance.created_by),
- was_impersonated=activity_storage.get_was_impersonated(),
- item_id=instance.id,
- scope="Experiment",
- activity="deleted",
- detail=Detail(name=instance.name, type="holdout"),
- )
-
-
@dataclasses.dataclass(frozen=True)
class OAuthApplicationScopesContext(ActivityContextBase):
client_id: str
@@ -569,35 +494,6 @@ def handle_oauth_application_scopes_change(
)
-@mutable_receiver(model_activity_signal, sender=ExperimentToSavedMetric)
-def handle_experiment_to_saved_metric_change(
- sender, scope, before_update, after_update, activity, user, was_impersonated=False, **kwargs
-):
- instance = after_update or before_update
- if not instance:
- return
-
- log_activity(
- organization_id=instance.experiment.team.organization_id,
- team_id=instance.experiment.team_id,
- user=user or activity_storage.get_user(),
- was_impersonated=was_impersonated or activity_storage.get_was_impersonated(),
- item_id=instance.experiment_id,
- # Stored under the public Experiment scope so it shows up in the experiment
- # activity log feed. The describer arm on `type="saved_metric_config"`
- # renders the row.
- scope="Experiment",
- activity=activity,
- detail=Detail(
- # `"ExperimentToSavedMetric"` is an InternalActivityScope key used only for
- # field_exclusions / changes_between — never written to ActivityLog.scope.
- changes=changes_between("ExperimentToSavedMetric", previous=before_update, current=after_update),
- name=instance.saved_metric.name,
- type="saved_metric_config",
- ),
- )
-
-
# --- Receivers relocated from posthog.api viewset modules ---------------------------------
# These used to live next to their viewsets and wired in as an import side effect of the
# eager API router. With the lazy router, AppConfig.ready() imports this module instead, so
diff --git a/posthog/test/repo_invariants/setup_receivers_baseline.txt b/posthog/test/repo_invariants/setup_receivers_baseline.txt
index a982b51f1666..aa85a5b175a6 100644
--- a/posthog/test/repo_invariants/setup_receivers_baseline.txt
+++ b/posthog/test/repo_invariants/setup_receivers_baseline.txt
@@ -3,9 +3,6 @@
# UPDATE_SETUP_RECEIVERS_BASELINE=1 pytest posthog/test/repo_invariants/test_startup_import_budget.py -k receivers_match
# A receiver disappearing from this set means it connects in NO process (silent audit/cache loss):
# restore its AppConfig.ready() wiring instead of deleting the line.
-model_activity:posthog.models.activity_logging.signal_handlers.handle_experiment_holdout_change
-model_activity:posthog.models.activity_logging.signal_handlers.handle_experiment_saved_metric_change
-model_activity:posthog.models.activity_logging.signal_handlers.handle_experiment_to_saved_metric_change
model_activity:posthog.models.activity_logging.signal_handlers.handle_identity_provider_config_change
model_activity:posthog.models.activity_logging.signal_handlers.handle_oauth_application_scopes_change
model_activity:posthog.models.activity_logging.signal_handlers.handle_organization_change
@@ -39,6 +36,9 @@ model_activity:products.data_quality.backend.activity_logging.handle_data_qualit
model_activity:products.data_tools.backend.activity_logging.handle_expression_activity
model_activity:products.data_tools.backend.activity_logging.handle_join_activity
model_activity:products.experiments.backend.activity_logging.handle_experiment_change
+model_activity:products.experiments.backend.activity_logging.handle_experiment_holdout_change
+model_activity:products.experiments.backend.activity_logging.handle_experiment_saved_metric_change
+model_activity:products.experiments.backend.activity_logging.handle_experiment_to_saved_metric_change
model_activity:products.experiments.backend.activity_logging.handle_team_experiments_config_change
model_activity:products.feature_flags.backend.activity_logging.handle_feature_flag_change
model_activity:products.legal_documents.backend.signals.handle_legal_document_change
@@ -276,13 +276,11 @@ post_save:products.workflows.backend.models.hog_flow.hog_flow.hog_flow_saved
post_save:products.workflows.backend.models.hog_flow.hog_flow.team_saved_for_hog_flows
post_save:products.workflows.backend.models.hog_flow_batch_job.hog_flow_batch_job.handle_hog_flow_batch_job_created
post_save:products.workflows.backend.receivers.workflow_saved
-pre_delete:posthog.models.scim_provisioned_user.clear_scim_provisioned_user_config
-pre_delete:posthog.models.activity_logging.signal_handlers.handle_experiment_holdout_delete
-pre_delete:posthog.models.activity_logging.signal_handlers.handle_experiment_saved_metric_delete
pre_delete:posthog.models.activity_logging.signal_handlers.handle_personal_api_key_delete
pre_delete:posthog.models.activity_logging.signal_handlers.handle_project_secret_api_key_delete
pre_delete:posthog.models.organization.ensure_organization_membership_consistency
pre_delete:posthog.models.organization_invite._unsuppress_delegator_onboarding_on_invite_delete
+pre_delete:posthog.models.scim_provisioned_user.clear_scim_provisioned_user_config
pre_delete:posthog.storage.gateway_credential_signal_handlers._clear_oauth_on_delete
pre_delete:posthog.storage.gateway_credential_signal_handlers._clear_secret_key_on_delete
pre_delete:posthog.storage.team_access_cache_signal_handlers.clear_project_secret_api_key_cache_on_delete
@@ -292,6 +290,8 @@ pre_delete:products.alerts.backend.activity_logging.cleanup_alert_hog_functions
pre_delete:products.alerts.backend.activity_logging.handle_alert_subscription_delete
pre_delete:products.billing_alerts.backend.team_lifecycle.rehome_billing_alerts_before_team_delete
pre_delete:products.customer_analytics.backend.signals.delete_private_account_views_for_deleted_user
+pre_delete:products.experiments.backend.activity_logging.handle_experiment_holdout_delete
+pre_delete:products.experiments.backend.activity_logging.handle_experiment_saved_metric_delete
pre_delete:products.managed_migrations.backend.activity_logging.handle_batch_import_delete
pre_delete:products.tasks.backend.models.clear_channel_repositories_on_github_integration_delete
pre_delete:products.tasks.backend.team_deletion.cancel_task_workflows_on_team_delete
diff --git a/products/experiments/backend/activity_logging.py b/products/experiments/backend/activity_logging.py
index 9312766927f6..103120669e7b 100644
--- a/products/experiments/backend/activity_logging.py
+++ b/products/experiments/backend/activity_logging.py
@@ -1,10 +1,19 @@
from typing import Any
+from django.db.models.signals import pre_delete
+from django.dispatch import receiver
+
from posthog.models.activity_logging.activity_log import AuditableScope, Change, Detail, changes_between, log_activity
+from posthog.models.activity_logging.utils import activity_storage
from posthog.models.signals import model_activity_signal, mutable_receiver
from posthog.models.user import User
-from products.experiments.backend.models.experiment import Experiment
+from products.experiments.backend.models.experiment import (
+ Experiment,
+ ExperimentHoldout,
+ ExperimentSavedMetric,
+ ExperimentToSavedMetric,
+)
from products.experiments.backend.models.team_experiments_config import TeamExperimentsConfig
from products.experiments.backend.models.web_experiment import WebExperiment
@@ -122,3 +131,101 @@ def handle_team_experiments_config_change(
activity="updated",
detail=Detail(changes=changes, name=after_update.team.name),
)
+
+
+@mutable_receiver(model_activity_signal, sender=ExperimentSavedMetric)
+def handle_experiment_saved_metric_change(
+ sender, scope, before_update, after_update, activity, user, was_impersonated=False, **kwargs
+):
+ log_activity(
+ organization_id=after_update.team.organization_id,
+ team_id=after_update.team_id,
+ user=user,
+ was_impersonated=was_impersonated,
+ item_id=after_update.id,
+ scope="Experiment", # log under Experiment scope so it appears in experiment activity log
+ activity=activity,
+ detail=Detail(
+ # need to use ExperimentSavedMetric here for field exclusions..
+ changes=changes_between("ExperimentSavedMetric", previous=before_update, current=after_update),
+ name=after_update.name,
+ type="shared_metric",
+ ),
+ )
+
+
+@receiver(pre_delete, sender=ExperimentSavedMetric)
+def handle_experiment_saved_metric_delete(sender, instance, **kwargs):
+ log_activity(
+ organization_id=instance.team.organization_id,
+ team_id=instance.team_id,
+ user=activity_storage.get_user() or getattr(instance, "last_modified_by", instance.created_by),
+ was_impersonated=activity_storage.get_was_impersonated(),
+ item_id=instance.id,
+ scope="Experiment", # log under Experiment scope so it appears in experiment activity log
+ activity="deleted",
+ detail=Detail(name=instance.name, type="shared_metric"),
+ )
+
+
+@mutable_receiver(model_activity_signal, sender=ExperimentHoldout)
+def handle_experiment_holdout_change(
+ sender, scope, before_update, after_update, activity, user=None, was_impersonated=False, **kwargs
+):
+ log_activity(
+ organization_id=after_update.team.organization_id,
+ team_id=after_update.team_id,
+ user=user or after_update.created_by,
+ was_impersonated=was_impersonated,
+ item_id=after_update.id,
+ scope="Experiment", # log under Experiment scope so it appears in experiment activity log
+ activity=activity,
+ detail=Detail(
+ changes=changes_between(scope, previous=before_update, current=after_update),
+ name=after_update.name,
+ type="holdout",
+ ),
+ )
+
+
+@receiver(pre_delete, sender=ExperimentHoldout)
+def handle_experiment_holdout_delete(sender, instance, **kwargs):
+ log_activity(
+ organization_id=instance.team.organization_id,
+ team_id=instance.team_id,
+ user=activity_storage.get_user() or getattr(instance, "last_modified_by", instance.created_by),
+ was_impersonated=activity_storage.get_was_impersonated(),
+ item_id=instance.id,
+ scope="Experiment",
+ activity="deleted",
+ detail=Detail(name=instance.name, type="holdout"),
+ )
+
+
+@mutable_receiver(model_activity_signal, sender=ExperimentToSavedMetric)
+def handle_experiment_to_saved_metric_change(
+ sender, scope, before_update, after_update, activity, user, was_impersonated=False, **kwargs
+):
+ instance = after_update or before_update
+ if not instance:
+ return
+
+ log_activity(
+ organization_id=instance.experiment.team.organization_id,
+ team_id=instance.experiment.team_id,
+ user=user or activity_storage.get_user(),
+ was_impersonated=was_impersonated or activity_storage.get_was_impersonated(),
+ item_id=instance.experiment_id,
+ # Stored under the public Experiment scope so it shows up in the experiment
+ # activity log feed. The describer arm on `type="saved_metric_config"`
+ # renders the row.
+ scope="Experiment",
+ activity=activity,
+ detail=Detail(
+ # `"ExperimentToSavedMetric"` is an InternalActivityScope key used only for
+ # field_exclusions / changes_between — never written to ActivityLog.scope.
+ changes=changes_between("ExperimentToSavedMetric", previous=before_update, current=after_update),
+ name=instance.saved_metric.name,
+ type="saved_metric_config",
+ ),
+ )
diff --git a/posthog/management/commands/generate_experiment_data.py b/products/experiments/backend/management/commands/generate_experiment_data.py
similarity index 100%
rename from posthog/management/commands/generate_experiment_data.py
rename to products/experiments/backend/management/commands/generate_experiment_data.py