Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(replay): quill styling fixes and tab update for debug (#128150)

Hayne Ryu6e95027a1105
diff --git a/frontend/src/scenes/session-recordings/components/PaneTabBar.tsx b/frontend/src/scenes/session-recordings/components/PaneTabBar.tsx
index 947dd667d77d..3f83413314ab 100644
--- a/frontend/src/scenes/session-recordings/components/PaneTabBar.tsx
+++ b/frontend/src/scenes/session-recordings/components/PaneTabBar.tsx
@@ -1,7 +1,7 @@
import clsx from 'clsx'
-import { ReactNode } from 'react'
+import { Fragment, ReactNode } from 'react'
-import { Tabs, TabsList, TabsTrigger } from '@posthog/quill'
+import { Separator, Tabs, TabsList, TabsTrigger } from '@posthog/quill'
export interface PaneTab<K extends string> {
key: K
@@ -9,6 +9,7 @@ export interface PaneTab<K extends string> {
icon?: ReactNode
dataAttr: string
disabledReason?: string
+ dividerBefore?: boolean
}
export function PaneTabBar<K extends string>({
@@ -35,16 +36,18 @@ export function PaneTabBar<K extends string>({
>
<TabsList variant="line" className="w-full justify-start rounded-none bg-muted">
{tabs.map((tab) => (
- <TabsTrigger
- key={tab.key}
- value={tab.key}
- disabled={!!tab.disabledReason}
- className={clsx('text-xs', fullWidth && 'flex-auto')}
- data-attr={tab.dataAttr}
- >
- {tab.icon}
- {tab.label}
- </TabsTrigger>
+ <Fragment key={tab.key}>
+ {tab.dividerBefore && <Separator orientation="vertical" className="h-4 self-center mx-1" />}
+ <TabsTrigger
+ value={tab.key}
+ disabled={!!tab.disabledReason}
+ className={clsx('text-xs', fullWidth ? 'flex-auto' : 'flex-none')}
+ data-attr={tab.dataAttr}
+ >
+ {tab.icon}
+ {tab.label}
+ </TabsTrigger>
+ </Fragment>
))}
{!fullWidth && <div className="flex-1" />}
{children}
diff --git a/frontend/src/scenes/session-recordings/player/player-meta/PlayerMetaExperimentTags.tsx b/frontend/src/scenes/session-recordings/player/player-meta/PlayerMetaExperimentTags.tsx
index a68cf5467fa0..70c6b8595f2b 100644
--- a/frontend/src/scenes/session-recordings/player/player-meta/PlayerMetaExperimentTags.tsx
+++ b/frontend/src/scenes/session-recordings/player/player-meta/PlayerMetaExperimentTags.tsx
@@ -23,8 +23,8 @@ export function PlayerMetaExperimentTags(): JSX.Element | null {
sessionRecordingExperimentContextLogic({ sessionRecordingId: logicProps.sessionRecordingId })
)
const { setTab } = useActions(playerSidebarLogic)
- const { setSidebarOpen, toggleWatchPanelSection } = useActions(playerSettingsLogic)
- const { replayLayout, watchPanelOpenSections } = useValues(playerSettingsLogic)
+ const { setSidebarOpen, setWatchPanelTab } = useActions(playerSettingsLogic)
+ const { replayLayout } = useValues(playerSettingsLogic)
// Only surface the chip when something experiment-related happened *in this recording*.
// Enrollments without an in-session exposure event have nothing visible to watch, so they
@@ -34,11 +34,9 @@ export function PlayerMetaExperimentTags(): JSX.Element | null {
}
const openOverview = (): void => {
- // In the watch layout the overview is a disclosure under the player, and the sidebar state means Debug mode.
+ // In the watch layout the overview is a tab under the player, and the sidebar state means Debug mode.
if (playerUsesWatchLayout(replayLayout, logicProps)) {
- if (!watchPanelOpenSections.includes('overview')) {
- toggleWatchPanelSection('overview')
- }
+ setWatchPanelTab('overview')
return
}
setSidebarOpen(true)
diff --git a/frontend/src/scenes/session-recordings/player/playerSettingsLogic.ts b/frontend/src/scenes/session-recordings/player/playerSettingsLogic.ts
index 442540d77be8..c474d0098506 100644
--- a/frontend/src/scenes/session-recordings/player/playerSettingsLogic.ts
+++ b/frontend/src/scenes/session-recordings/player/playerSettingsLogic.ts
@@ -13,9 +13,25 @@ import {
} from 'scenes/session-recordings/playlist/replayLayout'
import { urls } from 'scenes/urls'
-import { AutoplayDirection, ReplayTabs, SessionRecordingSidebarStacking } from '~/types'
+import { AutoplayDirection, ReplayTabs, SessionRecordingSidebarStacking, SessionRecordingSidebarTab } from '~/types'
-export type WatchPanelSection = 'overview' | 'observations'
+export type DebugWatchPanelTab =
+ | SessionRecordingSidebarTab.INSPECTOR
+ | SessionRecordingSidebarTab.NETWORK_WATERFALL
+ | SessionRecordingSidebarTab.LINKED_ISSUES
+export type WatchPanelTab = 'overview' | 'observations' | DebugWatchPanelTab
+
+const DEBUG_WATCH_PANEL_TABS: ReadonlySet<string> = new Set([
+ SessionRecordingSidebarTab.INSPECTOR,
+ SessionRecordingSidebarTab.NETWORK_WATERFALL,
+ SessionRecordingSidebarTab.LINKED_ISSUES,
+])
+
+export function isDebugWatchPanelTab(
+ tab: SessionRecordingSidebarTab | WatchPanelTab | null
+): tab is DebugWatchPanelTab {
+ return tab !== null && DEBUG_WATCH_PANEL_TABS.has(tab)
+}
export type WatchDebugDock = 'bottom' | 'right'
export enum TimestampFormat {
@@ -59,7 +75,7 @@ export interface playerSettingsLogicValues {
userPreferenceSidebarOpen: boolean
watchDebugDock: WatchDebugDock
watchLayoutOffered: boolean
- watchPanelOpenSections: WatchPanelSection[]
+ watchPanelTab: WatchPanelTab | null
}
// Generated by kea-typegen. Update if you're an agent, ignore if you're human.
@@ -67,9 +83,6 @@ export interface playerSettingsLogicActions {
dismissDebugHint: () => {
value: true
}
- openWatchPanelSection: (section: WatchPanelSection) => {
- section: WatchPanelSection
- }
setAutoplayDirection: (autoplayDirection: AutoplayDirection) => {
autoplayDirection: AutoplayDirection
}
@@ -127,8 +140,8 @@ export interface playerSettingsLogicActions {
setWatchDebugDock: (dock: WatchDebugDock) => {
dock: WatchDebugDock
}
- toggleWatchPanelSection: (section: WatchPanelSection) => {
- section: WatchPanelSection
+ setWatchPanelTab: (tab: WatchPanelTab) => {
+ tab: WatchPanelTab
}
}
@@ -183,8 +196,7 @@ export const playerSettingsLogic = kea<playerSettingsLogicType>([
setPlayerControlsOverlay: (playerControlsOverlay: boolean) => ({ playerControlsOverlay }),
setPreferClassicReplayLayout: (preferClassicReplayLayout: boolean) => ({ preferClassicReplayLayout }),
setStaffLayoutOverride: (layout: ReplayLayout | null) => ({ layout }),
- toggleWatchPanelSection: (section: WatchPanelSection) => ({ section }),
- openWatchPanelSection: (section: WatchPanelSection) => ({ section }),
+ setWatchPanelTab: (tab: WatchPanelTab) => ({ tab }),
setWatchDebugDock: (dock: WatchDebugDock) => ({ dock }),
dismissDebugHint: true,
setLegacyDebugLinkPending: (pending: boolean) => ({ pending }),
@@ -299,15 +311,7 @@ export const playerSettingsLogic = kea<playerSettingsLogicType>([
setDebugMode: (state, { open }) => state || open,
},
],
- watchPanelOpenSections: [
- [] as WatchPanelSection[],
- { persist: true },
- {
- toggleWatchPanelSection: (state, { section }) =>
- state.includes(section) ? state.filter((s) => s !== section) : [...state, section],
- openWatchPanelSection: (state, { section }) => (state.includes(section) ? state : [...state, section]),
- },
- ],
+ watchPanelTab: [null as WatchPanelTab | null, { persist: true }, { setWatchPanelTab: (_, { tab }) => tab }],
})),
selectors({
@@ -371,7 +375,7 @@ export const playerSettingsLogic = kea<playerSettingsLogicType>([
],
}),
- listeners({
+ listeners(({ actions, values }) => ({
setSpeed: ({ speed }) => {
posthog.capture('recording player speed changed', { new_speed: speed })
},
@@ -388,7 +392,17 @@ export const playerSettingsLogic = kea<playerSettingsLogicType>([
layout: preferClassicReplayLayout ? 'classic' : 'watch',
})
},
- }),
+ setDebugMode: ({ open }) => {
+ if (open && values.watchDebugDock === 'bottom' && !isDebugWatchPanelTab(values.watchPanelTab)) {
+ actions.setWatchPanelTab(SessionRecordingSidebarTab.INSPECTOR)
+ }
+ },
+ setWatchDebugDock: ({ dock }) => {
+ if (dock === 'bottom' && values.debugMode && !isDebugWatchPanelTab(values.watchPanelTab)) {
+ actions.setWatchPanelTab(SessionRecordingSidebarTab.INSPECTOR)
+ }
+ },
+ })),
subscriptions(({ actions, values }) => ({
receivedFeatureFlags: (received: boolean) => {
diff --git a/frontend/src/scenes/session-recordings/player/watch/DebugTabBar.tsx b/frontend/src/scenes/session-recordings/player/watch/DebugTabBar.tsx
index 750de0d40061..a64877689e98 100644
--- a/frontend/src/scenes/session-recordings/player/watch/DebugTabBar.tsx
+++ b/frontend/src/scenes/session-recordings/player/watch/DebugTabBar.tsx
@@ -3,7 +3,7 @@ import { ReactNode } from 'react'
import { IconBug, IconPulse } from '@posthog/icons'
import { IconUnverifiedEvent } from 'lib/lemon-ui/icons'
-import { PaneTabBar } from 'scenes/session-recordings/components/PaneTabBar'
+import { PaneTab, PaneTabBar } from 'scenes/session-recordings/components/PaneTabBar'
import { SessionRecordingSidebarTab } from '~/types'
@@ -31,6 +31,13 @@ const DEBUG_TABS: Partial<Record<SessionRecordingSidebarTab, { label: string; ic
},
}
+export function debugPaneTabs<K extends SessionRecordingSidebarTab>(tabs: K[]): PaneTab<K>[] {
+ return tabs.flatMap((tab) => {
+ const debugTab = DEBUG_TABS[tab]
+ return debugTab ? [{ key: tab, ...debugTab }] : []
+ })
+}
+
export function DebugTabBar({
tabs,
activeTab,
@@ -42,12 +49,8 @@ export function DebugTabBar({
onChange: (tab: SessionRecordingSidebarTab) => void
children?: ReactNode
}): JSX.Element {
- const paneTabs = tabs.flatMap((tab) => {
- const debugTab = DEBUG_TABS[tab]
- return debugTab ? [{ key: tab, ...debugTab }] : []
- })
return (
- <PaneTabBar tabs={paneTabs} activeKey={activeTab} onChange={onChange}>
+ <PaneTabBar tabs={debugPaneTabs(tabs)} activeKey={activeTab} onChange={onChange}>
{children}
</PaneTabBar>
)
diff --git a/frontend/src/scenes/session-recordings/player/watch/RecordingDebugSection.tsx b/frontend/src/scenes/session-recordings/player/watch/RecordingDebugSection.tsx
deleted file mode 100644
index bb3152436595..000000000000
--- a/frontend/src/scenes/session-recordings/player/watch/RecordingDebugSection.tsx
+++ /dev/null
@@ -1,45 +0,0 @@
-import { useActions, useValues } from 'kea'
-
-import { IconSidePanel } from '@posthog/icons'
-import { Button } from '@posthog/quill'
-
-import { playerSettingsLogic } from 'scenes/session-recordings/player/playerSettingsLogic'
-import { playerSidebarLogic } from 'scenes/session-recordings/player/sidebar/playerSidebarLogic'
-import { PlayerSidebarTab } from 'scenes/session-recordings/player/sidebar/PlayerSidebarTab'
-import { useLinkedIssuesAvailable } from 'scenes/session-recordings/player/sidebar/useLinkedIssuesAvailable'
-
-import { SessionRecordingSidebarTab } from '~/types'
-
-import { DebugTabBar, debugTabKeys } from './DebugTabBar'
-
-export function RecordingDebugSection(): JSX.Element {
- const { activeTab } = useValues(playerSidebarLogic)
- const { setTab } = useActions(playerSidebarLogic)
- const { setWatchDebugDock } = useActions(playerSettingsLogic)
- const tabs = debugTabKeys(useLinkedIssuesAvailable())
- const tab = tabs.includes(activeTab) ? activeTab : SessionRecordingSidebarTab.INSPECTOR
-
- return (
- <div
- data-quill
- className="flex flex-col border border-border rounded bg-card overflow-hidden h-[calc(45cqh-1.5rem)] min-h-48"
- data-attr="watch-panel-debug"
- >
- <DebugTabBar tabs={tabs} activeTab={tab} onChange={setTab}>
- <Button
- size="icon"
- onClick={() => setWatchDebugDock('right')}
- tooltip="Dock to right"
- aria-label="Dock to right"
- className="rounded-none"
- data-attr="player-sidebar-dock-toggle"
- >
- <IconSidePanel />
- </Button>
- </DebugTabBar>
- <div className="flex flex-col flex-1 min-w-0 overflow-hidden">
- <PlayerSidebarTab tab={tab} />
- </div>
- </div>
- )
-}
diff --git a/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewDisclosure.tsx b/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewDisclosure.tsx
deleted file mode 100644
index 9a3603d4b02d..000000000000
--- a/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewDisclosure.tsx
+++ /dev/null
@@ -1,29 +0,0 @@
-import { useActions, useValues } from 'kea'
-
-import { Collapsible, CollapsibleContent, CollapsibleTrigger } from '@posthog/quill'
-
-import { playerSettingsLogic } from 'scenes/session-recordings/player/playerSettingsLogic'
-
-import { RecordingOverviewPanels } from './RecordingOverviewPanels'
-
-export function RecordingOverviewDisclosure(): JSX.Element {
- const { watchPanelOpenSections } = useValues(playerSettingsLogic)
- const { toggleWatchPanelSection } = useActions(playerSettingsLogic)
-
- return (
- <Collapsible
- data-quill
- open={watchPanelOpenSections.includes('overview')}
- onOpenChange={() => toggleWatchPanelSection('overview')}
- data-attr="watch-panel-section-overview"
- >
- <CollapsibleTrigger className="w-full">
- Overview
- <span className="grow" />
- </CollapsibleTrigger>
- <CollapsibleContent>
- <RecordingOverviewPanels />
- </CollapsibleContent>
- </Collapsible>
- )
-}
diff --git a/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx b/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx
index 1d3803def0d0..25d91eb11db2 100644
--- a/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx
+++ b/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx
@@ -22,7 +22,13 @@ export function RecordingOverviewPanels(): JSX.Element {
const { ref, size } = useResizeBreakpoints({ 0: 'narrow', [WIDE_OVERVIEW_PX]: 'wide' })
return (
<div ref={ref} data-attr="watch-panel-overview">
- {size === 'wide' ? <WideOverview /> : <PlayerSidebarOverviewTab />}
+ {size === 'wide' ? (
+ <WideOverview />
+ ) : (
+ <div data-not-quill>
+ <PlayerSidebarOverviewTab />
+ </div>
+ )}
</div>
)
}
@@ -32,7 +38,9 @@ function WideOverview(): JSX.Element {
const { snapshotAt } = useValues(playerMetaLogic(logicProps))
return (
<div data-quill className="flex flex-col gap-2 bg-background text-foreground px-2 py-2">
- <TTLWarning />
+ <div data-not-quill className="contents">
+ <TTLWarning />
+ </div>
<div className="grid grid-cols-3 gap-x-2 gap-y-1">
<OverviewColumn title="Session" dataAttr="watch-overview-session">
<PlayerSidebarOverviewSessionTab />
@@ -50,11 +58,15 @@ function WideOverview(): JSX.Element {
<span className="grow" />
</CollapsibleTrigger>
<CollapsibleContent>
- <SettingsSnapshot at={snapshotAt} scope={OVERVIEW_SNAPSHOT_SCOPE} title="" layout="grid" />
+ <div data-not-quill className="contents">
+ <SettingsSnapshot at={snapshotAt} scope={OVERVIEW_SNAPSHOT_SCOPE} title="" layout="grid" />
+ </div>
</CollapsibleContent>
</Collapsible>
- <PlayerSidebarExperimentsSection />
- <PlayerSidebarOverviewOtherWatchers />
+ <div data-not-quill className="contents">
+ <PlayerSidebarExperimentsSection />
+ <PlayerSidebarOverviewOtherWatchers />
+ </div>
</div>
)
}
@@ -70,7 +82,11 @@ function OverviewColumn({
}): JSX.Element {
// subgrid keeps the headings, top cards and row tables level across columns
return (
- <div className="grid grid-cols-1 grid-rows-subgrid row-span-3 gap-1 min-w-0" data-attr={dataAttr}>
+ <div
+ data-not-quill
+ className="grid grid-cols-1 grid-rows-subgrid row-span-3 gap-1 min-w-0"
+ data-attr={dataAttr}
+ >
<span className="text-xxs font-semibold uppercase tracking-wide text-muted-foreground px-0.5">{title}</span>
{children}
</div>
diff --git a/frontend/src/scenes/session-recordings/player/watch/WatchPanel.tsx b/frontend/src/scenes/session-recordings/player/watch/WatchPanel.tsx
index d13d76a73e7d..fe1b2fd7f391 100644
--- a/frontend/src/scenes/session-recordings/player/watch/WatchPanel.tsx
+++ b/frontend/src/scenes/session-recordings/player/watch/WatchPanel.tsx
@@ -10,10 +10,9 @@ import { visionSurfaceShown } from 'products/replay_vision/frontend/utils/vision
import { sessionRecordingPlayerLogic } from '../sessionRecordingPlayerLogic'
import { DebugModeBanner } from './DebugModeBanner'
import { RecordingCommentsList } from './RecordingCommentsList'
-import { RecordingDebugSection } from './RecordingDebugSection'
-import { RecordingObservationsSection } from './RecordingObservationsSection'
-import { RecordingOverviewDisclosure } from './RecordingOverviewDisclosure'
import { RecordingTitleBlock } from './RecordingTitleBlock'
+import { WatchPanelTabs } from './WatchPanelTabs'
+import { WatchPanelTabsWithObservations } from './WatchPanelTabsWithObservations'
export function WatchPanel({
summaryActions,
@@ -28,6 +27,7 @@ export function WatchPanel({
return null
}
const vision = visionSurfaceShown(logicProps)
+ const debugDocked = debugMode && watchDebugDock === 'bottom'
return (
<div data-quill className="flex flex-col gap-4 px-1 pt-3 pb-6 text-foreground" data-attr="watch-panel">
@@ -35,10 +35,12 @@ export function WatchPanel({
<RecordingTitleBlock
actions={vision ? <SummarizeRecordingBar inline extraActions={summaryActions} /> : summaryActions}
/>
- <RecordingOverviewDisclosure />
+ {vision && dataProcessingAccepted ? (
+ <WatchPanelTabsWithObservations sessionId={sessionRecordingId} debug={debugDocked} />
+ ) : (
+ <WatchPanelTabs debug={debugDocked} />
+ )}
<RecordingCommentsList sessionId={sessionRecordingId} />
- {debugMode && watchDebugDock === 'bottom' && <RecordingDebugSection />}
- {vision && dataProcessingAccepted && <RecordingObservationsSection sessionId={sessionRecordingId} />}
</div>
)
}
diff --git a/frontend/src/scenes/session-recordings/player/watch/WatchPanelTabs.tsx b/frontend/src/scenes/session-recordings/player/watch/WatchPanelTabs.tsx
new file mode 100644
index 000000000000..ddf3845cb21c
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/player/watch/WatchPanelTabs.tsx
@@ -0,0 +1,111 @@
+import { useActions, useValues } from 'kea'
+import { ReactNode } from 'react'
+
+import { IconSidePanel, IconSparkles } from '@posthog/icons'
+import { Badge, Button } from '@posthog/quill'
+
+import { PaneTab, PaneTabBar } from 'scenes/session-recordings/components/PaneTabBar'
+import {
+ WatchPanelTab,
+ isDebugWatchPanelTab,
+ playerSettingsLogic,
+} from 'scenes/session-recordings/player/playerSettingsLogic'
+import { playerSidebarLogic } from 'scenes/session-recordings/player/sidebar/playerSidebarLogic'
+import { PlayerSidebarTab } from 'scenes/session-recordings/player/sidebar/PlayerSidebarTab'
+import { useLinkedIssuesAvailable } from 'scenes/session-recordings/player/sidebar/useLinkedIssuesAvailable'
+
+import { debugPaneTabs, debugTabKeys } from './DebugTabBar'
+import { RecordingOverviewPanels } from './RecordingOverviewPanels'
+
+export interface ObservationsTab {
+ count: number
+ hasObservations: boolean
+ content: ReactNode
+}
+
+export function WatchPanelTabs({
+ observations,
+ debug,
+}: {
+ observations?: ObservationsTab
+ debug: boolean
+}): JSX.Element {
+ const { watchPanelTab } = useValues(playerSettingsLogic)
+ const { setWatchPanelTab, setWatchDebugDock } = useActions(playerSettingsLogic)
+ const { setTab } = useActions(playerSidebarLogic)
+ const linkedIssuesAvailable = useLinkedIssuesAvailable()
+
+ const tabs: PaneTab<WatchPanelTab>[] = [
+ { key: 'overview', label: 'Overview', dataAttr: 'watch-panel-section-overview' },
+ ...(observations
+ ? [
+ {
+ key: 'observations' as const,
+ label: (
+ <>
+ Observations
+ {observations.count > 0 && <Badge>{observations.count}</Badge>}
+ </>
+ ),
+ icon: <IconSparkles />,
+ dataAttr: 'watch-panel-section-observations',
+ },
+ ]
+ : []),
+ ...(debug
+ ? debugPaneTabs(debugTabKeys(linkedIssuesAvailable).filter(isDebugWatchPanelTab)).map((tab, index) => ({
+ ...tab,
+ dividerBefore: index === 0,
+ }))
+ : []),
+ ]
+ if (tabs.length === 1) {
+ return <RecordingOverviewPanels />
+ }
+ const tab =
+ tabs.find((candidate) => candidate.key === watchPanelTab)?.key ??
+ (observations?.hasObservations ? 'observations' : 'overview')
+
+ const select = (key: WatchPanelTab): void => {
+ setWatchPanelTab(key)
+ if (key !== 'overview' && key !== 'observations') {
+ setTab(key)
+ }
+ }
+
+ return (
+ <div
+ data-quill
+ className="flex flex-col border border-border rounded overflow-hidden"
+ data-attr="watch-panel-tabs"
+ >
+ <PaneTabBar tabs={tabs} activeKey={tab} onChange={select}>
+ {debug && (
+ <Button
+ size="icon"
+ onClick={() => setWatchDebugDock('right')}
+ tooltip="Dock to right"
+ aria-label="Dock to right"
+ className="rounded-none"
+ data-attr="player-sidebar-dock-toggle"
+ >
+ <IconSidePanel />
+ </Button>
+ )}
+ </PaneTabBar>
+ {tab === 'overview' ? (
+ <RecordingOverviewPanels />
+ ) : tab === 'observations' ? (
+ observations?.content
+ ) : (
+ <div
+ data-not-quill
+ className="flex flex-col min-w-0 overflow-hidden h-[calc(45cqh-1.5rem)] min-h-48"
+ data-attr="watch-panel-debug"
+ >
+ <PlayerSidebarTab tab={tab} />
+ </div>
+ )}
+ </div>
+ )
+}
diff --git a/frontend/src/scenes/session-recordings/player/watch/RecordingObservationsSection.tsx b/frontend/src/scenes/session-recordings/player/watch/WatchPanelTabsWithObservations.tsx
similarity index 53%
rename from frontend/src/scenes/session-recordings/player/watch/RecordingObservationsSection.tsx
rename to frontend/src/scenes/session-recordings/player/watch/WatchPanelTabsWithObservations.tsx
index de965d8760d4..0a18f6c17fa6 100644
--- a/frontend/src/scenes/session-recordings/player/watch/RecordingObservationsSection.tsx
+++ b/frontend/src/scenes/session-recordings/player/watch/WatchPanelTabsWithObservations.tsx
@@ -1,9 +1,7 @@
-import { useActions, useValues } from 'kea'
+import { useValues } from 'kea'
-import { IconSparkles } from '@posthog/icons'
-import { Badge, Collapsible, CollapsibleContent, CollapsibleTrigger, Skeleton } from '@posthog/quill'
+import { Skeleton } from '@posthog/quill'
-import { playerSettingsLogic } from 'scenes/session-recordings/player/playerSettingsLogic'
import { sessionRecordingPlayerLogic } from 'scenes/session-recordings/player/sessionRecordingPlayerLogic'
import { RecordingMoments } from 'products/replay_vision/frontend/components/RecordingMoments'
@@ -12,12 +10,17 @@ import { observationsDockLogic } from 'products/replay_vision/frontend/logics/ob
import { momentCount } from 'products/replay_vision/frontend/utils/recordingTimeline'
import { recordingScanBlock } from 'products/replay_vision/frontend/utils/scanEligibility'
-export function RecordingObservationsSection({ sessionId }: { sessionId: string }): JSX.Element {
+import { WatchPanelTabs } from './WatchPanelTabs'
+
+export function WatchPanelTabsWithObservations({
+ sessionId,
+ debug,
+}: {
+ sessionId: string
+ debug: boolean
+}): JSX.Element {
const { logicProps, sessionPlayerMetaData } = useValues(sessionRecordingPlayerLogic)
const { observations, hasLoadedObservations, timeline } = useValues(observationsDockLogic({ sessionId }))
- const { watchPanelOpenSections } = useValues(playerSettingsLogic)
- const { toggleWatchPanelSection } = useActions(playerSettingsLogic)
- const count = momentCount(timeline)
const content = !hasLoadedObservations ? (
<Skeleton className="h-24 m-2" />
@@ -34,19 +37,9 @@ export function RecordingObservationsSection({ sessionId }: { sessionId: string
)
return (
- <Collapsible
- data-quill
- open={watchPanelOpenSections.includes('observations')}
- onOpenChange={() => toggleWatchPanelSection('observations')}
- data-attr="watch-panel-section-observations"
- >
- <CollapsibleTrigger className="w-full">
- <IconSparkles />
- <span>Observations</span>
- {count > 0 && <Badge>{count}</Badge>}
- <span className="grow" />
- </CollapsibleTrigger>
- <CollapsibleContent className="p-0">{content}</CollapsibleContent>
- </Collapsible>
+ <WatchPanelTabs
+ debug={debug}
+ observations={{ count: momentCount(timeline), hasObservations: observations.length > 0, content }}
+ />
)
}
diff --git a/products/replay_vision/frontend/logics/observationsDockLogic.ts b/products/replay_vision/frontend/logics/observationsDockLogic.ts
index 39c5e33e5b3b..84ed4902ddea 100644
--- a/products/replay_vision/frontend/logics/observationsDockLogic.ts
+++ b/products/replay_vision/frontend/logics/observationsDockLogic.ts
@@ -68,14 +68,12 @@ export interface observationsDockLogicValues {
// Generated by kea-typegen. Update if you're an agent, ignore if you're human.
export interface observationsDockLogicActions {
- openWatchPanelSection: (
- section: import('scenes/session-recordings/player/playerSettingsLogic').WatchPanelSection
- ) => {
- section: import('scenes/session-recordings/player/playerSettingsLogic').WatchPanelSection
- } // playerSettingsLogic
setSidebarOpen: (open: boolean) => {
open: boolean
} // playerSettingsLogic
+ setWatchPanelTab: (tab: import('scenes/session-recordings/player/playerSettingsLogic').WatchPanelTab) => {
+ tab: import('scenes/session-recordings/player/playerSettingsLogic').WatchPanelTab
+ } // playerSettingsLogic
setAutoTab: (tab: SessionRecordingSidebarTab | null) => {
tab: SessionRecordingSidebarTab | null
} // playerSidebarLogic
@@ -198,7 +196,7 @@ export const observationsDockLogic = kea<observationsDockLogicType>([
playerSidebarLogic,
['setTab', 'setAutoTab'],
playerSettingsLogic,
- ['setSidebarOpen', 'openWatchPanelSection'],
+ ['setSidebarOpen', 'setWatchPanelTab'],
],
})),
@@ -381,7 +379,7 @@ export const observationsDockLogic = kea<observationsDockLogicType>([
}
const landOnExistingObservations = (): void => {
if (values.observations.length > 0) {
- actions.openWatchPanelSection('observations')
+ actions.setWatchPanelTab('observations')
}
if (values.observations.some((o) => isSummaryObservation(o) && o.status === 'succeeded')) {
actions.setAutoTab(SessionRecordingSidebarTab.OBSERVATIONS)
@@ -550,7 +548,7 @@ export const observationsDockLogic = kea<observationsDockLogicType>([
showObservations: ({ inWatchLayout }) => {
if (inWatchLayout) {
- actions.openWatchPanelSection('observations')
+ actions.setWatchPanelTab('observations')
return
}
actions.setSidebarOpen(true)
diff --git a/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.test.ts b/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.test.ts
index 271edf6bf51d..b898366f6661 100644
--- a/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.test.ts
+++ b/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.test.ts
@@ -174,16 +174,13 @@ describe('highlightPicksLogic', () => {
expect(shownEvents()).toEqual([])
})
- it('opens the Observations section on every pick', async () => {
+ it('selects the Observations tab on every pick', async () => {
const settings = playerSettingsLogic()
settings.mount()
for (const position of [0, 1]) {
- if (settings.values.watchPanelOpenSections.includes('observations')) {
- settings.actions.toggleWatchPanelSection('observations')
- }
- expect(settings.values.watchPanelOpenSections).not.toContain('observations')
+ settings.actions.setWatchPanelTab('overview')
logic.actions.highlightPick(logic.values.picks![position], position)
- expect(settings.values.watchPanelOpenSections).toContain('observations')
+ expect(settings.values.watchPanelTab).toBe('observations')
}
settings.unmount()
})
diff --git a/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.ts b/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.ts
index 475545b372ac..f8776f666249 100644
--- a/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.ts
+++ b/products/replay_vision/frontend/replay_scanners/highlightPicksLogic.ts
@@ -363,7 +363,7 @@ export const highlightPicksLogic: LogicWrapper<highlightPicksLogicType> = kea<hi
sessionRecordingsPlaylistLogic(props.playlistLogicProps).actions.setSelectedRecordingId(
observation.session_id
)
- playerSettingsLogic.findMounted()?.actions.openWatchPanelSection('observations')
+ playerSettingsLogic.findMounted()?.actions.setWatchPanelTab('observations')
if (!markViewed) {
return
}