:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(data-warehouse): skip error capture for user-caused view query errors (#119349)
posthog[bot]6fc9538193a7
diff --git a/products/data_warehouse/backend/presentation/views/saved_query/editing.py b/products/data_warehouse/backend/presentation/views/saved_query/editing.pyindex 7e0c72d73c3c..d82bd54bde78 100644--- a/products/data_warehouse/backend/presentation/views/saved_query/editing.py+++ b/products/data_warehouse/backend/presentation/views/saved_query/editing.py@@ -26,7 +26,7 @@ from posthog.hogql.printer import prepare_and_print_astfrom posthog.api.scoped_related_fields import TeamScopedPrimaryKeyRelatedFieldfrom posthog.api.shared import UserBasicSerializer-from posthog.errors import ExposedCHQueryError+from posthog.errors import ExposedCHQueryError, QueryErrorCategory, classify_query_errorfrom posthog.event_usage import report_user_actionfrom posthog.exceptions_capture import capture_exceptionfrom posthog.helpers.impersonation import is_impersonated@@ -68,6 +68,13 @@ def _lineage_sync_error_detail(error: Exception) -> str:return str(error) if isinstance(error, ExposedHogQLError) else GENERIC_LINEAGE_SYNC_ERROR+def _capture_unless_user_error(error: Exception) -> None:+ # Errors in the user's own SQL are not defects. Classify by error code, not by class, because+ # some user-safe ClickHouse codes, for example UNKNOWN_IDENTIFIER, are not ExposedCHQueryError.+ if classify_query_error(error) != QueryErrorCategory.USER_ERROR:+ capture_exception(error)++def _as_uuid(value: object) -> uuid.UUID | None:# Clients echo the revision back in whatever UUID form their stack produces, so parse both# sides before comparing. A raw string comparison rejects an uppercase or unhyphenated spelling@@ -370,7 +377,7 @@ class DataWarehouseSavedQuerySerializer(view.external_tables = view.get_s3_tables(database=self.context["database"])except Exception as e:- capture_exception(e)+ _capture_unless_user_error(e)logger.exception("Failed to retrieve types for view %s", view.name)raise _view_types_validation_error(e)@@ -495,7 +502,7 @@ class DataWarehouseSavedQuerySerializer(except (RecursionError, ResolutionCycleError):raise serializers.ValidationError("Model contains a cycle")except Exception as e:- capture_exception(e)+ _capture_unless_user_error(e)logger.exception("Failed to retrieve types for view %s", probe.name)raise _view_types_validation_error(e)diff --git a/products/data_warehouse/backend/tests/api/test_saved_query.py b/products/data_warehouse/backend/tests/api/test_saved_query.pyindex ff1863d11e42..515fd47bf682 100644--- a/products/data_warehouse/backend/tests/api/test_saved_query.py+++ b/products/data_warehouse/backend/tests/api/test_saved_query.py@@ -13,11 +13,15 @@ from django.test import SimpleTestCasefrom django.test.utils import CaptureQueriesContextfrom django.utils import timezone+from clickhouse_driver.errors import ServerExceptionfrom parameterized import parameterizedfrom rest_framework.parsers import JSONParserfrom rest_framework.request import Requestfrom rest_framework.test import APIRequestFactory+from posthog.hogql.errors import ExposedHogQLError++from posthog.errors import CHQueryErrorS3Error, wrap_clickhouse_query_errorfrom posthog.models import ActivityLogfrom posthog.models.scoping import team_scope@@ -38,6 +42,7 @@ from products.data_tools.backend.models.datawarehouse_saved_query_folder importfrom products.data_warehouse.backend.presentation.views.saved_query.editing import (INCREMENTAL_CONFIG_CHANGED_REFUSAL,DataWarehouseSavedQuerySerializer,+ _capture_unless_user_error,)from products.data_warehouse.backend.presentation.views.saved_query.viewset import (SavedQueryMaterializeSerializer,@@ -2735,6 +2740,24 @@ class TestSavedQueryNameValidation(SimpleTestCase):]+class TestCaptureUnlessUserError(SimpleTestCase):+ @parameterized.expand(+ [+ ("unknown_identifier", wrap_clickhouse_query_error(ServerException("Unknown identifier", code=47)), False),+ ("exposed_ch_error", wrap_clickhouse_query_error(ServerException("Bad argument", code=43)), False),+ ("exposed_hogql_error", ExposedHogQLError("Unknown table"), False),+ ("internal_ch_error", CHQueryErrorS3Error("S3 failed", code=499), True),+ ("unexpected_error", ValueError("boom"), True),+ ]+ )+ def test_captures_only_errors_the_user_did_not_cause(self, _name: str, error: Exception, captured: bool) -> None:+ with patch(+ "products.data_warehouse.backend.presentation.views.saved_query.editing.capture_exception"+ ) as mock_capture:+ _capture_unless_user_error(error)+ assert mock_capture.called is captured++class TestSavedQueryModelsNamespaceGuard(BaseTest):@parameterized.expand([