:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(tasks): keep dev-stack sandbox floors off self-driving boxes (#120940)
Alessandro Pogliaghi75bb55bdd02c
diff --git a/products/tasks/backend/logic/services/sandbox.py b/products/tasks/backend/logic/services/sandbox.pyindex 43857256ec6d..7633bdc93853 100644--- a/products/tasks/backend/logic/services/sandbox.py+++ b/products/tasks/backend/logic/services/sandbox.py@@ -278,18 +278,22 @@ class SandboxConfig(BaseModel):return self.dev_stack_presentreturn self.custom_image_name == DEV_STACK_IMAGE_NAME+ @property+ def applies_dev_stack_floors(self) -> bool:+ return self.is_dev_stack_image and self.workload == SandboxWorkload.DEFAULT+@model_validator(mode="after")def _enforce_dev_stack_memory_floor(self) -> Self:- if self.is_dev_stack_image:+ if self.applies_dev_stack_floors:self.memory_gb = max(self.memory_gb, DEV_STACK_MEMORY_GB)return self@propertydef effective_cpu_request_cores(self) -> float:"""CPU floor the provider actually reserves when burstable: the configured request,- raised to the dev-stack image floor, clamped to the limit."""+ raised to the dev-stack floor on default-workload boxes, clamped to the limit."""floor = float(self.cpu_request_cores)- if self.is_dev_stack_image:+ if self.applies_dev_stack_floors:floor = max(floor, DEV_STACK_CPU_REQUEST_CORES)return min(floor, float(self.cpu_cores))diff --git a/products/tasks/backend/logic/services/tests/test_modal_sandbox.py b/products/tasks/backend/logic/services/tests/test_modal_sandbox.pyindex 187df4340363..af4fec736ad9 100644--- a/products/tasks/backend/logic/services/tests/test_modal_sandbox.py+++ b/products/tasks/backend/logic/services/tests/test_modal_sandbox.py@@ -100,6 +100,7 @@ from products.tasks.backend.logic.services.sandbox import (ExecutionResult,SandboxConfig,SandboxTemplate,+ SandboxWorkload,health_check_timeout_seconds,)@@ -2717,6 +2718,15 @@ class TestResourceCreateKwargs:"config_kwargs, expected_cpu, expected_memory",[({"vm_runtime": True, "custom_image_name": "posthog-dev-stack"}, (2.0, 8.0), (65536, 65536)),+ (+ {+ "vm_runtime": True,+ "custom_image_name": "posthog-dev-stack",+ "workload": SandboxWorkload.SELF_DRIVING,+ },+ (0.5, 8.0),+ (16384, 16384),+ ),({"vm_runtime": True, "custom_image_name": "posthog-dev-stack", "cpu_request_cores": 6},(6.0, 8.0),