:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(data-modeling): count posthog tables as direct reads (#124383)
Thiago Salvatore81804b9cc294
diff --git a/posthog/hogql/context.py b/posthog/hogql/context.pyindex 9a2981127c59..a5c84c42b99d 100644--- a/posthog/hogql/context.py+++ b/posthog/hogql/context.py@@ -249,10 +249,11 @@ class HogQLContext:self.directly_read_ids.clear()def read_tags(self) -> dict[str, list[str] | None]:+ reads_warehouse_object = bool(self.referenced_saved_query_ids or self.referenced_warehouse_table_ids)return {"saved_query_ids": sorted(self.referenced_saved_query_ids) or None,"warehouse_table_ids": sorted(self.referenced_warehouse_table_ids) or None,- "directly_read_ids": sorted(self.directly_read_ids) or None,+ "directly_read_ids": (sorted(self.directly_read_ids) or None) if reads_warehouse_object else None,}@contextmanagerdiff --git a/posthog/hogql/resolver.py b/posthog/hogql/resolver.pyindex c7f6fa427b13..96e3620b0268 100644--- a/posthog/hogql/resolver.py+++ b/posthog/hogql/resolver.py@@ -1458,7 +1458,7 @@ class Resolver(CloningVisitor):raisedatabase_table = opaque_table- self._record_read(database_table)+ self._record_read(database_table, ".".join(table_name_chain))if self.dialect == "trino":database_table = lower_trino_table(database_table, self.context)@@ -2974,7 +2974,7 @@ class Resolver(CloningVisitor):return False- def _record_read(self, database_table: Table) -> None:+ def _record_read(self, database_table: Table, table_name: str) -> None:if isinstance(database_table, SavedQuery):self._record_saved_query_read(database_table.id, is_user_view=type(database_table) is SavedQuery)elif isinstance(database_table, S3Table) and database_table.saved_query_id is not None:@@ -2982,6 +2982,8 @@ class Resolver(CloningVisitor):elif isinstance(database_table, S3Table) and database_table.table_id is not None:self.context.referenced_warehouse_table_ids.add(database_table.table_id)self._record_direct_read(database_table.table_id)+ else:+ self._record_direct_read(table_name)def _record_saved_query_read(self, saved_query_id: str, *, is_user_view: bool) -> None:self.context.referenced_saved_query_ids.add(saved_query_id)diff --git a/products/data_modeling/backend/test/test_saved_query_tagging.py b/products/data_modeling/backend/test/test_saved_query_tagging.pyindex d86c843dc3a7..9143fef273b7 100644--- a/products/data_modeling/backend/test/test_saved_query_tagging.py+++ b/products/data_modeling/backend/test/test_saved_query_tagging.py@@ -26,6 +26,7 @@ ID_COLUMNS = {"id": {"hogql": "IntegerDatabaseField", "clickhouse": "Int64", "schema_valid": True},"distinct_id": {"hogql": "StringDatabaseField", "clickhouse": "String", "schema_valid": True},}+POSTHOG_TABLE_NAMES = {"events"}class _Captured(Exception):@@ -92,7 +93,7 @@ class TestSavedQueryTagging(APIBaseTest):)def ids(self, *names: str) -> list[str] | None:- return sorted(str(getattr(self, name).pk) for name in names) or None+ return sorted(name if name in POSTHOG_TABLE_NAMES else str(getattr(self, name).pk) for name in names) or None@contextmanagerdef captured_tags(self) -> Iterator[list[ReadTags]]:@@ -140,7 +141,21 @@ class TestSavedQueryTagging(APIBaseTest):["customers_raw"],["customer_events"],),- ("top_level_lazy_join", "SELECT events.customer.id FROM events", [], ["customers_raw"], ["customers_raw"]),+ (+ "top_level_lazy_join",+ "SELECT events.customer.id FROM events",+ [],+ ["customers_raw"],+ ["customers_raw", "events"],+ ),+ (+ "view_filters_events",+ "SELECT event FROM events WHERE distinct_id IN (SELECT distinct_id FROM demand_view)",+ ["view"],+ [],+ ["view", "events"],+ ),+ ("events_only", "SELECT event FROM events", [], [], []),("union_view", "SELECT id FROM all_ids", ["all_ids"], ["orders_raw", "customers_raw"], ["all_ids"]),("no_saved_query", "SELECT 1", [], [], []),]