:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(aio): refresh the open dataset on add and keep the button's datasets (#129970)
Carlos Marchal8193ffdc7e9d
diff --git a/products/ai_observability/frontend/datasets/SaveToDatasetButton.tsx b/products/ai_observability/frontend/datasets/SaveToDatasetButton.tsxindex b1ffab940910..e601ec966160 100644--- a/products/ai_observability/frontend/datasets/SaveToDatasetButton.tsx+++ b/products/ai_observability/frontend/datasets/SaveToDatasetButton.tsx@@ -52,7 +52,7 @@ export const SaveToDatasetButton = React.memo(function SaveToDatasetButton({const logic = saveToDatasetButtonLogic({ partialDatasetItem })const { dropdownVisible, isModalOpen, selectedDataset, isModalMounted } = useValues(logic)- const { setEditMode, setDropdownVisible, setIsModalOpen } = useActions(logic)+ const { setEditMode, setDropdownVisible, closeItemModal } = useActions(logic)return (<>@@ -93,7 +93,7 @@ export const SaveToDatasetButton = React.memo(function SaveToDatasetButton({{isModalMounted && selectedDataset && (<DatasetItemModalisOpen={isModalOpen}- onClose={() => setIsModalOpen(false)}+ onClose={closeItemModal}datasetId={selectedDataset.id}partialDatasetItem={partialDatasetItem}title={`New dataset item for ${selectedDataset.name}`}diff --git a/products/ai_observability/frontend/datasets/aiObservabilityDatasetLogic.test.ts b/products/ai_observability/frontend/datasets/aiObservabilityDatasetLogic.test.tsindex 62049623815a..7f5a64f6699d 100644--- a/products/ai_observability/frontend/datasets/aiObservabilityDatasetLogic.test.ts+++ b/products/ai_observability/frontend/datasets/aiObservabilityDatasetLogic.test.ts@@ -23,6 +23,7 @@ import {} from './aiObservabilityDatasetLogic'import { aiObservabilityDatasetsLogic } from './aiObservabilityDatasetsLogic'import { datasetsApi } from './datasetsApi'+import { saveToDatasetButtonLogic } from './saveToDatasetButtonLogic'import { EMPTY_JSON } from './utils'jest.mock('./datasetsApi', () => ({@@ -33,6 +34,7 @@ jest.mock('./datasetsApi', () => ({getItem: jest.fn(),listDatasets: jest.fn(),listItems: jest.fn(),+ createItem: jest.fn(),listItemVersions: jest.fn(),listRevisions: jest.fn(),archiveDataset: jest.fn(),@@ -135,6 +137,7 @@ describe('aiObservabilityDatasetLogic', () => {mockDatasetsApi.getDataset.mockResolvedValue(mockDataset)mockDatasetsApi.listDatasets.mockResolvedValue({ results: [], count: 0 })mockDatasetsApi.listItems.mockResolvedValue({ results: [], count: 0 })+ mockDatasetsApi.createItem.mockResolvedValue(mockDatasetItem1)mockDatasetsApi.getItem.mockImplementation(async (itemId) => {const item = [mockDatasetItem1, mockDatasetItem2].find(({ id }) => id === itemId)if (!item) {@@ -707,6 +710,41 @@ describe('aiObservabilityDatasetLogic', () => {})})+ describe('items added from the add to dataset button', () => {+ it.each([+ { via: 'pick', target: 'this', itemCreated: true, refreshes: true },+ { via: 'pick', target: 'another', itemCreated: true, refreshes: false },+ { via: 'modal', target: 'this', itemCreated: true, refreshes: true },+ { via: 'modal', target: 'this', itemCreated: false, refreshes: false },+ ])(+ 'an item saved by $via into $target dataset (created $itemCreated) refreshes the items: $refreshes',+ async ({ via, target, itemCreated, refreshes }) => {+ const targetDataset = target === 'this' ? mockDataset : { ...mockDataset, id: 'another-dataset-id' }+ mockDatasetsApi.listDatasets.mockResolvedValue({ results: [targetDataset], count: 1 })+ const logic = aiObservabilityDatasetLogic({ datasetId: mockDataset.id })+ logic.mount()+ const button = saveToDatasetButtonLogic({ partialDatasetItem: { input: { message: 'hello' } } })+ button.mount()+ await expectLogic(logic).toFinishAllListeners()+ await expectLogic(button).toFinishAllListeners()+ const listCallCount = mockDatasetsApi.listItems.mock.calls.length++ await expectLogic(button, () => {+ if (via === 'pick') {+ button.actions.setSearchFormValues({ search: '', datasetId: targetDataset.id })+ button.actions.submitSearchForm()+ } else {+ button.actions.setSelectedDataset(targetDataset)+ button.actions.closeItemModal(itemCreated)+ }+ }).toFinishAllListeners()+ await expectLogic(logic).toFinishAllListeners()++ expect(mockDatasetsApi.listItems).toHaveBeenCalledTimes(listCallCount + (refreshes ? 1 : 0))+ }+ )+ })+describe('dataset loading and defaults', () => {let logic: ReturnType<typeof aiObservabilityDatasetLogic.build>const props: DatasetLogicProps = { datasetId: 'existing-dataset-id' }@@ -722,6 +760,7 @@ describe('aiObservabilityDatasetLogic', () => {await expectLogic(logic).toFinishAllListeners()expect(mockDatasetsApi.getDataset).toHaveBeenCalledWith('existing-dataset-id')+ expect(saveToDatasetButtonLogic.isMounted()).toBe(false)})it('sets form defaults when dataset is loaded', async () => {diff --git a/products/ai_observability/frontend/datasets/saveToDatasetButtonLogic.ts b/products/ai_observability/frontend/datasets/saveToDatasetButtonLogic.tsindex 7d7aa4d15e97..d2f5af80157e 100644--- a/products/ai_observability/frontend/datasets/saveToDatasetButtonLogic.ts+++ b/products/ai_observability/frontend/datasets/saveToDatasetButtonLogic.ts@@ -9,6 +9,7 @@ import { lemonToast } from 'lib/lemon-ui/LemonToast'import { urls } from 'scenes/urls'import type { DatasetItemCreateApi, DatasetReadApi } from '../generated/api.schemas'+import { aiObservabilityDatasetLogic } from './aiObservabilityDatasetLogic'import { datasetsApi } from './datasetsApi'export interface saveToDatasetButtonLogicProps {@@ -53,6 +54,12 @@ export interface saveToDatasetButtonLogicValues {// Generated by kea-typegen. Update if you're an agent, ignore if you're human.export interface saveToDatasetButtonLogicActions {+ closeItemModal: (itemCreated?: boolean) => {+ itemCreated: boolean+ }+ datasetItemCreated: (datasetId: string) => {+ datasetId: string+ }loadDatasets: (debounce?: boolean) => booleanloadDatasetsFailure: (error: string,@@ -177,6 +184,8 @@ export const saveToDatasetButtonLogic = kea<saveToDatasetButtonLogicType>([setSelectedDataset: (dataset: DatasetReadApi | null) => ({ dataset }),setRecentDatasetIds: (recentDatasetIds: string[]) => ({ recentDatasetIds }),setRecentDatasets: (recentDatasets: DatasetReadApi[]) => ({ recentDatasets }),+ closeItemModal: (itemCreated: boolean = false) => ({ itemCreated }),+ datasetItemCreated: (datasetId: string) => ({ datasetId }),}),reducers(() => ({@@ -324,6 +333,7 @@ export const saveToDatasetButtonLogic = kea<saveToDatasetButtonLogicType>([source_event_id: props.partialDatasetItem?.source_event_id,source_timestamp: props.partialDatasetItem?.source_timestamp,})+ actions.datasetItemCreated(datasetId)lemonToast.success('Dataset item has been created successfully', {button: {label: 'View',@@ -373,6 +383,17 @@ export const saveToDatasetButtonLogic = kea<saveToDatasetButtonLogicType>([actions.setSearchFormValue('search', '')},+ closeItemModal: ({ itemCreated }) => {+ actions.setIsModalOpen(false)+ if (itemCreated && values.selectedDataset) {+ actions.datasetItemCreated(values.selectedDataset.id)+ }+ },++ datasetItemCreated: ({ datasetId }) => {+ aiObservabilityDatasetLogic.findMounted({ datasetId })?.actions.refreshAfterDatasetItemMutation()+ },+setSearchFormValue: ({ name, value }) => {if (compareFieldName(name, 'search')) {asyncActions.loadDatasets(true)diff --git a/products/ai_observability/frontend/redesign/trace/adapter/TraceViewContainer.tsx b/products/ai_observability/frontend/redesign/trace/adapter/TraceViewContainer.tsxindex 9c8e1333b31d..02e246fafbf0 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/TraceViewContainer.tsx+++ b/products/ai_observability/frontend/redesign/trace/adapter/TraceViewContainer.tsx@@ -1,7 +1,8 @@import { useActions, useMountedLogic, useValues } from 'kea'-import { memo } from 'react'+import { memo, useEffect } from 'react'import { SaveToDatasetButton } from '../../../datasets/SaveToDatasetButton'+import { saveToDatasetButtonLogic } from '../../../datasets/saveToDatasetButtonLogic'import { TraceView, TraceViewProps, TraceViewReadyProps } from '../components/TraceView'import { traceExportLogic } from '../traceExportLogic'import { traceMessagesOpeningLogic } from '../traceMessagesOpeningLogic'@@ -199,6 +200,7 @@ export const TraceViewContainer = memo(function TraceViewContainer({detailData,detailTab,datasetItemSource,+ datasetsEnabled,canViewInThread,thread,timeline,@@ -228,6 +230,9 @@ export const TraceViewContainer = memo(function TraceViewContainer({useValues(reviewLogic)const { loadReviewStatus, removeFromQueue } = useActions(reviewLogic)useMountedLogic(traceReviewBridgeLogic({ traceId }))+ // The dataset button unmounts while a step loads. Its logic has no key, so it would refetch datasets and recents+ // on every remount without this mount.+ useEffect(() => (datasetsEnabled ? saveToDatasetButtonLogic.mount() : undefined), [datasetsEnabled])const { messagesOpening } = useValues(traceMessagesOpeningLogic)const { setMessagesOpening } = useActions(traceMessagesOpeningLogic)diff --git a/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsx b/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsxindex 46743ddfd609..2a655f8d49ff 100644--- a/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsx+++ b/products/ai_observability/frontend/redesign/trace/adapter/traceSceneWiring.test.tsx@@ -15,6 +15,7 @@ import { initKeaTests } from '~/test/init'import { AccessControlLevel, AccessControlResourceType } from '~/types'import { aiObservabilityTraceLogic } from '../../../aiObservabilityTraceLogic'+import { saveToDatasetButtonLogic } from '../../../datasets/saveToDatasetButtonLogic'import type { TraceClusterApi } from '../../../generated/api.schemas'import { traceReviewLogic } from '../traceReviewLogic'import { TraceScene } from '../TraceScene'@@ -72,6 +73,7 @@ const askedGeneration = makeNodeDetail({})const nodeDetails: Record<string, typeof answeredGeneration> = { 'gen-1': askedGeneration, 'gen-2': answeredGeneration }let nodeRequests: string[] = []+let datasetListRequests = 0const nodeMock = {[NODE_URL]: ({ params }: { params: Record<string, unknown> }) => {const nodeId = decodeIdSegment(String(params.node_id))@@ -122,6 +124,7 @@ function renderNewView(flags)nodeRequests = []+ datasetListRequests = 0jest.mocked(performQuery).mockReset()jest.mocked(performQuery).mockResolvedValue({ results: [] })aiObservabilityTraceLogic.mount()@@ -148,7 +151,10 @@ describe('TraceScene', () => {useMocks({get: {[TRACE_URL]: () => [200, makeTraceResource({ defaultNodeId: 'gen-2' })],- [DATASETS_URL]: () => [200, { count: 0, results: [] }],+ [DATASETS_URL]: () => {+ datasetListRequests+++ return [200, { count: 0, results: [] }]+ },[SEARCH_URL]: () => [200, { total: 1, matches: [{ nodeId: 'gen-1', count: 1 }] }],...nodeMock,...evaluationsMock,@@ -490,6 +496,21 @@ describe('TraceScene', () => {expect(await findByText('Two seats were added.')).toBeTruthy()expect(queryByText('Add to dataset') !== null).toBe(enabled)+ expect(datasetListRequests > 0).toBe(enabled)+ })++ it('keeps the dataset list loaded while an unread step loads', async () => {+ const { findByText } = renderNewView({ [DATASETS_FLAG]: true })+ await findByText('Add to dataset')+ await waitFor(() => expect(datasetListRequests).toBeGreaterThan(0))+ const requestsBeforeStep = datasetListRequests++ fireEvent.click(await findByText('span-1'))+ await waitFor(() => expect(nodeRequests).toContain('span-1'))+ await findByText('Add to dataset')+ await expectLogic(saveToDatasetButtonLogic).toFinishAllListeners()++ expect(datasetListRequests).toBe(requestsBeforeStep)})it.each([diff --git a/products/ai_observability/frontend/redesign/trace/traceViewModelLogic.ts b/products/ai_observability/frontend/redesign/trace/traceViewModelLogic.tsindex a9b74479bb97..cb1579ee35f3 100644--- a/products/ai_observability/frontend/redesign/trace/traceViewModelLogic.ts+++ b/products/ai_observability/frontend/redesign/trace/traceViewModelLogic.ts@@ -111,6 +111,7 @@ export interface traceViewModelLogicValues {canViewInThread: booleanclustersChip: TraceClustersChipProps | nulldatasetItemSource: ReturnType<typeof toDatasetItemSource>+ datasetsEnabled: booleandetailData: NodeDetailData | nullevalOutcomesByNode: Record<string, EvalRollupOutcome>evalsChip: EvalsChipData | null@@ -262,8 +263,9 @@ export interface traceViewModelLogicMeta {createdAt: string | null,sessionId: string | null) => NodeDetailData | null+ datasetsEnabled: (featureFlags: FeatureFlagsSet) => booleandatasetItemSource: (- featureFlags: FeatureFlagsSet,+ datasetsEnabled: boolean,selectedNodeLoad: NodeLoad,createdAt: string | null,traceId: string@@ -505,17 +507,19 @@ export const traceViewModelLogic = kea<traceViewModelLogicType>([}): null,],+ datasetsEnabled: [+ (s) => [s.featureFlags],+ (featureFlags: FeatureFlagsSet): boolean => !!featureFlags[FEATURE_FLAGS.LLM_ANALYTICS_DATASETS],+ ],datasetItemSource: [- (s, p) => [s.featureFlags, s.selectedNodeLoad, s.createdAt, p.traceId],+ (s, p) => [s.datasetsEnabled, s.selectedNodeLoad, s.createdAt, p.traceId],(- featureFlags: FeatureFlagsSet,+ datasetsEnabled: boolean,load: NodeLoad,createdAt: string | null,traceId: string): ReturnType<typeof toDatasetItemSource> =>- featureFlags[FEATURE_FLAGS.LLM_ANALYTICS_DATASETS] && createdAt- ? toDatasetItemSource({ traceId, createdAt, load })- : null,+ datasetsEnabled && createdAt ? toDatasetItemSource({ traceId, createdAt, load }) : null,],thread: [(s, p) => [s.status, s.threadNodeLoad, s.createdAt, s.currentTeamId, p.traceId],