Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(data-modeling): collapse columns by default on node detail query tab (#119531)

Jovan Sakovic8368b65652d5
diff --git a/frontend/snapshots.yml b/frontend/snapshots.yml
index 3ee41255fbef..84cf1d44c5e9 100644
--- a/frontend/snapshots.yml
+++ b/frontend/snapshots.yml
@@ -7311,25 +7311,25 @@ snapshots:
products-data-modeling-node-detail-scene--deleted-model--light:
hash: v1.k794b7964.d1862e22a973b0fb2725b4b6d613eb0ddbe2074d54d20b4dbb85eb5193a994b6.0uti-ZtW-QCeFNNJ3XmHjC7NRpp3dO35TR3L3v9_Zw0
products-data-modeling-node-detail-scene--materialized-view--dark:
- hash: v1.k794b7964.9c8663e101f08c4bd2578b787402053a1bd7e930f06fad0ee6f5f1d728b0b14c.hV26Y05ssUiKJQPOBYVX6EXXkVSkd9rCOQvnA3PRPBY
+ hash: v1.k794b7964.58a8839d5c900eaed0b737649081b40539b0e7940baf571534b83e5f506c7061.Uf_yvFlyMvL0fxzPy6y9r5-utRl9LowGOko9v-ARNBY
products-data-modeling-node-detail-scene--materialized-view--light:
- hash: v1.k794b7964.1bd5ef93e5abb60990433d0f591b143ef4bce9e249cd5bb90c1c8aeecc09c8d5.yh3XKuwM5JDKsZjGtBV_ukV-upgf9x0J64yV6hCwC8E
+ hash: v1.k794b7964.82adf6bc8d2bd6e60134097e96040905a2a91c3e0d7b6a0fbcfa1cee34f547ff.2drU1_bHNGTIaek7WA83B5wfJtrn727wYIuF4CrtmPY
products-data-modeling-node-detail-scene--narrow-materialized-view--dark:
- hash: v1.k794b7964.d434bef909772810035f7365e0708f55638dbd6b9b067f8103ae5fc44bdeee86.B6D2vcrTN4lAr9wyJhdppEe8pxfhv5BBdg-yMIKOGCs
+ hash: v1.k794b7964.08d1d1b194143eed6ceab6782f5818e78071c4792f52745b2fdfc194b95a21ab.Mgs5G6P9Ycgk7xnl_2IaPXWcYuDY0BhbD9rAHfaxp10
products-data-modeling-node-detail-scene--narrow-materialized-view--light:
- hash: v1.k794b7964.3dd7a8488d960144bef5a3cd7473c9337bd4881ed62e5f4559b66f22b52610e6.e_43r1kxIPrLb6ZQA6oQHHh23lYQrIfOqTwMJwKfIWE
+ hash: v1.k794b7964.41f98a6954b927063854d9815cdaf89ce84a0fb1ffac1e7a55a16b0412d69fdb.Uv3S7f1GiyV_k6iRMBBQLuHmJr9C-Jr4XDwIYb4KQgM
products-data-modeling-node-detail-scene--narrow-suspended-with-run-history--dark:
hash: v1.k794b7964.61e9fdf103d31a89474fce6c238e7daf727a23734c93113d0ce6beda8bd6bde8.5xne6j1ft6cwHmCVvkk8XTwAJvjmbjYu0H_viJzPrws
products-data-modeling-node-detail-scene--narrow-suspended-with-run-history--light:
hash: v1.k794b7964.bb01b3a50bc5b002f1cf7c9cbd6dc8ddca449d37abbdc6750623d2873630879e.AsQNacWMvT8ZkkMBKJH0Ux0tO2oE_Afzh9Y-qdCzTqc
products-data-modeling-node-detail-scene--narrow-view--dark:
- hash: v1.k794b7964.9110aa72356c45ec91a7ac3ac712904e28cf6b51a2b4ae6b032d60b524327427.6x6APOu5hbFc9JZVJBA1YQNgrxqszt3X2PfHorWYzrw
+ hash: v1.k794b7964.25a34e60b9c8a2f742c3357b7de9582b729e83f6495ca01440e7594d54e5051b.y0d9tum0sniHvMHHe-tQNen40sNqpnCRYyuIJnJZyHY
products-data-modeling-node-detail-scene--narrow-view--light:
- hash: v1.k794b7964.42808291c239b90849edc8df8dfc10a69b0d73974de964412492325fdca5cb01.YfMvngDzfur4xRvb7O6msDlyuLsJkv7gcunSWAhNG5g
+ hash: v1.k794b7964.e336da3925495efba09641d7d55ae60447f25e34db60de4964935eb25b313586.08WjFpLXY0-1D76DZvm8-rxnZm44FU02rO39X8CGwHw
products-data-modeling-node-detail-scene--paginated-columns--dark:
- hash: v1.k794b7964.5c623bdf59901765f55de0d7a1164d11feefa003292f7c0fc37a8bdcf778d3d2.UhfAB2qZz0EGEphjIL9GwkuEiuovUfT31-Ow5_gn2b8
+ hash: v1.k794b7964.8ba9125eab82549cf3c968b011c30a507a2fe3bf2a651d3bff25e30cb4fb8fa6.PrjNUSmyms9gik_jkQPbO_0O-_MfNi8SJtv4Jr4nfjE
products-data-modeling-node-detail-scene--paginated-columns--light:
- hash: v1.k794b7964.b119e3e790d76d28ef0b53b7a7116717a4c2660347e23054a47922696c799548.YmPMhBqGr7MBKRXPb815ZXpqZp1V17KRg4PPq33hd5I
+ hash: v1.k794b7964.f61eaae027db3d08cb3c2121418110bfd75fdb60f4428e218a47b4d8f26cce33.ataBThPgwZ7aakJY6XgnmagVcYt1ddzqdXp2pQrSvK0
products-data-modeling-node-detail-scene--post-hog-table--dark:
hash: v1.k794b7964.4c6319ac95438cae6bdb4708f9e5df00ae41cdd530f5a6b627c874b539c370d2._qHdJB0ZxCNXW61GVlt-oRucyXgt-_H-hKbJ3pdoFik
products-data-modeling-node-detail-scene--post-hog-table--light:
@@ -7339,9 +7339,9 @@ snapshots:
products-data-modeling-node-detail-scene--suspended-with-run-history--light:
hash: v1.k794b7964.8e3a299698deffd2d09cc49fcef1f040cf40d0ec3be8fddf52ca34551c8f7e0a.uq9M5UbnFlUTEOem2aXKGYcYItgfYjMxhBk7AG-UvyQ
products-data-modeling-node-detail-scene--view--dark:
- hash: v1.k794b7964.c3a0122ed3c944fd0036bf07405b2e09e14f7f218660863779a3587da606f3aa.HS-n7WOMbDZm10kaWIku0Y01udvSaEeEdFoDzUBLlrk
+ hash: v1.k794b7964.0aedbf7d575d33462e900758b5d7cd5a599542e982d157d998f198378863d28b.YRWr1jgXH75zwmMShTj6HaBQsaDWW_NraXqBq3h_G2k
products-data-modeling-node-detail-scene--view--light:
- hash: v1.k794b7964.36643c2fa6800cf361c623fca665343f8b4a2708afd3cd46ed9abb19cfd1db5f.mqGLSD5Sce2yBSvIXIS7PajSjOdXlLIoEjGEK4iwYEc
+ hash: v1.k794b7964.c5a6103b866e7ec5ffcc146f472a56a6ebac67de9fd4d383d883fdf5c013a9be.kcTlP88yxKcpwp_WBpM0v9WdPSbECiQszcpexP9ni5g
products-data-modeling-node-detail-scene--warehouse-table--dark:
hash: v1.k794b7964.1cd6cfb29f1510ee23c7bd3c54e8fd139f64e2c62796c85f2159f104562f56ab.8NkVqssgmL3BJGQBcZdXzZ_iGrYklaxHo_JUtIkinWQ
products-data-modeling-node-detail-scene--warehouse-table--light:
diff --git a/products/data_modeling/frontend/nodeDetail/NodeDetailQuery.tsx b/products/data_modeling/frontend/nodeDetail/NodeDetailQuery.tsx
index e87462c8287b..8ce2e3e63605 100644
--- a/products/data_modeling/frontend/nodeDetail/NodeDetailQuery.tsx
+++ b/products/data_modeling/frontend/nodeDetail/NodeDetailQuery.tsx
@@ -1,6 +1,6 @@
import { useActions, useValues } from 'kea'
-import { LemonBanner, LemonSkeleton, LemonTable } from '@posthog/lemon-ui'
+import { LemonBanner, LemonCollapse, LemonSkeleton, LemonTable } from '@posthog/lemon-ui'
import { CodeSnippet, Language } from 'lib/components/CodeSnippet'
@@ -33,7 +33,8 @@ export function NodeDetailQuery({ id }: { id: string }): JSX.Element {
{queryString ? (
<CodeSnippet
language={Language.SQL}
- className="[&_pre]:max-h-96 [&_pre]:overflow-auto"
+ // Scales with the viewport so the query gets the space the collapsed columns free up.
+ className="[&_pre]:max-h-[70vh] [&_pre]:overflow-auto"
thing="query"
>
{queryString}
@@ -43,32 +44,41 @@ export function NodeDetailQuery({ id }: { id: string }): JSX.Element {
)}
</div>
- <div className="flex flex-col gap-2">
- <h3 className="mb-0">Columns</h3>
- <LemonTable
- size="small"
- key={id}
- pagination={{ pageSize: 10, useUrl: false }}
- dataSource={columns}
- rowKey="name"
- nouns={['column', 'columns']}
- emptyState="Columns appear after the view runs."
- columns={[
- {
- title: 'Name',
- key: 'name',
- render: (_, column: DatabaseSchemaField) => (
- <span className="font-mono">{column.name}</span>
- ),
- },
- {
- title: 'Type',
- key: 'type',
- render: (_, column: DatabaseSchemaField) => column.type,
- },
- ]}
- />
- </div>
+ <LemonCollapse
+ key={id}
+ size="small"
+ panels={[
+ {
+ key: 'columns',
+ header: `Columns (${columns.length})`,
+ dataAttr: 'node-detail-query-columns',
+ content: (
+ <LemonTable
+ size="small"
+ pagination={{ pageSize: 10, useUrl: false }}
+ dataSource={columns}
+ rowKey="name"
+ nouns={['column', 'columns']}
+ emptyState="Columns appear after the view runs."
+ columns={[
+ {
+ title: 'Name',
+ key: 'name',
+ render: (_, column: DatabaseSchemaField) => (
+ <span className="font-mono">{column.name}</span>
+ ),
+ },
+ {
+ title: 'Type',
+ key: 'type',
+ render: (_, column: DatabaseSchemaField) => column.type,
+ },
+ ]}
+ />
+ ),
+ },
+ ]}
+ />
</div>
)
}
diff --git a/products/data_modeling/frontend/nodeDetail/NodeDetailScene.stories.tsx b/products/data_modeling/frontend/nodeDetail/NodeDetailScene.stories.tsx
index c8bd3bb3940c..61e8d3264a61 100644
--- a/products/data_modeling/frontend/nodeDetail/NodeDetailScene.stories.tsx
+++ b/products/data_modeling/frontend/nodeDetail/NodeDetailScene.stories.tsx
@@ -259,6 +259,9 @@ export const NarrowView: Story = {
}
export const PaginatedColumns: Story = {
+ play: async ({ canvas, userEvent }): Promise<void> => {
+ await userEvent.click(await canvas.findByRole('button', { name: /^Columns/ }))
+ },
parameters: {
msw: {
mocks: {
diff --git a/products/data_modeling/frontend/nodeDetail/nodeDetailSceneLogic.test.ts b/products/data_modeling/frontend/nodeDetail/nodeDetailSceneLogic.test.ts
index 0be001352d49..f8df03b13713 100644
--- a/products/data_modeling/frontend/nodeDetail/nodeDetailSceneLogic.test.ts
+++ b/products/data_modeling/frontend/nodeDetail/nodeDetailSceneLogic.test.ts
@@ -342,6 +342,10 @@ describe('nodeDetailSceneLogic', () => {
render(createElement(NodeDetailQuery, { id: NODE_ID }))
+ // The columns panel is collapsed by default.
+ expect(screen.queryByText('column_1')).toBeNull()
+ fireEvent.click(screen.getByText('Columns (11)'))
+
expect(screen.getByText('column_10')).toBeTruthy()
expect(screen.queryByText('column_11')).toBeNull()
expect(screen.getByText('1-10 of 11 columns')).toBeTruthy()