Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(access-control): check warehouse tables and manage access by ref (#125306)

Yasen86d40ded67e8
diff --git a/products/access_control/backend/facade/contracts.py b/products/access_control/backend/facade/contracts.py
index ac01d5d2bc39..f8a4e53adf72 100644
--- a/products/access_control/backend/facade/contracts.py
+++ b/products/access_control/backend/facade/contracts.py
@@ -67,20 +67,30 @@ class PropertyAccessControlState:
# --- Input DTOs ---
+@frozen
+class FallbackParent:
+ """The parent a reference falls back to. `resource` must match `RESOURCE_FALLBACK_MAP`; `id=None` means no parent."""
+
+ resource: APIScopeObject
+ id: str | None
+
+
@frozen
class ObjectAccessRef:
"""The fields object-level access control reads from one object, without the model.
A view that serves a facade contract passes this to `check_object_permissions` in place of a
- model instance. Resolution needs only the resource, the object id, and the creator. A resource
- that inherits access from a parent object through a foreign key (`RESOURCE_FALLBACK_MAP`)
- cannot be resolved from a reference, so the check raises for it.
+ model instance. Resolution needs the resource, the object id, and the creator. A resource that
+ inherits access from a parent object through a foreign key (`RESOURCE_FALLBACK_MAP`) also needs
+ `fallback_parent`, read off that foreign key. Without it the check raises, because resolution
+ would skip the parent's rules.
"""
resource: APIScopeObject
id: str
team_id: int
created_by_id: int | None
+ fallback_parent: FallbackParent | None = None
@frozen
diff --git a/products/access_control/backend/facade/user_access_control.py b/products/access_control/backend/facade/user_access_control.py
index f43a14d29ad9..bf089f18699d 100644
--- a/products/access_control/backend/facade/user_access_control.py
+++ b/products/access_control/backend/facade/user_access_control.py
@@ -1041,6 +1041,17 @@ class UserAccessControl:
return project_admin_check
+ def check_can_modify_access_levels_for_ref(self, ref: ObjectAccessRef) -> bool:
+ """`check_can_modify_access_levels_for_object` for an object held only as a reference."""
+ self._target_for_ref(ref) # validates the team and parent before the creator shortcut
+ if ref.resource == "project":
+ return self.check_can_modify_access_levels_for_object(cast(Team, self._team))
+ return (
+ self._is_creator_id(ref.created_by_id)
+ or self.check_access_level_for_object(cast(Team, self._team), required_level="admin", explicit=True)
+ or self.check_access_level_for_ref(ref, required_level="manager", explicit=True)
+ )
+
def get_access_source_for_object(
self, obj: Model, resource: Optional[APIScopeObject] = None
) -> Optional[AccessSource]:
@@ -1806,13 +1817,18 @@ class UserAccessControl:
def _target_for_ref(self, ref: ObjectAccessRef) -> _ObjectAccessTarget:
parent = RESOURCE_FALLBACK_MAP.get(ref.resource)
- if parent:
- # The parent id comes from the model's foreign key, which a reference does not carry.
- # Resolution without it skips the parent's rules, so it can return the wrong level.
+ if parent and ref.fallback_parent is None:
+ # The parent id comes from the model's foreign key. Resolution without it skips the
+ # parent's rules, so it can return the wrong level.
raise ValueError(
- f"An ObjectAccessRef cannot resolve `{ref.resource}`, which inherits access from "
- f"`{parent}`. Check access on the model instance instead."
+ f"An ObjectAccessRef for `{ref.resource}`, which inherits access from `{parent}`, needs "
+ "`fallback_parent`. Set it, or check access on the model instance instead."
)
+ if not parent and ref.fallback_parent is not None:
+ raise ValueError(f"`{ref.resource}` has no fallback parent, so `fallback_parent` must stay unset.")
+ # A stated type keeps a changed map from reading the parent id as another type's id.
+ if parent and ref.fallback_parent is not None and ref.fallback_parent.resource != parent:
+ raise ValueError(f"`{ref.resource}` falls back to `{parent}`, not `{ref.fallback_parent.resource}`.")
# The rule lookups are scoped to self._team, so a reference checked without a team, or against
# another team, would resolve against the wrong rules.
if self._team is None:
@@ -1823,7 +1839,7 @@ class UserAccessControl:
resource=ref.resource,
object_id=ref.id,
created_by_id=ref.created_by_id,
- fallback_parent_id=None,
+ fallback_parent_id=ref.fallback_parent.id if ref.fallback_parent else None,
)
def _resolved_access_for_target(
@@ -1880,9 +1896,11 @@ class UserAccessControl:
"""`get_user_access_level` for an object the caller holds only as a reference."""
return self._access_level_for_target(self._target_for_ref(ref), explicit=explicit)
- def check_access_level_for_ref(self, ref: ObjectAccessRef, required_level: AccessControlLevel) -> bool:
+ def check_access_level_for_ref(
+ self, ref: ObjectAccessRef, required_level: AccessControlLevel, explicit: bool = False
+ ) -> bool:
"""`check_access_level_for_object` for an object the caller holds only as a reference."""
- access_level = self.access_level_for_ref(ref)
+ access_level = self.access_level_for_ref(ref, explicit=explicit)
if not access_level:
return False
return access_level_satisfied_for_resource(ref.resource, access_level, required_level)
diff --git a/products/access_control/backend/tests/test_user_access_control.py b/products/access_control/backend/tests/test_user_access_control.py
index a28e743298cc..e3d5695d39e4 100644
--- a/products/access_control/backend/tests/test_user_access_control.py
+++ b/products/access_control/backend/tests/test_user_access_control.py
@@ -11,7 +11,7 @@ from posthog.models.organization import Organization, OrganizationMembership
from posthog.models.team.team import Team
from posthog.models.user import User
-from products.access_control.backend.facade.contracts import ObjectAccessRef
+from products.access_control.backend.facade.contracts import FallbackParent, ObjectAccessRef
from products.access_control.backend.facade.subject_access_control import SubjectAccessControl
from products.access_control.backend.facade.user_access_control import (
RESOURCE_INHERITANCE_MAP,
@@ -2224,6 +2224,23 @@ class TestUserAccessControlFallbackParent(BaseUserAccessControlTest):
)
self._clear_uac_caches()
+ @parameterized.expand([("sourced_table", True, "none"), ("self_managed_table", False, "editor")])
+ def test_ref_with_fallback_parent_resolves_like_the_model(self, _name, sourced, expected):
+ table = self.sourced_table if sourced else self.self_managed_table
+ self._apply({"this_source": "none"}, table)
+ ref = ObjectAccessRef(
+ resource="warehouse_table",
+ id=str(table.id),
+ team_id=self.team.id,
+ created_by_id=None,
+ fallback_parent=FallbackParent(
+ resource="external_data_source", id=str(self.source.id) if sourced else None
+ ),
+ )
+
+ assert self.user_access_control.access_level_for_ref(ref) == expected
+ assert self.user_access_control.get_user_access_level(table) == expected
+
def _level(self, table):
return self.user_access_control.get_user_access_level(table)
@@ -2488,6 +2505,7 @@ class TestObjectAccessRefMatchesModel(BaseUserAccessControlTest):
("org_admin", "manager"),
("object_default_none", "none"),
("object_member_viewer", "viewer"),
+ ("object_member_manager", "manager"),
("resource_viewer", "viewer"),
]
]
@@ -2502,11 +2520,11 @@ class TestObjectAccessRefMatchesModel(BaseUserAccessControlTest):
self.organization_membership.save()
elif scenario == "object_default_none":
self._create_access_control(resource="dashboard", resource_id=str(self.dashboard.id), access_level="none")
- elif scenario == "object_member_viewer":
+ elif scenario in ("object_member_viewer", "object_member_manager"):
self._create_access_control(
resource="dashboard",
resource_id=str(self.dashboard.id),
- access_level="viewer",
+ access_level=expected,
organization_member=self.organization_membership,
)
elif scenario == "resource_viewer":
@@ -2520,6 +2538,9 @@ class TestObjectAccessRefMatchesModel(BaseUserAccessControlTest):
assert self.user_access_control.check_access_level_for_ref(
ref, required
) == self.user_access_control.check_access_level_for_object(self.dashboard, required)
+ assert self.user_access_control.check_can_modify_access_levels_for_ref(
+ ref
+ ) == self.user_access_control.check_can_modify_access_levels_for_object(self.dashboard)
@parameterized.expand([("legacy", False), ("most_specific", True)])
def test_project_level_none_matches_the_team(self, _name, most_specific):
@@ -2531,11 +2552,33 @@ class TestObjectAccessRefMatchesModel(BaseUserAccessControlTest):
assert self.user_access_control.get_user_access_level(self.team) == "none"
assert self.user_access_control.access_level_for_ref(ref) == "none"
assert self.user_access_control.check_access_level_for_ref(ref, "member") is False
+ assert self.user_access_control.check_can_modify_access_levels_for_ref(
+ ref
+ ) == self.user_access_control.check_can_modify_access_levels_for_object(self.team)
- def test_ref_for_fallback_resource_raises(self):
- ref = ObjectAccessRef(resource="warehouse_table", id="1", team_id=self.team.id, created_by_id=None)
+ @parameterized.expand(
+ [
+ ("fallback_resource_without_parent", "warehouse_table", None, "external_data_source"),
+ (
+ "parent_on_resource_without_fallback",
+ "dashboard",
+ FallbackParent(resource="dashboard", id="1"),
+ "no fallback parent",
+ ),
+ (
+ "parent_of_another_type",
+ "warehouse_table",
+ FallbackParent(resource="warehouse_objects", id="1"),
+ "falls back to `external_data_source`",
+ ),
+ ]
+ )
+ def test_ref_with_wrong_fallback_parent_raises(self, _name, resource, fallback_parent, match):
+ ref = ObjectAccessRef(
+ resource=resource, id="1", team_id=self.team.id, created_by_id=None, fallback_parent=fallback_parent
+ )
- with pytest.raises(ValueError, match="external_data_source"):
+ with pytest.raises(ValueError, match=match):
self.user_access_control.access_level_for_ref(ref)
@parameterized.expand([("another_team", True), ("no_team", False)])