:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(data-warehouse): stop reporting bing webmaster tools IP throttling as an error (#123578)
Tom Owers88342c017fc1
diff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/source.py b/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/source.pyindex 6df936af2973..0d22ee75edce 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/source.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/source.py@@ -63,10 +63,12 @@ class BingWebmasterToolsSource(SimpleSource[BingWebmasterToolsSourceConfig]):def get_retryable_errors(self) -> set[str]:return {- # Bing's rate-limit fault, raised as `BingWebmasterToolsError` by `_request_payload`.- # The key is per API user rather than per request, so a Temporal retry with backoff- # normally clears it once the window rolls over; it must not page as a bug.+ # Bing's rate-limit faults, raised as `BingWebmasterToolsError` by `_request_payload`.+ # ThrottleUser scopes the limit to the API key, ThrottleIP to the caller's egress+ # address; either clears once its window rolls over, so a Temporal retry with backoff+ # normally resolves it and it must not page as a bug."ERROR!!! ThrottleUser",+ "ERROR!!! ThrottleIP",}def get_canonical_descriptions(self) -> CanonicalDescriptions:diff --git a/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/tests/test_bing_webmaster_tools_source.py b/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/tests/test_bing_webmaster_tools_source.pyindex 3a063ad1d3fb..1e0badb4717e 100644--- a/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/tests/test_bing_webmaster_tools_source.py+++ b/products/warehouse_sources/backend/temporal/data_imports/sources/bing_webmaster_tools/tests/test_bing_webmaster_tools_source.py@@ -43,10 +43,11 @@ class TestBingWebmasterToolsSource:# Static endpoint catalog with no I/O; must opt in so public docs render the table list.assert self.source.lists_tables_without_credentials is True- def test_throttle_fault_is_retryable_not_disabling(self):+ @pytest.mark.parametrize("fault", ["ThrottleUser", "ThrottleIP"])+ def test_throttle_fault_is_retryable_not_disabling(self, fault):# A rate-limit fault must keep Temporal retrying the activity (it is not a permanent# account/credential problem) and must stay out of error tracking as noise.- error_message = "Bing Webmaster Tools GetUserSites failed with status 400: ERROR!!! ThrottleUser"+ error_message = f"Bing Webmaster Tools GetUserSites failed with status 400: ERROR!!! {fault}"assert error_message_matches(error_message, self.source.get_retryable_errors())assert not error_message_matches(error_message, self.source.get_non_retryable_errors())