:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(signals): override the anomaly scoring payload per deployment (#127028)
posthog[bot]8d1791c18faf
diff --git a/products/signals/backend/anomaly_scores/config.py b/products/signals/backend/anomaly_scores/config.pyindex 538f7d6bc2ea..3d8b1b961de4 100644--- a/products/signals/backend/anomaly_scores/config.py+++ b/products/signals/backend/anomaly_scores/config.py@@ -3,6 +3,8 @@The payload parse fails closed: a missing, malformed or unreadable payload turns the tick off. An invalidfield falls back to its default, and no default is unbounded. A malformed team allowlist also turns the tickoff, because its default enrolls every team of the listed organizations.++A `deployments` object, keyed by `settings.CLOUD_DEPLOYMENT`, holds per-region overrides of the top-level fields."""import uuid@@ -11,6 +13,8 @@ import dataclassesfrom enum import StrEnumfrom typing import TYPE_CHECKING, Any+from django.conf import settings+import structlogfrom posthog.schema import IntervalType@@ -365,8 +369,32 @@ def covers_team(config: AnomalyScoringConfig, team: "Team") -> bool:return has_enabled_source(team.id)+def deployment_payload(payload: Any, deployment: str | None) -> Any:+ """The payload with the entry of `deployment` in its `deployments` object merged over the top-level fields.++ A malformed `deployments` object or entry is ignored, so the top-level fields apply. Each field then gets+ the same validation and caps as a top-level field.+ """+ if not isinstance(payload, dict) or "deployments" not in payload:+ return payload+ base = {key: value for key, value in payload.items() if key != "deployments"}+ deployments = payload["deployments"]+ if not isinstance(deployments, dict):+ logger.warning("anomaly_scoring_config_malformed_deployments")+ return base+ if deployment is None or deployment not in deployments:+ return base+ override = deployments[deployment]+ if not isinstance(override, dict) or "deployments" in override:+ logger.warning("anomaly_scoring_config_malformed_deployment_override", deployment=deployment)+ return base+ return {**base, **override}++def read_payload() -> dict | None:- return read_flag_payload(ANOMALY_SCORING_FLAG, ANOMALY_SCORING_FLAG_DISTINCT_ID)+ return deployment_payload(+ read_flag_payload(ANOMALY_SCORING_FLAG, ANOMALY_SCORING_FLAG_DISTINCT_ID), settings.CLOUD_DEPLOYMENT+ )def read_config(payload: Any) -> AnomalyScoringConfig:diff --git a/products/signals/backend/anomaly_scores/tick.py b/products/signals/backend/anomaly_scores/tick.pyindex 2355886637c3..a7fc181c1965 100644--- a/products/signals/backend/anomaly_scores/tick.py+++ b/products/signals/backend/anomaly_scores/tick.py@@ -132,6 +132,7 @@ class AnomalyScoringTickPlan:enrolled_organizations: int = 0teams_planned: int = 0teams_skipped: int = 0+ self_driving_organization_percentage: float = 0.0due_insights: int | None = Noneoldest_due_seconds: int | None = Noneoldest_refresh_seconds: int | None = None@@ -191,6 +192,8 @@ class AnomalyScoringTickResult:# Teams with active insights that the plan loaded, and the teams that wait for a later tick.teams_planned: int = 0teams_skipped: int = 0+ # The percentage rollout after the overrides of this deployment.+ self_driving_organization_percentage: float = 0.0# The plan activity failed, and the tick scored nothing. `plan_error` is the error class.plan_failed: bool = Falseplan_error: str | None = None@@ -232,6 +235,7 @@ def plan_tick(limit: int | None, now: datetime.datetime) -> AnomalyScoringTickPlenrolled_organizations=selection.enrolled_organizations,teams_planned=selection.teams_planned,teams_skipped=selection.teams_skipped,+ self_driving_organization_percentage=config.self_driving_organization_percentage,due_insights=selection.due_insights,oldest_due_seconds=selection.oldest_due_seconds,oldest_refresh_seconds=selection.oldest_refresh_seconds,@@ -493,6 +497,7 @@ def capture_tick(result: AnomalyScoringTickResult) -> None:plan_ms=result.plan_ms,teams_planned=result.teams_planned,teams_skipped=result.teams_skipped,+ self_driving_organization_percentage=result.self_driving_organization_percentage,plan_failed=result.plan_failed,plan_error=result.plan_error,due_insights=result.due_insights,@@ -530,6 +535,7 @@ def capture_tick(result: AnomalyScoringTickResult) -> None:"plan_ms": result.plan_ms,"teams_planned": result.teams_planned,"teams_skipped": result.teams_skipped,+ "self_driving_organization_percentage": result.self_driving_organization_percentage,"plan_failed": result.plan_failed,"plan_error": result.plan_error,"due_insights": result.due_insights,@@ -658,6 +664,7 @@ class AnomalyScoringTickWorkflow:plan_ms=plan_ms,teams_planned=plan.teams_planned,teams_skipped=plan.teams_skipped,+ self_driving_organization_percentage=plan.self_driving_organization_percentage,due_insights=plan.due_insights,oldest_due_seconds=plan.oldest_due_seconds,oldest_refresh_seconds=plan.oldest_refresh_seconds,diff --git a/products/signals/backend/test/test_anomaly_scoring_tick.py b/products/signals/backend/test/test_anomaly_scoring_tick.pyindex 249e199a0acd..8d2a2ab458bb 100644--- a/products/signals/backend/test/test_anomaly_scoring_tick.py+++ b/products/signals/backend/test/test_anomaly_scoring_tick.py@@ -11,7 +11,7 @@ from posthog.test.base import BaseTest, ClickhouseTestMixin, _create_eventfrom unittest.mock import MagicMock, patchfrom django.core.cache import cache-from django.test import SimpleTestCase+from django.test import SimpleTestCase, override_settingsimport numpy as npfrom parameterized import parameterized@@ -43,6 +43,7 @@ from products.signals.backend.anomaly_scores.config import (ScoringRun,covers_team,parse_config,+ read_payload,)from products.signals.backend.anomaly_scores.due_list import record_scored, refresh_due_listfrom products.signals.backend.anomaly_scores.emission import SCORER_DISTINCT_ID, score_events@@ -202,6 +203,48 @@ class TestTickConfig(SimpleTestCase):assert (config.enabled, config.allow_team_ids) == (True, ())+ @parameterized.expand(+ [+ ("no_deployments", "US", {}, 1.0, 8),+ ("matching_deployment", "US", {"deployments": {"US": {"self_driving_organization_percentage": 5}}}, 5.0, 8),+ ("other_deployment", "EU", {"deployments": {"US": {"self_driving_organization_percentage": 5}}}, 1.0, 8),+ ("no_cloud_deployment", None, {"deployments": {"US": {"self_driving_organization_percentage": 5}}}, 1.0, 8),+ ("override_capped", "US", {"deployments": {"US": {"max_insights_per_tick": 100}}}, 1.0, 50),+ (+ "invalid_override_value",+ "US",+ {"deployments": {"US": {"self_driving_organization_percentage": "50"}}},+ 0.0,+ 8,+ ),+ ("deployments_not_an_object", "US", {"deployments": ["US"]}, 1.0, 8),+ ("override_not_an_object", "US", {"deployments": {"US": 50}}, 1.0, 8),+ (+ "nested_deployments",+ "US",+ {"deployments": {"US": {"self_driving_organization_percentage": 50, "deployments": {}}}},+ 1.0,+ 8,+ ),+ ]+ )+ def test_the_deployment_override_merges_over_the_top_level_fields(+ self, _name: str, deployment: str | None, overrides: dict[str, Any], percentage: float, max_insights: int+ ) -> None:+ payload = {"enabled": True, "self_driving_organization_percentage": 1, "max_insights_per_tick": 8, **overrides}++ with (+ override_settings(CLOUD_DEPLOYMENT=deployment),+ patch("products.signals.backend.anomaly_scores.config.read_flag_payload", return_value=payload),+ ):+ config = parse_config(read_payload())++ assert (config.enabled, config.self_driving_organization_percentage, config.max_insights_per_tick) == (+ True,+ percentage,+ max_insights,+ )+@parameterized.expand([("max_insights_per_tick", 51, 50),@@ -1638,17 +1681,19 @@ async def test_the_tick_stops_starting_picks_when_clickhouse_is_at_capacity(candidates=8,max_concurrency=2,skipped_for_budget=3,+ self_driving_organization_percentage=5.0,)result, ran = await _run_tick(plan, statuses)assert sorted(ran) == started- assert (result.picked, result.queries, result.skipped_for_budget, result.stopped_at_capacity) == (- len(started),- queries,- 3,- stopped,- )+ assert (+ result.picked,+ result.queries,+ result.skipped_for_budget,+ result.stopped_at_capacity,+ result.self_driving_organization_percentage,+ ) == (len(started), queries, 3, stopped, 5.0)@pytest.mark.asyncio