:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(replay-vision): dim the feed with a spinner while a filter change loads (#123582)
Tue Haulund952a55d7d33d
diff --git a/products/replay_vision/frontend/replay_scanners/components/WatchFeedTab.tsx b/products/replay_vision/frontend/replay_scanners/components/WatchFeedTab.tsxindex de6fd4d007fa..993b2de2d220 100644--- a/products/replay_vision/frontend/replay_scanners/components/WatchFeedTab.tsx+++ b/products/replay_vision/frontend/replay_scanners/components/WatchFeedTab.tsx@@ -1,9 +1,10 @@+import clsx from 'clsx'import { useActions, useValues } from 'kea'import { useEffect } from 'react'import { useInView } from 'react-intersection-observer'import { IconChevronDown } from '@posthog/icons'-import { LemonButton, LemonMenu, LemonSkeleton, LemonTabs } from '@posthog/lemon-ui'+import { LemonButton, LemonMenu, LemonSkeleton, LemonTabs, Spinner } from '@posthog/lemon-ui'import { isWatchFeedBlock } from '../watchFeedEmptyState'import { FEED_DATE_OPTIONS, feedWindowOption, feedWindowPhrase, watchFeedLogic } from '../watchFeedLogic'@@ -59,8 +60,17 @@ function FeedEnd({ itemCount }: { itemCount: number }): JSX.Element | null {}export function WatchFeedTab(): JSX.Element {- const { feedItems, feedItemsLoading, feedLoad, feedFailed, dateFrom, scopedToMine, hasOwnScanners, emptyReason } =- useValues(watchFeedLogic)+ const {+ feedItems,+ feedItemsLoading,+ feedReloading,+ feedLoad,+ feedFailed,+ dateFrom,+ scopedToMine,+ hasOwnScanners,+ emptyReason,+ } = useValues(watchFeedLogic)const { setDateFrom, setOnlyMyScanners, loadFeed } = useActions(watchFeedLogic)const items = feedItems ?? []@@ -117,7 +127,18 @@ export function WatchFeedTab(): JSX.Element {{(feedItems === null && !feedFailed) || (feedItemsLoading && items.length === 0) ? (<FeedSkeleton />) : (- <div className="mx-auto flex w-full max-w-xl flex-col gap-4">+ <div className="relative mx-auto flex w-full max-w-xl flex-col gap-4">+ {/* The last result stays while a filter change loads, dimmed so it doesn't read as the new one. */}+ {feedReloading && (+ <div+ className="pointer-events-none absolute inset-0 z-10 flex justify-center pt-32"+ data-attr="vision-watch-feed-reloading"+ role="status"+ aria-label="Loading the feed"+ >+ <Spinner className="sticky top-1/3 text-6xl" />+ </div>+ )}{/* kea-loaders keeps the last value on failure, so a later filter or date change can failwith cards still on screen. Show the error above them rather than replacing them. */}{feedFailed && (@@ -135,15 +156,20 @@ export function WatchFeedTab(): JSX.Element {{items.length > 0 && isWatchFeedBlock(emptyReason) && (<WatchFeedBlockedBanner reason={emptyReason} />)}- {/* Three newest clips and nothing else is the answer, not a half-loaded feed, so say so- rather than leaving the reader to infer it from three identical reason lines. */}- {onlyFiller && (- <p className="text-sm text-secondary m-0">- No sessions stood out {feedWindowPhrase(dateFrom)}. These are the newest ones.- </p>- )}{items.length > 0 ? (- <>+ <div+ className={clsx('flex flex-col gap-4 transition-opacity', feedReloading && 'opacity-40')}+ aria-busy={feedReloading}+ // `inert` keeps the stale cards out of keyboard reach; React 18 types lack the attribute.+ {...(feedReloading ? { inert: '' } : {})}+ >+ {/* Three newest clips and nothing else is the answer, not a half-loaded feed, so say so+ rather than leaving the reader to infer it from three identical reason lines. */}+ {onlyFiller && (+ <p className="text-sm text-secondary m-0">+ No sessions stood out {feedWindowPhrase(dateFrom)}. These are the newest ones.+ </p>+ )}{items.map((item, index) => (<WatchFeedRowkey={`${feedLoad?.feedLoadId}-${item.observation.id}`}@@ -152,7 +178,7 @@ export function WatchFeedTab(): JSX.Element {/>))}<FeedEnd itemCount={items.length} />- </>+ </div>) : feedFailed ? null : emptyReason ? (<WatchFeedEmptyState reason={emptyReason} />) : (diff --git a/products/replay_vision/frontend/replay_scanners/watchFeedLogic.test.ts b/products/replay_vision/frontend/replay_scanners/watchFeedLogic.test.tsindex 8d818b736d23..a208c9e2bdff 100644--- a/products/replay_vision/frontend/replay_scanners/watchFeedLogic.test.ts+++ b/products/replay_vision/frontend/replay_scanners/watchFeedLogic.test.ts@@ -239,7 +239,8 @@ describe('watchFeedLogic', () => {)logic.actions.loadMoreFeed({})logic.actions.loadMoreFeed({})- await expectLogic(logic).toMatchValues({ feedItemsLoading: true })+ // Loading the next page keeps the cards usable; only a filter change dims them.+ await expectLogic(logic).toMatchValues({ feedItemsLoading: true, feedReloading: false })await waitFor(() => expect(pending).toHaveLength(2))// The newer request lands first, then the older one would append the same page again.pending[1]()@@ -255,7 +256,7 @@ describe('watchFeedLogic', () => {logic.mount()await expectLogic(logic).toDispatchActions(['loadFeed', 'loadFeedFailure'])- .toMatchValues({ feedFailed: true, feedItems: null })+ .toMatchValues({ feedFailed: true, feedItems: null, feedReloading: false })feedSpy.mockImplementation(() => [200, { results: [] }])await expectLogic(logic, () => {logic.actions.loadFeed()diff --git a/products/replay_vision/frontend/replay_scanners/watchFeedLogic.ts b/products/replay_vision/frontend/replay_scanners/watchFeedLogic.tsindex 83cb121dd229..de380de16a2f 100644--- a/products/replay_vision/frontend/replay_scanners/watchFeedLogic.ts+++ b/products/replay_vision/frontend/replay_scanners/watchFeedLogic.ts@@ -46,6 +46,7 @@ export interface watchFeedLogicValues {feedMoreFailed: booleanfeedRanker: WatchFeedRankerfeedRankerVariant: string | null+ feedReloading: booleanfeedServed: numberhasOwnScanners: boolean | nullonlyMyScanners: boolean@@ -380,6 +381,15 @@ export const watchFeedLogic = kea<watchFeedLogicType>([loadFeedFailure: () => true,},],+ // A filter change reloads page one, unlike loading the next page, which shares the loader.+ feedReloading: [+ false,+ {+ loadFeed: () => true,+ loadFeedSuccess: () => false,+ loadFeedFailure: () => false,+ },+ ],// Set from each response, so the card layout always matches the ranking it shows.feedRanker: ['weighted-score' as WatchFeedRanker,