Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(quill-charts): stop pie and sankey repainting the canvas on hover (#125329)

Sam Pennington968bcd7d16b4
diff --git a/packages/quill/packages/charts/src/charts/PieChart/PieChart.test.tsx b/packages/quill/packages/charts/src/charts/PieChart/PieChart.test.tsx
index c04159e1e6c2..30fcc5a32bd6 100644
--- a/packages/quill/packages/charts/src/charts/PieChart/PieChart.test.tsx
+++ b/packages/quill/packages/charts/src/charts/PieChart/PieChart.test.tsx
@@ -124,6 +124,19 @@ describe('PieChart', () => {
expect(tooltip.seriesData[0].series.label).toBe('Firefox')
})
+ it('does not repaint the static canvas on hover', async () => {
+ const { chart } = renderChart(<PieChart series={SERIES} theme={THEME} />)
+ let paints = 0
+ const observer = new MutationObserver((records) => (paints += records.length))
+ observer.observe(chart.canvas, { attributeFilter: ['data-hog-charts-paint'] })
+ const layout = layoutFor(SERIES)
+ fireEvent.mouseMove(chart.element, pointInSlice(layout, 0))
+ fireEvent.mouseMove(chart.element, pointInSlice(layout, 1))
+ await chart.waitForTooltip()
+ expect(paints + observer.takeRecords().length).toBe(0)
+ observer.disconnect()
+ })
+
it('shows no tooltip when hovering the donut hole', async () => {
const { chart } = renderChart(<PieChart series={SERIES} theme={THEME} config={{ innerRadiusRatio: 0.5 }} />)
const layout = layoutFor(SERIES, 0.5)
diff --git a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.test.tsx b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.test.tsx
index d065d2334e25..5f403ebf2c33 100644
--- a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.test.tsx
+++ b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.test.tsx
@@ -137,6 +137,21 @@ describe('SankeyChart', () => {
expect(onNodeClick).not.toHaveBeenCalled()
})
+ it('does not repaint the static canvas on hover', async () => {
+ const { chart } = renderChart(<SankeyChart nodes={NODES} links={LINKS} theme={THEME} />)
+ let paints = 0
+ const observer = new MutationObserver((records) => (paints += records.length))
+ observer.observe(chart.canvas, { attributeFilter: ['data-hog-charts-paint'] })
+ await waitFor(() => {
+ fireEvent.mouseMove(chart.element, nodeCenter('a'))
+ expect(getChartTooltip()?.textContent).toContain('Tool A')
+ })
+ fireEvent.mouseMove(chart.element, nodeCenter('done'))
+ expect(getChartTooltip()?.textContent).toContain('Completed')
+ expect(paints + observer.takeRecords().length).toBe(0)
+ observer.disconnect()
+ })
+
it('shows the tooltip on a first tap, fires onNodeClick on the second, and clears on an empty tap', async () => {
const onNodeClick = jest.fn()
const onHoverChange = jest.fn()
diff --git a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.tsx b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.tsx
index 4c449ad82f48..d3df8e020a70 100644
--- a/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.tsx
+++ b/packages/quill/packages/charts/src/charts/SankeyChart/SankeyChart.tsx
@@ -247,8 +247,6 @@ function SankeyChartInner<NodeMeta = unknown, LinkMeta = NodeMeta>({
overlayCtx,
dimensions,
scales,
- series: [],
- labels: [],
hoverIndex,
hoverPosition,
theme,
diff --git a/packages/quill/packages/charts/src/core/RadialChart.tsx b/packages/quill/packages/charts/src/core/RadialChart.tsx
index 546412281b9e..735cd162b6b4 100644
--- a/packages/quill/packages/charts/src/core/RadialChart.tsx
+++ b/packages/quill/packages/charts/src/core/RadialChart.tsx
@@ -119,9 +119,6 @@ export function RadialChart<Meta = unknown>({
dimensions,
scales,
series: coloredSeries,
- // No x-axis category labels in a radial chart; preserve the contract by passing []. Slice
- // labels live in the SliceLabels overlay, which reads from the radial layout directly.
- labels: [],
hoverIndex,
hoverPosition: null,
theme,
diff --git a/packages/quill/packages/charts/src/core/hooks/useChartDraw.ts b/packages/quill/packages/charts/src/core/hooks/useChartDraw.ts
index b8e453552cf9..bd3d91eaa6f5 100644
--- a/packages/quill/packages/charts/src/core/hooks/useChartDraw.ts
+++ b/packages/quill/packages/charts/src/core/hooks/useChartDraw.ts
@@ -20,8 +20,8 @@ interface UseChartDrawOptions {
overlayCtx: CanvasRenderingContext2D | null
dimensions: ChartDimensions | null
scales: ChartScales | null
- series: ResolvedSeries[]
- labels: string[]
+ series?: ResolvedSeries[]
+ labels?: string[]
hoverIndex: number
hoverPosition: { x: number; y: number } | null
theme: ChartTheme
@@ -32,13 +32,17 @@ interface UseChartDrawOptions {
hoverAnimationMs?: number
}
+// Shared defaults: a fresh `[]` per render would repaint the static layer on every hover.
+const NO_SERIES: ResolvedSeries[] = []
+const NO_LABELS: string[] = []
+
export function useChartDraw({
ctx,
overlayCtx,
dimensions,
scales,
- series,
- labels,
+ series = NO_SERIES,
+ labels = NO_LABELS,
hoverIndex,
hoverPosition,
theme,