:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
refactor(experiments): route slack and eval seeder reads via the facade (#126290)
Anders9826162c9616
diff --git a/products/experiments/backend/facade/contracts.py b/products/experiments/backend/facade/contracts.pyindex 5a83a61991b8..ac52a86933b6 100644--- a/products/experiments/backend/facade/contracts.py+++ b/products/experiments/backend/facade/contracts.py@@ -44,6 +44,35 @@ class StoredPrimaryResult:variants: tuple[StoredArmResult, ...]+@frozen+class ExperimentUnfurlVariant:+ """One variant of the experiment's flag and its share of the rollout."""++ key: str+ # As the flag stores it, so a whole number stays an int and prints as `50`, not `50.0`.+ rollout_percentage: float+++@frozen+class ExperimentUnfurl:+ """What a link preview shows for an experiment."""++ id: int+ # An object access check reads the creator. The preview does not show it.+ created_by_id: int | None+ name: str+ description: str | None+ # Public status string: draft, running, paused, exposure_frozen, or stopped.+ status: str+ start_date: datetime | None+ end_date: datetime | None+ updated_at: datetime+ # The name of the first inline primary metric, when that metric has one.+ primary_metric_name: str | None+ # The variants of the experiment's flag, in the flag's order. Empty when the flag config can't be read.+ variants: tuple[ExperimentUnfurlVariant, ...]++@frozenclass ExperimentSummaryData:"""Result of fetching experiment data for the AI results summary."""diff --git a/products/experiments/backend/facade/slack.py b/products/experiments/backend/facade/slack.pynew file mode 100644index 000000000000..c50003d972a0--- /dev/null+++ b/products/experiments/backend/facade/slack.py@@ -0,0 +1,41 @@+"""Experiment reads for the Slack app, which unfurls links to experiments."""++from products.experiments.backend.facade.contracts import ExperimentUnfurl, ExperimentUnfurlVariant+from products.experiments.backend.models.experiment import Experiment+from products.feature_flags.backend.facade.config import ConfigFormatError+++def get_experiment_unfurl(*, team_id: int, experiment_id: int) -> ExperimentUnfurl | None:+ """What a link preview shows for an experiment of the team. None when the team has none with this id, or it is deleted."""+ experiment = (+ Experiment.objects.filter(team_id=team_id, pk=experiment_id, deleted=False)+ .select_related("feature_flag")+ .first()+ )+ if experiment is None:+ return None+ try:+ variants = experiment.feature_flag.variants+ except ConfigFormatError:+ variants = []+ return ExperimentUnfurl(+ id=experiment.id,+ created_by_id=experiment.created_by_id,+ name=experiment.name,+ description=experiment.description,+ status=experiment.status_label,+ start_date=experiment.start_date,+ end_date=experiment.end_date,+ updated_at=experiment.updated_at,+ primary_metric_name=_first_metric_name(experiment.metrics),+ variants=tuple(+ ExperimentUnfurlVariant(key=variant["key"], rollout_percentage=variant["rollout_percentage"])+ for variant in variants+ ),+ )+++def _first_metric_name(metrics: object) -> str | None:+ first = metrics[0] if isinstance(metrics, list) and metrics else None+ name = first.get("name") if isinstance(first, dict) else None+ return name if isinstance(name, str) and name else Nonediff --git a/products/experiments/backend/facade/testing.py b/products/experiments/backend/facade/testing.pyindex 29c97dc93d1c..7991799dac1e 100644--- a/products/experiments/backend/facade/testing.py+++ b/products/experiments/backend/facade/testing.py@@ -109,9 +109,16 @@ def create_holdout(return holdout.id-def create_saved_metric(*, team_id: int, name: str, query: dict[str, Any], created_by_id: int | None = None) -> int:+def create_saved_metric(+ *,+ team_id: int,+ name: str,+ query: dict[str, Any],+ description: str | None = None,+ created_by_id: int | None = None,+) -> int:saved_metric = ExperimentSavedMetric.objects.create(- team_id=team_id, name=name, query=query, created_by_id=created_by_id+ team_id=team_id, name=name, description=description, query=query, created_by_id=created_by_id)return saved_metric.iddiff --git a/products/experiments/backend/test/test_facade_slack.py b/products/experiments/backend/test/test_facade_slack.pynew file mode 100644index 000000000000..eba081e8441b--- /dev/null+++ b/products/experiments/backend/test/test_facade_slack.py@@ -0,0 +1,79 @@+from datetime import UTC, datetime++from posthog.test.base import BaseTest++from parameterized import parameterized++from posthog.models.team import Team++from products.experiments.backend.facade import testing+from products.experiments.backend.facade.contracts import ExperimentUnfurl, ExperimentUnfurlVariant+from products.experiments.backend.facade.slack import get_experiment_unfurl+from products.feature_flags.backend.models.feature_flag import FeatureFlag+++class TestGetExperimentUnfurl(BaseTest):+ @parameterized.expand(+ [+ ("live", False, False, True),+ ("deleted", False, True, False),+ ("another_team", True, False, False),+ ]+ )+ def test_finds_only_a_live_experiment_of_the_team(+ self, _name: str, other_team: bool, deleted: bool, found: bool+ ) -> None:+ team = Team.objects.create(organization=self.organization, name="Other") if other_team else self.team+ flag = FeatureFlag.objects.create(team=team, key="experiment-flag", created_by=self.user)+ experiment_id = testing.create_experiment(team_id=team.id, feature_flag_id=flag.id, deleted=deleted)++ unfurl = get_experiment_unfurl(team_id=self.team.id, experiment_id=experiment_id)++ assert (unfurl is not None) is found++ def test_reads_what_the_preview_shows(self) -> None:+ flag = FeatureFlag.objects.create(+ team=self.team,+ key="checkout-copy",+ created_by=self.user,+ active=False,+ filters={+ "groups": [{"properties": [], "rollout_percentage": 100}],+ "multivariate": {+ "variants": [+ {"key": "control", "rollout_percentage": 30},+ {"key": "test", "rollout_percentage": 70},+ ]+ },+ },+ )+ start_date = datetime(2026, 9, 1, tzinfo=UTC)+ updated_at = datetime(2026, 9, 2, tzinfo=UTC)+ experiment_id = testing.create_experiment(+ team_id=self.team.id,+ feature_flag_id=flag.id,+ name="Checkout copy",+ description="Shorter copy converts better.",+ created_by_id=self.user.id,+ start_date=start_date,+ metrics=[{"kind": "ExperimentMetric", "metric_type": "funnel", "name": "Completed checkout"}],+ updated_at=updated_at,+ )++ unfurl = get_experiment_unfurl(team_id=self.team.id, experiment_id=experiment_id)++ assert unfurl == ExperimentUnfurl(+ id=experiment_id,+ created_by_id=self.user.id,+ name="Checkout copy",+ description="Shorter copy converts better.",+ status="paused",+ start_date=start_date,+ end_date=None,+ updated_at=updated_at,+ primary_metric_name="Completed checkout",+ variants=(+ ExperimentUnfurlVariant(key="control", rollout_percentage=30),+ ExperimentUnfurlVariant(key="test", rollout_percentage=70),+ ),+ )diff --git a/products/experiments/backend/test/test_facade_testing.py b/products/experiments/backend/test/test_facade_testing.pyindex fa0f05e53a6d..8fdcebcff514 100644--- a/products/experiments/backend/test/test_facade_testing.py+++ b/products/experiments/backend/test/test_facade_testing.py@@ -31,7 +31,10 @@ class TestFacadeTesting(BaseTest):updated_at=start_date,)saved_metric_id = testing.create_saved_metric(- team_id=self.team.id, name="Shared metric", query={"kind": "ExperimentMetric", "metric_type": "funnel"}+ team_id=self.team.id,+ name="Shared metric",+ description="Counts checkouts.",+ query={"kind": "ExperimentMetric", "metric_type": "funnel"},)testing.link_saved_metric(experiment_id=experiment_id, saved_metric_id=saved_metric_id, metadata={"type": "secondary"}@@ -50,7 +53,7 @@ class TestFacadeTesting(BaseTest):assert experiment.updated_at == start_datelink = ExperimentToSavedMetric.objects.get(experiment_id=experiment_id)assert (link.saved_metric_id, link.metadata) == (saved_metric_id, {"type": "secondary"})- assert link.saved_metric.team_id == self.team.id+ assert (link.saved_metric.team_id, link.saved_metric.description) == (self.team.id, "Counts checkouts.")config = TeamExperimentsConfig.objects.get(team_id=self.team.id)assert (config.default_cuped_enabled, config.experiment_precomputation_enabled) == (True, True)diff --git a/products/posthog_ai/evals/experiments/seeders.py b/products/posthog_ai/evals/experiments/seeders.pyindex 6d6b0c88822d..933f92ac6e32 100644--- a/products/posthog_ai/evals/experiments/seeders.py+++ b/products/posthog_ai/evals/experiments/seeders.py@@ -51,12 +51,17 @@ ENDED_EXPERIMENT_NAME = "checkout cta v2"# Verbatim description of the catch-all release condition that PostHog adds to a feature flag-# when a variant is shipped to all users, see the ship_flag_variant call in-# products.experiments.backend.experiment_service+# when a variant is shipped to all users, see the `ship_flag_variant` call in the experiments+# product's experiment serviceSHIP_VARIANT_FLIP_SIGNATURE = "Added automatically when the experiment was ended to keep only one variant."-def seed_running_experiment(context: CustomPromptSandboxContext) -> dict[str, Any]:+def seed_running_experiment(+ context: CustomPromptSandboxContext,+ *,+ start_date: datetime | None = None,+ description: str = "Seeded by eval — running experiment with 50/50 split.",+) -> dict[str, Any]:"""Seed one running experiment with a 50/50 multivariate flag.Designed for prompts that ask the agent to change variant split on a@@ -69,7 +74,7 @@ def seed_running_experiment(context: CustomPromptSandboxContext) -> dict[str, Anparameterising this one — the eval framework passes only ``context`` to seeders, socase-specific config has to live in the seeder definition."""- from products.experiments.backend.models.experiment import Experiment+ from products.experiments.backend.facade.testing import create_experimentfrom products.feature_flags.backend.models.feature_flag import FeatureFlagteam_id = context.team_id@@ -92,19 +97,18 @@ def seed_running_experiment(context: CustomPromptSandboxContext) -> dict[str, Anactive=True,)- experiment = Experiment.objects.create(+ experiment_id = create_experiment(team_id=team_id,created_by_id=user_id,name=ROLLOUT_EXPERIMENT_NAME,- description="Seeded by eval — running experiment with 50/50 split.",- feature_flag=flag,- start_date=datetime.now(tz=UTC) - timedelta(days=7),- end_date=None,+ description=description,+ feature_flag_id=flag.id,+ start_date=start_date or datetime.now(tz=UTC) - timedelta(days=7),)payload: dict[str, Any] = {- "experiment_id": experiment.id,- "experiment_name": experiment.name,+ "experiment_id": experiment_id,+ "experiment_name": ROLLOUT_EXPERIMENT_NAME,"feature_flag_id": flag.id,"feature_flag_key": flag.key,"initial_split": {"control": 50, "test": 50},@@ -112,7 +116,7 @@ def seed_running_experiment(context: CustomPromptSandboxContext) -> dict[str, Anlogger.info("Seeded running experiment for team_id=%s: experiment_id=%s flag_key=%s",team_id,- experiment.id,+ experiment_id,flag.key,)return payload@@ -122,12 +126,7 @@ def _seed_split_test_experiment_started_at(context: CustomPromptSandboxContext, *, start_date: datetime, description: str) -> dict[str, Any]:"""Seed the shared 50/50 experiment with the start date that a case's prompt describes."""- from products.experiments.backend.models.experiment import Experiment-- payload = seed_running_experiment(context)- Experiment.objects.filter(team_id=context.team_id, id=payload["experiment_id"]).update(- start_date=start_date, description=description- )+ payload = seed_running_experiment(context, start_date=start_date, description=description)return {**payload, "start_date": start_date.isoformat()}@@ -212,7 +211,7 @@ def seed_uneven_split_experiment(context: CustomPromptSandboxContext) -> dict[strecognise that an 80/20 split combined with Exclude systematically removesoverlap users from the smaller variant, biasing the test arm."""- from products.experiments.backend.models.experiment import Experiment+ from products.experiments.backend.facade.testing import create_experimentfrom products.feature_flags.backend.models.feature_flag import FeatureFlagteam_id = context.team_id@@ -235,19 +234,18 @@ def seed_uneven_split_experiment(context: CustomPromptSandboxContext) -> dict[stactive=True,)- experiment = Experiment.objects.create(+ experiment_id = create_experiment(team_id=team_id,created_by_id=user_id,name=UNEVEN_SPLIT_EXPERIMENT_NAME,description="Seeded by eval — 80/20 split, default exclude handling.",- feature_flag=flag,+ feature_flag_id=flag.id,start_date=datetime.now(tz=UTC) - timedelta(days=14),- end_date=None,)return {- "experiment_id": experiment.id,- "experiment_name": experiment.name,+ "experiment_id": experiment_id,+ "experiment_name": UNEVEN_SPLIT_EXPERIMENT_NAME,"feature_flag_id": flag.id,"feature_flag_key": flag.key,"initial_split": {"control": 80, "test": 20},@@ -262,7 +260,7 @@ def seed_inactive_flag_experiment(context: CustomPromptSandboxContext) -> dict[scan never fire, so the exposure-shape snapshot will be empty and thediagnostic is B10 / A5 (flag inactive / experiment not actually live)."""- from products.experiments.backend.models.experiment import Experiment+ from products.experiments.backend.facade.testing import create_experimentfrom products.feature_flags.backend.models.feature_flag import FeatureFlagteam_id = context.team_id@@ -287,19 +285,18 @@ def seed_inactive_flag_experiment(context: CustomPromptSandboxContext) -> dict[sactive=False,)- experiment = Experiment.objects.create(+ experiment_id = create_experiment(team_id=team_id,created_by_id=user_id,name=INACTIVE_FLAG_EXPERIMENT_NAME,description="Seeded by eval — experiment with start_date set but flag inactive.",- feature_flag=flag,+ feature_flag_id=flag.id,start_date=datetime.now(tz=UTC) - timedelta(days=3),- end_date=None,)return {- "experiment_id": experiment.id,- "experiment_name": experiment.name,+ "experiment_id": experiment_id,+ "experiment_name": INACTIVE_FLAG_EXPERIMENT_NAME,"feature_flag_id": flag.id,"feature_flag_key": flag.key,"flag_active": False,@@ -325,7 +322,7 @@ def seed_ended_experiment_with_flag_flip(context: CustomPromptSandboxContext) ->"""from posthog.models.activity_logging.activity_log import ActivityLog, Change, Detail- from products.experiments.backend.models.experiment import Experiment+ from products.experiments.backend.facade.testing import create_experimentfrom products.feature_flags.backend.models.feature_flag import FeatureFlagteam_id = context.team_id@@ -363,12 +360,12 @@ def seed_ended_experiment_with_flag_flip(context: CustomPromptSandboxContext) ->active=True,)- experiment = Experiment.objects.create(+ experiment_id = create_experiment(team_id=team_id,created_by_id=user_id,name=ENDED_EXPERIMENT_NAME,description="Seeded by eval — experiment ended via ship-variant; flag rewritten to 0/100.",- feature_flag=flag,+ feature_flag_id=flag.id,start_date=datetime.now(tz=UTC) - timedelta(days=30),end_date=datetime.now(tz=UTC) - timedelta(days=1),)@@ -401,8 +398,8 @@ def seed_ended_experiment_with_flag_flip(context: CustomPromptSandboxContext) ->)return {- "experiment_id": experiment.id,- "experiment_name": experiment.name,+ "experiment_id": experiment_id,+ "experiment_name": ENDED_EXPERIMENT_NAME,"feature_flag_id": flag.id,"feature_flag_key": flag.key,"final_split": {"control": 0, "test": 100},@@ -416,7 +413,7 @@ SHARED_METRIC_EVENT = "purchase_completed"def seed_shared_metric_purchase_count(context: CustomPromptSandboxContext) -> dict[str, Any]:"""Seed one shared metric: mean count of purchase_completed per user, no filters."""- from products.experiments.backend.models.experiment import ExperimentSavedMetric+ from products.experiments.backend.facade.testing import create_saved_metricteam_id = context.team_iduser_id = context.user_id@@ -432,7 +429,7 @@ def seed_shared_metric_purchase_count(context: CustomPromptSandboxContext) -> di"uuid": str(uuid.uuid4()),}- metric = ExperimentSavedMetric.objects.create(+ saved_metric_id = create_saved_metric(team_id=team_id,created_by_id=user_id,name=SHARED_METRIC_NAME,@@ -441,8 +438,8 @@ def seed_shared_metric_purchase_count(context: CustomPromptSandboxContext) -> di)payload: dict[str, Any] = {- "saved_metric_id": metric.id,- "saved_metric_name": metric.name,+ "saved_metric_id": saved_metric_id,+ "saved_metric_name": SHARED_METRIC_NAME,"event": SHARED_METRIC_EVENT,"metric_type": "mean","math": "total",@@ -450,8 +447,8 @@ def seed_shared_metric_purchase_count(context: CustomPromptSandboxContext) -> dilogger.info("Seeded shared metric for team_id=%s: id=%s name=%s event=%s",team_id,- metric.id,- metric.name,+ saved_metric_id,+ SHARED_METRIC_NAME,SHARED_METRIC_EVENT,)return payloaddiff --git a/products/slack_app/backend/slack_link_unfurl.py b/products/slack_app/backend/slack_link_unfurl.pyindex 350f15b4d6d2..770b8c08138b 100644--- a/products/slack_app/backend/slack_link_unfurl.py+++ b/products/slack_app/backend/slack_link_unfurl.py@@ -35,6 +35,7 @@ from posthog.slack.formatting import escape_slack_mrkdwnfrom posthog.temporal.common.client import sync_connectfrom posthog.utils import get_instance_region+from products.access_control.backend.facade.contracts import ObjectAccessReffrom products.access_control.backend.facade.user_access_control import (UserAccessControl,access_level_satisfied_for_resource,@@ -45,9 +46,11 @@ from products.conversations.backend.models.ticket import Ticketfrom products.dashboards.backend.models.dashboard import Dashboardfrom products.dashboards.backend.models.dashboard_tile import DashboardTilefrom products.error_tracking.backend.facade import api as error_tracking_facade-from products.experiments.backend.facade import api as experiments_facade+from products.experiments.backend.facade import (+ api as experiments_facade,+ slack as experiments_slack,+)from products.experiments.backend.facade.contracts import StoredArmResult, StoredPrimaryResult-from products.experiments.backend.models.experiment import Experimentfrom products.exports.backend.facade import api as exports_facadefrom products.feature_flags.backend.facade.config import ConfigFormatErrorfrom products.feature_flags.backend.facade.filters import condition_rollout_percentage@@ -726,21 +729,8 @@ def _date_range(query: object) -> str | None:return f"Last {unit}" if amount == 1 else f"Last {_count(amount, unit)}"-def _primary_metric(metrics: object) -> str | None:- first = metrics[0] if isinstance(metrics, list) and metrics else None- name = first.get("name") if isinstance(first, dict) else None- return name if isinstance(name, str) and name else None---def _variant_rows(variants: list[dict]) -> list[_ChartRow]:- return [- _ChartRow(- label=_chart_label(variant["key"]),- bar=_bar(variant["rollout_percentage"] / 100),- value=f"{variant['rollout_percentage']}%",- )- for variant in variants- ]+def _variant_row(key: object, rollout_percentage: float) -> _ChartRow:+ return _ChartRow(label=_chart_label(key), bar=_bar(rollout_percentage / 100), value=f"{rollout_percentage}%")def _flag_variants(flag: FeatureFlag) -> list[dict]:@@ -966,7 +956,7 @@ def _notebook_card(ctx: _UnfurlContext, ref: str, url: str) -> _UnfurlCard | _Skdef _flag_chart(conditions: list[dict], variants: list[dict]) -> str | None:- rows = _variant_rows(variants)+ rows = [_variant_row(variant["key"], variant["rollout_percentage"]) for variant in variants]if len(conditions) == 1 and not conditions[0].get("properties"):rollout = condition_rollout_percentage(conditions[0])rows.insert(0, _ChartRow(label="Rollout", bar=_bar(rollout / 100), value=f"{rollout}% of users"))@@ -997,31 +987,34 @@ def _flag_card(ctx: _UnfurlContext, ref: str, url: str) -> _UnfurlCard | _SkipRedef _experiment_card(ctx: _UnfurlContext, ref: str, url: str) -> _UnfurlCard | _SkipReason:experiment = (- Experiment.objects.filter(team_id=ctx.team.pk, pk=ref, deleted=False).select_related("feature_flag").first()- if ref.isdigit()- else None+ experiments_slack.get_experiment_unfurl(team_id=ctx.team.pk, experiment_id=int(ref)) if ref.isdigit() else None)if not experiment:return "not_found"- if not ctx.uac.check_access_level_for_object(experiment, required_level="viewer"):+ # The experiment can sit on the legacy parent of the sharer's team. Access rules resolve against the sharer's team,+ # and the check raises for a reference to another team, so the reference names the sharer's team.+ access_ref = ObjectAccessRef(+ resource="experiment", id=str(experiment.id), team_id=ctx.team.pk, created_by_id=experiment.created_by_id+ )+ if not ctx.uac.check_access_level_for_ref(access_ref, "viewer"):return "no_access"details: list[str] = []if experiment.start_date:days = ((experiment.end_date or timezone.now()) - experiment.start_date).days + 1details.append(f"Ran {_count(days, 'day')}" if experiment.end_date else f"Day {days}")- stats = _stored_primary_result(experiment)- metric = stats.metric_name if stats else _primary_metric(experiment.metrics)+ stats = _stored_primary_result(team_id=ctx.team.pk, experiment_id=experiment.id)+ metric = stats.metric_name if stats else experiment.primary_metric_nameif metric:details.append(f"Metric: {metric}")- variants = _flag_variants(experiment.feature_flag)if stats:- details.append(f"Split {'/'.join(str(variant['rollout_percentage']) for variant in variants)}")+ details.append(f"Split {'/'.join(str(variant.rollout_percentage) for variant in experiment.variants)}")+ variant_rows = [_variant_row(variant.key, variant.rollout_percentage) for variant in experiment.variants]return _UnfurlCard(label="Experiment",title=experiment.name,- status=_humanize(experiment.status_label),+ status=_humanize(experiment.status),details=tuple(details),- chart=_experiment_chart(stats) if stats else _chart_rows(_variant_rows(variants)),+ chart=_experiment_chart(stats) if stats else _chart_rows(variant_rows),body="\n\n".join(part for part in (_experiment_verdict(stats) if stats else None, experiment.description) if part),@@ -1029,11 +1022,11 @@ def _experiment_card(ctx: _UnfurlContext, ref: str, url: str) -> _UnfurlCard | _)-def _stored_primary_result(experiment: Experiment) -> StoredPrimaryResult | None:+def _stored_primary_result(*, team_id: int, experiment_id: int) -> StoredPrimaryResult | None:try:- stats = experiments_facade.get_stored_primary_result(team_id=experiment.team_id, experiment_id=experiment.pk)+ stats = experiments_facade.get_stored_primary_result(team_id=team_id, experiment_id=experiment_id)except Exception:- logger.exception("slack_app_unfurl_experiment_results_failed", experiment_id=experiment.pk)+ logger.exception("slack_app_unfurl_experiment_results_failed", experiment_id=experiment_id)return Noneif (stats is Nonediff --git a/products/slack_app/backend/tests/test_link_unfurl.py b/products/slack_app/backend/tests/test_link_unfurl.pyindex f5df34b7bb5c..da3598f20b2c 100644--- a/products/slack_app/backend/tests/test_link_unfurl.py+++ b/products/slack_app/backend/tests/test_link_unfurl.py@@ -37,7 +37,7 @@ from products.dashboards.backend.models.dashboard import Dashboardfrom products.dashboards.backend.models.dashboard_tile import DashboardTilefrom products.error_tracking.backend.facade import testing as error_tracking_testingfrom products.experiments.backend.facade.contracts import StoredArmResult, StoredPrimaryResult-from products.experiments.backend.models.experiment import Experiment+from products.experiments.backend.facade.testing import create_experimentfrom products.feature_flags.backend.models.feature_flag import FeatureFlagfrom products.notebooks.backend.models import Notebookfrom products.product_analytics.backend.facade.models import Insight@@ -952,8 +952,8 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):return f"{base}/feature_flags/{flag.pk}", ["new-checkout", "*Active*", "25% of users"]case "experiment":flag = FeatureFlag.objects.create(team=self.team, key="button-color", created_by=self.user)- experiment = Experiment.objects.create(team=self.team, name="Button color", feature_flag=flag)- return f"{base}/experiments/{experiment.pk}", ["Button color", "*Draft*"]+ experiment_id = create_experiment(team_id=self.team.pk, name="Button color", feature_flag_id=flag.pk)+ return f"{base}/experiments/{experiment_id}", ["Button color", "*Draft*"]case "survey":survey = Survey.objects.create(team=self.team,@@ -1187,13 +1187,13 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):self, mock_slack_integration_class: MagicMock, mock_resolve: MagicMock) -> None:flag = FeatureFlag.objects.create(team=self.team, key="paused-test", created_by=self.user, active=False)- experiment = Experiment.objects.create(- team=self.team, name="Paused test", feature_flag=flag, start_date=timezone.now(), status="running"+ experiment_id = create_experiment(+ team_id=self.team.pk, name="Paused test", feature_flag_id=flag.pk, start_date=timezone.now())mock_resolve.return_value = MagicMock(user=self.user)mock_client = MagicMock()mock_slack_integration_class.return_value.client = mock_client- url = f"http://testserver/project/{self.team.pk}/experiments/{experiment.pk}"+ url = f"http://testserver/project/{self.team.pk}/experiments/{experiment_id}"self._unfurl_links([url])@@ -1202,15 +1202,29 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):@parameterized.expand([- ("winner", 0.15, True, ["*Winner so far: test.* +15.0% vs control.", "20.0%", "23.0% +15.0% ✓"]),- ("too_early", None, None, ["*Too early to call.* 10,400 exposed so far.", "23.0% +15.0%"]),+ (+ "winner",+ True,+ 0.15,+ True,+ ["Split 50/50", "*Winner so far: test.* +15.0% vs control.", "20.0%", "23.0% +15.0% ✓"],+ ),+ (+ "too_early",+ True,+ None,+ None,+ ["Split 50/50", "*Too early to call.* 10,400 exposed so far.", "23.0% +15.0%"],+ ),+ ("no_result", False, None, None, ["50%"]),])@patch("products.slack_app.backend.api.resolve_slack_user")@patch("products.slack_app.backend.slack_link_unfurl.SlackIntegration")- def test_experiment_card_shows_the_stored_primary_result(+ def test_experiment_card_shows_the_stored_primary_result_or_the_split(self,_name: str,+ has_result: bool,change: float | None,significant: bool | None,expected: list[str],@@ -1231,7 +1245,12 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):},},)- experiment = Experiment.objects.create(team=self.team, name="Checkout copy", feature_flag=flag)+ experiment_id = create_experiment(+ team_id=self.team.pk,+ name="Checkout copy",+ feature_flag_id=flag.pk,+ metrics=[{"kind": "ExperimentMetric", "metric_type": "funnel", "name": "Completed checkout"}],+ )stored = StoredPrimaryResult(metric_name="Completed checkout",metric_type="funnel",@@ -1245,17 +1264,16 @@ class TestHandlePosthogLinkUnfurl(APIBaseTest):mock_resolve.return_value = MagicMock(user=self.user)mock_client = MagicMock()mock_slack_integration_class.return_value.client = mock_client- url = f"http://testserver/project/{self.team.pk}/experiments/{experiment.pk}"+ url = f"http://testserver/project/{self.team.pk}/experiments/{experiment_id}"with patch("products.slack_app.backend.slack_link_unfurl.experiments_facade.get_stored_primary_result",- return_value=stored,+ return_value=stored if has_result else None,):self._unfurl_links([url])text = self._unfurl_text(mock_client.chat_unfurl.call_args.kwargs["unfurls"][url])assert "Metric: Completed checkout" in text- assert "Split 50/50" in textfor fragment in expected:assert fragment in text