Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(replay): quill twin for the experiments section in the overview (#129433)

Hayne Ryu9846cf5d82a3
diff --git a/frontend/src/scenes/session-recordings/player/watch/QuillOverviewOtherWatchers.tsx b/frontend/src/scenes/session-recordings/player/watch/QuillOverviewOtherWatchers.tsx
new file mode 100644
index 000000000000..42de4793ff12
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/player/watch/QuillOverviewOtherWatchers.tsx
@@ -0,0 +1,71 @@
+import { useValues } from 'kea'
+import { useState } from 'react'
+
+import { IconChevronDown, IconPeople } from '@posthog/icons'
+import { AvatarGroup, Button, Skeleton } from '@posthog/quill'
+
+import { cn } from 'lib/utils/css-classes'
+import { sessionRecordingPlayerLogic } from 'scenes/session-recordings/player/sessionRecordingPlayerLogic'
+import { userLogic } from 'scenes/userLogic'
+
+import { QuillUserAvatar } from './QuillUserAvatar'
+
+const MAX_BUBBLES = 6
+
+export function QuillOverviewOtherWatchers(): JSX.Element {
+ const { sessionPlayerMetaDataLoading, sessionPlayerMetaData } = useValues(sessionRecordingPlayerLogic)
+ const { user: currentUser } = useValues(userLogic)
+ const [expanded, setExpanded] = useState(false)
+
+ const otherViewers = (sessionPlayerMetaData?.viewers ?? []).filter((viewer) => viewer !== currentUser?.email)
+ const count = otherViewers.length
+
+ return (
+ <div className="rounded border border-border bg-card">
+ {sessionPlayerMetaDataLoading ? (
+ <div className="flex items-center justify-center gap-2 px-2 py-1">
+ <IconPeople />
+ <Skeleton className="h-5 w-48" />
+ </div>
+ ) : count === 0 ? (
+ <div className="flex items-center justify-center gap-2 px-2 py-1">
+ <IconPeople />
+ <span>Nobody else has watched this recording.</span>
+ </div>
+ ) : (
+ <div className="flex flex-col gap-2 px-2 py-1">
+ <div className="flex items-center justify-center gap-2 ph-no-capture">
+ <AvatarGroup stacked size="xs">
+ {otherViewers.slice(0, MAX_BUBBLES).map((email) => (
+ <QuillUserAvatar key={email} user={{ email }} size="xs" />
+ ))}
+ </AvatarGroup>
+ <span>
+ {count} other {count > 1 ? 'users have' : 'user has'} watched this recording.
+ </span>
+ <Button
+ size="icon-xs"
+ className="ml-2"
+ aria-expanded={expanded}
+ aria-label={expanded ? 'Hide watchers' : 'Show watchers'}
+ onClick={() => setExpanded(!expanded)}
+ data-attr="player-overview-watchers-toggle"
+ >
+ <IconChevronDown className={cn('transition-transform', expanded && 'rotate-180')} />
+ </Button>
+ </div>
+ {expanded && (
+ <div className="flex flex-col gap-1 mt-2 border-t border-border pt-2">
+ {otherViewers.map((email) => (
+ <div key={email} className="flex items-center gap-2 text-sm ph-no-capture">
+ <QuillUserAvatar user={{ email }} size="xs" />
+ <span className="truncate">{email === currentUser?.email ? 'you' : email}</span>
+ </div>
+ ))}
+ </div>
+ )}
+ </div>
+ )}
+ </div>
+ )
+}
diff --git a/frontend/src/scenes/session-recordings/player/watch/QuillUserAvatar.tsx b/frontend/src/scenes/session-recordings/player/watch/QuillUserAvatar.tsx
new file mode 100644
index 000000000000..26be1db4d7fb
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/player/watch/QuillUserAvatar.tsx
@@ -0,0 +1,40 @@
+import { Avatar, AvatarFallback, AvatarImage } from '@posthog/quill'
+
+import { cn } from 'lib/utils/css-classes'
+import { gravatarUrl } from 'lib/utils/gravatar'
+
+export interface AvatarUser {
+ email?: string | null
+ first_name?: string | null
+ last_name?: string | null
+}
+
+function initials(user: AvatarUser): string {
+ const name = [user.first_name, user.last_name].filter(Boolean).join(' ').trim()
+ const source = name || user.email || '?'
+ return source
+ .split(/[\s@._-]+/)
+ .filter(Boolean)
+ .slice(0, 2)
+ .map((part) => part[0]?.toUpperCase() ?? '')
+ .join('')
+}
+
+/** A person's gravatar with their initials behind it, for comment and viewer lists. */
+export function QuillUserAvatar({
+ user,
+ size = 'sm',
+ className,
+}: {
+ user: AvatarUser | null | undefined
+ size?: 'xs' | 'sm' | 'default'
+ className?: string
+}): JSX.Element {
+ const email = user?.email ?? undefined
+ return (
+ <Avatar size={size} className={cn('ph-no-capture', className)}>
+ {email && <AvatarImage src={gravatarUrl(email)} alt="" />}
+ <AvatarFallback>{user ? initials(user) : '?'}</AvatarFallback>
+ </Avatar>
+ )
+}
diff --git a/frontend/src/scenes/session-recordings/player/watch/RecordingCommentsList.tsx b/frontend/src/scenes/session-recordings/player/watch/RecordingCommentsList.tsx
index f55f222bb147..bebffbf08cd4 100644
--- a/frontend/src/scenes/session-recordings/player/watch/RecordingCommentsList.tsx
+++ b/frontend/src/scenes/session-recordings/player/watch/RecordingCommentsList.tsx
@@ -5,13 +5,13 @@ import { Button, Skeleton } from '@posthog/quill'
import { LazyRichContentPreview, LazyTextContent } from 'lib/components/RichContentEditor/LazyRichContent'
import { TZLabel } from 'lib/components/TZLabel'
import { dayjs } from 'lib/dayjs'
-import { ProfilePicture } from 'lib/lemon-ui/ProfilePicture'
import { colonDelimitedDuration } from 'lib/utils/durations'
import { CommentType } from '~/types'
import { sessionRecordingCommentsLogic } from '../sessionRecordingCommentsLogic'
import { sessionRecordingPlayerLogic } from '../sessionRecordingPlayerLogic'
+import { QuillUserAvatar } from './QuillUserAvatar'
export function RecordingCommentsList({ sessionId }: { sessionId: string }): JSX.Element | null {
const { sessionComments, sessionCommentsLoading } = useValues(
@@ -43,7 +43,7 @@ export function RecordingCommentsList({ sessionId }: { sessionId: string }): JSX
const atMs = timeInRecordingMs(comment)
return (
<div key={comment.id} className="flex items-start gap-2 text-sm">
- <ProfilePicture user={comment.created_by} size="sm" className="mt-0.5" />
+ <QuillUserAvatar user={comment.created_by} size="sm" className="mt-0.5" />
<div className="flex flex-col gap-0.5 min-w-0 flex-1">
<div className="flex items-center gap-2 text-xs text-muted-foreground">
<span className="font-medium text-foreground">
diff --git a/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx b/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx
index 2cf3e7baea09..586c06eb8b74 100644
--- a/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx
+++ b/frontend/src/scenes/session-recordings/player/watch/RecordingOverviewPanels.tsx
@@ -10,10 +10,10 @@ import { playerMetaLogic } from 'scenes/session-recordings/player/player-meta/pl
import { sessionRecordingPlayerLogic } from 'scenes/session-recordings/player/sessionRecordingPlayerLogic'
import { OVERVIEW_SNAPSHOT_SCOPE } from 'scenes/session-recordings/player/sidebar/overviewSnapshotScope'
import { playerSidebarLogic } from 'scenes/session-recordings/player/sidebar/playerSidebarLogic'
-import { PlayerSidebarOverviewOtherWatchers } from 'scenes/session-recordings/player/sidebar/PlayerSidebarOverviewOtherWatchers'
import { QuillExperimentsSection } from './QuillExperimentsSection'
import { QuillOverviewDeviceCard } from './QuillOverviewDeviceCard'
+import { QuillOverviewOtherWatchers } from './QuillOverviewOtherWatchers'
import { QuillOverviewPersonCard } from './QuillOverviewPersonCard'
import { QuillOverviewSessionCard } from './QuillOverviewSessionCard'
import { QuillTTLWarning } from './QuillTTLWarning'
@@ -111,9 +111,7 @@ function OverviewExtras(): JSX.Element {
</CollapsibleContent>
</Collapsible>
<QuillExperimentsSection />
- <div data-not-quill className="contents">
- <PlayerSidebarOverviewOtherWatchers />
- </div>
+ <QuillOverviewOtherWatchers />
</>
)
}
diff --git a/frontend/src/scenes/session-recordings/playlist/FilterChips.tsx b/frontend/src/scenes/session-recordings/playlist/FilterChips.tsx
index b2b27e555b5e..8ca1798a4dba 100644
--- a/frontend/src/scenes/session-recordings/playlist/FilterChips.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/FilterChips.tsx
@@ -5,7 +5,6 @@ import { IconClock, IconEye, IconPerson } from '@posthog/icons'
import { Button, Chip, ChipClose } from '@posthog/quill'
import { convertSecondsToDuration } from 'lib/components/DurationPicker/DurationPicker'
-import { UniversalFilterButton } from 'lib/components/UniversalFilters/UniversalFilterButton'
import { playerSettingsLogic } from 'scenes/session-recordings/player/playerSettingsLogic'
import { PropertyOperator, RecordingDurationFilter, RecordingUniversalFilters } from '~/types'
@@ -13,6 +12,7 @@ import { PropertyOperator, RecordingDurationFilter, RecordingUniversalFilters }
import { asDisplay } from 'products/persons/frontend/person-utils'
import { filterLeaves, removeFilterLeaf } from './filterChipLeaves'
+import { QuillUniversalFilterChip } from './QuillUniversalFilterChip'
import { defaultRecordingDurationFilter, sessionRecordingsPlaylistLogic } from './sessionRecordingsPlaylistLogic'
const MAX_VISIBLE_CHIPS = 4
@@ -54,7 +54,7 @@ export function FilterChips({
const chips: ReactNode[] = [
...leaves.map(({ path, filter }) => (
- <UniversalFilterButton
+ <QuillUniversalFilterChip
key={path.join('.')}
filter={filter}
onClose={() => setFilters({ filter_group: removeFilterLeaf(filters.filter_group, path) })}
diff --git a/frontend/src/scenes/session-recordings/playlist/QuillSaveFiltersModal.tsx b/frontend/src/scenes/session-recordings/playlist/QuillSaveFiltersModal.tsx
new file mode 100644
index 000000000000..28f256de1fd5
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/playlist/QuillSaveFiltersModal.tsx
@@ -0,0 +1,86 @@
+import { useActions } from 'kea'
+import { useState } from 'react'
+
+import {
+ Button,
+ Dialog,
+ DialogBody,
+ DialogContent,
+ DialogDescription,
+ DialogFooter,
+ DialogHeader,
+ DialogTitle,
+ Input,
+} from '@posthog/quill'
+
+import { sessionRecordingSavedFiltersLogic } from 'scenes/session-recordings/filters/sessionRecordingSavedFiltersLogic'
+
+import { RecordingUniversalFilters } from '~/types'
+
+import { createPlaylist, stripSessionIds } from './playlistUtils'
+
+export function QuillSaveFiltersModal({
+ isOpen,
+ setIsOpen,
+ filters,
+}: {
+ isOpen: boolean
+ setIsOpen: (open: boolean) => void
+ filters: RecordingUniversalFilters
+}): JSX.Element {
+ const { loadSavedFilters, setAppliedSavedFilter } = useActions(sessionRecordingSavedFiltersLogic)
+ const [name, setName] = useState('')
+
+ const close = (): void => {
+ setIsOpen(false)
+ setName('')
+ }
+
+ const save = async (): Promise<void> => {
+ const saved = await createPlaylist(
+ { name, filters: stripSessionIds(filters), type: 'filters', creation_method: 'new' },
+ false
+ )
+ loadSavedFilters()
+ close()
+ setAppliedSavedFilter(saved)
+ }
+
+ return (
+ <Dialog open={isOpen} onOpenChange={(open: boolean) => !open && close()}>
+ <DialogContent>
+ <DialogHeader>
+ <DialogTitle>Save filters for later</DialogTitle>
+ <DialogDescription>You can access them from the saved filters menu</DialogDescription>
+ </DialogHeader>
+ <DialogBody>
+ <Input
+ value={name}
+ placeholder="Saved filter name"
+ autoFocus
+ onChange={(event) => setName(event.target.value)}
+ onKeyDown={(event) => {
+ if (event.key === 'Enter' && name.length > 0) {
+ void save()
+ }
+ }}
+ data-attr="filters-save-modal-name"
+ />
+ </DialogBody>
+ <DialogFooter>
+ <Button variant="outline" onClick={close} data-attr="filters-save-modal-close">
+ Close
+ </Button>
+ <Button
+ variant="primary"
+ disabledReason={name.length === 0 ? 'Enter a name' : undefined}
+ onClick={() => void save()}
+ data-attr="filters-save-modal-save"
+ >
+ Save filters
+ </Button>
+ </DialogFooter>
+ </DialogContent>
+ </Dialog>
+ )
+}
diff --git a/frontend/src/scenes/session-recordings/playlist/QuillUniversalFilterChip.tsx b/frontend/src/scenes/session-recordings/playlist/QuillUniversalFilterChip.tsx
new file mode 100644
index 000000000000..c02172ff509b
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/playlist/QuillUniversalFilterChip.tsx
@@ -0,0 +1,71 @@
+import { useValues } from 'kea'
+
+import { IconLogomark } from '@posthog/icons'
+import { Chip, ChipClose } from '@posthog/quill'
+
+import { EntityFilterInfo } from 'lib/components/EntityFilterInfo'
+import { PropertyFilterIcon } from 'lib/components/PropertyFilters/components/PropertyFilterIcon'
+import { formatPropertyLabel } from 'lib/components/PropertyFilters/utils'
+import {
+ isActionFilter,
+ isEntityFilter,
+ isEventFilter,
+ isFeatureFlagFilter,
+} from 'lib/components/UniversalFilters/utils'
+import { midEllipsis } from 'lib/utils/strings'
+
+import { cohortsModel } from '~/models/cohortsModel'
+import { propertyDefinitionsModel } from '~/models/propertyDefinitionsModel'
+import { AnyPropertyFilter, UniversalFilterValue } from '~/types'
+
+function PropertyLabel({ filter }: { filter: AnyPropertyFilter }): JSX.Element {
+ const { cohortsById } = useValues(cohortsModel)
+ const { formatPropertyValueForDisplay } = useValues(propertyDefinitionsModel)
+
+ let label = formatPropertyLabel(
+ filter,
+ cohortsById,
+ (s) => formatPropertyValueForDisplay(filter.key, s)?.toString() || '?'
+ )
+ const isEventFeature = label.startsWith('$feature/')
+ if (isEventFeature) {
+ label = label.replace('$feature/', 'Feature: ')
+ }
+ return (
+ <>
+ <span className="shrink-0 text-muted-foreground">
+ {isEventFeature ? <IconLogomark /> : <PropertyFilterIcon type={filter.type} />}
+ </span>
+ <span className="truncate" title={label}>
+ {midEllipsis(label, 32)}
+ </span>
+ </>
+ )
+}
+
+/** A removable chip for one property, event, action or feature flag filter of the recordings list. */
+export function QuillUniversalFilterChip({
+ filter,
+ onClose,
+}: {
+ filter: UniversalFilterValue
+ onClose: () => void
+}): JSX.Element {
+ return (
+ <Chip className="max-w-60 ph-no-capture" data-attr="list-filter-chip">
+ {isEntityFilter(filter) && filter.negation && (
+ <span className="shrink-0 text-muted-foreground">did not perform</span>
+ )}
+ {isEventFilter(filter) || isActionFilter(filter) ? (
+ <span className="truncate">
+ <EntityFilterInfo filter={filter} />
+ </span>
+ ) : isFeatureFlagFilter(filter) ? (
+ <span className="truncate">{filter.key}</span>
+ ) : (
+ <PropertyLabel filter={filter} />
+ )}
+ <ChipClose onClick={onClose} aria-label="Remove filter" />
+ </Chip>
+ )
+}
diff --git a/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsx b/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsx
index b9e0e78fd879..9cbb93b20f83 100644
--- a/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsx
@@ -6,7 +6,6 @@ import { IconFilter, IconRefresh } from '@posthog/icons'
import { Badge, Button, Toggle, Tooltip, TooltipContent, TooltipTrigger } from '@posthog/quill'
import { useMaxTool } from 'scenes/max/useMaxTool'
-import { SaveFiltersModal } from 'scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed'
import { sessionRecordingSavedFiltersLogic } from 'scenes/session-recordings/filters/sessionRecordingSavedFiltersLogic'
import { useRecordingFiltersAssist } from 'scenes/session-recordings/filters/useRecordingFiltersAssist'
@@ -15,6 +14,7 @@ import { RecordingUniversalFilters } from '~/types'
import { FilterChips } from './FilterChips'
import { playlistFiltersLogic } from './playlistFiltersLogic'
import { comparableRecordingFilters } from './playlistUtils'
+import { QuillSaveFiltersModal } from './QuillSaveFiltersModal'
import { SavedFilterChips } from './SavedFilterChips'
import { SavedFilterEditedBar } from './SavedFilterEditedBar'
import { SavedFilterSelect } from './SavedFilterSelect'
@@ -107,7 +107,7 @@ export function ReplayFilterBar({
</Button>
</div>
{edited && <SavedFilterEditedBar filters={filters} onSaveAsCopy={() => setSaveModalOpen(true)} />}
- <SaveFiltersModal isOpen={saveModalOpen} setIsOpen={setSaveModalOpen} filters={filters} />
+ <QuillSaveFiltersModal isOpen={saveModalOpen} setIsOpen={setSaveModalOpen} filters={filters} />
</div>
)
}
diff --git a/products/replay_vision/frontend/replay_scanners/components/QuillHighlightPickRankBadge.tsx b/products/replay_vision/frontend/replay_scanners/components/QuillHighlightPickRankBadge.tsx
new file mode 100644
index 000000000000..a0f2cdfd2ecc
--- /dev/null
+++ b/products/replay_vision/frontend/replay_scanners/components/QuillHighlightPickRankBadge.tsx
@@ -0,0 +1,12 @@
+import { Badge } from '@posthog/quill'
+
+export function QuillHighlightPickRankBadge({ rank }: { rank: number }): JSX.Element {
+ return (
+ <Badge
+ variant="warning"
+ className="pointer-events-none absolute left-0 top-0 z-10 rounded-none rounded-br px-1 font-bold tabular-nums"
+ >
+ #{rank}
+ </Badge>
+ )
+}
diff --git a/products/replay_vision/frontend/replay_scanners/components/QuillHighlightPickRow.tsx b/products/replay_vision/frontend/replay_scanners/components/QuillHighlightPickRow.tsx
index 39fcfdeffa53..255c767b14d5 100644
--- a/products/replay_vision/frontend/replay_scanners/components/QuillHighlightPickRow.tsx
+++ b/products/replay_vision/frontend/replay_scanners/components/QuillHighlightPickRow.tsx
@@ -6,7 +6,7 @@ import { useAutoMarkRead } from 'lib/components/NotificationsMenu/useAutoMarkRea
import { TZLabel } from 'lib/components/TZLabel'
import { cn } from 'lib/utils/css-classes'
-import { ObservationThumbnail } from '../../components/ObservationThumbnail'
+import { QuillObservationThumbnail } from '../../components/QuillObservationThumbnail'
import type { HighlightFeedItemApi } from '../../generated/api.schemas'
import { citedTextToPlainText } from '../../utils/citations'
import { CARD_SEEN_DWELL_MS } from '../highlightFeedTelemetry'
@@ -14,7 +14,7 @@ import { highlightPicksLogic } from '../highlightPicksLogic'
import { highlightPickSummary } from '../highlightPickSummary'
import { highlightReasonCopy } from './HighlightFeedCard'
import { HighlightPickPreview } from './HighlightPickPreview'
-import { HighlightPickRankBadge } from './HighlightPickRankBadge'
+import { QuillHighlightPickRankBadge } from './QuillHighlightPickRankBadge'
interface QuillHighlightPickRowProps {
item: HighlightFeedItemApi
@@ -52,17 +52,13 @@ export function QuillHighlightPickRow({ item, position, isActive, rank }: QuillH
)}
>
<span className="relative w-28 shrink-0">
- <ObservationThumbnail
+ <QuillObservationThumbnail
observation={observation}
className="w-full"
size="small"
retryKey={picksLoad?.feedLoadId}
/>
- {rank !== undefined && (
- <span data-not-quill className="contents">
- <HighlightPickRankBadge rank={rank} size="small" />
- </span>
- )}
+ {rank !== undefined && <QuillHighlightPickRankBadge rank={rank} />}
{!observation.viewed && (
<span className="absolute inset-y-0 left-0 w-1 rounded-l bg-primary" aria-hidden />
)}