:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(flags): refresh the team metadata cache from every process that saves a team (#122886)
Gustavo H. Strassburger9a72509fcbb1
diff --git a/posthog/apps.py b/posthog/apps.pyindex b8f59e47356d..214247cb798a 100644--- a/posthog/apps.py+++ b/posthog/apps.py@@ -38,8 +38,12 @@ class PostHogConfig(AppConfig):connect_signal_handlers as connect_gateway_credential_signal_handlers,)from posthog.storage.team_llm_gateway_policy_signal_handlers import connect_signal_handlers+ from posthog.storage.team_metadata_signal_handlers import (+ connect_signal_handlers as connect_team_metadata_signal_handlers,+ )connect_signal_handlers()+ connect_team_metadata_signal_handlers()connect_gateway_credential_signal_handlers()connect_organization_cache_signal_handlers()diff --git a/posthog/storage/team_metadata_signal_handlers.py b/posthog/storage/team_metadata_signal_handlers.pynew file mode 100644index 000000000000..be5fd134ab2b--- /dev/null+++ b/posthog/storage/team_metadata_signal_handlers.py@@ -0,0 +1,148 @@+"""+Signal handlers that keep the team metadata cache in sync with Team state.++Wired from PostHogConfig.ready() via connect_signal_handlers() so the receivers+register in every Django process that can mutate a team (web, asgi, workers).+Do not declare them in posthog.tasks.team_metadata: a web process imports that module+only when its Celery app finalizes on the first task it sends, so a save in a process+that has not sent a task yet would leave the flags service reading stale team metadata+until the hourly verification fixes it.+"""++from typing import Any++from django.conf import settings+from django.db import transaction+from django.db.models.signals import post_save, pre_delete++import structlog++from posthog.models.organization import Organization+from posthog.models.project import Project+from posthog.models.team import Team+from posthog.storage.hypercache_manager import HYPERCACHE_SIGNAL_UPDATE_COUNTER+from posthog.storage.team_metadata_cache import clear_team_metadata_cache++from products.feature_flags.backend.models.team_feature_flag_policy_config import TeamFeatureFlagPolicyConfig++logger = structlog.get_logger(__name__)+++def _record_enqueue_failure() -> None:+ HYPERCACHE_SIGNAL_UPDATE_COUNTER.labels(+ namespace="team_metadata", cache_name="team_metadata", operation="enqueue", result="failure"+ ).inc()+++def _enqueue_team_metadata_update_on_commit(team_id: int) -> None:+ def enqueue_task() -> None:+ # posthog.tasks.__init__ eagerly imports every task module (celery autoimport);+ # this signal module is wired at django.setup(), so import the task lazily.+ from posthog.tasks.team_metadata import update_team_metadata_cache_task # noqa: PLC0415++ try:+ update_team_metadata_cache_task.delay(team_id)+ except Exception as e:+ _record_enqueue_failure()+ logger.exception(+ "Failed to enqueue cache update task",+ team_id=team_id,+ error=str(e),+ )++ # Use transaction.on_commit to ensure the database changes are committed+ # before we update the cache+ transaction.on_commit(enqueue_task)+++def _enqueue_related_team_metadata_fanout(*, organization_id: int | None = None, project_id: int | None = None) -> None:+ # Imported lazily for the same reason as in _enqueue_team_metadata_update_on_commit.+ from posthog.tasks.team_metadata import update_related_teams_metadata_cache_task # noqa: PLC0415++ try:+ update_related_teams_metadata_cache_task.delay(organization_id=organization_id, project_id=project_id)+ except Exception as e:+ _record_enqueue_failure()+ logger.exception(+ "Failed to enqueue related team metadata fan-out",+ organization_id=organization_id,+ project_id=project_id,+ error=str(e),+ )+++def _any_field_may_have_changed(update_fields: frozenset[str] | None, fields: frozenset[str]) -> bool:+ """Whether a save could have touched any of `fields`.++ A `None` update_fields means a full save, where we can't tell, so we assume it might have.+ """+ return update_fields is None or not fields.isdisjoint(update_fields)+++def update_team_metadata_cache_on_save(sender: type[Team], instance: Team, created: bool, **kwargs: Any) -> None:+ """Update team metadata cache when a Team is saved."""+ if not settings.FLAGS_REDIS_URL:+ return++ _enqueue_team_metadata_update_on_commit(instance.id)+++def update_team_metadata_cache_on_flag_policy_save(+ sender: type[TeamFeatureFlagPolicyConfig], instance: TeamFeatureFlagPolicyConfig, created: bool, **kwargs: Any+) -> None:+ """Refresh the cached team when its request blocklists change, because the flags service reads them from that cache."""+ if not settings.FLAGS_REDIS_URL:+ return+ # The first read of Team.feature_flag_policy_config creates an empty row, and the cache+ # already holds empty lists for a team without a row.+ if created and not instance.blocked_hosts and not instance.blocked_ips:+ return+ if not _any_field_may_have_changed(kwargs.get("update_fields"), frozenset({"blocked_hosts", "blocked_ips"})):+ return++ _enqueue_team_metadata_update_on_commit(instance.team_id)+++def clear_team_metadata_cache_on_delete(sender: type[Team], instance: Team, **kwargs: Any) -> None:+ """Clear team metadata cache when a Team is deleted."""+ if not settings.FLAGS_REDIS_URL:+ return++ # NB: For unit tests, only clear Redis to avoid S3 timestamp issues with frozen time+ kinds = ["redis"] if settings.TEST else None+ clear_team_metadata_cache(instance, kinds=kinds)+++# Organization and project names are denormalized into team metadata, but only the Team signal+# refreshes the cache. These receivers cover org/project renames, which never touch the Team row.+# Deletes need no receiver: both FKs cascade to Team, firing the Team pre_delete handler above.+def update_team_metadata_cache_on_organization_save(+ sender: type[Organization], instance: Organization, created: bool, **kwargs: Any+) -> None:+ """Refresh dependent team metadata caches when an organization is renamed."""+ if created or not settings.FLAGS_REDIS_URL:+ return+ if not _any_field_may_have_changed(kwargs.get("update_fields"), frozenset({"name"})):+ return++ transaction.on_commit(lambda: _enqueue_related_team_metadata_fanout(organization_id=instance.id))+++def update_team_metadata_cache_on_project_save(+ sender: type[Project], instance: Project, created: bool, **kwargs: Any+) -> None:+ """Refresh dependent team metadata caches when a project is renamed."""+ if created or not settings.FLAGS_REDIS_URL:+ return+ if not _any_field_may_have_changed(kwargs.get("update_fields"), frozenset({"name"})):+ return++ transaction.on_commit(lambda: _enqueue_related_team_metadata_fanout(project_id=instance.id))+++def connect_signal_handlers() -> None:+ post_save.connect(update_team_metadata_cache_on_save, sender=Team)+ post_save.connect(update_team_metadata_cache_on_flag_policy_save, sender=TeamFeatureFlagPolicyConfig)+ pre_delete.connect(clear_team_metadata_cache_on_delete, sender=Team)+ post_save.connect(update_team_metadata_cache_on_organization_save, sender=Organization)+ post_save.connect(update_team_metadata_cache_on_project_save, sender=Project)diff --git a/posthog/storage/test/test_team_metadata_cache.py b/posthog/storage/test/test_team_metadata_cache.pyindex 088d91e5b53b..1e1eaf094850 100644--- a/posthog/storage/test/test_team_metadata_cache.py+++ b/posthog/storage/test/test_team_metadata_cache.py@@ -129,8 +129,8 @@ class TestTeamMetadataCacheTasks(BaseTest):class TestTeamMetadataCacheSignals(BaseTest):"""Test Django signals for cache updates."""- @patch("posthog.tasks.team_metadata.transaction")- @patch("posthog.tasks.team_metadata.settings")+ @patch("posthog.storage.team_metadata_signal_handlers.transaction")+ @patch("posthog.storage.team_metadata_signal_handlers.settings")@patch("posthog.tasks.team_metadata.update_team_metadata_cache_task.delay")def test_team_save_triggers_update(self, mock_task, mock_settings, mock_transaction):"""Test that saving a team schedules a cache update when FLAGS_REDIS_URL is set."""@@ -145,8 +145,8 @@ class TestTeamMetadataCacheSignals(BaseTest):# Task should be called with the team IDmock_task.assert_called_with(self.team.id)- @patch("posthog.tasks.team_metadata.settings")- @patch("posthog.tasks.team_metadata.clear_team_metadata_cache")+ @patch("posthog.storage.team_metadata_signal_handlers.settings")+ @patch("posthog.storage.team_metadata_signal_handlers.clear_team_metadata_cache")def test_team_delete_clears_cache(self, mock_clear, mock_settings):"""Test that deleting a team clears its cache when FLAGS_REDIS_URL is set."""mock_settings.FLAGS_REDIS_URL = "redis://localhost"@@ -162,8 +162,8 @@ class TestTeamMetadataCacheSignals(BaseTest):# Cache should be clearedmock_clear.assert_called_once()- @patch("posthog.tasks.team_metadata.transaction")- @patch("posthog.tasks.team_metadata.settings")+ @patch("posthog.storage.team_metadata_signal_handlers.transaction")+ @patch("posthog.storage.team_metadata_signal_handlers.settings")@patch("posthog.tasks.team_metadata.update_team_metadata_cache_task.delay")def test_team_save_noop_without_flags_redis_url(self, mock_task, mock_settings, mock_transaction):"""Test that signal is no-op when FLAGS_REDIS_URL is not set."""@@ -178,8 +178,8 @@ class TestTeamMetadataCacheSignals(BaseTest):# Task should NOT be calledmock_task.assert_not_called()- @patch("posthog.tasks.team_metadata.settings")- @patch("posthog.tasks.team_metadata.clear_team_metadata_cache")+ @patch("posthog.storage.team_metadata_signal_handlers.settings")+ @patch("posthog.storage.team_metadata_signal_handlers.clear_team_metadata_cache")def test_team_delete_noop_without_flags_redis_url(self, mock_clear, mock_settings):"""Test that signal is no-op when FLAGS_REDIS_URL is not set."""mock_settings.FLAGS_REDIS_URL = Nonediff --git a/posthog/tasks/test/test_team_metadata_signals.py b/posthog/storage/test/test_team_metadata_signal_handlers.pysimilarity index 77%rename from posthog/tasks/test/test_team_metadata_signals.pyrename to posthog/storage/test/test_team_metadata_signal_handlers.pyindex 93219d3ad375..b2c98ddafafd 100644--- a/posthog/tasks/test/test_team_metadata_signals.py+++ b/posthog/storage/test/test_team_metadata_signal_handlers.py@@ -7,7 +7,6 @@ from parameterized import parameterizedfrom posthog.models.organization import Organizationfrom posthog.models.project import Project-from posthog.tasks.team_metadata import update_related_teams_metadata_cache_taskfrom products.feature_flags.backend.models.team_feature_flag_policy_config import TeamFeatureFlagPolicyConfig@@ -70,7 +69,9 @@ class TestTeamMetadataInvalidationSignals(BaseTest):def test_enqueue_failure_records_counter_and_does_not_propagate(self) -> None:with patch("posthog.tasks.team_metadata.update_related_teams_metadata_cache_task") as mock_task:mock_task.delay.side_effect = Exception("broker down")- with patch("posthog.tasks.team_metadata.HYPERCACHE_SIGNAL_UPDATE_COUNTER") as mock_counter:+ with patch(+ "posthog.storage.team_metadata_signal_handlers.HYPERCACHE_SIGNAL_UPDATE_COUNTER"+ ) as mock_counter:try:with self.captureOnCommitCallbacks(execute=True):self.organization.name = "Renamed org"@@ -84,44 +85,6 @@ class TestTeamMetadataInvalidationSignals(BaseTest):mock_counter.labels.return_value.inc.assert_called_once_with()-@override_settings(FLAGS_REDIS_URL="redis://localhost:6379")-class TestRelatedTeamsMetadataFanoutTask(BaseTest):- def test_organization_fanout_enqueues_every_team(self) -> None:- _, second_team = Project.objects.create_with_team(- organization=self.organization, initiating_user=self.user, name="Second project"- )-- with patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update:- update_related_teams_metadata_cache_task(organization_id=self.organization.id)-- enqueued_team_ids = {call.args[0] for call in mock_update.delay.call_args_list}- self.assertEqual(enqueued_team_ids, {self.team.id, second_team.id})-- def test_project_fanout_enqueues_project_team(self) -> None:- with patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update:- update_related_teams_metadata_cache_task(project_id=self.project.id)-- enqueued_team_ids = {call.args[0] for call in mock_update.delay.call_args_list}- self.assertEqual(enqueued_team_ids, {self.team.id})-- def test_fanout_is_noop_without_ids(self) -> None:- with patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update:- update_related_teams_metadata_cache_task()-- mock_update.delay.assert_not_called()-- def test_logs_and_reraises_on_failure(self) -> None:- with (- patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update,- patch("posthog.tasks.team_metadata.logger") as mock_logger,- self.assertRaises(Exception),- ):- mock_update.delay.side_effect = Exception("broker down")- update_related_teams_metadata_cache_task(organization_id=self.organization.id)-- mock_logger.exception.assert_called_once()--@override_settings(FLAGS_REDIS_URL="redis://localhost:6379")class TestOrgProjectDeleteCascadesToTeamClear(BaseTest):def test_deleting_project_clears_team_metadata_via_cascade(self) -> None:@@ -134,7 +97,7 @@ class TestOrgProjectDeleteCascadesToTeamClear(BaseTest):# so reading instance.id after project.delete() returns would see None.cleared_team_ids: set[int] = set()with patch(- "posthog.tasks.team_metadata.clear_team_metadata_cache",+ "posthog.storage.team_metadata_signal_handlers.clear_team_metadata_cache",side_effect=lambda instance, **kwargs: cleared_team_ids.add(instance.id),):project.delete()diff --git a/posthog/tasks/team_metadata.py b/posthog/tasks/team_metadata.pyindex bf96fc3af790..a48a71df0a33 100644--- a/posthog/tasks/team_metadata.py+++ b/posthog/tasks/team_metadata.py@@ -5,32 +5,23 @@ Provides async tasks for updating and syncing team metadata caches."""import time-from typing import Anyfrom django.conf import settings-from django.db import transaction-from django.db.models.signals import post_save, pre_delete-from django.dispatch import receiverimport structlogfrom celery import shared_task-from posthog.models.organization import Organization-from posthog.models.project import Projectfrom posthog.models.team import Teamfrom posthog.scoping_audit import skip_team_scope_auditfrom posthog.storage.hypercache_manager import HYPERCACHE_SIGNAL_UPDATE_COUNTERfrom posthog.storage.team_metadata_cache import (cleanup_stale_expiry_tracking,- clear_team_metadata_cache,get_cache_stats,refresh_expiring_caches,update_team_metadata_cache,)from posthog.tasks.utils import CeleryQueue-from products.feature_flags.backend.models.team_feature_flag_policy_config import TeamFeatureFlagPolicyConfig-logger = structlog.get_logger(__name__)@@ -147,116 +138,6 @@ def refresh_expiring_team_metadata_cache_entries() -> None:raise-def _enqueue_team_metadata_update_on_commit(team_id: int) -> None:- def enqueue_task() -> None:- try:- update_team_metadata_cache_task.delay(team_id)- except Exception as e:- _record_enqueue_failure()- logger.exception(- "Failed to enqueue cache update task",- team_id=team_id,- error=str(e),- )-- # Use transaction.on_commit to ensure the database changes are committed- # before we update the cache- transaction.on_commit(enqueue_task)---def _any_field_may_have_changed(update_fields: frozenset[str] | None, fields: frozenset[str]) -> bool:- """Whether a save could have touched any of `fields`.-- A `None` update_fields means a full save, where we can't tell, so we assume it might have.- """- return update_fields is None or not fields.isdisjoint(update_fields)---@receiver(post_save, sender=Team)-def update_team_metadata_cache_on_save(sender: type[Team], instance: Team, created: bool, **kwargs: Any) -> None:- """Update team metadata cache when a Team is saved."""- if not settings.FLAGS_REDIS_URL:- return-- _enqueue_team_metadata_update_on_commit(instance.id)---@receiver(post_save, sender=TeamFeatureFlagPolicyConfig)-def update_team_metadata_cache_on_flag_policy_save(- sender: type[TeamFeatureFlagPolicyConfig], instance: TeamFeatureFlagPolicyConfig, created: bool, **kwargs: Any-) -> None:- """Refresh the cached team when its request blocklists change, because the flags service reads them from that cache."""- if not settings.FLAGS_REDIS_URL:- return- # The first read of Team.feature_flag_policy_config creates an empty row, and the cache- # already holds empty lists for a team without a row.- if created and not instance.blocked_hosts and not instance.blocked_ips:- return- if not _any_field_may_have_changed(kwargs.get("update_fields"), frozenset({"blocked_hosts", "blocked_ips"})):- return-- _enqueue_team_metadata_update_on_commit(instance.team_id)---@receiver(pre_delete, sender=Team)-def clear_team_metadata_cache_on_delete(sender: type[Team], instance: Team, **kwargs: Any) -> None:- """Clear team metadata cache when a Team is deleted."""- if not settings.FLAGS_REDIS_URL:- return-- # NB: For unit tests, only clear Redis to avoid S3 timestamp issues with frozen time- kinds = ["redis"] if settings.TEST else None- clear_team_metadata_cache(instance, kinds=kinds)---def _record_enqueue_failure() -> None:- HYPERCACHE_SIGNAL_UPDATE_COUNTER.labels(- namespace="team_metadata", cache_name="team_metadata", operation="enqueue", result="failure"- ).inc()---def _enqueue_related_team_metadata_fanout(*, organization_id: int | None = None, project_id: int | None = None) -> None:- try:- update_related_teams_metadata_cache_task.delay(organization_id=organization_id, project_id=project_id)- except Exception as e:- _record_enqueue_failure()- logger.exception(- "Failed to enqueue related team metadata fan-out",- organization_id=organization_id,- project_id=project_id,- error=str(e),- )---# Organization and project names are denormalized into team metadata, but only the Team signal-# refreshes the cache. These receivers cover org/project renames, which never touch the Team row.-# Deletes need no receiver: both FKs cascade to Team, firing the Team pre_delete handler above.-@receiver(post_save, sender=Organization)-def update_team_metadata_cache_on_organization_save(- sender: type[Organization], instance: Organization, created: bool, **kwargs: Any-) -> None:- """Refresh dependent team metadata caches when an organization is renamed."""- if created or not settings.FLAGS_REDIS_URL:- return- if not _any_field_may_have_changed(kwargs.get("update_fields"), frozenset({"name"})):- return-- transaction.on_commit(lambda: _enqueue_related_team_metadata_fanout(organization_id=instance.id))---@receiver(post_save, sender=Project)-def update_team_metadata_cache_on_project_save(- sender: type[Project], instance: Project, created: bool, **kwargs: Any-) -> None:- """Refresh dependent team metadata caches when a project is renamed."""- if created or not settings.FLAGS_REDIS_URL:- return- if not _any_field_may_have_changed(kwargs.get("update_fields"), frozenset({"name"})):- return-- transaction.on_commit(lambda: _enqueue_related_team_metadata_fanout(project_id=instance.id))--@shared_task(ignore_result=True, queue=CeleryQueue.DEFAULT.value)def cleanup_stale_expiry_tracking_task() -> None:"""diff --git a/posthog/tasks/test/test_team_metadata.py b/posthog/tasks/test/test_team_metadata.pynew file mode 100644index 000000000000..7e2e78141ccf--- /dev/null+++ b/posthog/tasks/test/test_team_metadata.py@@ -0,0 +1,45 @@+from posthog.test.base import BaseTest+from unittest.mock import patch++from django.test import override_settings++from posthog.models.project import Project+from posthog.tasks.team_metadata import update_related_teams_metadata_cache_task+++@override_settings(FLAGS_REDIS_URL="redis://localhost:6379")+class TestRelatedTeamsMetadataFanoutTask(BaseTest):+ def test_organization_fanout_enqueues_every_team(self) -> None:+ _, second_team = Project.objects.create_with_team(+ organization=self.organization, initiating_user=self.user, name="Second project"+ )++ with patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update:+ update_related_teams_metadata_cache_task(organization_id=self.organization.id)++ enqueued_team_ids = {call.args[0] for call in mock_update.delay.call_args_list}+ self.assertEqual(enqueued_team_ids, {self.team.id, second_team.id})++ def test_project_fanout_enqueues_project_team(self) -> None:+ with patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update:+ update_related_teams_metadata_cache_task(project_id=self.project.id)++ enqueued_team_ids = {call.args[0] for call in mock_update.delay.call_args_list}+ self.assertEqual(enqueued_team_ids, {self.team.id})++ def test_fanout_is_noop_without_ids(self) -> None:+ with patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update:+ update_related_teams_metadata_cache_task()++ mock_update.delay.assert_not_called()++ def test_logs_and_reraises_on_failure(self) -> None:+ with (+ patch("posthog.tasks.team_metadata.update_team_metadata_cache_task") as mock_update,+ patch("posthog.tasks.team_metadata.logger") as mock_logger,+ self.assertRaises(Exception),+ ):+ mock_update.delay.side_effect = Exception("broker down")+ update_related_teams_metadata_cache_task(organization_id=self.organization.id)++ mock_logger.exception.assert_called_once()diff --git a/posthog/test/repo_invariants/setup_receivers_baseline.txt b/posthog/test/repo_invariants/setup_receivers_baseline.txtindex b64d886decd6..a982b51f1666 100644--- a/posthog/test/repo_invariants/setup_receivers_baseline.txt+++ b/posthog/test/repo_invariants/setup_receivers_baseline.txt@@ -177,6 +177,10 @@ post_save:posthog.storage.team_access_cache_signal_handlers.project_secret_api_kpost_save:posthog.storage.team_access_cache_signal_handlers.team_saved_auth_cachepost_save:posthog.storage.team_access_cache_signal_handlers.user_savedpost_save:posthog.storage.team_llm_gateway_policy_signal_handlers._update_cache_on_save+post_save:posthog.storage.team_metadata_signal_handlers.update_team_metadata_cache_on_flag_policy_save+post_save:posthog.storage.team_metadata_signal_handlers.update_team_metadata_cache_on_organization_save+post_save:posthog.storage.team_metadata_signal_handlers.update_team_metadata_cache_on_project_save+post_save:posthog.storage.team_metadata_signal_handlers.update_team_metadata_cache_on_savepost_save:products.access_control.backend.property_access_control._invalidate_restriction_cache_on_changepost_save:products.actions.backend.models.action.action_savedpost_save:products.ai_observability.backend.models.clustering_job.create_default_clustering_jobs_for_new_team@@ -283,6 +287,7 @@ pre_delete:posthog.storage.gateway_credential_signal_handlers._clear_oauth_on_depre_delete:posthog.storage.gateway_credential_signal_handlers._clear_secret_key_on_deletepre_delete:posthog.storage.team_access_cache_signal_handlers.clear_project_secret_api_key_cache_on_deletepre_delete:posthog.storage.team_llm_gateway_policy_signal_handlers._clear_cache_on_delete+pre_delete:posthog.storage.team_metadata_signal_handlers.clear_team_metadata_cache_on_deletepre_delete:products.alerts.backend.activity_logging.cleanup_alert_hog_functionspre_delete:products.alerts.backend.activity_logging.handle_alert_subscription_deletepre_delete:products.billing_alerts.backend.team_lifecycle.rehome_billing_alerts_before_team_delete