Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(error-tracking): read usage report counts from the replica (#127457)

Sven Lange9c509b82fb4e
diff --git a/products/error_tracking/backend/logic/__init__.py b/products/error_tracking/backend/logic/__init__.py
index 71a105424f44..62346f48f480 100644
--- a/products/error_tracking/backend/logic/__init__.py
+++ b/products/error_tracking/backend/logic/__init__.py
@@ -3,6 +3,7 @@ from urllib.parse import quote
from uuid import UUID
from django.conf import settings
+from django.db import DEFAULT_DB_ALIAS
from django.db.models import Count, Q, QuerySet
from posthog.models.event_filter_config import EventFilterPipelineOverride
@@ -206,19 +207,31 @@ def count_issues_created_since(team_id: int, since: datetime) -> int:
return ErrorTrackingIssue.objects.filter(team_id=team_id, created_at__gte=since).count()
+def read_database() -> str:
+ """The database for expensive reads that can tolerate replica lag."""
+ return "replica" if "replica" in settings.DATABASES else DEFAULT_DB_ALIAS
+
+
def get_issue_counts_by_team() -> list[tuple[int, int]]:
return list(
- ErrorTrackingIssue.objects.values("team_id")
+ ErrorTrackingIssue.objects.using(read_database())
+ .values("team_id")
.annotate(total=Count("id"))
.order_by("team_id")
.values_list("team_id", "total")
)
-def get_symbol_set_counts_by_team(*, resolved_only: bool = False) -> list[tuple[int, int]]:
- queryset = ErrorTrackingSymbolSet.objects.all()
+def _symbol_set_counts_queryset(*, resolved_only: bool) -> QuerySet[ErrorTrackingSymbolSet]:
+ # These counts scan the whole table and the usage report runs them every 30 minutes, so keep them off the writer.
+ queryset = ErrorTrackingSymbolSet.objects.using(read_database()).all()
if resolved_only:
queryset = queryset.filter(storage_ptr__isnull=False)
+ return queryset
+
+
+def get_symbol_set_counts_by_team(*, resolved_only: bool = False) -> list[tuple[int, int]]:
+ queryset = _symbol_set_counts_queryset(resolved_only=resolved_only)
return list(
queryset.values("team_id").annotate(total=Count("id")).order_by("team_id").values_list("team_id", "total")
diff --git a/products/error_tracking/backend/temporal/symbol_set_cleanup/activities.py b/products/error_tracking/backend/temporal/symbol_set_cleanup/activities.py
index 3b692c943539..012e3a32d338 100644
--- a/products/error_tracking/backend/temporal/symbol_set_cleanup/activities.py
+++ b/products/error_tracking/backend/temporal/symbol_set_cleanup/activities.py
@@ -3,7 +3,6 @@ import datetime
from itertools import batched
from uuid import UUID
-from django.conf import settings
from django.db import DEFAULT_DB_ALIAS, close_old_connections, models, transaction
from django.db.models import F, Q
from django.db.models.lookups import GreaterThan
@@ -14,6 +13,7 @@ from temporalio import activity
from posthog.dataclasses import frozen
+from products.error_tracking.backend.logic import read_database
from products.error_tracking.backend.models import (
ErrorTrackingStackFrame,
ErrorTrackingSymbolSet,
@@ -40,10 +40,6 @@ class _CleanupTotals:
storage_failed: int = 0
-def _cleanup_read_database() -> str:
- return "replica" if "replica" in settings.DATABASES else DEFAULT_DB_ALIAS
-
-
def _cleanup_branches(inputs: SymbolSetCleanupInputs) -> list[Q]:
cutoff_date = timezone.now() - datetime.timedelta(days=inputs.days_old)
query_branches = [Q(last_used__isnull=False, last_used__lt=cutoff_date)]
@@ -71,7 +67,7 @@ def _after_cursor(cursor: tuple[datetime.datetime | None, datetime.datetime, UUI
def _bucket_queryset(*, query_filter: Q, bucket: int) -> models.QuerySet[ErrorTrackingSymbolSet]:
return (
- ErrorTrackingSymbolSet.objects.using(_cleanup_read_database())
+ ErrorTrackingSymbolSet.objects.using(read_database())
.alias(cleanup_bucket=symbol_set_cleanup_bucket_expression())
.filter(query_filter, cleanup_bucket=bucket)
.order_by(
diff --git a/products/error_tracking/backend/test/test_facade_api.py b/products/error_tracking/backend/test/test_facade_api.py
index 0db02eb0f41e..0767ab344172 100644
--- a/products/error_tracking/backend/test/test_facade_api.py
+++ b/products/error_tracking/backend/test/test_facade_api.py
@@ -3,8 +3,9 @@ from datetime import timedelta
from posthog.test.base import BaseTest
from unittest.mock import patch
+from django.conf import settings
from django.db import DataError
-from django.test import override_settings
+from django.test import SimpleTestCase, override_settings
from django.utils.timezone import now
import requests
@@ -19,6 +20,7 @@ from posthog.models.integration import GitLabIntegrationError, Integration
from products.access_control.backend.facade.testing import add_role_member, create_role
from products.error_tracking.backend.facade import api, contracts
+from products.error_tracking.backend.logic import _symbol_set_counts_queryset
from products.error_tracking.backend.models import (
ErrorTrackingExternalReference,
ErrorTrackingIssue,
@@ -726,3 +728,36 @@ class TestErrorTrackingFacadeAPI(BaseTest):
assert updated.multiplier == 9
assert updated.threshold == 50
assert api.get_spike_detection_config(self.team.id) == updated
+
+
+class TestUsageReportCountsDatabase(SimpleTestCase):
+ @parameterized.expand([("all", False), ("resolved_only", True)])
+ def test_reads_from_replica_when_configured(self, _name: str, resolved_only: bool) -> None:
+ with patch.dict(settings.DATABASES, {"replica": settings.DATABASES["default"]}):
+ queryset = _symbol_set_counts_queryset(resolved_only=resolved_only)
+
+ assert queryset.db == "replica"
+
+ @parameterized.expand([("all", False), ("resolved_only", True)])
+ def test_falls_back_to_default_without_replica(self, _name: str, resolved_only: bool) -> None:
+ with patch.dict(settings.DATABASES):
+ settings.DATABASES.pop("replica", None)
+ queryset = _symbol_set_counts_queryset(resolved_only=resolved_only)
+
+ assert queryset.db == "default"
+
+ def test_issue_counts_read_from_replica_when_configured(self) -> None:
+ with (
+ patch.dict(settings.DATABASES, {"replica": settings.DATABASES["default"]}),
+ patch.object(ErrorTrackingIssue.objects, "using") as using,
+ ):
+ api.get_issue_counts_by_team()
+
+ using.assert_called_once_with("replica")
+
+ def test_issue_counts_fall_back_to_default_without_replica(self) -> None:
+ with patch.dict(settings.DATABASES), patch.object(ErrorTrackingIssue.objects, "using") as using:
+ settings.DATABASES.pop("replica", None)
+ api.get_issue_counts_by_team()
+
+ using.assert_called_once_with("default")