:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(experiments): build exposure cohorts from the resolved exposure event (#124461)
Phil Haacka0da629ec451
diff --git a/products/experiments/backend/experiment_service.py b/products/experiments/backend/experiment_service.pyindex d47d7a4c7aa7..396ae0a44e26 100644--- a/products/experiments/backend/experiment_service.py+++ b/products/experiments/backend/experiment_service.py@@ -3,7 +3,7 @@import jsonimport timefrom collections import defaultdict-from collections.abc import Iterable, Mapping+from collections.abc import Iterable, Mapping, Sequencefrom copy import deepcopyfrom datetime import date, datetime, timedeltafrom enum import Enum@@ -75,6 +75,7 @@ from products.experiments.backend.hogql_queries.exposure_query_logic import (EXPERIMENT_EXPOSURE_EVENT,apply_exposure_criteria_defaults,build_exposure_event_conditions,+ exposure_event_names,get_exposure_event_and_property,resolve_default_exposure_event,)@@ -4267,7 +4268,7 @@ class ExperimentService:if exposure_filter_data:exposure_entities = parse_entities(exposure_filter_data)- target_entity: int | str = "$feature_flag_called"+ target_entities: Sequence[int | str]target_entity_type = "events"target_filters = [{@@ -4278,22 +4279,24 @@ class ExperimentService:}]- if exposure_entities:- entity = exposure_entities[0]- if entity.id:- target_entity_type = entity.type if entity.type in ["events", "actions"] else "events"- target_entity = entity.id- if entity.type == "actions":- try:- target_entity = int(target_entity)- except ValueError:- raise ValidationError("Invalid action ID")-- target_filters = [- prop.to_dict()- for prop in entity.property_groups.flat- if prop.type in ("event", "feature", "element", "hogql")- ]+ entity = exposure_entities[0] if exposure_entities else None+ if entity is not None and entity.id:+ if entity.type == "actions":+ target_entity_type = "actions"+ try:+ target_entities = [int(entity.id)]+ except ValueError:+ raise ValidationError("Invalid action ID")+ else:+ target_entities = exposure_event_names(str(entity.id))++ target_filters = [+ prop.to_dict()+ for prop in entity.property_groups.flat+ if prop.type in ("event", "feature", "element", "hogql")+ ]+ else:+ target_entities = exposure_event_names(resolve_default_exposure_event(self.team, experiment.start_date))context = serializer_context or self._build_serializer_context()# CohortSerializer expects "team" directly in context@@ -4320,6 +4323,7 @@ class ExperimentService:"event_filters": target_filters,"explicit_datetime": experiment.start_date.isoformat(),}+ for target_entity in target_entities],}],diff --git a/products/experiments/backend/hogql_queries/exposure_query_logic.py b/products/experiments/backend/hogql_queries/exposure_query_logic.pyindex f66c8aef7f7a..42d515b97fc8 100644--- a/products/experiments/backend/hogql_queries/exposure_query_logic.py+++ b/products/experiments/backend/hogql_queries/exposure_query_logic.py@@ -78,8 +78,8 @@ def resolve_default_exposure_event(team: Team, start_date: Optional[datetime]) -return EXPERIMENT_EXPOSURE_EVENT if enabled else DEFAULT_EXPOSURE_EVENT-def exposure_event_name_filter(event: str, *, read_copies: bool = True) -> ast.Expr:- """Matches the events that carry exposures for a resolved exposure event.+def exposure_event_names(event: str, *, read_copies: bool = True) -> list[str]:+ """Returns the events that carry exposures for a resolved exposure event.An experiment on $feature_flag_called also reads $experiment_exposure, unless `read_copies`is False. Ingestion stops writing $feature_flag_called to events for an organization on@@ -89,15 +89,23 @@ def exposure_event_name_filter(event: str, *, read_copies: bool = True) -> ast.Erows give the same result as one."""if event == DEFAULT_EXPOSURE_EVENT and read_copies:+ return [DEFAULT_EXPOSURE_EVENT, EXPERIMENT_EXPOSURE_EVENT]+ return [event]+++def exposure_event_name_filter(event: str, *, read_copies: bool = True) -> ast.Expr:+ """Matches the events that `exposure_event_names` returns for a resolved exposure event."""+ names = exposure_event_names(event, read_copies=read_copies)+ if len(names) > 1:return ast.CompareOperation(op=ast.CompareOperationOp.In,left=ast.Field(chain=["event"]),- right=ast.Constant(value=[DEFAULT_EXPOSURE_EVENT, EXPERIMENT_EXPOSURE_EVENT]),+ right=ast.Constant(value=names),)return ast.CompareOperation(op=ast.CompareOperationOp.Eq,left=ast.Field(chain=["event"]),- right=ast.Constant(value=event),+ right=ast.Constant(value=names[0]),)diff --git a/products/experiments/backend/test/test_experiment_service.py b/products/experiments/backend/test/test_experiment_service.pyindex 5576ad0a5f88..bd0739bbd801 100644--- a/products/experiments/backend/test/test_experiment_service.py+++ b/products/experiments/backend/test/test_experiment_service.py@@ -49,6 +49,10 @@ from products.experiments.backend.experiment_service import (_merge_saved_metric_links,_resolve_scalar_updates,)+from products.experiments.backend.hogql_queries.exposure_query_logic import (+ EXPERIMENT_EXPOSURE_EVENT_CUTOFF,+ EXPERIMENT_EXPOSURE_EVENT_FLAG,+)from products.experiments.backend.metric_calculation.config import get_metric_calculation_configfrom products.experiments.backend.metric_calculation.results import _recalc_fingerprintfrom products.experiments.backend.metric_resolution import METRIC_BUILDERS@@ -5372,6 +5376,61 @@ class TestExperimentService(APIBaseTest):experiment.refresh_from_db()assert experiment.exposure_cohort_id == cohort.id+ @parameterized.expand(+ [+ # (name, flag enabled for team, start_date offset from cutoff in days, custom exposure event, expected events)+ ("before_cutoff", True, -7, None, ["$feature_flag_called", "$experiment_exposure"]),+ ("after_cutoff", True, 7, None, ["$experiment_exposure"]),+ ("after_cutoff_flag_disabled", False, 7, None, ["$feature_flag_called", "$experiment_exposure"]),+ (+ "custom_flag_called_after_cutoff",+ True,+ 7,+ "$feature_flag_called",+ ["$feature_flag_called", "$experiment_exposure"],+ ),+ ]+ )+ def test_create_exposure_cohort_uses_resolved_exposure_event(+ self,+ name: str,+ flag_enabled: bool,+ start_offset_days: int,+ custom_exposure_event: str | None,+ expected_events: list[str],+ ) -> None:+ flag_key = f"cohort-resolved-{name}"+ flag_filter = {"key": "$feature_flag", "value": [flag_key], "operator": "exact", "type": "event"}+ self._create_flag(key=flag_key)+ service = self._service()+ experiment = service.create_experiment(+ name=f"Resolved {name}",+ feature_flag_key=flag_key,+ start_date=EXPERIMENT_EXPOSURE_EVENT_CUTOFF + timedelta(days=start_offset_days),+ parameters=(+ {+ "custom_exposure_filter": {+ "events": [{"id": custom_exposure_event, "order": 0, "properties": [flag_filter]}]+ }+ }+ if custom_exposure_event+ else None+ ),+ )++ def fake_feature_enabled(key: str, *args: Any, **kwargs: Any) -> bool:+ return flag_enabled if key == EXPERIMENT_EXPOSURE_EVENT_FLAG else False++ with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ cohort = service.create_exposure_cohort(experiment)++ assert cohort.filters is not None+ criteria = cohort.filters["properties"]["values"][0]["values"]+ assert [criterion["key"] for criterion in criteria] == expected_events+ for criterion in criteria:+ assert criterion["event_type"] == "events"+ assert criterion["event_filters"] == [flag_filter]+def test_create_exposure_cohort_without_start_date_raises(self):self._create_flag(key="cohort-no-start")service = self._service()diff --git a/products/experiments/backend/test/test_presentation_api.py b/products/experiments/backend/test/test_presentation_api.pyindex 6e44664dd35e..ba3a89dbc538 100644--- a/products/experiments/backend/test/test_presentation_api.py+++ b/products/experiments/backend/test/test_presentation_api.py@@ -7348,6 +7348,74 @@ class TestExperimentAuxiliaryEndpoints(_HoistFlagConfigClientMixin, ClickhouseTeself.assertEqual(response.status_code, 200, response.content)self.assertEqual(["person1", "person2"], sorted([res["name"] for res in response.json()["results"]]))+ @parameterized.expand(+ [+ # (name, start_date)+ ("before_cutoff", "2026-08-20T10:00"),+ ("after_cutoff", "2026-09-10T10:00"),+ ]+ )+ @patch("django.db.transaction.on_commit", side_effect=lambda func: func())+ def test_create_exposure_cohort_for_flag_evaluations_only_org(+ self, _name: str, start_date: str, patch_on_commit: MagicMock+ ):+ # Ingestion writes no $feature_flag_called rows to events for this org. Only the $experiment_exposure copies reach events.+ OrganizationFeatureFlagsConfig.objects.update_or_create(+ organization=self.organization,+ defaults={"flag_evaluations_mode": FlagEvaluationsMode.FLAG_EVALUATIONS_ONLY},+ )+ response = self._generate_experiment(start_date)+ created_experiment = response.json()["id"]+ start = datetime.fromisoformat(start_date)++ journeys_for(+ {+ "exposed": [+ {+ "event": "$experiment_exposure",+ "timestamp": (start + timedelta(days=2)).isoformat(),+ "properties": {"$feature_flag": "a-b-test", "$feature_flag_response": "control"},+ },+ ],+ "other_flag": [+ {+ "event": "$experiment_exposure",+ "timestamp": (start + timedelta(days=2)).isoformat(),+ "properties": {"$feature_flag": "a-b-test2", "$feature_flag_response": "control"},+ },+ ],+ "before_start": [+ {+ "event": "$experiment_exposure",+ "timestamp": (start - timedelta(days=2)).isoformat(),+ "properties": {"$feature_flag": "a-b-test", "$feature_flag_response": "control"},+ },+ ],+ },+ self.team,+ )+ flush_persons_and_events()++ def fake_feature_enabled(flag_key: str, *args: Any, **kwargs: Any) -> bool:+ return flag_key == EXPERIMENT_EXPOSURE_EVENT_FLAG++ with patch("posthoganalytics.feature_enabled", side_effect=fake_feature_enabled):+ response = self.client.post(+ f"/api/projects/{self.team.id}/experiments/{created_experiment}/create_exposure_cohort_for_experiment/",+ {},+ )+ self.assertEqual(response.status_code, status.HTTP_201_CREATED, response.content)+ cohort = response.json()["cohort"]+ cohort_id = cohort["id"]++ while cohort["is_calculating"]:+ response = self.client.get(f"/api/projects/{self.team.id}/cohorts/{cohort_id}")+ cohort = response.json()++ response = self.client.get(f"/api/projects/{self.team.id}/cohorts/{cohort_id}/persons/?cohort={cohort_id}")+ self.assertEqual(response.status_code, 200, response.content)+ self.assertEqual(["exposed"], [res["name"] for res in response.json()["results"]])+@patch("django.db.transaction.on_commit", side_effect=lambda func: func())def test_create_exposure_cohort_for_experiment_with_custom_event_exposure(self, patch_on_commit: MagicMock):self.maxDiff = None